Re: Review Request 72566: ATLAS-1798 : Fix Findbugs problems in repository module

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72566/#review221018
---




repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
Line 265 (original)


why is this logic removed? please revert if not intended.

how will sortBy and sortOrder be normalized?



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasStructDefStoreV2.java
Line 629 (original)


why reverse this logic?

if isUnique is null or false - it should be LIST.

Revert if not intended.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Line 2249 (original), 2235 (patched)


these checks are confusing, revert to old one.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Line 2273 (original), 2260 (patched)


these checks are confusing, revert to old one.



repository/src/main/java/org/apache/atlas/util/FileUtils.java
Lines 36 (patched)


nit: unused import. consider removing it.


- Sarath Subramanian


On June 10, 2020, 7:56 p.m., mayank jain wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72566/
> ---
> 
> (Updated June 10, 2020, 7:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1798
> https://issues.apache.org/jira/browse/ATLAS-1798
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently Findbugs complaints about some problems (see attachment) in the 
> repository module. They should be fixed to get the code more reliable.
> 
> 
> Diffs
> -
> 
>   build-tools/src/main/resources/findbugs-exclude.xml da6c58d 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
> 57e454a 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  dd4d1b4 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  56956e6 
>   
> repository/src/main/java/org/apache/atlas/discovery/SearchAggregatorImpl.java 
> e8f7dbc 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 804c694 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 
> d630f66 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java 
> 2c84ec7 
>   repository/src/main/java/org/apache/atlas/glossary/GlossaryUtils.java 
> 2a2cebb 
>   repository/src/main/java/org/apache/atlas/query/AtlasDSL.java b8a744b 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 801e898 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLLexer.java 
> 142b9ca 
>   repository/src/main/java/org/apache/atlas/query/antlr4/AtlasDSLParser.java 
> 6b33edb 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  1aac375 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListener.java
>  69d373d 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  79527ac 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  9fca744 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasArrayFormatConverter.java
>  c335f0a 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasInstanceConverter.java
>  6fc0c65 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasMapFormatConverter.java
>  0eacd8e 
>   
> repository/src/main/java/org/apache/atlas/repository/converters/AtlasStructFormatConverter.java
>  ae92b8b 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/FullTextMapperV2.java
>  497a877 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  4a09b08 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> 7b7ec65 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a85 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportService.java
>  1d29bf8 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTransforms.java
>  a2f592c 
>   

Re: Review Request 72593: ATLAS-3841 Response Headers: Code refactoring

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72593/#review221017
---


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java
Lines 40 (patched)


consider refactoring to:

```
private boolean isFileExtensionExcluded(String fileExtension) {
  boolean ret = false;

  if (ArrayUtils.isNotEmpty(excludeFileFormats)) {
ret = 
Arrays.asList(excludeFileFormats).contains(fileExtension.toLowerCase());
  }
  
  return ret;
}
```



webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java
Lines 51 (patched)


consider using the following to get file extension:
```
String fileExtension = FilenameUtils.getExtension(path);

if (!isFileExtensionExcluded(fileExtension)) {
  setHeaders((HttpServletResponse) response);
}
```


- Sarath Subramanian


On June 16, 2020, 7:37 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72593/
> ---
> 
> (Updated June 16, 2020, 7:37 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3841
> https://issues.apache.org/jira/browse/ATLAS-3841
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently headers setting code is scattered at different places.
> In this patch, code refactoring is done to set response headers from 
> AtlasHeaderFilter.java
> 
> Also this patch provides flexibility to select file formats to be excluded 
> from applying response headers.
> 
> 
> Diffs
> -
> 
>   distro/src/conf/atlas-application.properties e06e74a 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
>  d9b1c82 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java
>  c629a7e 
>   webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java 
> fa7218c 
>   
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
>  1944a9f 
>   webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d 
>   webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
> e74a9e9 
>   webapp/src/main/webapp/WEB-INF/web.xml 2595a15 
> 
> 
> Diff: https://reviews.apache.org/r/72593/diff/1/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1964/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72595: ATLAS-3833 : Packaging for atlas index repair tool

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72595/#review221015
---


Ship it!




Ship It!

- Sarath Subramanian


On June 16, 2020, 6:44 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72595/
> ---
> 
> (Updated June 16, 2020, 6:44 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3833
> https://issues.apache.org/jira/browse/ATLAS-3833
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add packaging for apache atlas build for tools/atlas-index-repair
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 7159b16cf 
>   distro/src/main/assemblies/atlas-repair-index-package.xml PRE-CREATION 
>   pom.xml 8d02a6f26 
>   tools/atlas-index-repair/README PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72595/diff/3/
> 
> 
> Testing
> ---
> 
> verified tools directory after packaging atlas
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 72595: ATLAS-3833 : Packaging for atlas index repair tool

[Nikhil Bonte]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72595/#review221011
---




tools/atlas-index-repair/README
Lines 1 (patched)


Need to add atlas-index-repair/pom.xml in modules list of root pom.xml


- Nikhil Bonte


On June 16, 2020, 1:44 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72595/
> ---
> 
> (Updated June 16, 2020, 1:44 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3833
> https://issues.apache.org/jira/browse/ATLAS-3833
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add packaging for apache atlas build for tools/atlas-index-repair
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 7159b16cf 
>   distro/src/main/assemblies/atlas-repair-index-package.xml PRE-CREATION 
>   tools/atlas-index-repair/README PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72595/diff/2/
> 
> 
> Testing
> ---
> 
> verified tools directory after packaging atlas
> 
> 
> Thanks,
> 
> chaitali
> 
>

Re: Review Request 72593: ATLAS-3841 Response Headers: Code refactoring

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72593/
---

(Updated June 16, 2020, 2:37 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3841
https://issues.apache.org/jira/browse/ATLAS-3841


Repository: atlas


Description
---

Currently headers setting code is scattered at different places.
In this patch, code refactoring is done to set response headers from 
AtlasHeaderFilter.java

Also this patch provides flexibility to select file formats to be excluded from 
applying response headers.


Diffs
-

  distro/src/conf/atlas-application.properties e06e74a 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 d9b1c82 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java
 c629a7e 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java 
fa7218c 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
 1944a9f 
  webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e9 
  webapp/src/main/webapp/WEB-INF/web.xml 2595a15 


Diff: https://reviews.apache.org/r/72593/diff/1/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1964/console


Thanks,

Mandar Ambawane

Re: Review Request 72595: ATLAS-3833 : Packaging for atlas index repair tool

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72595/
---

(Updated June 16, 2020, 1:44 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3833
https://issues.apache.org/jira/browse/ATLAS-3833


Repository: atlas


Description
---

Add packaging for apache atlas build for tools/atlas-index-repair


Diffs
-

  distro/pom.xml 7159b16cf 
  distro/src/main/assemblies/atlas-repair-index-package.xml PRE-CREATION 
  tools/atlas-index-repair/README PRE-CREATION 


Diff: https://reviews.apache.org/r/72595/diff/2/


Testing
---

verified tools directory after packaging atlas


Thanks,

chaitali

[jira] [Updated] (ATLAS-3822) UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3822:
---
Description: 
!image-2020-06-16-17-01-29-797.png|width=650,height=361!

 

!image-2020-06-16-17-01-58-179.png|width=641,height=472!

 

 

> UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE
> 
>
> Key: ATLAS-3822
> URL: https://issues.apache.org/jira/browse/ATLAS-3822
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mandar Ambawane
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3822-1.patch, ATLAS-3822.patch, 
> image-2020-06-16-17-01-29-797.png, image-2020-06-16-17-01-58-179.png
>
>
> !image-2020-06-16-17-01-29-797.png|width=650,height=361!
>  
> !image-2020-06-16-17-01-58-179.png|width=641,height=472!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3822) UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3822:
---
Attachment: Screen Shot 2020-06-16 at 5.00.53 PM.png

> UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE
> 
>
> Key: ATLAS-3822
> URL: https://issues.apache.org/jira/browse/ATLAS-3822
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mandar Ambawane
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3822-1.patch, ATLAS-3822.patch, 
> image-2020-06-16-17-01-29-797.png, image-2020-06-16-17-01-58-179.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3822) UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3822:
---
Attachment: image-2020-06-16-17-01-58-179.png

> UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE
> 
>
> Key: ATLAS-3822
> URL: https://issues.apache.org/jira/browse/ATLAS-3822
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mandar Ambawane
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3822-1.patch, ATLAS-3822.patch, 
> image-2020-06-16-17-01-29-797.png, image-2020-06-16-17-01-58-179.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3822) UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3822:
---
Attachment: image-2020-06-16-17-01-29-797.png

> UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE
> 
>
> Key: ATLAS-3822
> URL: https://issues.apache.org/jira/browse/ATLAS-3822
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mandar Ambawane
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3822-1.patch, ATLAS-3822.patch, 
> image-2020-06-16-17-01-29-797.png, image-2020-06-16-17-01-58-179.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3822) UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3822:
---
Attachment: (was: Screen Shot 2020-06-16 at 5.00.53 PM.png)

> UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE
> 
>
> Key: ATLAS-3822
> URL: https://issues.apache.org/jira/browse/ATLAS-3822
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mandar Ambawane
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3822-1.patch, ATLAS-3822.patch, 
> image-2020-06-16-17-01-29-797.png, image-2020-06-16-17-01-58-179.png
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3822) UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE

[Keval Bhatt (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Keval Bhatt updated ATLAS-3822:
---
Attachment: ATLAS-3822-1.patch

> UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE
> 
>
> Key: ATLAS-3822
> URL: https://issues.apache.org/jira/browse/ATLAS-3822
> Project: Atlas
>  Issue Type: Bug
>Reporter: Mandar Ambawane
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3822-1.patch, ATLAS-3822.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)