[jira] [Commented] (ATLAS-3863) Avoid re-evaluating tag propagation when deleting relationship (edge)
[
https://issues.apache.org/jira/browse/ATLAS-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146022#comment-17146022
]
ASF subversion and git services commented on ATLAS-3863:
Commit dee537b7e25a4bcc24d17ef77c20364b4446870e in atlas's branch
refs/heads/branch-2.0 from Sarath Subramanian
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=dee537b ]
ATLAS-3863: Avoid re-evaluating tag propagation when deleting relationship
(edge)
(cherry picked from commit eb641d560e1537808df172aad11f1338cc0e5e7f)
> Avoid re-evaluating tag propagation when deleting relationship (edge)
> -
>
> Key: ATLAS-3863
> URL: https://issues.apache.org/jira/browse/ATLAS-3863
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
>Affects Versions: 2.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Labels: classification, tagpropagation
> Fix For: 2.1.0
>
> Attachments: ATLAS-3863.001.patch, image-2020-06-24-12-51-38-941.png
>
>
> Tag propagation is re-evaluated every time when a relationship (edge) is
> deleted.
> Removal of propagated classifications is controlled at the assignment time to
> an entity:
> !image-2020-06-24-12-51-38-941.png|width=716,height=272!
>
> * {color:#172b4d}Remove propagation on entity delete - *TRUE :* {color}
> ** _Propagated classifications (to all downstream entities) will be removed
> when the source entity where the classification is originally assigned is
> deleted._
>
> * Remove propagation on entity delete - *FALSE :*
> ** _Propagated classifications (to all downstream entities) will *not* be
> removed when the source entity where the classification is
> originally assigned is deleted._
>
> There is no need to revaluate tag propagation during relationship (edge)
> deletion since removal of tag propagation depends on the above config
>
> *Significant performance improvement observed: 83% performance improvement
> seen.*
> Deleting a hive_table entity (with 44 columns and 16 propagated
> classifications)
> {{Before patch : 279 secs (4 mins, 39 secs) }}
> {{After patch : 46.92 secs}}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3863) Avoid re-evaluating tag propagation when deleting relationship (edge)
[
https://issues.apache.org/jira/browse/ATLAS-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17146021#comment-17146021
]
ASF subversion and git services commented on ATLAS-3863:
Commit eb641d560e1537808df172aad11f1338cc0e5e7f in atlas's branch
refs/heads/master from Sarath Subramanian
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=eb641d5 ]
ATLAS-3863: Avoid re-evaluating tag propagation when deleting relationship
(edge)
> Avoid re-evaluating tag propagation when deleting relationship (edge)
> -
>
> Key: ATLAS-3863
> URL: https://issues.apache.org/jira/browse/ATLAS-3863
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
>Affects Versions: 2.0.0
>Reporter: Sarath Subramanian
>Assignee: Sarath Subramanian
>Priority: Major
> Labels: classification, tagpropagation
> Fix For: 2.1.0
>
> Attachments: ATLAS-3863.001.patch, image-2020-06-24-12-51-38-941.png
>
>
> Tag propagation is re-evaluated every time when a relationship (edge) is
> deleted.
> Removal of propagated classifications is controlled at the assignment time to
> an entity:
> !image-2020-06-24-12-51-38-941.png|width=716,height=272!
>
> * {color:#172b4d}Remove propagation on entity delete - *TRUE :* {color}
> ** _Propagated classifications (to all downstream entities) will be removed
> when the source entity where the classification is originally assigned is
> deleted._
>
> * Remove propagation on entity delete - *FALSE :*
> ** _Propagated classifications (to all downstream entities) will *not* be
> removed when the source entity where the classification is
> originally assigned is deleted._
>
> There is no need to revaluate tag propagation during relationship (edge)
> deletion since removal of tag propagation depends on the above config
>
> *Significant performance improvement observed: 83% performance improvement
> seen.*
> Deleting a hive_table entity (with 44 columns and 16 propagated
> classifications)
> {{Before patch : 279 secs (4 mins, 39 secs) }}
> {{After patch : 46.92 secs}}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (ATLAS-3857) [UI] When deleted term same term twice shows 'Something went wrong' msg.
[ https://issues.apache.org/jira/browse/ATLAS-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Durga Kadam resolved ATLAS-3857. Resolution: Fixed https://issues.apache.org/jira/browse/ATLAS-3857 and https://issues.apache.org/jira/browse/ATLAS-3156 have the same solution as added loader on the delete button. > [UI] When deleted term same term twice shows 'Something went wrong' msg. > > > Key: ATLAS-3857 > URL: https://issues.apache.org/jira/browse/ATLAS-3857 > Project: Atlas > Issue Type: Bug >Reporter: Durga Kadam >Priority: Minor > Attachments: delete term something went wrong issue.webm > > > When deleted term, it does not get delete immediately when tried again to > delete the same term shows 'Something went wrong msg'. PFA Video > *Expected ::* On first delete it should show loading sign and/or delete > button should get disabled > *Actual::* It takes long to delete a term and as the delete button is enabled > user tried to delete it again. When deleted the same term again Shows > 'Something went wrong' msg. > Server Logs are as follows:: > 2020-06-23 12:12:44,315 ERROR - [pool-2-thread-10 - > 1a7a6991-e5c3-4519-9b5b-e0a926abd4be:] ~ Could not commit transaction [7] due > to exception (StandardJanusGraph:808) > org.janusgraph.diskstorage.locking.PermanentLockingException: Local lock > contention > at > org.janusgraph.diskstorage.locking.AbstractLocker.writeLock(AbstractLocker.java:327) > at > org.janusgraph.diskstorage.locking.consistentkey.ExpectedValueCheckingStore.acquireLock(ExpectedValueCheckingStore.java:103) > at > org.janusgraph.diskstorage.keycolumnvalue.KCVSProxy.acquireLock(KCVSProxy.java:51) > at > org.janusgraph.diskstorage.BackendTransaction.acquireEdgeLock(BackendTransaction.java:236) > at > org.janusgraph.graphdb.database.StandardJanusGraph.prepareCommit(StandardJanusGraph.java:551) > at > org.janusgraph.graphdb.database.StandardJanusGraph.commit(StandardJanusGraph.java:731) > at > org.janusgraph.graphdb.transaction.StandardJanusGraphTx.commit(StandardJanusGraphTx.java:1425) > at > org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsGraph$GraphTransaction.doCommit(JanusGraphBlueprintsGraph.java:297) > at > org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.commit(AbstractTransaction.java:104) > at > org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.commit(AtlasJanusGraph.java:248) > at > org.apache.atlas.GraphTransactionInterceptor.doCommit(GraphTransactionInterceptor.java:157) > at > org.apache.atlas.GraphTransactionInterceptor.doCommitOrRollback(GraphTransactionInterceptor.java:152) > at > org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) > at > org.apache.atlas.glossary.GlossaryService$$EnhancerBySpringCGLIB$$71fceabc.deleteTerm() > at > org.apache.atlas.web.rest.GlossaryREST.deleteGlossaryTerm(GlossaryREST.java:590) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$VoidOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:167) -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72619: ATLAS-3863: Avoid re-evaluating tag propagation when deleting relationship (edge)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72619/#review221072 --- Ship it! Ship It! - Madhan Neethiraj On June 25, 2020, 12:33 a.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72619/ > --- > > (Updated June 25, 2020, 12:33 a.m.) > > > Review request for atlas, Ashutosh Mestry, chaitali, Jayendra Parab, Madhan > Neethiraj, Mandar Ambawane, mayank jain, Nikhil Bonte, Nixon Rodrigues, Pinal > Shah, and Sidharth Mishra. > > > Bugs: ATLAS-3863 > https://issues.apache.org/jira/browse/ATLAS-3863 > > > Repository: atlas > > > Description > --- > > Tag propagation is re-evaluated every time when a relationship (edge) is > deleted. > > Removal of propagated classifications is controlled at the assignment time to > an entity: > > > Remove propagation on entity delete - TRUE : > Propagated classifications (to all downstream entities) will be removed when > the source entity where the classification is originally assigned is deleted. > > > Remove propagation on entity delete - FALSE : > Propagated classifications (to all downstream entities) will not be removed > when the source entity where the classification is originally > assigned is deleted. > > > There is no need to revaluate tag propagation during relationship (edge) > deletion since removal of tag propagation depends on the above config. > > > Diffs > - > > repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java > 7b7ec6567 > > repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java > 3f8503ac3 > > > Diff: https://reviews.apache.org/r/72619/diff/2/ > > > Testing > --- > > Manually validated: > > Deleted relationship, Deleted downstream entities and verified that > propagated tags are not affected and revaluation of tag propagation is not > computed. > > Precommit - > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1978/console > > > `Significant performance improvement observed:` > > Deleting a hive_table entity (with 44 columns and 16 propagated > classifications) > > Before patch : 279 secs (4 mins, 39 secs) > After patch : 46.92 secs > > 83% performance improvement seen. > > > Thanks, > > Sarath Subramanian > >
[jira] [Updated] (ATLAS-3855) Bulk entity tag association and bulk api enhancement
[
https://issues.apache.org/jira/browse/ATLAS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarath Subramanian updated ATLAS-3855:
--
Affects Version/s: (was: 3.0.0)
2.0.0
> Bulk entity tag association and bulk api enhancement
>
>
> Key: ATLAS-3855
> URL: https://issues.apache.org/jira/browse/ATLAS-3855
> Project: Atlas
> Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> API : /api/atlas/v2/entity/bulk/classification
> Body :
> {code:java}
> {"classification":{"typeName":"PII","attributes":{},"propagate":true,"removePropagationsOnEntityDelete":false,"validityPeriods":[]},"entityGuids":["guid1","guid2"]}
> {code}
> when user doesn't have authorisation on either of guid1 or guid2 , the bulk
> entity call fails with 403.
> bulk api _v2/entity/bulk_ to retrieve a list of entities identified by its
> guids.
> This bulk api fails with 403 if some guids belong to entities on which user
> is *unauthorized* and other guids belong to entities on which user is
> *authorized*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3855) Bulk entity tag association and bulk api enhancement
[
https://issues.apache.org/jira/browse/ATLAS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarath Subramanian updated ATLAS-3855:
--
Component/s: atlas-core
> Bulk entity tag association and bulk api enhancement
>
>
> Key: ATLAS-3855
> URL: https://issues.apache.org/jira/browse/ATLAS-3855
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
>Affects Versions: 2.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 2.1.0
>
>
> API : /api/atlas/v2/entity/bulk/classification
> Body :
> {code:java}
> {"classification":{"typeName":"PII","attributes":{},"propagate":true,"removePropagationsOnEntityDelete":false,"validityPeriods":[]},"entityGuids":["guid1","guid2"]}
> {code}
> when user doesn't have authorisation on either of guid1 or guid2 , the bulk
> entity call fails with 403.
> bulk api _v2/entity/bulk_ to retrieve a list of entities identified by its
> guids.
> This bulk api fails with 403 if some guids belong to entities on which user
> is *unauthorized* and other guids belong to entities on which user is
> *authorized*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3855) Bulk entity tag association and bulk api enhancement
[
https://issues.apache.org/jira/browse/ATLAS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarath Subramanian updated ATLAS-3855:
--
Fix Version/s: 2.1.0
> Bulk entity tag association and bulk api enhancement
>
>
> Key: ATLAS-3855
> URL: https://issues.apache.org/jira/browse/ATLAS-3855
> Project: Atlas
> Issue Type: Improvement
>Affects Versions: 2.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 2.1.0
>
>
> API : /api/atlas/v2/entity/bulk/classification
> Body :
> {code:java}
> {"classification":{"typeName":"PII","attributes":{},"propagate":true,"removePropagationsOnEntityDelete":false,"validityPeriods":[]},"entityGuids":["guid1","guid2"]}
> {code}
> when user doesn't have authorisation on either of guid1 or guid2 , the bulk
> entity call fails with 403.
> bulk api _v2/entity/bulk_ to retrieve a list of entities identified by its
> guids.
> This bulk api fails with 403 if some guids belong to entities on which user
> is *unauthorized* and other guids belong to entities on which user is
> *authorized*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3855) Bulk entity tag association and bulk api enhancement
[
https://issues.apache.org/jira/browse/ATLAS-3855?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sarath Subramanian updated ATLAS-3855:
--
Labels: api-change (was: )
> Bulk entity tag association and bulk api enhancement
>
>
> Key: ATLAS-3855
> URL: https://issues.apache.org/jira/browse/ATLAS-3855
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
>Affects Versions: 2.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Labels: api-change
> Fix For: 2.1.0
>
>
> API : /api/atlas/v2/entity/bulk/classification
> Body :
> {code:java}
> {"classification":{"typeName":"PII","attributes":{},"propagate":true,"removePropagationsOnEntityDelete":false,"validityPeriods":[]},"entityGuids":["guid1","guid2"]}
> {code}
> when user doesn't have authorisation on either of guid1 or guid2 , the bulk
> entity call fails with 403.
> bulk api _v2/entity/bulk_ to retrieve a list of entities identified by its
> guids.
> This bulk api fails with 403 if some guids belong to entities on which user
> is *unauthorized* and other guids belong to entities on which user is
> *authorized*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3856) Create new entity typeDefs for Apache Ozone
[ https://issues.apache.org/jira/browse/ATLAS-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145866#comment-17145866 ] ASF subversion and git services commented on ATLAS-3856: Commit 2f88e7ad3b9dc28e903f8522e6ab0019b6d1d18e in atlas's branch refs/heads/branch-2.0 from nikhilbonte [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=2f88e7a ] ATLAS-3856 Create new entity typeDefs for Apache Ozone Signed-off-by: Sarath Subramanian (cherry picked from commit 25ba9b30b916269bc20a5b99b9bc326f5b9e18d3) > Create new entity typeDefs for Apache Ozone > --- > > Key: ATLAS-3856 > URL: https://issues.apache.org/jira/browse/ATLAS-3856 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: Nikhil Bonte >Assignee: Nikhil Bonte >Priority: Major > Attachments: > ATLAS-3856-Create-new-entity-typeDefs-for-Apache-Ozone-v0.patch > > > Add following ozone typeDefs to Atlas models > * Ozone volume > * Ozone bucket > * Ozone key -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ATLAS-3856) Create new entity typeDefs for Apache Ozone
[ https://issues.apache.org/jira/browse/ATLAS-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3856. --- Resolution: Fixed > Create new entity typeDefs for Apache Ozone > --- > > Key: ATLAS-3856 > URL: https://issues.apache.org/jira/browse/ATLAS-3856 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: Nikhil Bonte >Assignee: Nikhil Bonte >Priority: Major > Fix For: 2.1.0 > > Attachments: > ATLAS-3856-Create-new-entity-typeDefs-for-Apache-Ozone-v0.patch > > > Add following ozone typeDefs to Atlas models > * Ozone volume > * Ozone bucket > * Ozone key -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3856) Create new entity typeDefs for Apache Ozone
[ https://issues.apache.org/jira/browse/ATLAS-3856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145865#comment-17145865 ] ASF subversion and git services commented on ATLAS-3856: Commit 25ba9b30b916269bc20a5b99b9bc326f5b9e18d3 in atlas's branch refs/heads/master from nikhilbonte [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=25ba9b3 ] ATLAS-3856 Create new entity typeDefs for Apache Ozone Signed-off-by: Sarath Subramanian > Create new entity typeDefs for Apache Ozone > --- > > Key: ATLAS-3856 > URL: https://issues.apache.org/jira/browse/ATLAS-3856 > Project: Atlas > Issue Type: New Feature > Components: atlas-core >Affects Versions: 2.0.0 >Reporter: Nikhil Bonte >Assignee: Nikhil Bonte >Priority: Major > Attachments: > ATLAS-3856-Create-new-entity-typeDefs-for-Apache-Ozone-v0.patch > > > Add following ozone typeDefs to Atlas models > * Ozone volume > * Ozone bucket > * Ozone key -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72614/#review221069 --- Ship it! Ship It! - Sarath Subramanian On June 24, 2020, 8:07 a.m., Nikhil Bonte wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72614/ > --- > > (Updated June 24, 2020, 8:07 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon > Rodrigues, Sarath Subramanian, and Sidharth Mishra. > > > Bugs: ATLAS-3856 > https://issues.apache.org/jira/browse/ATLAS-3856 > > > Repository: atlas > > > Description > --- > > Add following ozone typeDefs to Atlas models > > entityDefs: > ozone_volume > ozone_bucket > ozone_key > > enumDefs: > ozone_storage_type > ozone_replication_type > > structDefs: > ozone_key_location > > relationshipDefs: > ozone_volume_buckets > ozone_bucket_keys > > > Diffs > - > > addons/models/3000-Cloud/3050-ozone-typedefs.json PRE-CREATION > > > Diff: https://reviews.apache.org/r/72614/diff/3/ > > > Testing > --- > > > Thanks, > > Nikhil Bonte > >
[jira] [Commented] (ATLAS-3852) Entity Bulk Create with unique reference
[ https://issues.apache.org/jira/browse/ATLAS-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145755#comment-17145755 ] Vasanth kumar RJ commented on ATLAS-3852: - [~nikhilbonte] - I feel using actual unique attribute (qualifiedName) for reference will avoid error and readable when a bulk request got multiple db, table and columns. Negative guid is temporary value. > Entity Bulk Create with unique reference > > > Key: ATLAS-3852 > URL: https://issues.apache.org/jira/browse/ATLAS-3852 > Project: Atlas > Issue Type: Improvement >Reporter: Vasanth kumar RJ >Priority: Major > Fix For: 2.1.0 > > Attachments: ATLAS-3852.patch, BulkPostCreate.json > > > Entities created in bulk and unique referenced in same request. Bulk create > DB, Table and Column referenced in a request itself. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3858) [UI] Misaligment happened in Glossaries when added term with large name
[
https://issues.apache.org/jira/browse/ATLAS-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145687#comment-17145687
]
ASF subversion and git services commented on ATLAS-3858:
Commit f9dcf611b88cea278212306885bf03f3a83a32c0 in atlas's branch
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f9dcf61 ]
ATLAS-3858:- [UI] Misaligment happened in Glossaries when added term with large
name
> [UI] Misaligment happened in Glossaries when added term with large name
> ---
>
> Key: ATLAS-3858
> URL: https://issues.apache.org/jira/browse/ATLAS-3858
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3858.patch, embedded_tag_added_in_glossries.webm
>
>
> Steps to reproduce:
> # {color:#00}Go to Glossaries and add term with this Name ::
> {color}{color:#00}SRC="data:image/svg+xml;base64,PHN2ZyB4bWxuczpzdmc9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv
> MjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hs
> aW5rIiB2ZXJzaW9uPSIxLjAiIHg9IjAiIHk9IjAiIHdpZHRoPSIxOTQiIGhlaWdodD0iMjAw
> IiBpZD0ieHNzIj48c2NyaXB0IHR5cGU9InRleHQvZWNtYXNjcmlwdCI+YWxlcnQoIlh
> TUyIpOzwvc2NyaXB0Pjwvc3ZnPg==" type="image/svg+xml"
> AllowScriptAccess="always{color}
> # {color:#00}Save the Term {color}
> # {color:#00}Now check the aligment on the left hand panel{color}
> *{color:#4c9aff}_NOTE- Issue is producible only on New UI. It works fine on
> Old UI._{color}*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3858) [UI] Misaligment happened in Glossaries when added term with large name
[
https://issues.apache.org/jira/browse/ATLAS-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145686#comment-17145686
]
ASF subversion and git services commented on ATLAS-3858:
Commit ab9f973123192e0711f67f707cb118525b19993f in atlas's branch
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ab9f973 ]
ATLAS-3858:- [UI] Misaligment happened in Glossaries when added term with large
name
> [UI] Misaligment happened in Glossaries when added term with large name
> ---
>
> Key: ATLAS-3858
> URL: https://issues.apache.org/jira/browse/ATLAS-3858
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3858.patch, embedded_tag_added_in_glossries.webm
>
>
> Steps to reproduce:
> # {color:#00}Go to Glossaries and add term with this Name ::
> {color}{color:#00}SRC="data:image/svg+xml;base64,PHN2ZyB4bWxuczpzdmc9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv
> MjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hs
> aW5rIiB2ZXJzaW9uPSIxLjAiIHg9IjAiIHk9IjAiIHdpZHRoPSIxOTQiIGhlaWdodD0iMjAw
> IiBpZD0ieHNzIj48c2NyaXB0IHR5cGU9InRleHQvZWNtYXNjcmlwdCI+YWxlcnQoIlh
> TUyIpOzwvc2NyaXB0Pjwvc3ZnPg==" type="image/svg+xml"
> AllowScriptAccess="always{color}
> # {color:#00}Save the Term {color}
> # {color:#00}Now check the aligment on the left hand panel{color}
> *{color:#4c9aff}_NOTE- Issue is producible only on New UI. It works fine on
> Old UI._{color}*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3858) [UI] Misaligment happened in Glossaries when added term with large name
[
https://issues.apache.org/jira/browse/ATLAS-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145685#comment-17145685
]
Sameer Shaikh commented on ATLAS-3858:
--
+1
> [UI] Misaligment happened in Glossaries when added term with large name
> ---
>
> Key: ATLAS-3858
> URL: https://issues.apache.org/jira/browse/ATLAS-3858
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3858.patch, embedded_tag_added_in_glossries.webm
>
>
> Steps to reproduce:
> # {color:#00}Go to Glossaries and add term with this Name ::
> {color}{color:#00}SRC="data:image/svg+xml;base64,PHN2ZyB4bWxuczpzdmc9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv
> MjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hs
> aW5rIiB2ZXJzaW9uPSIxLjAiIHg9IjAiIHk9IjAiIHdpZHRoPSIxOTQiIGhlaWdodD0iMjAw
> IiBpZD0ieHNzIj48c2NyaXB0IHR5cGU9InRleHQvZWNtYXNjcmlwdCI+YWxlcnQoIlh
> TUyIpOzwvc2NyaXB0Pjwvc3ZnPg==" type="image/svg+xml"
> AllowScriptAccess="always{color}
> # {color:#00}Save the Term {color}
> # {color:#00}Now check the aligment on the left hand panel{color}
> *{color:#4c9aff}_NOTE- Issue is producible only on New UI. It works fine on
> Old UI._{color}*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3858) [UI] Misaligment happened in Glossaries when added term with large name
[
https://issues.apache.org/jira/browse/ATLAS-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keval Bhatt updated ATLAS-3858:
---
Fix Version/s: 3.0.0
2.1.0
> [UI] Misaligment happened in Glossaries when added term with large name
> ---
>
> Key: ATLAS-3858
> URL: https://issues.apache.org/jira/browse/ATLAS-3858
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3858.patch, embedded_tag_added_in_glossries.webm
>
>
> Steps to reproduce:
> # {color:#00}Go to Glossaries and add term with this Name ::
> {color}{color:#00}SRC="data:image/svg+xml;base64,PHN2ZyB4bWxuczpzdmc9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv
> MjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hs
> aW5rIiB2ZXJzaW9uPSIxLjAiIHg9IjAiIHk9IjAiIHdpZHRoPSIxOTQiIGhlaWdodD0iMjAw
> IiBpZD0ieHNzIj48c2NyaXB0IHR5cGU9InRleHQvZWNtYXNjcmlwdCI+YWxlcnQoIlh
> TUyIpOzwvc2NyaXB0Pjwvc3ZnPg==" type="image/svg+xml"
> AllowScriptAccess="always{color}
> # {color:#00}Save the Term {color}
> # {color:#00}Now check the aligment on the left hand panel{color}
> *{color:#4c9aff}_NOTE- Issue is producible only on New UI. It works fine on
> Old UI._{color}*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3858) [UI] Misaligment happened in Glossaries when added term with large name
[
https://issues.apache.org/jira/browse/ATLAS-3858?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keval Bhatt updated ATLAS-3858:
---
Attachment: ATLAS-3858.patch
> [UI] Misaligment happened in Glossaries when added term with large name
> ---
>
> Key: ATLAS-3858
> URL: https://issues.apache.org/jira/browse/ATLAS-3858
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: ATLAS-3858.patch, embedded_tag_added_in_glossries.webm
>
>
> Steps to reproduce:
> # {color:#00}Go to Glossaries and add term with this Name ::
> {color}{color:#00}SRC="data:image/svg+xml;base64,PHN2ZyB4bWxuczpzdmc9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIiB4bWxucz0iaHR0cDovL3d3dy53My5vcmcv
> MjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hs
> aW5rIiB2ZXJzaW9uPSIxLjAiIHg9IjAiIHk9IjAiIHdpZHRoPSIxOTQiIGhlaWdodD0iMjAw
> IiBpZD0ieHNzIj48c2NyaXB0IHR5cGU9InRleHQvZWNtYXNjcmlwdCI+YWxlcnQoIlh
> TUyIpOzwvc2NyaXB0Pjwvc3ZnPg==" type="image/svg+xml"
> AllowScriptAccess="always{color}
> # {color:#00}Save the Term {color}
> # {color:#00}Now check the aligment on the left hand panel{color}
> *{color:#4c9aff}_NOTE- Issue is producible only on New UI. It works fine on
> Old UI._{color}*
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (ATLAS-3862) [UI] When added term with large name validation msgs are misaligned. PFA snaps
[ https://issues.apache.org/jira/browse/ATLAS-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt resolved ATLAS-3862. Resolution: Fixed > [UI] When added term with large name validation msgs are misaligned. PFA snaps > -- > > Key: ATLAS-3862 > URL: https://issues.apache.org/jira/browse/ATLAS-3862 > Project: Atlas > Issue Type: Sub-task >Reporter: Durga Kadam >Assignee: Keval Bhatt >Priority: Major > Fix For: 2.1.0, 3.0.0 > > Attachments: > added_glossary_with_embedded_tag_success_msg_misalignment.png, > deleted_term_with_embedded_tag_validation_msg_misalignment.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3862) [UI] When added term with large name validation msgs are misaligned. PFA snaps
[ https://issues.apache.org/jira/browse/ATLAS-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3862: --- Fix Version/s: 3.0.0 2.1.0 > [UI] When added term with large name validation msgs are misaligned. PFA snaps > -- > > Key: ATLAS-3862 > URL: https://issues.apache.org/jira/browse/ATLAS-3862 > Project: Atlas > Issue Type: Sub-task >Reporter: Durga Kadam >Assignee: Keval Bhatt >Priority: Major > Fix For: 2.1.0, 3.0.0 > > Attachments: > added_glossary_with_embedded_tag_success_msg_misalignment.png, > deleted_term_with_embedded_tag_validation_msg_misalignment.png > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ATLAS-3857) [UI] When deleted term same term twice shows 'Something went wrong' msg.
[ https://issues.apache.org/jira/browse/ATLAS-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt reassigned ATLAS-3857: -- Assignee: (was: Keval Bhatt) > [UI] When deleted term same term twice shows 'Something went wrong' msg. > > > Key: ATLAS-3857 > URL: https://issues.apache.org/jira/browse/ATLAS-3857 > Project: Atlas > Issue Type: Bug >Reporter: Durga Kadam >Priority: Minor > Attachments: delete term something went wrong issue.webm > > > When deleted term, it does not get delete immediately when tried again to > delete the same term shows 'Something went wrong msg'. PFA Video > *Expected ::* On first delete it should show loading sign and/or delete > button should get disabled > *Actual::* It takes long to delete a term and as the delete button is enabled > user tried to delete it again. When deleted the same term again Shows > 'Something went wrong' msg. > Server Logs are as follows:: > 2020-06-23 12:12:44,315 ERROR - [pool-2-thread-10 - > 1a7a6991-e5c3-4519-9b5b-e0a926abd4be:] ~ Could not commit transaction [7] due > to exception (StandardJanusGraph:808) > org.janusgraph.diskstorage.locking.PermanentLockingException: Local lock > contention > at > org.janusgraph.diskstorage.locking.AbstractLocker.writeLock(AbstractLocker.java:327) > at > org.janusgraph.diskstorage.locking.consistentkey.ExpectedValueCheckingStore.acquireLock(ExpectedValueCheckingStore.java:103) > at > org.janusgraph.diskstorage.keycolumnvalue.KCVSProxy.acquireLock(KCVSProxy.java:51) > at > org.janusgraph.diskstorage.BackendTransaction.acquireEdgeLock(BackendTransaction.java:236) > at > org.janusgraph.graphdb.database.StandardJanusGraph.prepareCommit(StandardJanusGraph.java:551) > at > org.janusgraph.graphdb.database.StandardJanusGraph.commit(StandardJanusGraph.java:731) > at > org.janusgraph.graphdb.transaction.StandardJanusGraphTx.commit(StandardJanusGraphTx.java:1425) > at > org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsGraph$GraphTransaction.doCommit(JanusGraphBlueprintsGraph.java:297) > at > org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.commit(AbstractTransaction.java:104) > at > org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.commit(AtlasJanusGraph.java:248) > at > org.apache.atlas.GraphTransactionInterceptor.doCommit(GraphTransactionInterceptor.java:157) > at > org.apache.atlas.GraphTransactionInterceptor.doCommitOrRollback(GraphTransactionInterceptor.java:152) > at > org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) > at > org.apache.atlas.glossary.GlossaryService$$EnhancerBySpringCGLIB$$71fceabc.deleteTerm() > at > org.apache.atlas.web.rest.GlossaryREST.deleteGlossaryTerm(GlossaryREST.java:590) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$VoidOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:167) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (ATLAS-3859) [UI] In edit entity window shows calender with 'Invalid date'
[
https://issues.apache.org/jira/browse/ATLAS-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keval Bhatt resolved ATLAS-3859.
Fix Version/s: 3.0.0
2.1.0
Resolution: Fixed
> [UI] In edit entity window shows calender with 'Invalid date'
> -
>
> Key: ATLAS-3859
> URL: https://issues.apache.org/jira/browse/ATLAS-3859
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Fix For: 2.1.0, 3.0.0
>
> Attachments: ATLAS-3859.patch, shows Invalid date with 'NaN'.webm
>
>
> Steps to reproduce::
> # {color:#00}Open entity in edit mode{color}
> # {color:#00}Click on toggle 'Required' set to ALL {color}
> # {color:#00}For 'Created Time' shows 'Invalid Date' {color}
> # {color:#00}When Opened calender shows 'NaN' for all the dates{color}
> {color:#00}Expected: Calender should be available with dates to select
> the required date
> {color}
> {color:#00}Actual: Shows NaN all over the calender{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3859) [UI] In edit entity window shows calender with 'Invalid date'
[
https://issues.apache.org/jira/browse/ATLAS-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145037#comment-17145037
]
ASF subversion and git services commented on ATLAS-3859:
Commit b5c4a56f1ece7e10e7a2da15de466899021da254 in atlas's branch
refs/heads/master from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b5c4a56 ]
ATLAS-3859:- [UI] In edit entity window shows calender with 'Invalid date'
> [UI] In edit entity window shows calender with 'Invalid date'
> -
>
> Key: ATLAS-3859
> URL: https://issues.apache.org/jira/browse/ATLAS-3859
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: ATLAS-3859.patch, shows Invalid date with 'NaN'.webm
>
>
> Steps to reproduce::
> # {color:#00}Open entity in edit mode{color}
> # {color:#00}Click on toggle 'Required' set to ALL {color}
> # {color:#00}For 'Created Time' shows 'Invalid Date' {color}
> # {color:#00}When Opened calender shows 'NaN' for all the dates{color}
> {color:#00}Expected: Calender should be available with dates to select
> the required date
> {color}
> {color:#00}Actual: Shows NaN all over the calender{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading
[ https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145036#comment-17145036 ] ASF subversion and git services commented on ATLAS-3156: Commit 177b01bc61828cd03e7ee6bcd76d336d7d7d3f54 in atlas's branch refs/heads/master from Keval Bhatt [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=177b01b ] ATLAS-3156:- UI:No loading animation while creating or deleting a Classification, Term, SaveSearch loading #4 > UI:No loading animation while creating or deleting a Classification, Create > Entity, View loading > > > Key: ATLAS-3156 > URL: https://issues.apache.org/jira/browse/ATLAS-3156 > Project: Atlas > Issue Type: Improvement >Reporter: Rahul Kurup >Assignee: Keval Bhatt >Priority: Minor > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3156-1.patch, ATLAS-3156-3.patch, > ATLAS-3156-4.patch, ATLAS-3156.patch > > > While creating a Classification, there is no loading animation or any > indication to the user that the creation process is underway. The user only > gets a notification that the creation process is complete. If for some reason > the creation process takes a long while, then this lack of indication might > confuse the user into thinking that nothing is happening on clicking the > 'Create' button. > > This same issue exists when trying to delete a classification. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading
[ https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145033#comment-17145033 ] ASF subversion and git services commented on ATLAS-3156: Commit adff44e740cfc379f0e7e0a32c2f3e2c2ac42f6d in atlas's branch refs/heads/branch-2.0 from Keval Bhatt [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=adff44e ] ATLAS-3156:- UI:No loading animation while creating or deleting a Classification, Term, SaveSearch loading #4 > UI:No loading animation while creating or deleting a Classification, Create > Entity, View loading > > > Key: ATLAS-3156 > URL: https://issues.apache.org/jira/browse/ATLAS-3156 > Project: Atlas > Issue Type: Improvement >Reporter: Rahul Kurup >Assignee: Keval Bhatt >Priority: Minor > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3156-1.patch, ATLAS-3156-3.patch, > ATLAS-3156-4.patch, ATLAS-3156.patch > > > While creating a Classification, there is no loading animation or any > indication to the user that the creation process is underway. The user only > gets a notification that the creation process is complete. If for some reason > the creation process takes a long while, then this lack of indication might > confuse the user into thinking that nothing is happening on clicking the > 'Create' button. > > This same issue exists when trying to delete a classification. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3859) [UI] In edit entity window shows calender with 'Invalid date'
[
https://issues.apache.org/jira/browse/ATLAS-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145032#comment-17145032
]
Nixon Rodrigues commented on ATLAS-3859:
+1 for the patch. thanks [~kevalbhatt]
> [UI] In edit entity window shows calender with 'Invalid date'
> -
>
> Key: ATLAS-3859
> URL: https://issues.apache.org/jira/browse/ATLAS-3859
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: ATLAS-3859.patch, shows Invalid date with 'NaN'.webm
>
>
> Steps to reproduce::
> # {color:#00}Open entity in edit mode{color}
> # {color:#00}Click on toggle 'Required' set to ALL {color}
> # {color:#00}For 'Created Time' shows 'Invalid Date' {color}
> # {color:#00}When Opened calender shows 'NaN' for all the dates{color}
> {color:#00}Expected: Calender should be available with dates to select
> the required date
> {color}
> {color:#00}Actual: Shows NaN all over the calender{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3859) [UI] In edit entity window shows calender with 'Invalid date'
[
https://issues.apache.org/jira/browse/ATLAS-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145034#comment-17145034
]
ASF subversion and git services commented on ATLAS-3859:
Commit f005c32cd8cad78fcdf47835ad3d18d9e032752c in atlas's branch
refs/heads/branch-2.0 from Keval Bhatt
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f005c32 ]
ATLAS-3859:- [UI] In edit entity window shows calender with 'Invalid date'
> [UI] In edit entity window shows calender with 'Invalid date'
> -
>
> Key: ATLAS-3859
> URL: https://issues.apache.org/jira/browse/ATLAS-3859
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: ATLAS-3859.patch, shows Invalid date with 'NaN'.webm
>
>
> Steps to reproduce::
> # {color:#00}Open entity in edit mode{color}
> # {color:#00}Click on toggle 'Required' set to ALL {color}
> # {color:#00}For 'Created Time' shows 'Invalid Date' {color}
> # {color:#00}When Opened calender shows 'NaN' for all the dates{color}
> {color:#00}Expected: Calender should be available with dates to select
> the required date
> {color}
> {color:#00}Actual: Shows NaN all over the calender{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3156) UI:No loading animation while creating or deleting a Classification, Create Entity, View loading
[ https://issues.apache.org/jira/browse/ATLAS-3156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Keval Bhatt updated ATLAS-3156: --- Attachment: ATLAS-3156-4.patch > UI:No loading animation while creating or deleting a Classification, Create > Entity, View loading > > > Key: ATLAS-3156 > URL: https://issues.apache.org/jira/browse/ATLAS-3156 > Project: Atlas > Issue Type: Improvement >Reporter: Rahul Kurup >Assignee: Keval Bhatt >Priority: Minor > Fix For: 2.1.0, 3.0.0 > > Attachments: ATLAS-3156-1.patch, ATLAS-3156-3.patch, > ATLAS-3156-4.patch, ATLAS-3156.patch > > > While creating a Classification, there is no loading animation or any > indication to the user that the creation process is underway. The user only > gets a notification that the creation process is complete. If for some reason > the creation process takes a long while, then this lack of indication might > confuse the user into thinking that nothing is happening on clicking the > 'Create' button. > > This same issue exists when trying to delete a classification. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3859) [UI] In edit entity window shows calender with 'Invalid date'
[
https://issues.apache.org/jira/browse/ATLAS-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Keval Bhatt updated ATLAS-3859:
---
Attachment: ATLAS-3859.patch
> [UI] In edit entity window shows calender with 'Invalid date'
> -
>
> Key: ATLAS-3859
> URL: https://issues.apache.org/jira/browse/ATLAS-3859
> Project: Atlas
> Issue Type: Bug
>Affects Versions: 2.0.0
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: ATLAS-3859.patch, shows Invalid date with 'NaN'.webm
>
>
> Steps to reproduce::
> # {color:#00}Open entity in edit mode{color}
> # {color:#00}Click on toggle 'Required' set to ALL {color}
> # {color:#00}For 'Created Time' shows 'Invalid Date' {color}
> # {color:#00}When Opened calender shows 'NaN' for all the dates{color}
> {color:#00}Expected: Calender should be available with dates to select
> the required date
> {color}
> {color:#00}Actual: Shows NaN all over the calender{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (ATLAS-3861) [UI] When Entity added with existing BusinessMetadata Attribute shows misalignment
[
https://issues.apache.org/jira/browse/ATLAS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Durga Kadam closed ATLAS-3861.
--
not able to reproduce on new and old ui, hence colsing this.
> [UI] When Entity added with existing BusinessMetadata Attribute shows
> misalignment
> --
>
> Key: ATLAS-3861
> URL: https://issues.apache.org/jira/browse/ATLAS-3861
> Project: Atlas
> Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: Screenshot from 2020-06-25 20-49-29.png, Screenshot from
> 2020-06-25 20-49-29.png, while adding exisitng Business metadata to an entity
> shows misalignment .png
>
>
> {color:#00}Steps to reproduce the bug::{color}
> # {color:#00}Create business metadata with any large attribute name
> {color}
> # {color:#00}Create/Update any entity with same BM attribute in
> 'Business Metadata' section{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (ATLAS-3861) [UI] When Entity added with existing BusinessMetadata Attribute shows misalignment
[
https://issues.apache.org/jira/browse/ATLAS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Durga Kadam resolved ATLAS-3861.
Resolution: Cannot Reproduce
> [UI] When Entity added with existing BusinessMetadata Attribute shows
> misalignment
> --
>
> Key: ATLAS-3861
> URL: https://issues.apache.org/jira/browse/ATLAS-3861
> Project: Atlas
> Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: Screenshot from 2020-06-25 20-49-29.png, Screenshot from
> 2020-06-25 20-49-29.png, while adding exisitng Business metadata to an entity
> shows misalignment .png
>
>
> {color:#00}Steps to reproduce the bug::{color}
> # {color:#00}Create business metadata with any large attribute name
> {color}
> # {color:#00}Create/Update any entity with same BM attribute in
> 'Business Metadata' section{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3861) [UI] When Entity added with existing BusinessMetadata Attribute shows misalignment
[
https://issues.apache.org/jira/browse/ATLAS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Durga Kadam updated ATLAS-3861:
---
Attachment: Screenshot from 2020-06-25 20-49-29.png
> [UI] When Entity added with existing BusinessMetadata Attribute shows
> misalignment
> --
>
> Key: ATLAS-3861
> URL: https://issues.apache.org/jira/browse/ATLAS-3861
> Project: Atlas
> Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: Screenshot from 2020-06-25 20-49-29.png, Screenshot from
> 2020-06-25 20-49-29.png, while adding exisitng Business metadata to an entity
> shows misalignment .png
>
>
> {color:#00}Steps to reproduce the bug::{color}
> # {color:#00}Create business metadata with any large attribute name
> {color}
> # {color:#00}Create/Update any entity with same BM attribute in
> 'Business Metadata' section{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3861) [UI] When Entity added with existing BusinessMetadata Attribute shows misalignment
[
https://issues.apache.org/jira/browse/ATLAS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17145022#comment-17145022
]
Durga Kadam commented on ATLAS-3861:
Not able to reproduce, hence closing this Jira. !Screenshot from 2020-06-25
20-49-29.png!
> [UI] When Entity added with existing BusinessMetadata Attribute shows
> misalignment
> --
>
> Key: ATLAS-3861
> URL: https://issues.apache.org/jira/browse/ATLAS-3861
> Project: Atlas
> Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: Screenshot from 2020-06-25 20-49-29.png, Screenshot from
> 2020-06-25 20-49-29.png, while adding exisitng Business metadata to an entity
> shows misalignment .png
>
>
> {color:#00}Steps to reproduce the bug::{color}
> # {color:#00}Create business metadata with any large attribute name
> {color}
> # {color:#00}Create/Update any entity with same BM attribute in
> 'Business Metadata' section{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (ATLAS-3861) [UI] When Entity added with existing BusinessMetadata Attribute shows misalignment
[
https://issues.apache.org/jira/browse/ATLAS-3861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Durga Kadam updated ATLAS-3861:
---
Attachment: Screenshot from 2020-06-25 20-49-29.png
> [UI] When Entity added with existing BusinessMetadata Attribute shows
> misalignment
> --
>
> Key: ATLAS-3861
> URL: https://issues.apache.org/jira/browse/ATLAS-3861
> Project: Atlas
> Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Minor
> Attachments: Screenshot from 2020-06-25 20-49-29.png, while adding
> exisitng Business metadata to an entity shows misalignment .png
>
>
> {color:#00}Steps to reproduce the bug::{color}
> # {color:#00}Create business metadata with any large attribute name
> {color}
> # {color:#00}Create/Update any entity with same BM attribute in
> 'Business Metadata' section{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (ATLAS-3848) Quick Search : Incorrect aggregation metrics
[ https://issues.apache.org/jira/browse/ATLAS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144987#comment-17144987 ] ASF subversion and git services commented on ATLAS-3848: Commit aa86d62c057d56f858dc7962aa158d23c82f972b in atlas's branch refs/heads/master from Pinal Shah [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=aa86d62 ] ATLAS-3848 : Quick Search : Fixed incorrect aggregation metrics Signed-off-by: nixonrodrigues > Quick Search : Incorrect aggregation metrics > > > Key: ATLAS-3848 > URL: https://issues.apache.org/jira/browse/ATLAS-3848 > Project: Atlas > Issue Type: Bug > Components: atlas-core, atlas-intg >Affects Versions: 2.0.0 >Reporter: Pinal >Assignee: Pinal >Priority: Major > Labels: quicksearch > Fix For: 2.1.0, 3.0.0 > > > Below scenarios doesn't result correct aggregation metrics in quick search > * when filtered with System Attributes > * when filtered with more than one filters > * when filtered with negation operators > * need to support _customAttributes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3848) Quick Search : Incorrect aggregation metrics
[ https://issues.apache.org/jira/browse/ATLAS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144975#comment-17144975 ] Nixon Rodrigues commented on ATLAS-3848: +1 for the patch, thanks [~pinal.shah] for the patch > Quick Search : Incorrect aggregation metrics > > > Key: ATLAS-3848 > URL: https://issues.apache.org/jira/browse/ATLAS-3848 > Project: Atlas > Issue Type: Bug > Components: atlas-core, atlas-intg >Affects Versions: 2.0.0 >Reporter: Pinal >Assignee: Pinal >Priority: Major > Labels: quicksearch > Fix For: 2.1.0, 3.0.0 > > > Below scenarios doesn't result correct aggregation metrics in quick search > * when filtered with System Attributes > * when filtered with more than one filters > * when filtered with negation operators > * need to support _customAttributes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3857) [UI] When deleted term same term twice shows 'Something went wrong' msg.
[ https://issues.apache.org/jira/browse/ATLAS-3857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144957#comment-17144957 ] Keval Bhatt commented on ATLAS-3857: UI issue if fixed by ATLAS-3156 > [UI] When deleted term same term twice shows 'Something went wrong' msg. > > > Key: ATLAS-3857 > URL: https://issues.apache.org/jira/browse/ATLAS-3857 > Project: Atlas > Issue Type: Bug >Reporter: Durga Kadam >Assignee: Keval Bhatt >Priority: Minor > Attachments: delete term something went wrong issue.webm > > > When deleted term, it does not get delete immediately when tried again to > delete the same term shows 'Something went wrong msg'. PFA Video > *Expected ::* On first delete it should show loading sign and/or delete > button should get disabled > *Actual::* It takes long to delete a term and as the delete button is enabled > user tried to delete it again. When deleted the same term again Shows > 'Something went wrong' msg. > Server Logs are as follows:: > 2020-06-23 12:12:44,315 ERROR - [pool-2-thread-10 - > 1a7a6991-e5c3-4519-9b5b-e0a926abd4be:] ~ Could not commit transaction [7] due > to exception (StandardJanusGraph:808) > org.janusgraph.diskstorage.locking.PermanentLockingException: Local lock > contention > at > org.janusgraph.diskstorage.locking.AbstractLocker.writeLock(AbstractLocker.java:327) > at > org.janusgraph.diskstorage.locking.consistentkey.ExpectedValueCheckingStore.acquireLock(ExpectedValueCheckingStore.java:103) > at > org.janusgraph.diskstorage.keycolumnvalue.KCVSProxy.acquireLock(KCVSProxy.java:51) > at > org.janusgraph.diskstorage.BackendTransaction.acquireEdgeLock(BackendTransaction.java:236) > at > org.janusgraph.graphdb.database.StandardJanusGraph.prepareCommit(StandardJanusGraph.java:551) > at > org.janusgraph.graphdb.database.StandardJanusGraph.commit(StandardJanusGraph.java:731) > at > org.janusgraph.graphdb.transaction.StandardJanusGraphTx.commit(StandardJanusGraphTx.java:1425) > at > org.janusgraph.graphdb.tinkerpop.JanusGraphBlueprintsGraph$GraphTransaction.doCommit(JanusGraphBlueprintsGraph.java:297) > at > org.apache.tinkerpop.gremlin.structure.util.AbstractTransaction.commit(AbstractTransaction.java:104) > at > org.apache.atlas.repository.graphdb.janus.AtlasJanusGraph.commit(AtlasJanusGraph.java:248) > at > org.apache.atlas.GraphTransactionInterceptor.doCommit(GraphTransactionInterceptor.java:157) > at > org.apache.atlas.GraphTransactionInterceptor.doCommitOrRollback(GraphTransactionInterceptor.java:152) > at > org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:91) > at > org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179) > at > org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:671) > at > org.apache.atlas.glossary.GlossaryService$$EnhancerBySpringCGLIB$$71fceabc.deleteTerm() > at > org.apache.atlas.web.rest.GlossaryREST.deleteGlossaryTerm(GlossaryREST.java:590) > at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) > at > sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) > at > sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) > at java.lang.reflect.Method.invoke(Method.java:498) > at > com.sun.jersey.spi.container.JavaMethodInvokerFactory$1.invoke(JavaMethodInvokerFactory.java:60) > at > com.sun.jersey.server.impl.model.method.dispatch.AbstractResourceMethodDispatchProvider$VoidOutInvoker._dispatch(AbstractResourceMethodDispatchProvider.java:167) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3865) HookConsumer shouldn't use ShutdownThrea
[ https://issues.apache.org/jira/browse/ATLAS-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3865: --- Summary: HookConsumer shouldn't use ShutdownThrea (was: HookConsumer shouldn't use ShutdownThread or depend on Scala code) > HookConsumer shouldn't use ShutdownThrea > > > Key: ATLAS-3865 > URL: https://issues.apache.org/jira/browse/ATLAS-3865 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > The internal ShutdownThread depends on Kafka core which isn't desired as it > isn't a public API and also it pulls in a Scala dependency that can change > across Kafka versions and isn't good to expose. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3865) HookConsumer shouldn't use ShutdownThread
[ https://issues.apache.org/jira/browse/ATLAS-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3865: --- Summary: HookConsumer shouldn't use ShutdownThread (was: HookConsumer shouldn't use ShutdownThrea) > HookConsumer shouldn't use ShutdownThread > - > > Key: ATLAS-3865 > URL: https://issues.apache.org/jira/browse/ATLAS-3865 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > The internal ShutdownThread depends on Kafka core which isn't desired as it > isn't a public API and also it pulls in a Scala dependency that can change > across Kafka versions and isn't good to expose. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3865) HookConsumer shouldn't use ShutdownThread or depend on Scala code
[ https://issues.apache.org/jira/browse/ATLAS-3865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Viktor Somogyi-Vass updated ATLAS-3865: --- Summary: HookConsumer shouldn't use ShutdownThread or depend on Scala code (was: HookConsumer shouldn't use ShutdownThread) > HookConsumer shouldn't use ShutdownThread or depend on Scala code > - > > Key: ATLAS-3865 > URL: https://issues.apache.org/jira/browse/ATLAS-3865 > Project: Atlas > Issue Type: Improvement >Reporter: Viktor Somogyi-Vass >Priority: Major > > The internal ShutdownThread depends on Kafka core which isn't desired as it > isn't a public API and also it pulls in a Scala dependency that can change > across Kafka versions and isn't good to expose. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-3865) HookConsumer shouldn't use ShutdownThread
Viktor Somogyi-Vass created ATLAS-3865: -- Summary: HookConsumer shouldn't use ShutdownThread Key: ATLAS-3865 URL: https://issues.apache.org/jira/browse/ATLAS-3865 Project: Atlas Issue Type: Improvement Reporter: Viktor Somogyi-Vass The internal ShutdownThread depends on Kafka core which isn't desired as it isn't a public API and also it pulls in a Scala dependency that can change across Kafka versions and isn't good to expose. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (ATLAS-3852) Entity Bulk Create with unique reference
[ https://issues.apache.org/jira/browse/ATLAS-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144830#comment-17144830 ] Nikhil Bonte edited comment on ATLAS-3852 at 6/25/20, 10:51 AM: [~vasanthkumar] - Currently Atlas does support creating entities which are referenced in same bulk request using negative guid approach. [^BulkPostCreate.json] I have attached sample payload which will create new a hive_db, a hive_table & a hive_column in single request. Hope this would help. was (Author: nikhilbonte): [~vasanthkumar] - Currently Atlas does support creating entities with referenced in same bulk request using negative guid approach. [^BulkPostCreate.json] I have attached sample payload which will create new a hive_db, a hive_table & a hive_column in single request. Hope this would help. > Entity Bulk Create with unique reference > > > Key: ATLAS-3852 > URL: https://issues.apache.org/jira/browse/ATLAS-3852 > Project: Atlas > Issue Type: Improvement >Reporter: Vasanth kumar RJ >Priority: Major > Fix For: 2.1.0 > > Attachments: ATLAS-3852.patch, BulkPostCreate.json > > > Entities created in bulk and unique referenced in same request. Bulk create > DB, Table and Column referenced in a request itself. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3852) Entity Bulk Create with unique reference
[ https://issues.apache.org/jira/browse/ATLAS-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17144830#comment-17144830 ] Nikhil Bonte commented on ATLAS-3852: - [~vasanthkumar] - Currently Atlas does support creating entities with referenced in same bulk request using negative guid approach. [^BulkPostCreate.json] I have attached sample payload which will create new a hive_db, a hive_table & a hive_column in single request. Hope this would help. > Entity Bulk Create with unique reference > > > Key: ATLAS-3852 > URL: https://issues.apache.org/jira/browse/ATLAS-3852 > Project: Atlas > Issue Type: Improvement >Reporter: Vasanth kumar RJ >Priority: Major > Fix For: 2.1.0 > > Attachments: ATLAS-3852.patch, BulkPostCreate.json > > > Entities created in bulk and unique referenced in same request. Bulk create > DB, Table and Column referenced in a request itself. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3852) Entity Bulk Create with unique reference
[ https://issues.apache.org/jira/browse/ATLAS-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nikhil Bonte updated ATLAS-3852: Attachment: BulkPostCreate.json > Entity Bulk Create with unique reference > > > Key: ATLAS-3852 > URL: https://issues.apache.org/jira/browse/ATLAS-3852 > Project: Atlas > Issue Type: Improvement >Reporter: Vasanth kumar RJ >Priority: Major > Fix For: 2.1.0 > > Attachments: ATLAS-3852.patch, BulkPostCreate.json > > > Entities created in bulk and unique referenced in same request. Bulk create > DB, Table and Column referenced in a request itself. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Asking for JIRA permissions
Hi devs, I created a JIRA [1] that I'd like to resolve (and have a PR already) but I'd like to assign it to myself. Could you please grant me the required permissions? Also, do you accept PR's against the master branch or does it have to be provided via JIRA in git patch format? [1] https://issues.apache.org/jira/browse/ATLAS-3864 Thanks, Viktor
[jira] [Created] (ATLAS-3864) KafkaBridge should use AdminClient
Viktor Somogyi-Vass created ATLAS-3864: -- Summary: KafkaBridge should use AdminClient Key: ATLAS-3864 URL: https://issues.apache.org/jira/browse/ATLAS-3864 Project: Atlas Issue Type: Improvement Reporter: Viktor Somogyi-Vass Kafka removed ZkUtils as it's an internal class and replaced it with KafkaZkClient. To be compatible with newer Kafka versions Atlas should use AdminClient and migrate from ZkUtils to KafkaZkClient. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72567/ --- (Updated June 25, 2020, 9:17 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- commented one testcase, need to look, succesful on local but failed for precommit Bugs: ATLAS-3782 https://issues.apache.org/jira/browse/ATLAS-3782 Repository: atlas Description --- The operator 'SearchParameters.Operator.NOT_CONTAINS' is defined and implemented in SearchProcessors. It would allow a search of entities that do not contain in given string in a specified attribute (eg exclude entities from search that contain 'temp' in the qualified name). JanusGraph doesn't allow NOT_CONTAINS operator. So we will handle this in inmemory BasicSearch can generates query via three modes 1. Index query -> NOT_CONTAINS will not be supported 2. InMemeory Predicated -> NOT_CONTAINS will be supported, Already handled #123 SearchProcessor 3. Graph query -> NOT_CONTAINS will not be supported We need to apply filter(inMemoryPredicate) after either index/graph query. To support above, i have modified ClassificationSearchProcessor + For both cases index as well as graph, added typeNamePredicate and attributePredicate + Added these predicate after query - Removed gremlinQuery block Diffs (updated) - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 5dd0d7f97 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ad48be11b repository/src/test/java/org/apache/atlas/BasicTestSetup.java 8b98b3990 repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java 9b16e919d repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java 43f11d1df Diff: https://reviews.apache.org/r/72567/diff/3/ Changes: https://reviews.apache.org/r/72567/diff/2-3/ Testing --- Added testcases Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1952 Thanks, Pinal Shah
[jira] [Updated] (ATLAS-3848) Quick Search : Incorrect aggregation metrics
[ https://issues.apache.org/jira/browse/ATLAS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pinal updated ATLAS-3848: - Fix Version/s: 3.0.0 2.1.0 > Quick Search : Incorrect aggregation metrics > > > Key: ATLAS-3848 > URL: https://issues.apache.org/jira/browse/ATLAS-3848 > Project: Atlas > Issue Type: Bug >Affects Versions: 2.0.0 >Reporter: Pinal >Assignee: Pinal >Priority: Major > Labels: quicksearch > Fix For: 2.1.0, 3.0.0 > > > Below scenarios doesn't result correct aggregation metrics in quick search > * when filtered with System Attributes > * when filtered with more than one filters > * when filtered with negation operators > * need to support _customAttributes -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-3848) Quick Search : Incorrect aggregation metrics
[ https://issues.apache.org/jira/browse/ATLAS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pinal updated ATLAS-3848: - Component/s: atlas-intg atlas-core > Quick Search : Incorrect aggregation metrics > > > Key: ATLAS-3848 > URL: https://issues.apache.org/jira/browse/ATLAS-3848 > Project: Atlas > Issue Type: Bug > Components: atlas-core, atlas-intg >Affects Versions: 2.0.0 >Reporter: Pinal >Assignee: Pinal >Priority: Major > Labels: quicksearch > Fix For: 2.1.0, 3.0.0 > > > Below scenarios doesn't result correct aggregation metrics in quick search > * when filtered with System Attributes > * when filtered with more than one filters > * when filtered with negation operators > * need to support _customAttributes -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 72567: ATLAS-3782 : Support NOT_CONTAINS operator in basic search
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72567/ --- (Updated June 25, 2020, 6:57 a.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- rebase patch, to update indexes from solrConfig.xml and removed one log statement Bugs: ATLAS-3782 https://issues.apache.org/jira/browse/ATLAS-3782 Repository: atlas Description --- The operator 'SearchParameters.Operator.NOT_CONTAINS' is defined and implemented in SearchProcessors. It would allow a search of entities that do not contain in given string in a specified attribute (eg exclude entities from search that contain 'temp' in the qualified name). JanusGraph doesn't allow NOT_CONTAINS operator. So we will handle this in inmemory BasicSearch can generates query via three modes 1. Index query -> NOT_CONTAINS will not be supported 2. InMemeory Predicated -> NOT_CONTAINS will be supported, Already handled #123 SearchProcessor 3. Graph query -> NOT_CONTAINS will not be supported We need to apply filter(inMemoryPredicate) after either index/graph query. To support above, i have modified ClassificationSearchProcessor + For both cases index as well as graph, added typeNamePredicate and attributePredicate + Added these predicate after query - Removed gremlinQuery block Diffs (updated) - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 5dd0d7f97 repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java ad48be11b repository/src/test/java/org/apache/atlas/BasicTestSetup.java 8b98b3990 repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java PRE-CREATION repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java 9b16e919d repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java 43f11d1df Diff: https://reviews.apache.org/r/72567/diff/2/ Changes: https://reviews.apache.org/r/72567/diff/1-2/ Testing --- Added testcases Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1952 Thanks, Pinal Shah
