Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-26 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72698/#review221372
---




atlas-examples/pom.xml
Lines 1 (patched)


Copyright header missing. Please copy from an existing pom.xml file in 
Atlas.



atlas-examples/sample-app/pom.xml
Lines 1 (patched)


Copyright header missing. Please copy from an existing pom.xml file in 
Atlas.



atlas-examples/sample-app/pom.xml
Lines 18 (patched)


3.0.0-SNAPSHOT => ${project.version}
  - please update at #23, #29, #35 as well



atlas-examples/sample-app/pom.xml
Lines 41 (patched)


2.9.4 => ${jackson.version}
 - please update #57, #63 as well



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java
Lines 31 (patched)


Do atlasClient and tableEntity_us need to be static? I suggest to remove 
static, and mark these as final, as they are initialized only in the 
constructor.



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java
Lines 39 (patched)


Consider replacing this method with a static constant:
  private static final String[] DSL_QUERIES = new String[] { "from 
DataSet", "from Process" };



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java
Lines 64 (patched)


tableEntity_us.getTypeName() is the query-string to quickSearch(). Its not 
clear from this usage. I suggest to:
 - remove tableEntity_us as member
 - update quickSearch() with an argument
   public void quickSearch(String searchString) {
 ...
   }



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 41 (patched)


DATABASE_ENTITY_NAME => DATABASE_NAME
TABLE_ENTITY_NAME=> TABLE_NAME
PROCESS_ENTITY_NAME  => PROCESS_NAME



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 47 (patched)


NAME   => ATTR_NAME
DESCRIPTION=> ATTR_DESCRIPTION
QUALIFIED_NAME => ATTR_QUALIFIED_NAME
TIME_ID_COLUMN => ATTR_TIME_ID_COLUMN
CUSTOMER_ID_COLUMN => ATTR_CUSTOMER_ID_COLUMN
COMPANY_ID_COLUMN  => ATTR_COMPANY_ID_COLUMN



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 58 (patched)


I suggest to remove static for following members:
 - atlasClient
 - dbEntity
 - tableEntityUS
 - ttableEntityCanada
 - loadProcess

- atlasClient can be declared as final, as it is initialized only in the 
constructor



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 101 (patched)


deleteEntityByGuid() => deleteEntities()



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 109 (patched)


getCreatedTableEntity() => createTableEntity()



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 117 (patched)


getCreatedLoadProcess() => createLoadProcess()



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 213 (patched)


dbInstance => database



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 229 (patched)


protected => private
createHiveTableInstance() => createHiveTable()
databaseInstance  => database



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 230 (patched)


tableInstance => table



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 231 (patched)


Is #231 necessary, given it is overwriten at #248?



atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
Lines 238 (patched)

[jira] [Updated] (ATLAS-3848) Quick Search : Incorrect aggregation metrics

2020-07-26 Thread Pinal (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Pinal updated ATLAS-3848:
-
Fix Version/s: (was: 2.1.0)

> Quick Search : Incorrect aggregation metrics
> 
>
> Key: ATLAS-3848
> URL: https://issues.apache.org/jira/browse/ATLAS-3848
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-intg
>Affects Versions: 2.0.0
>Reporter: Pinal
>Assignee: Pinal
>Priority: Major
>  Labels: quicksearch
> Fix For: 3.0.0
>
>
> Below scenarios doesn't result correct aggregation metrics in quick search
>  * when filtered with System Attributes
>  * when filtered with more than one filters
>  * when filtered with negation operators
>  * need to support _customAttributesĀ 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)