Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/#review221472
---


Ship it!




Ship It!

- Nixon Rodrigues


On Aug. 5, 2020, 4:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72646/
> ---
> 
> (Updated Aug. 5, 2020, 4:27 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3876
> https://issues.apache.org/jira/browse/ATLAS-3876
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:**
> Relationship api doesn't provide approximate count of the related entities in 
> the response.
> 
> **Workaround:**
> Get the total count of related given entity , irrespective of the 
> offset/limit.
> Added 'getApproximateCount' as queryParam in Rest api.
> 
> 
> Also this patch includes **improvement in the time taken to fetch related 
> entities**  .
> Average time taken for the Api to search relationship entities having **5000 
> end vertices** with limit **500**:
> Before: 9seconds
> After applying this patch : 3seconds
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  86572598a 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4b9564295 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 044179d44 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  863a00350 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 5069d78c8 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 
> 
> 
> Diff: https://reviews.apache.org/r/72646/diff/6/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2084
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/#review221471
---


Ship it!




Ship It!

- Madhan Neethiraj


On Aug. 5, 2020, 4:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72646/
> ---
> 
> (Updated Aug. 5, 2020, 4:27 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3876
> https://issues.apache.org/jira/browse/ATLAS-3876
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:**
> Relationship api doesn't provide approximate count of the related entities in 
> the response.
> 
> **Workaround:**
> Get the total count of related given entity , irrespective of the 
> offset/limit.
> Added 'getApproximateCount' as queryParam in Rest api.
> 
> 
> Also this patch includes **improvement in the time taken to fetch related 
> entities**  .
> Average time taken for the Api to search relationship entities having **5000 
> end vertices** with limit **500**:
> Before: 9seconds
> After applying this patch : 3seconds
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  86572598a 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4b9564295 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 044179d44 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  863a00350 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 5069d78c8 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 
> 
> 
> Diff: https://reviews.apache.org/r/72646/diff/6/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2084
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/
---

(Updated Aug. 5, 2020, 4:27 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3876
https://issues.apache.org/jira/browse/ATLAS-3876


Repository: atlas


Description
---

**Issue:**
Relationship api doesn't provide approximate count of the related entities in 
the response.

**Workaround:**
Get the total count of related given entity , irrespective of the offset/limit.
Added 'getApproximateCount' as queryParam in Rest api.


Also this patch includes **improvement in the time taken to fetch related 
entities**  .
Average time taken for the Api to search relationship entities having **5000 
end vertices** with limit **500**:
Before: 9seconds
After applying this patch : 3seconds


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
86572598a 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4b9564295 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
044179d44 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 863a00350 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 


Diff: https://reviews.apache.org/r/72646/diff/6/

Changes: https://reviews.apache.org/r/72646/diff/5-6/


Testing (updated)
---

Manually tested
Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2084


Thanks,

Pinal Shah

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/#review221470
---


Fix it, then Ship it!





intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java
Line 19 (original), 19 (patched)


Only import related changes are in AtlasEntityType.java. Please review and 
revert.


- Madhan Neethiraj


On Aug. 4, 2020, 11:01 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72646/
> ---
> 
> (Updated Aug. 4, 2020, 11:01 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3876
> https://issues.apache.org/jira/browse/ATLAS-3876
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Issue:**
> Relationship api doesn't provide approximate count of the related entities in 
> the response.
> 
> **Workaround:**
> Get the total count of related given entity , irrespective of the 
> offset/limit.
> Added 'getApproximateCount' as queryParam in Rest api.
> 
> 
> Also this patch includes **improvement in the time taken to fetch related 
> entities**  .
> Average time taken for the Api to search relationship entities having **5000 
> end vertices** with limit **500**:
> Before: 9seconds
> After applying this patch : 3seconds
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc47 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  86572598a 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  4b9564295 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 044179d44 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  863a00350 
>   repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
> 5069d78c8 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 
> 
> 
> Diff: https://reviews.apache.org/r/72646/diff/5/
> 
> 
> Testing
> ---
> 
> Manually tested
> Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 
> (Failed in Impala build)
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

[Jyoti Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72698/
---

(Updated Aug. 4, 2020, 4:27 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

Using this project users can get an idea as how to integrate with Atlas using 
AtlasCleint. This helps the user to understand the basic rest functionality of 
Atlas such as

- EntityRest
- TypeDefRest
- DiscoveryRest
- LineageRest
- GlossaryRest


Diffs (updated)
-

  atlas-examples/pom.xml PRE-CREATION 
  atlas-examples/sample-app/README.md PRE-CREATION 
  atlas-examples/sample-app/pom.xml PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java
 PRE-CREATION 
  atlas-examples/sample-app/src/main/resources/atlas-application.properties 
PRE-CREATION 
  pom.xml 5e0442ae5 


Diff: https://reviews.apache.org/r/72698/diff/7/

Changes: https://reviews.apache.org/r/72698/diff/6-7/


Testing
---


Thanks,

Jyoti Singh

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

[Jyoti Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72698/
---

(Updated Aug. 4, 2020, 4:05 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

Using this project users can get an idea as how to integrate with Atlas using 
AtlasCleint. This helps the user to understand the basic rest functionality of 
Atlas such as

- EntityRest
- TypeDefRest
- DiscoveryRest
- LineageRest
- GlossaryRest


Diffs (updated)
-

  atlas-examples/pom.xml PRE-CREATION 
  atlas-examples/sample-app/README.md PRE-CREATION 
  atlas-examples/sample-app/pom.xml PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/DiscoveryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/EntityExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/GlossaryExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/LineageExample.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleApp.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/SampleAppConstants.java
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/java/org/apache/atlas/examples/sampleapp/TypeDefExample.java
 PRE-CREATION 
  atlas-examples/sample-app/src/main/resources/atlas-application.properties 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72698/diff/6/

Changes: https://reviews.apache.org/r/72698/diff/5-6/


Testing
---


Thanks,

Jyoti Singh

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

[Pinal Shah]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72646/
---

(Updated Aug. 4, 2020, 11:01 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

added support for Edge attribute predicate


Bugs: ATLAS-3876
https://issues.apache.org/jira/browse/ATLAS-3876


Repository: atlas


Description
---

**Issue:**
Relationship api doesn't provide approximate count of the related entities in 
the response.

**Workaround:**
Get the total count of related given entity , irrespective of the offset/limit.
Added 'getApproximateCount' as queryParam in Rest api.


Also this patch includes **improvement in the time taken to fetch related 
entities**  .
Average time taken for the Api to search relationship entities having **5000 
end vertices** with limit **500**:
Before: 9seconds
After applying this patch : 3seconds


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc47 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee4589f 
  
repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java 
86572598a 
  
repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java 
4b9564295 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
044179d44 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 863a00350 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
5069d78c8 
  webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java cdeb912a4 


Diff: https://reviews.apache.org/r/72646/diff/5/

Changes: https://reviews.apache.org/r/72646/diff/4-5/


Testing
---

Manually tested
Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2011 
(Failed in Impala build)


Thanks,

Pinal Shah

Review Request 72729: ATLAS-3910: Use KafkaZkClient instead of ZkUtils

[Viktor Somogyi-Vass]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72729/
---

Review request for atlas.


Repository: atlas


Description
---

ATLAS-3910: Use KafkaZkClient instead of ZkUtils


Diffs
-

  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 40b1fee71e57175cd7ddf8a3696ef147282295c2 
  
addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java
 c8cc85cda1f62b2d1a0a49c61abf06d9beb6fdb7 
  notification/src/main/java/org/apache/atlas/hook/AtlasTopicCreator.java 
c69574103e360fcfb7dfb525bb06043a1fd647c3 
  notification/src/test/java/org/apache/atlas/hook/AtlasTopicCreatorTest.java 
293784770502299875177bd4a4a9c4b32c6b5a9a 


Diff: https://reviews.apache.org/r/72729/diff/1/


Testing
---


Thanks,

Viktor Somogyi-Vass

[GitHub] [atlas] Aka-shi commented on pull request #101: add-dist-cassandra-elasticsearch-profile and support GS

[GitBox]

Aka-shi commented on pull request #101:
URL: https://github.com/apache/atlas/pull/101#issuecomment-668440631


   @mohamed-a-abdelaziz thanks. This worked for me. I checked out onto your 
branch and was able to build this. Any idea when this PR will be merged to 
master?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/
---

(Updated Aug. 4, 2020, 6:14 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3872
https://issues.apache.org/jira/browse/ATLAS-3872


Repository: atlas


Description
---

Cause of the problem:
Type-def Column is created by quick-start script.

Here in this case, Type-def Column has the attribute "name". And it has 
property isOptional = true

Type-def Column is a child of Type-def Asset which also has the attribute 
"name". And it has property isOptional = false

Now while creating Entity of Type-def Column from UI, it does not show 
attribute "name" in the mandatory fields because for Type-def Column its 
property isOptional = true

But while validating the attributes from server side we iterate through all the 
attributes of Entity type (Including Parent's attributes)
In this case, while validating Type-def Asset's attribute "name" (which has 
property isOptional = false) we get an error because its value is sent as 
"null" from UI side.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java e0843cb 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee458 
  repository/src/test/resources/sales-v1-full.zip 
07afbf6ecae312a840b54cae5ab01335c513d180 
  webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
6db6b58 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
 7c820e7 


Diff: https://reviews.apache.org/r/72644/diff/5/

Changes: https://reviews.apache.org/r/72644/diff/4-5/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console


Thanks,

Mandar Ambawane