Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-08-10 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated Aug. 11, 2020, 5:25 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments

Updated below index field names for FreetextSearchProcessor to resolve Test 
case failures.

"Referenceable.qualifiedName" -> "3k05_t"
"Asset.__s_name" -> "3r45_s"
"Asset.description" -> "3u9x_t"


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/7/

Changes: https://reviews.apache.org/r/72477/diff/6-7/


Testing (updated)
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console


Thanks,

Mandar Ambawane



Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

2020-08-10 Thread Jyoti Singh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72730/
---

(Updated Aug. 10, 2020, 5:26 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Sarath 
Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3875
https://issues.apache.org/jira/browse/ATLAS-3875


Repository: atlas


Description
---

- Added basic structure for Python client
- This includes all classes for Entity and TypeDef
- Added all endpoints for typedef


Diffs (updated)
-

  atlas-examples/sample-app/src/main/python/discovery_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/entity_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/glossary_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/lineage_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/entity_create_db.json 
PRE-CREATION 
  
atlas-examples/sample-app/src/main/python/request_json/entity_create_process.json
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_canada.json
 PRE-CREATION 
  
atlas-examples/sample-app/src/main/python/request_json/entity_create_table_us.json
 PRE-CREATION 
  atlas-examples/sample-app/src/main/python/request_json/typedef_create.json 
PRE-CREATION 
  atlas-examples/sample-app/src/main/python/sample_client.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/typedef_example.py PRE-CREATION 
  atlas-examples/sample-app/src/main/python/utils.py PRE-CREATION 
  client/client-v2/src/main/python/LICENSE PRE-CREATION 
  client/client-v2/src/main/python/README.md PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/__init__.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/base_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/discovery_client.py 
PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/discovery_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/entity_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/entity_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/glossary_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/glossary_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/lineage_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/lineage_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/relationship_client.py 
PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/relationship_model.py 
PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/typedef_client.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/typedef_model.py PRE-CREATION 
  client/client-v2/src/main/python/atlas_client/utils.py PRE-CREATION 
  client/client-v2/src/main/python/requirements.txt PRE-CREATION 
  client/client-v2/src/main/python/setup.py PRE-CREATION 
  client/client-v2/src/main/python/tests/__init__.py PRE-CREATION 
  client/client-v2/src/main/resources/logging.conf PRE-CREATION 


Diff: https://reviews.apache.org/r/72730/diff/4/

Changes: https://reviews.apache.org/r/72730/diff/3-4/


Testing
---

Tested on local.


Thanks,

Jyoti Singh



Re: Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

2020-08-10 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/
---

(Updated Aug. 10, 2020, 3 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3892
https://issues.apache.org/jira/browse/ATLAS-3892


Repository: atlas


Description
---

1.This patch implements the search history feature where from UI we will 
receive below filters.
2.In backend we have introduced a new operator "TIME_RANGE" where all the below 
7 attribute values will have TIME_RANGE operator.
3.There will be a slight change in the JSON where previously we were passing 
the Attribute value in Search parameters from the UI but for below filters   we 
will not pass any attributeValue except for "custom range" filter we provide 
attribute value 
  for eg ;"attributeValue":"159354180,159544260" .

New 7 filters :

1.last 7 days.
2.Last month.
3.Last 30 days.
4.Today.
5.Yesterday.
6.Custom Range.
7.This Month.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
fcc4494f2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
c5e3d6f0b 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
cf158cd99 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 7b40c2184 


Diff: https://reviews.apache.org/r/72713/diff/9/

Changes: https://reviews.apache.org/r/72713/diff/8-9/


Testing
---

Tested with below json: 
eg : 
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "TIME_RANGE",
"attributeValue": "YESTERDAY"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "hdfs_path",
  "classification": null,
  "termName": null
}
eg: Only For custom range filter we provide attribute value.
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "TIME_RANGE",
"attributeValue": "1595956315473,159596100"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}

* Added Test cases to check new processDateRange method functionality


Thanks,

chaitali



Re: Review Request 72713: ATLAS-3892 : Basic search enhanced Feature - Search history

2020-08-10 Thread chaitali

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72713/
---

(Updated Aug. 10, 2020, 2:44 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3892
https://issues.apache.org/jira/browse/ATLAS-3892


Repository: atlas


Description
---

1.This patch implements the search history feature where from UI we will 
receive below filters.
2.In backend we have introduced a new operator "TIME_RANGE" where all the below 
7 attribute values will have TIME_RANGE operator.
3.There will be a slight change in the JSON where previously we were passing 
the Attribute value in Search parameters from the UI but for below filters   we 
will not pass any attributeValue except for "custom range" filter we provide 
attribute value 
  for eg ;"attributeValue":"159354180,159544260" .

New 7 filters :

1.last 7 days.
2.Last month.
3.Last 30 days.
4.Today.
5.Yesterday.
6.Custom Range.
7.This Month.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java a71787bc0 
  intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java 
fcc4494f2 
  repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
c5e3d6f0b 
  repository/src/main/java/org/apache/atlas/util/SearchPredicateUtil.java 
cf158cd99 
  
repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
 7b40c2184 


Diff: https://reviews.apache.org/r/72713/diff/8/

Changes: https://reviews.apache.org/r/72713/diff/7-8/


Testing
---

Tested with below json: 
eg : 
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "TIME_RANGE",
"attributeValue": "YESTERDAY"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "hdfs_path",
  "classification": null,
  "termName": null
}
eg: Only For custom range filter we provide attribute value.
{
  "excludeDeletedEntities": true,
  "includeSubClassifications": true,
  "includeSubTypes": true,
  "includeClassificationAttributes": true,
  "entityFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "__timestamp",
"operator": "TIME_RANGE",
"attributeValue": "1595956315473,159596100"
  }
]
  },
  "tagFilters": null,
  "attributes": [
"__timestamp"
  ],
  "limit": 25,
  "offset": 0,
  "typeName": "Table",
  "classification": null,
  "termName": null
}

* Added Test cases to check new processDateRange method functionality


Thanks,

chaitali



[jira] [Updated] (ATLAS-3915) impala_process startTime and endTime epoch is being set to 0

2020-08-10 Thread chaitali borole (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-3915:
---
Attachment: (was: Screenshot from 2020-08-10 12-42-45.png)

> impala_process startTime and endTime epoch is being set to 0
> 
>
> Key: ATLAS-3915
> URL: https://issues.apache.org/jira/browse/ATLAS-3915
> Project: Atlas
>  Issue Type: Improvement
>  Components: impala-integration
>Affects Versions: 2.1.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> This patch fix following issue : impala process enitity start time and end 
> time was set 0 in the backend due to which the UI wasn't showing up timings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3915) impala_process startTime and endTime epoch is being set to 0

2020-08-10 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3915:
---
Affects Version/s: (was: 3.0.0)
   2.1.0

> impala_process startTime and endTime epoch is being set to 0
> 
>
> Key: ATLAS-3915
> URL: https://issues.apache.org/jira/browse/ATLAS-3915
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: Screenshot from 2020-08-10 12-42-45.png
>
>
> This patch fix following issue : impala process enitity start time and end 
> time was set 0 in the backend due to which the UI wasn't showing up timings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3915) impala_process startTime and endTime epoch is being set to 0

2020-08-10 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3915:
---
Component/s: impala-integration

> impala_process startTime and endTime epoch is being set to 0
> 
>
> Key: ATLAS-3915
> URL: https://issues.apache.org/jira/browse/ATLAS-3915
> Project: Atlas
>  Issue Type: Improvement
>  Components: impala-integration
>Affects Versions: 2.1.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: Screenshot from 2020-08-10 12-42-45.png
>
>
> This patch fix following issue : impala process enitity start time and end 
> time was set 0 in the backend due to which the UI wasn't showing up timings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3915) impala_process startTime and endTime epoch is being set to 0

2020-08-10 Thread chaitali borole (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-3915:
---
Attachment: Screenshot from 2020-08-10 12-42-45.png

> impala_process startTime and endTime epoch is being set to 0
> 
>
> Key: ATLAS-3915
> URL: https://issues.apache.org/jira/browse/ATLAS-3915
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: Screenshot from 2020-08-10 12-42-45.png
>
>
> This patch fix following issue : impala process enitity start time and end 
> time was set 0 in the backend due to which the UI wasn't showing up timings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3915) impala_process startTime and endTime epoch is being set to 0

2020-08-10 Thread chaitali borole (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-3915:
---
Description: This patch fix following issue : impala process enitity start 
time and end time was set 0 in the backend due to which the UI wasn't showing 
up timings.

> impala_process startTime and endTime epoch is being set to 0
> 
>
> Key: ATLAS-3915
> URL: https://issues.apache.org/jira/browse/ATLAS-3915
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> This patch fix following issue : impala process enitity start time and end 
> time was set 0 in the backend due to which the UI wasn't showing up timings.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3915) impala_process startTime and endTime epoch is being set to 0

2020-08-10 Thread chaitali borole (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-3915:
---
Fix Version/s: 3.0.0

> impala_process startTime and endTime epoch is being set to 0
> 
>
> Key: ATLAS-3915
> URL: https://issues.apache.org/jira/browse/ATLAS-3915
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3915) impala_process startTime and endTime epoch is being set to 0

2020-08-10 Thread chaitali borole (Jira)
chaitali borole created ATLAS-3915:
--

 Summary: impala_process startTime and endTime epoch is being set 
to 0
 Key: ATLAS-3915
 URL: https://issues.apache.org/jira/browse/ATLAS-3915
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 3.0.0
Reporter: chaitali borole
Assignee: chaitali borole






--
This message was sent by Atlassian Jira
(v8.3.4#803005)