[jira] [Commented] (ATLAS-3427) Atlas hooks enhancements for better fault-tolerance i.e. Kafka unavailability

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219971#comment-17219971
 ] 

ASF subversion and git services commented on ATLAS-3427:


Commit 5b3da223ffa611a66e6fd3ade2cb2d5a2345c733 in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5b3da22 ]

ATLAS-3427: fixed duplicate log4j.version definition in pom - #2


> Atlas hooks enhancements for better fault-tolerance i.e. Kafka unavailability
> -
>
> Key: ATLAS-3427
> URL: https://issues.apache.org/jira/browse/ATLAS-3427
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Nixon Rodrigues
>Assignee: Ashutosh Mestry
>Priority: Major
>
> *Background*
> Existing implementation for sending messages from the hooks relies on Kafka. 
> Which means that if Kafka is not available for any reasons, the messages do 
> not make it to Atlas. They are simply added to the _failed_._log_.
>  *Solution*
> Introduce a mechanism which preserves messages if destination for the 
> messages is not reachable. This new mechanism will also have logic to retry 
> these messages.
> *Requirements*
> The mechanism should be:
>  * Transparent: Existing hooks should not have to rework their 
> implementation. 
>  * Configurable: This should be introduced optionally. If hook chooses not to 
> use this, it should fallback to existing implementation. The behavior should 
> be configurable via properties.
>  * High-performance: Using this mechanism should not introduce additional 
> overhead. Ideally, there should not be additional serialization introduced.
>  * Reliable: The new mechanism should relay these messages reliably. Existing 
> message formats should be supported viz. plain, compressed, compress & 
> multi-part.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72988: ATLAS-3427: pom updates to fix duplicate definition of log4j.version

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72988/#review222123
---


Ship it!




Ship It!

- Ashutosh Mestry


On Oct. 23, 2020, 9:03 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72988/
> ---
> 
> (Updated Oct. 23, 2020, 9:03 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil 
> Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3427
> https://issues.apache.org/jira/browse/ATLAS-3427
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> recent updates to pom files introduced a duplicate property for log4j.version 
> - assigned 2 values: 1.2.17 and 2.8. Updated pom files to avoid duplicate 
> properties
> 
> 
> Diffs
> -
> 
>   addons/hbase-bridge/pom.xml 46d24589a 
>   addons/hive-bridge/pom.xml 54a6d8ec0 
>   addons/impala-bridge/pom.xml 14150dd1f 
>   notification/pom.xml 740e8e54e 
>   pom.xml d6cd6deba 
> 
> 
> Diff: https://reviews.apache.org/r/72988/diff/1/
> 
> 
> Testing
> ---
> 
> - precommit tests run: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/135/
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Review Request 72988: ATLAS-3427: pom updates to fix duplicate definition of log4j.version

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72988/
---

Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil 
Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3427
https://issues.apache.org/jira/browse/ATLAS-3427


Repository: atlas


Description
---

recent updates to pom files introduced a duplicate property for log4j.version - 
assigned 2 values: 1.2.17 and 2.8. Updated pom files to avoid duplicate 
properties


Diffs
-

  addons/hbase-bridge/pom.xml 46d24589a 
  addons/hive-bridge/pom.xml 54a6d8ec0 
  addons/impala-bridge/pom.xml 14150dd1f 
  notification/pom.xml 740e8e54e 
  pom.xml d6cd6deba 


Diff: https://reviews.apache.org/r/72988/diff/1/


Testing
---

- precommit tests run: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/135/


Thanks,

Madhan Neethiraj

Re: Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

[Jayendra Parab]

> On Oct. 23, 2020, 5:44 p.m., Ashutosh Mestry wrote:
> > Can you please add per-commit build details.

The build which passed 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/132/console
The build which failed 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/131/console


- Jayendra


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72987/#review222121
---


On Oct. 23, 2020, 5:43 p.m., Jayendra Parab wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72987/
> ---
> 
> (Updated Oct. 23, 2020, 5:43 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4005
> https://issues.apache.org/jira/browse/ATLAS-4005
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - The exception mentioned in the issue comes because the generated gremlin 
> query uses it.value() to get the values for an attribute of a vertex, If the 
> value isn't present, then it throws the mentioned exception
> - In the fix provided, a check is added in the generated gremlin script, 
> where property.isPresent(), is checked before getting any value
> - In ATLAS-2354, a similar issue was fixed, but because of that change there 
> are no results fetched for the scenario mentioned in ATLAS-4005. 
> - As part of fix for ATLAS-2354, whatever columns are present in select 
> clause, those columns were implicitly added to the where part of query, 
> because this no entities are selected
> - So this review request reverts that change so that selected values are 
> shown for entities matching the where clause
> - Also, after reverting the change one DSL Query test case was failing 
> because qualifiedName was null for columns which don't exist. So added a 
> check in GremilinQueryComposer.process() method to fix that testcase failure
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> 55ccabd23 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 801e89806 
>   repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
> fc7414802 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 5ace37944 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 959aa1149 
> 
> 
> Diff: https://reviews.apache.org/r/72987/diff/2/
> 
> 
> Testing
> ---
> 
> - All the testcases in DSLQueriesTest are passing
> - Tested with different queries from UI, like 
> "from hdfs_path where name="testPath" select name"
> "from hdfs_path where name="testPath" select name, owner"
> "from hdfs_path where name="testPath" select name, owner, description"
> all give expected results with any exceptions
> - Tried the above queries different scenarios
>   with all entites having the selected attributes set 
>   with some entities having the selected attribute set
>   with all entities having owner value as null
> all scenarios worked as expected
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>

Re: Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72987/#review222121
---


Ship it!




Can you please add per-commit build details.

- Ashutosh Mestry


On Oct. 23, 2020, 5:43 p.m., Jayendra Parab wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72987/
> ---
> 
> (Updated Oct. 23, 2020, 5:43 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4005
> https://issues.apache.org/jira/browse/ATLAS-4005
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - The exception mentioned in the issue comes because the generated gremlin 
> query uses it.value() to get the values for an attribute of a vertex, If the 
> value isn't present, then it throws the mentioned exception
> - In the fix provided, a check is added in the generated gremlin script, 
> where property.isPresent(), is checked before getting any value
> - In ATLAS-2354, a similar issue was fixed, but because of that change there 
> are no results fetched for the scenario mentioned in ATLAS-4005. 
> - As part of fix for ATLAS-2354, whatever columns are present in select 
> clause, those columns were implicitly added to the where part of query, 
> because this no entities are selected
> - So this review request reverts that change so that selected values are 
> shown for entities matching the where clause
> - Also, after reverting the change one DSL Query test case was failing 
> because qualifiedName was null for columns which don't exist. So added a 
> check in GremilinQueryComposer.process() method to fix that testcase failure
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> 55ccabd23 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 801e89806 
>   repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
> fc7414802 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 5ace37944 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 959aa1149 
> 
> 
> Diff: https://reviews.apache.org/r/72987/diff/2/
> 
> 
> Testing
> ---
> 
> - All the testcases in DSLQueriesTest are passing
> - Tested with different queries from UI, like 
> "from hdfs_path where name="testPath" select name"
> "from hdfs_path where name="testPath" select name, owner"
> "from hdfs_path where name="testPath" select name, owner, description"
> all give expected results with any exceptions
> - Tried the above queries different scenarios
>   with all entites having the selected attributes set 
>   with some entities having the selected attribute set
>   with all entities having owner value as null
> all scenarios worked as expected
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>

Re: Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72987/
---

(Updated Oct. 23, 2020, 5:43 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

- Addressed review comments
- Fixed testcases from GremlineQueryComposerTest which failed in precommit. 
Added isPresent check in the expected generated query value.


Bugs: ATLAS-4005
https://issues.apache.org/jira/browse/ATLAS-4005


Repository: atlas


Description
---

- The exception mentioned in the issue comes because the generated gremlin 
query uses it.value() to get the values for an attribute of a vertex, If the 
value isn't present, then it throws the mentioned exception
- In the fix provided, a check is added in the generated gremlin script, where 
property.isPresent(), is checked before getting any value
- In ATLAS-2354, a similar issue was fixed, but because of that change there 
are no results fetched for the scenario mentioned in ATLAS-4005. 
- As part of fix for ATLAS-2354, whatever columns are present in select clause, 
those columns were implicitly added to the where part of query, because this no 
entities are selected
- So this review request reverts that change so that selected values are shown 
for entities matching the where clause
- Also, after reverting the change one DSL Query test case was failing because 
qualifiedName was null for columns which don't exist. So added a check in 
GremilinQueryComposer.process() method to fix that testcase failure


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/query/GremlinClause.java 55ccabd23 
  repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
801e89806 
  repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
fc7414802 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 5ace37944 
  repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
959aa1149 


Diff: https://reviews.apache.org/r/72987/diff/2/

Changes: https://reviews.apache.org/r/72987/diff/1-2/


Testing
---

- All the testcases in DSLQueriesTest are passing
- Tested with different queries from UI, like 
"from hdfs_path where name="testPath" select name"
"from hdfs_path where name="testPath" select name, owner"
"from hdfs_path where name="testPath" select name, owner, description"
all give expected results with any exceptions
- Tried the above queries different scenarios
  with all entites having the selected attributes set 
  with some entities having the selected attribute set
  with all entities having owner value as null
all scenarios worked as expected


Thanks,

Jayendra Parab

[jira] [Commented] (ATLAS-4001) Update poi jar version to 4.1.1

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219833#comment-17219833
 ] 

ASF subversion and git services commented on ATLAS-4001:


Commit 947f83c623e3ce49c2f983002ed20101469a6e81 in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=947f83c ]

ATLAS-4001 : Update poi jar version to 4.1.1

(cherry picked from commit e45cd453a4abf9d0bf254ee127e62f0235039a69)


> Update poi jar version to 4.1.1
> ---
>
> Key: ATLAS-4001
> URL: https://issues.apache.org/jira/browse/ATLAS-4001
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
>  poi should be updated to 4.1.1+ to address CVE-2019-12415



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3994) import-hive.sh script fails when missing mandatory attribute value is null

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219835#comment-17219835
 ] 

ASF subversion and git services commented on ATLAS-3994:


Commit 3972da13d6df1b5975ae53ceddfe8d153db454fa in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3972da1 ]

ATLAS-3994 : import-hive.sh script fails when missing mandatory attribute value 
is null

(cherry picked from commit 82cdd700b2133e74ca8bce9aa55d93e76c8ec6fc)


> import-hive.sh script fails when missing mandatory attribute value is null
> --
>
> Key: ATLAS-3994
> URL: https://issues.apache.org/jira/browse/ATLAS-3994
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> 06:33:41.409 [main] ERROR org.apache.atlas.hive.bridge.HiveMetaStoreBridge - 
> Import failed for hive_table tobedeleted__wallet
> org.apache.atlas.AtlasServiceException: Metadata service API 
> org.apache.atlas.AtlasClientV2$API_V2@17f2dd85 failed with status 404 (Not 
> Found) Response Body ({"errorCode":"ATLAS-404-00-007","errorMessage":"Invalid 
> instance creation/updation parameters passed : hive_process.userName: 
> mandatory attribute value missing in type hive_process"})



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3996) Upgrade ant to 1.10.9

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219834#comment-17219834
 ] 

ASF subversion and git services commented on ATLAS-3996:


Commit 94dfc7a7d1a0f894d924dc02438cf01d22c1a504 in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=94dfc7a ]

ATLAS-3996 : Upgrade ant to 1.10.9

(cherry picked from commit 7925946adeeddeb878e2bdf3c0894b312a50f639)


> Upgrade ant to 1.10.9 
> --
>
> Key: ATLAS-3996
> URL: https://issues.apache.org/jira/browse/ATLAS-3996
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Critical
> Fix For: 3.0.0
>
>
> Upgrade ant to 1.10.9 due to CVE-2020-11979



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4003) Exclude findbugs-annotations jar from packaging

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219832#comment-17219832
 ] 

ASF subversion and git services commented on ATLAS-4003:


Commit 52d69b4dde5e53bb1db5774eaf91dbd5f75e7c41 in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=52d69b4 ]

ATLAS-4003 : Exclude findbugs-annotations jar from packaging

(cherry picked from commit 8f9ef44660230030a69bfc7c488edf8f11cfe933)


> Exclude findbugs-annotations jar from  packaging
> 
>
> Key: ATLAS-4003
> URL: https://issues.apache.org/jira/browse/ATLAS-4003
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4002) Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219831#comment-17219831
 ] 

ASF subversion and git services commented on ATLAS-4002:


Commit 4d050f0a205eb9b0394aceaae0e040cb5462aa2d in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4d050f0 ]

ATLAS-4002 : Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086

(cherry picked from commit f3faad547380ac786427d84c95244de502781360)


>  Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086
> -
>
> Key: ATLAS-4002
> URL: https://issues.apache.org/jira/browse/ATLAS-4002
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> Atlas is currently pulling in commons-beanutils 1.9.3 through atlas-repository
> We need to update opencsv jar version to 5.0 for the same
> commons-beanutils <1.9.4 is vulnerable to CVE-2019-10086
> ...
> [INFO] +- com.opencsv:opencsv:jar:4.6:compile
> [INFO] |  +- org.apache.commons:commons-text:jar:1.3:compile
> [INFO] |  +- commons-beanutils:commons-beanutils:jar:1.9.3:compile
> [INFO] |  \- org.apache.commons:commons-collections4:jar:4.4:compile
> ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (ATLAS-4000) update Jetty version to 9.4.31

[Madhan Neethiraj (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218160#comment-17218160
 ] 

Madhan Neethiraj edited comment on ATLAS-4000 at 10/23/20, 4:24 PM:


[Patch in review board - refactoring of UTs, 
ITs|https://reviews.apache.org/r/72986/]


was (Author: madhan.neethiraj):
[Patch in review board|https://reviews.apache.org/r/72978/]

> update Jetty version to 9.4.31
> --
>
> Key: ATLAS-4000
> URL: https://issues.apache.org/jira/browse/ATLAS-4000
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-4000-tests.patch, ATLAS-4000.patch
>
>
> Atlas currently uses Jetty version 9.2.12, which is about 4 years old. This 
> should be upgraded to a recent version - like 9.4.31.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4000) update Jetty version to 9.4.31

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-4000:

Attachment: ATLAS-4000-tests.patch

> update Jetty version to 9.4.31
> --
>
> Key: ATLAS-4000
> URL: https://issues.apache.org/jira/browse/ATLAS-4000
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-4000-tests.patch, ATLAS-4000.patch
>
>
> Atlas currently uses Jetty version 9.2.12, which is about 4 years old. This 
> should be upgraded to a recent version - like 9.4.31.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-3999) Update build to avoid distro in multiple formats - tar.gz and dir

[Madhan Neethiraj (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Madhan Neethiraj updated ATLAS-3999:

Fix Version/s: 2.2.0

> Update build to avoid distro in multiple formats - tar.gz and dir
> -
>
> Key: ATLAS-3999
> URL: https://issues.apache.org/jira/browse/ATLAS-3999
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3999.patch
>
>
> Atlas build generates distro in multiple formats - for example: tar.gz or zip 
> and a directory. To save build time and disk space, build should be updated 
> to only generate archives - .tar.gz or .zip, and avoid creating directories 
> with the same contents.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3999) Update build to avoid distro in multiple formats - tar.gz and dir

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219775#comment-17219775
 ] 

ASF subversion and git services commented on ATLAS-3999:


Commit d861641dd425f40e375298e90e4e081495efdbbb in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d861641 ]

ATLAS-3999: updated build to remove copying of dist artifacts into directories

(cherry picked from commit bd9d1213b48721f269f32db1ee388e2beb9a7d3d)


> Update build to avoid distro in multiple formats - tar.gz and dir
> -
>
> Key: ATLAS-3999
> URL: https://issues.apache.org/jira/browse/ATLAS-3999
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3999.patch
>
>
> Atlas build generates distro in multiple formats - for example: tar.gz or zip 
> and a directory. To save build time and disk space, build should be updated 
> to only generate archives - .tar.gz or .zip, and avoid creating directories 
> with the same contents.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4000) update Jetty version to 9.4.31

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219776#comment-17219776
 ] 

ASF subversion and git services commented on ATLAS-4000:


Commit f3f585170a7794d9f0c6b3f81ce18b276cef10ae in atlas's branch 
refs/heads/branch-2.0 from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f3f5851 ]

ATLAS-4000: refactored UTs and ITs to remove compile dependency from product 
code on atlas-testtools - #1

(cherry picked from commit 709598a3b6fd067327c922979a22071ff50fd1a6)


> update Jetty version to 9.4.31
> --
>
> Key: ATLAS-4000
> URL: https://issues.apache.org/jira/browse/ATLAS-4000
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-4000.patch
>
>
> Atlas currently uses Jetty version 9.2.12, which is about 4 years old. This 
> should be upgraded to a recent version - like 9.4.31.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4000) update Jetty version to 9.4.31

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219770#comment-17219770
 ] 

ASF subversion and git services commented on ATLAS-4000:


Commit 709598a3b6fd067327c922979a22071ff50fd1a6 in atlas's branch 
refs/heads/master from Madhan Neethiraj
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=709598a ]

ATLAS-4000: refactored UTs and ITs to remove compile dependency from product 
code on atlas-testtools - #1


> update Jetty version to 9.4.31
> --
>
> Key: ATLAS-4000
> URL: https://issues.apache.org/jira/browse/ATLAS-4000
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Madhan Neethiraj
>Assignee: Madhan Neethiraj
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-4000.patch
>
>
> Atlas currently uses Jetty version 9.2.12, which is about 4 years old. This 
> should be upgraded to a recent version - like 9.4.31.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72987/#review222120
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java
Lines 394 (patched)


nit: add spaces around operator. "+" => " + "



repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java
Line 90 (original), 90 (patched)


nit: add a space after a comma


- Madhan Neethiraj


On Oct. 23, 2020, 11:49 a.m., Jayendra Parab wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72987/
> ---
> 
> (Updated Oct. 23, 2020, 11:49 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4005
> https://issues.apache.org/jira/browse/ATLAS-4005
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - The exception mentioned in the issue comes because the generated gremlin 
> query uses it.value() to get the values for an attribute of a vertex, If the 
> value isn't present, then it throws the mentioned exception
> - In the fix provided, a check is added in the generated gremlin script, 
> where property.isPresent(), is checked before getting any value
> - In ATLAS-2354, a similar issue was fixed, but because of that change there 
> are no results fetched for the scenario mentioned in ATLAS-4005. 
> - As part of fix for ATLAS-2354, whatever columns are present in select 
> clause, those columns were implicitly added to the where part of query, 
> because this no entities are selected
> - So this review request reverts that change so that selected values are 
> shown for entities matching the where clause
> - Also, after reverting the change one DSL Query test case was failing 
> because qualifiedName was null for columns which don't exist. So added a 
> check in GremilinQueryComposer.process() method to fix that testcase failure
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> 55ccabd23 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 801e89806 
>   repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
> fc7414802 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 5ace37944 
> 
> 
> Diff: https://reviews.apache.org/r/72987/diff/1/
> 
> 
> Testing
> ---
> 
> - All the testcases in DSLQueriesTest are passing
> - Tested with different queries from UI, like 
> "from hdfs_path where name="testPath" select name"
> "from hdfs_path where name="testPath" select name, owner"
> "from hdfs_path where name="testPath" select name, owner, description"
> all give expected results with any exceptions
> - Tried the above queries different scenarios
>   with all entites having the selected attributes set 
>   with some entities having the selected attribute set
>   with all entities having owner value as null
> all scenarios worked as expected
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>

[jira] [Commented] (ATLAS-3984) Add UI Date Timezone and UI Date Format in Session api

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219735#comment-17219735
 ] 

ASF subversion and git services commented on ATLAS-3984:


Commit 4b0bd1c2308608e679757f21a9feec33a1ff0d5e in atlas's branch 
refs/heads/branch-2.0 from Mandar Ambawane
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=4b0bd1c ]

ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

Signed-off-by: Nikhil P Bonte 
(cherry picked from commit 90f5b4add36b8a006393d8fa92fa4ba93f49f309)


> Add UI Date Timezone and UI Date Format in Session api
> --
>
> Key: ATLAS-3984
> URL: https://issues.apache.org/jira/browse/ATLAS-3984
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3984-V2.patch
>
>
> Add UI Date Timezone and UI Date Format in Session api.
> Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
> values from property file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3984) Add UI Date Timezone and UI Date Format in Session api

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219730#comment-17219730
 ] 

ASF subversion and git services commented on ATLAS-3984:


Commit 90f5b4add36b8a006393d8fa92fa4ba93f49f309 in atlas's branch 
refs/heads/master from Mandar Ambawane
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=90f5b4a ]

ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

Signed-off-by: Nikhil P Bonte 


> Add UI Date Timezone and UI Date Format in Session api
> --
>
> Key: ATLAS-3984
> URL: https://issues.apache.org/jira/browse/ATLAS-3984
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3984-V2.patch
>
>
> Add UI Date Timezone and UI Date Format in Session api.
> Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
> values from property file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72979: ATLAS-4001 : Update poi jar version to 4.1.1

[Madhan Neethiraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72979/#review222119
---


Ship it!




Ship It!

- Madhan Neethiraj


On Oct. 23, 2020, 9:22 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72979/
> ---
> 
> (Updated Oct. 23, 2020, 9:22 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4001
> https://issues.apache.org/jira/browse/ATLAS-4001
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> poi should be updated to 4.1.1 to address CVE-2019-12415
> 
> 
> Diffs
> -
> 
>   pom.xml b9242016b 
>   repository/src/main/java/org/apache/atlas/util/FileUtils.java 66ade2640 
> 
> 
> Diff: https://reviews.apache.org/r/72979/diff/1/
> 
> 
> Testing
> ---
> 
> tested with the bulk upload glossary upload feature, bulk BM upload feature.
> Atlas server came up successfully.
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/124/consoleFull
> 
> 
> Thanks,
> 
> chaitali
> 
>

[jira] [Commented] (ATLAS-4003) Exclude findbugs-annotations jar from packaging

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219719#comment-17219719
 ] 

ASF subversion and git services commented on ATLAS-4003:


Commit 8f9ef44660230030a69bfc7c488edf8f11cfe933 in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=8f9ef44 ]

ATLAS-4003 : Exclude findbugs-annotations jar from packaging


> Exclude findbugs-annotations jar from  packaging
> 
>
> Key: ATLAS-4003
> URL: https://issues.apache.org/jira/browse/ATLAS-4003
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4001) Update poi jar version to 4.1.1

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219720#comment-17219720
 ] 

ASF subversion and git services commented on ATLAS-4001:


Commit e45cd453a4abf9d0bf254ee127e62f0235039a69 in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e45cd45 ]

ATLAS-4001 : Update poi jar version to 4.1.1


> Update poi jar version to 4.1.1
> ---
>
> Key: ATLAS-4001
> URL: https://issues.apache.org/jira/browse/ATLAS-4001
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
>  poi should be updated to 4.1.1+ to address CVE-2019-12415



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3994) import-hive.sh script fails when missing mandatory attribute value is null

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219722#comment-17219722
 ] 

ASF subversion and git services commented on ATLAS-3994:


Commit 82cdd700b2133e74ca8bce9aa55d93e76c8ec6fc in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=82cdd70 ]

ATLAS-3994 : import-hive.sh script fails when missing mandatory attribute value 
is null


> import-hive.sh script fails when missing mandatory attribute value is null
> --
>
> Key: ATLAS-3994
> URL: https://issues.apache.org/jira/browse/ATLAS-3994
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> 06:33:41.409 [main] ERROR org.apache.atlas.hive.bridge.HiveMetaStoreBridge - 
> Import failed for hive_table tobedeleted__wallet
> org.apache.atlas.AtlasServiceException: Metadata service API 
> org.apache.atlas.AtlasClientV2$API_V2@17f2dd85 failed with status 404 (Not 
> Found) Response Body ({"errorCode":"ATLAS-404-00-007","errorMessage":"Invalid 
> instance creation/updation parameters passed : hive_process.userName: 
> mandatory attribute value missing in type hive_process"})



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3996) Upgrade ant to 1.10.9

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219721#comment-17219721
 ] 

ASF subversion and git services commented on ATLAS-3996:


Commit 7925946adeeddeb878e2bdf3c0894b312a50f639 in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7925946 ]

ATLAS-3996 : Upgrade ant to 1.10.9


> Upgrade ant to 1.10.9 
> --
>
> Key: ATLAS-3996
> URL: https://issues.apache.org/jira/browse/ATLAS-3996
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Critical
> Fix For: 3.0.0
>
>
> Upgrade ant to 1.10.9 due to CVE-2020-11979



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4002) Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219718#comment-17219718
 ] 

ASF subversion and git services commented on ATLAS-4002:


Commit f3faad547380ac786427d84c95244de502781360 in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f3faad5 ]

ATLAS-4002 : Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086


>  Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086
> -
>
> Key: ATLAS-4002
> URL: https://issues.apache.org/jira/browse/ATLAS-4002
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> Atlas is currently pulling in commons-beanutils 1.9.3 through atlas-repository
> We need to update opencsv jar version to 5.0 for the same
> commons-beanutils <1.9.4 is vulnerable to CVE-2019-10086
> ...
> [INFO] +- com.opencsv:opencsv:jar:4.6:compile
> [INFO] |  +- org.apache.commons:commons-text:jar:1.3:compile
> [INFO] |  +- commons-beanutils:commons-beanutils:jar:1.9.3:compile
> [INFO] |  \- org.apache.commons:commons-collections4:jar:4.4:compile
> ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3935) Use Audit framework to capture audit entries for Import/Export operations

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219653#comment-17219653
 ] 

ASF subversion and git services commented on ATLAS-3935:


Commit a55dc670dd611c68d053f80c5fe0fc9c8c735a90 in atlas's branch 
refs/heads/branch-2.0 from Mandar Ambawane
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=a55dc67 ]

ATLAS-3935 Use Audit framework to capture audit entries for Import/Export 
operations #2

Signed-off-by: Nikhil P Bonte 
(cherry picked from commit f959d84adf8108386f513b5bd1601a4ef73749ad)


> Use Audit framework to capture audit entries for Import/Export operations
> -
>
> Key: ATLAS-3935
> URL: https://issues.apache.org/jira/browse/ATLAS-3935
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3935-V2.patch, ATLAS-3935-V3.patch
>
>
> By using Audit Framework, capture audit entries for Import/Export operations.
> These audit entries can be seen under the "Audits" tab of Admin section.
> *Add Import and Export specific information in Audit entry*
> * Total no. of entities imported/ exported
> * Total no. of entities imported/ exported of specific TypeDef
> * Export operation Fetch Type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3957) Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219654#comment-17219654
 ] 

ASF subversion and git services commented on ATLAS-3957:


Commit a5ce37e590cfa6c2dece394e264e44aaa029b08a in atlas's branch 
refs/heads/branch-2.0 from Mandar Ambawane
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=a5ce37e ]

ATLAS-3957 Use Audit framework to capture audit entries for Server Start and 
Server In Active mode (HA)

Signed-off-by: Nikhil P Bonte 
(cherry picked from commit 7dec8f538b6f3f52a4803b63efd3c5b0b41e966c)


> Use Audit framework to capture audit entries for "Server Start" and "Server 
> In Active mode" (HA)
> 
>
> Key: ATLAS-3957
> URL: https://issues.apache.org/jira/browse/ATLAS-3957
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3957-V3.patch, ATLAS-3957.patch
>
>
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> These audit entries can be seen under the "Audits" tab of Admin section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3935) Use Audit framework to capture audit entries for Import/Export operations

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219650#comment-17219650
 ] 

ASF subversion and git services commented on ATLAS-3935:


Commit f959d84adf8108386f513b5bd1601a4ef73749ad in atlas's branch 
refs/heads/master from Mandar Ambawane
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f959d84 ]

ATLAS-3935 Use Audit framework to capture audit entries for Import/Export 
operations #2

Signed-off-by: Nikhil P Bonte 


> Use Audit framework to capture audit entries for Import/Export operations
> -
>
> Key: ATLAS-3935
> URL: https://issues.apache.org/jira/browse/ATLAS-3935
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3935-V2.patch, ATLAS-3935-V3.patch
>
>
> By using Audit Framework, capture audit entries for Import/Export operations.
> These audit entries can be seen under the "Audits" tab of Admin section.
> *Add Import and Export specific information in Audit entry*
> * Total no. of entities imported/ exported
> * Total no. of entities imported/ exported of specific TypeDef
> * Export operation Fetch Type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3957) Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17219651#comment-17219651
 ] 

ASF subversion and git services commented on ATLAS-3957:


Commit 7dec8f538b6f3f52a4803b63efd3c5b0b41e966c in atlas's branch 
refs/heads/master from Mandar Ambawane
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7dec8f5 ]

ATLAS-3957 Use Audit framework to capture audit entries for Server Start and 
Server In Active mode (HA)

Signed-off-by: Nikhil P Bonte 


> Use Audit framework to capture audit entries for "Server Start" and "Server 
> In Active mode" (HA)
> 
>
> Key: ATLAS-3957
> URL: https://issues.apache.org/jira/browse/ATLAS-3957
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3957-V3.patch, ATLAS-3957.patch
>
>
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> These audit entries can be seen under the "Audits" tab of Admin section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

[Jayendra Parab]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72987/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4005
https://issues.apache.org/jira/browse/ATLAS-4005


Repository: atlas


Description
---

- The exception mentioned in the issue comes because the generated gremlin 
query uses it.value() to get the values for an attribute of a vertex, If the 
value isn't present, then it throws the mentioned exception
- In the fix provided, a check is added in the generated gremlin script, where 
property.isPresent(), is checked before getting any value
- In ATLAS-2354, a similar issue was fixed, but because of that change there 
are no results fetched for the scenario mentioned in ATLAS-4005. 
- As part of fix for ATLAS-2354, whatever columns are present in select clause, 
those columns were implicitly added to the where part of query, because this no 
entities are selected
- So this review request reverts that change so that selected values are shown 
for entities matching the where clause
- Also, after reverting the change one DSL Query test case was failing because 
qualifiedName was null for columns which don't exist. So added a check in 
GremilinQueryComposer.process() method to fix that testcase failure


Diffs
-

  repository/src/main/java/org/apache/atlas/query/GremlinClause.java 55ccabd23 
  repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
801e89806 
  repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
fc7414802 
  repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 5ace37944 


Diff: https://reviews.apache.org/r/72987/diff/1/


Testing
---

- All the testcases in DSLQueriesTest are passing
- Tested with different queries from UI, like 
"from hdfs_path where name="testPath" select name"
"from hdfs_path where name="testPath" select name, owner"
"from hdfs_path where name="testPath" select name, owner, description"
all give expected results with any exceptions
- Tried the above queries different scenarios
  with all entites having the selected attributes set 
  with some entities having the selected attribute set
  with all entities having owner value as null
all scenarios worked as expected


Thanks,

Jayendra Parab

Re: Review Request 72903: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations. Remove Import Audit params.

[Nixon Rodrigues]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72903/#review222112
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 23, 2020, 3:22 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72903/
> ---
> 
> (Updated Sept. 23, 2020, 3:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3935
> https://issues.apache.org/jira/browse/ATLAS-3935
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Remove list of guids which are stored in the params atrribute of 
> AtlasAuditEntry in case of Import operation.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 3a6139f 
> 
> 
> Diff: https://reviews.apache.org/r/72903/diff/1/
> 
> 
> Testing
> ---
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/32/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

[jira] [Created] (ATLAS-4005) DSL search gives error if select clause contains attributes with null values

[Jayendra Parab (Jira)]

Jayendra Parab created ATLAS-4005:
-

 Summary: DSL search gives error if select clause contains 
attributes with null values
 Key: ATLAS-4005
 URL: https://issues.apache.org/jira/browse/ATLAS-4005
 Project: Atlas
  Issue Type: Bug
Reporter: Jayendra Parab


When we do DSL search in the atlas, if one or more attributes in select clause 
are not set for a vertex then the below given exception is thrown:

 
{code:java}
java.lang.IllegalStateException: The property does not exist as the key has no 
associated value for the provided element 
{code}
Example, in the query below, if owner isn't set for any of the entities, but 
name and description are present then the above exception is thrown
{code:java}
from hdfs_path where name="testPath" select name, owner, description{code}
Expected Behaviour: Query should return name and description of the filtered 
entities with owner as blank



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72960: ATLAS-3994 : import-hive.sh script fails when missing mandatory attribute value is null

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72960/
---

(Updated Oct. 23, 2020, 9:32 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3994
https://issues.apache.org/jira/browse/ATLAS-3994


Repository: atlas


Description
---

06:33:41.409 [main] ERROR org.apache.atlas.hive.bridge.HiveMetaStoreBridge - 
Import failed for hive_table tobedeleted__wallet
org.apache.atlas.AtlasServiceException: Metadata service API 
org.apache.atlas.AtlasClientV2$API_V2@17f2dd85 failed with status 404 (Not 
Found) Response Body (

{"errorCode":"ATLAS-404-00-007","errorMessage":"Invalid instance 
creation/updation parameters passed : hive_process.userName: mandatory 
attribute value missing in type hive_process"}

)

This patch adds the null check for "owner" to fix the bug.


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 24e06dc2b 


Diff: https://reviews.apache.org/r/72960/diff/4/


Testing (updated)
---

Tested import hive script for db, tables
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/93/consoleFull


Thanks,

chaitali

Re: Review Request 72985: ATLAS-4003 : Exclude findbugs-annotations jar from packaging

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72985/
---

(Updated Oct. 23, 2020, 9:24 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4003
https://issues.apache.org/jira/browse/ATLAS-4003


Repository: atlas


Description
---

We need to exclude findbugs-annotations-1.3.9-1.jar from Atlas server packaging 
to resolve licensing issue


Diffs
-

  addons/hbase-bridge-shim/pom.xml ed8d7dfb2 
  addons/hbase-bridge/pom.xml c1d18c265 
  addons/hbase-testing-util/pom.xml 8bf5571f2 
  addons/hive-bridge/pom.xml 662fdd407 
  addons/sqoop-bridge/pom.xml 629eda161 
  repository/pom.xml 861896267 


Diff: https://reviews.apache.org/r/72985/diff/1/


Testing (updated)
---

Atlas server is up and running.
Atlas entities created
mvn clean install and mvn clean package went smooth.
findbugs-annotations-1.3.9-1.jar is not longer packaged.
import script was successful
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/123/console


Thanks,

chaitali

Re: Review Request 72979: ATLAS-4001 : Update poi jar version to 4.1.1

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72979/
---

(Updated Oct. 23, 2020, 9:22 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4001
https://issues.apache.org/jira/browse/ATLAS-4001


Repository: atlas


Description
---

poi should be updated to 4.1.1 to address CVE-2019-12415


Diffs
-

  pom.xml b9242016b 
  repository/src/main/java/org/apache/atlas/util/FileUtils.java 66ade2640 


Diff: https://reviews.apache.org/r/72979/diff/1/


Testing (updated)
---

tested with the bulk upload glossary upload feature, bulk BM upload feature.
Atlas server came up successfully.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/124/consoleFull


Thanks,

chaitali

Re: Review Request 72970: ATLAS-3996 : Upgrade ant to 1.10.9

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72970/
---

(Updated Oct. 23, 2020, 9:21 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3996
https://issues.apache.org/jira/browse/ATLAS-3996


Repository: atlas


Description
---

Upgrade ant to 1.10.9 due to vulnerability to CVE-2020-11979
It is a transitive dependency comes from solr-test-framework.


Diffs
-

  pom.xml 6b5d2fde6 


Diff: https://reviews.apache.org/r/72970/diff/1/


Testing (updated)
---

Tested with following scenario :
Created entities eg from Hive shell
mvn clean install
mvn clean package -Pdist,embedded-hbase-solr -DskipTests
Atlas server is running successfully
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/125/consoleFull


Thanks,

chaitali

Re: Review Request 72983: ATLAS-4002 : Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72983/
---

(Updated Oct. 23, 2020, 9:20 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4002
https://issues.apache.org/jira/browse/ATLAS-4002


Repository: atlas


Description
---

Atlas is currently pulling in commons-beanutils 1.9.3 through atlas-repository

We need to update opencsv jar version to 5.0 for the same

Upgrading opencsv jar to 5.0

commons-beanutils <1.9.4 is vulnerable to CVE-2019-10086

...
[INFO] +- com.opencsv:opencsv:jar:4.6:compile
[INFO] | +- org.apache.commons:commons-text:jar:1.3:compile
[INFO] | +- commons-beanutils:commons-beanutils:jar:1.9.3:compile
[INFO] | - org.apache.commons:commons-collections4:jar:4.4:compile


Diffs
-

  pom.xml b9242016b 
  repository/src/main/java/org/apache/atlas/util/FileUtils.java 66ade2640 


Diff: https://reviews.apache.org/r/72983/diff/1/


Testing (updated)
---

Tested with bulk upload feature for Businessmetadata and glossary
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/122/consoleFull


Thanks,

chaitali

Re: Review Request 72970: ATLAS-3996 : Upgrade ant to 1.10.9

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72970/
---

(Updated Oct. 23, 2020, 9:21 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3996
https://issues.apache.org/jira/browse/ATLAS-3996


Repository: atlas


Description
---

Upgrade ant to 1.10.9 due to vulnerability to CVE-2020-11979
It is a transitive dependency comes from solr-test-framework.


Diffs
-

  pom.xml 6b5d2fde6 


Diff: https://reviews.apache.org/r/72970/diff/1/


Testing (updated)
---

Tested with following scenario :
Created entities eg from Hive shell
mvn clean install
mvn clean package -Pdist,embedded-hbase-solr -DskipTests
Atlas server is running successfully
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/125/consoleFull-


Thanks,

chaitali

Re: Review Request 72979: ATLAS-4001 : Update poi jar version to 4.1.1

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72979/
---

(Updated Oct. 23, 2020, 9:19 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4001
https://issues.apache.org/jira/browse/ATLAS-4001


Repository: atlas


Description
---

poi should be updated to 4.1.1 to address CVE-2019-12415


Diffs
-

  pom.xml b9242016b 
  repository/src/main/java/org/apache/atlas/util/FileUtils.java 66ade2640 


Diff: https://reviews.apache.org/r/72979/diff/1/


Testing (updated)
---

tested with the bulk upload glossary upload feature, bulk BM upload feature.
Atlas server came up successfully.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/124/consoleFull-
 72979


Thanks,

chaitali

Re: Review Request 72979: ATLAS-4001 : Update poi jar version to 4.1.1

[chaitali]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72979/
---

(Updated Oct. 23, 2020, 9:16 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4001
https://issues.apache.org/jira/browse/ATLAS-4001


Repository: atlas


Description
---

poi should be updated to 4.1.1 to address CVE-2019-12415


Diffs
-

  pom.xml b9242016b 
  repository/src/main/java/org/apache/atlas/util/FileUtils.java 66ade2640 


Diff: https://reviews.apache.org/r/72979/diff/1/


Testing (updated)
---

tested with the bulk upload glossary upload feature, bulk BM upload feature.
Atlas server came up successfully.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/122/consoleFull


Thanks,

chaitali

[jira] [Updated] (ATLAS-4003) Exclude findbugs-annotations jar from packaging

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4003:
---
Fix Version/s: 3.0.0

> Exclude findbugs-annotations jar from  packaging
> 
>
> Key: ATLAS-4003
> URL: https://issues.apache.org/jira/browse/ATLAS-4003
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4002) Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4002:
---
Fix Version/s: 3.0.0

>  Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086
> -
>
> Key: ATLAS-4002
> URL: https://issues.apache.org/jira/browse/ATLAS-4002
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> Atlas is currently pulling in commons-beanutils 1.9.3 through atlas-repository
> We need to update opencsv jar version to 5.0 for the same
> commons-beanutils <1.9.4 is vulnerable to CVE-2019-10086
> ...
> [INFO] +- com.opencsv:opencsv:jar:4.6:compile
> [INFO] |  +- org.apache.commons:commons-text:jar:1.3:compile
> [INFO] |  +- commons-beanutils:commons-beanutils:jar:1.9.3:compile
> [INFO] |  \- org.apache.commons:commons-collections4:jar:4.4:compile
> ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4002) Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4002?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4002:
---
Affects Version/s: 3.0.0

>  Upgrade commons-beanutils to 1.9.4 due to CVE-2019-10086
> -
>
> Key: ATLAS-4002
> URL: https://issues.apache.org/jira/browse/ATLAS-4002
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> Atlas is currently pulling in commons-beanutils 1.9.3 through atlas-repository
> We need to update opencsv jar version to 5.0 for the same
> commons-beanutils <1.9.4 is vulnerable to CVE-2019-10086
> ...
> [INFO] +- com.opencsv:opencsv:jar:4.6:compile
> [INFO] |  +- org.apache.commons:commons-text:jar:1.3:compile
> [INFO] |  +- commons-beanutils:commons-beanutils:jar:1.9.3:compile
> [INFO] |  \- org.apache.commons:commons-collections4:jar:4.4:compile
> ...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4001) Update poi jar version to 4.1.1

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4001:
---
Affects Version/s: 3.0.0

> Update poi jar version to 4.1.1
> ---
>
> Key: ATLAS-4001
> URL: https://issues.apache.org/jira/browse/ATLAS-4001
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
>  poi should be updated to 4.1.1+ to address CVE-2019-12415



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4001) Update poi jar version to 4.1.1

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4001?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4001:
---
Fix Version/s: 3.0.0

> Update poi jar version to 4.1.1
> ---
>
> Key: ATLAS-4001
> URL: https://issues.apache.org/jira/browse/ATLAS-4001
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
>  poi should be updated to 4.1.1+ to address CVE-2019-12415



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4003) Exclude findbugs-annotations jar from packaging

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4003:
---
Affects Version/s: 3.0.0

> Exclude findbugs-annotations jar from  packaging
> 
>
> Key: ATLAS-4003
> URL: https://issues.apache.org/jira/browse/ATLAS-4003
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72986: ATLAS-4000: UTs, ITs refactoring, and removal of compile time dependency to atlas-testtools from product code - #1

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72986/#review222109
---


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 22, 2020, 10:49 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72986/
> ---
> 
> (Updated Oct. 22, 2020, 10:49 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Deep Singh, Jayendra Parab, Nikhil 
> Bonte, Nixon Rodrigues, Pinal Shah, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4000
> https://issues.apache.org/jira/browse/ATLAS-4000
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - refactored UTs and ITs to minmized references to LocalSolrRunner/Solr test 
> framework
> - removed compile time dependency to atlas-testtools from non-test code 
> (repository, graphdb/janus/webapp modules)
> 
> 
> Diffs
> -
> 
>   graphdb/janus/pom.xml 6deef5181 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  e9b4b09ef 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 6509fef6b 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AbstractGraphDatabaseTest.java
>  35004157f 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusDatabaseTest.java
>  5cd55093e 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/JanusGraphProviderTest.java
>  54b1bc621 
>   pom.xml 91fd593d8 
>   repository/pom.xml 861896267 
>   
> repository/src/main/java/org/apache/atlas/discovery/FreeTextSearchProcessor.java
>  d9981e6f6 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  e35f3594f 
>   repository/src/test/java/org/apache/atlas/BasicTestSetup.java 270051fdc 
>   repository/src/test/java/org/apache/atlas/TestModules.java a298934f3 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  d8c1546e2 
>   
> repository/src/test/java/org/apache/atlas/discovery/ClassificationSearchProcessorTest.java
>  869345921 
>   
> repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java
>  db107b377 
>   
> repository/src/test/java/org/apache/atlas/discovery/FreeTextSearchProcessorTest.java
>  2a38d874d 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 5ace37944 
>   repository/src/test/java/org/apache/atlas/repository/AtlasTestBase.java 
> c2668b195 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AdminPurgeTest.java
>  173e446e5 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ExportServiceTest.java
>  8e19dc4d3 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportReactivateTableTest.java
>  e06bf66d1 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/ImportServiceTest.java
>  7367153ec 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/RelationshipAttributesExtractorTest.java
>  5f41cc968 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TableReplicationRequestProcessorTest.java
>  99df914ff 
>   
> repository/src/test/java/org/apache/atlas/repository/migration/MigrationBaseAsserts.java
>  bd8359c4f 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStoreTest.java
>  b654638f1 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityDefStoreV2Test.java
>  587624834 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityTestBase.java
>  752f1acfc 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipDefStoreV2Test.java
>  1a774e2a1 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2Test.java
>  4cdd677e5 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/InverseReferenceUpdateV2Test.java
>  36aedae9f 
>   
> repository/src/test/java/org/apache/atlas/repository/tagpropagation/ClassificationPropagationTest.java
>  80e20bed8 
>   
> repository/src/test/java/org/apache/atlas/repository/userprofile/UserProfileServiceTest.java
>  eeab3bca2 
>   repository/src/test/java/org/apache/atlas/services/MetricsServiceTest.java 
> 4739bca31 
>   test-tools/pom.xml 434d15c1b 
>   test-tools/src/main/java/org/apache/atlas/runner/LocalSolrRunner.java 
> 2c79e2f51 
>   webapp/pom.xml ffc3d37ef 
>   webapp/src/test/java/org/apache/atlas/web/security/SSLAndKerberosTest.java 
> 417a19ace 
> 
> 
> Diff: https://reviews.apache.org/r/72986/diff/2/
> 
> 
> Testing
> ---
> 
> - precommit tests run: 
>