Re: Review Request 73007: ATLAS-4016 Update authorization - 'admin-audits' for retrieving admin audits

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73007/
---

(Updated Nov. 10, 2020, 7:55 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-4016
https://issues.apache.org/jira/browse/ATLAS-4016


Repository: atlas


Description
---

For Atlas Admin Audits we need to add new privilege - "admin-audits" for 
authorization

Similar permission needs to be updated in ranger atlas service-def.


Diffs (updated)
-

  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
9dbcd32 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
f6a20c0 


Diff: https://reviews.apache.org/r/73007/diff/2/

Changes: https://reviews.apache.org/r/73007/diff/1-2/


Testing
---

Testing is done on the cluster with Atlas and Ranger services running.

First, When only Atlas side changes are applied on cluster and then Admin tries 
to access the Admin Audits, It gets an Authorization error 403. Which is 
expected.

Then after applying Ranger side changes on cluster, Admin could successfully 
access the Admin Audits.


Thanks,

Mandar Ambawane

Re: Review Request 73010: Re-Indexing Implemented as JAVA_PATCH

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73010/#review222185
---




repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
Lines 58 (patched)


should ReIndexPatch be moved 1st in order? Reindexing (if enabled) should 
be complete first before other patches?



repository/src/main/java/org/apache/atlas/repository/patches/ReIndexPatch.java
Lines 37 (patched)


nit: remove unused imports in line 37/38



repository/src/main/java/org/apache/atlas/repository/patches/ReIndexPatch.java
Lines 85 (patched)


'vertexIndexNames' and 'edgeIndexNames' can be assigned as static string 
array here instead of assigning from constructor.


- Sarath Subramanian


On Nov. 9, 2020, 1:45 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73010/
> ---
> 
> (Updated Nov. 9, 2020, 1:45 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4015
> https://issues.apache.org/jira/browse/ATLAS-4015
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Please see JIRA.
> Re-indexing within Atlas was implemented so far as an external tool. Using 
> this tool had number of challenges. The biggest being the throughput of the 
> tool. For a medium sized Atlas repository, the tool could take days to finish.
> 
> The implementation addresses the problems. (See results below.)
> 
> **Approach**
> Re-indexing is now implemented as a JAVA_PATCH that is applied only when the 
> property _atlas.patch.reindex.enabled_ is set to true.
> 
> *Modified* AtlasJanusGraphManagement: New method _reindex_ implements the 
> re-indexing logic.
> *New* _ReIndexPatch_ is a JAVA_PATCH that implements the reindexing logic. 
> This uses the PC framework to enumerate vertices and edges. The patch 
> application displays useful log messages indicating progress.
> 
> **Configuration**
> _atlas.patch.reindex.enabled=true_
> 
> 
> Diffs
> -
> 
>   
> graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
>  f7d2e273c 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
>  2a2ef92a7 
>   intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 1c7915859 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
>  b142a2a4a 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java
>  c6f0e6438 
>   
> repository/src/main/java/org/apache/atlas/repository/patches/ReIndexPatch.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/73010/diff/1/
> 
> 
> Testing
> ---
> 
> **Test Setup**
> Start with a known Atlas setup with known data. Ascetain that basic search 
> yields results.
> 
> Use these CURL commands to delete Solr indexes:
> 
> curl http://:8983/solr/vertex_index/update?commit=true  -H 
> "Content-Type: text/xml" --data-binary 
> 'b2d_t:*'
> 
> curl http://:8983/solr/edge_index/update?commit=true  -H "Content-Type: 
> text/xml" --data-binary '1151_t:*'
> 
> curl 
> http://ve0128.halxg.cloudera.com:8983/solr/fulltext_index/update?commit=true  
> -H "Content-Type: text/xml" --data-binary 
> '14at_t:*'
> 
> This will delete solr indexes. If basic search is performed from within the 
> web UI, it will not show any results.
> 
> Now set configuration parameter. Restart Atlas.
> 
> Server-side logs will indicate that the patch is run.
> 
> **Volume Testing**
> Vertices: ~16M: Duration: ~5 hrs.
> Edges: ~122M: ~6 hrs.
> 
> Configuration parameters:
> atlas.patch.reindex.enabled=true
> atlas.patch.numWorkers=14
> atlas.patch.batchSize=1000
> 
> Node configuration:
> Atlas: Heap size: 6 GB.
> Solr: Heap size: 12 GB.
> 
> **PC Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/177/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222186
---


Ship it!




Ship It!

- Sarath Subramanian


On Nov. 9, 2020, 4:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 9, 2020, 4:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/179/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

[Ashutosh Mestry via Review Board]

> On Nov. 10, 2020, 6:02 a.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
> > Line 108 (original), 108 (patched)
> > 
> >
> > why ignore relationships flag is turned ON?

This is a use case where all the imported entities should have the 
_replicatedFrom_ attribute set. This 
https://issues.apache.org/jira/browse/ATLAS-3109 inadvertently removed that 
behavior causing only the top-level entities to have that attribite.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222183
---


On Nov. 10, 2020, 12:21 a.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 10, 2020, 12:21 a.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222183
---


Fix it, then Ship it!





repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
Line 108 (original), 108 (patched)


why ignore relationships flag is turned ON?


- Sarath Subramanian


On Nov. 9, 2020, 4:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Nov. 9, 2020, 4:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
>  542106f36 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
>   repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/3/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> File Attachments
> 
> 
> Stocks with BM
>   
> https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>

[jira] [Updated] (ATLAS-4015) Indexes: Add Conditional Re-Indexing Patch

[Ashutosh Mestry (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4015:
---
Description: 
*Background*

Every so often, we encounter cases where the Solr indexes are out of sync with 
the data stored in the database. This leads to incorrect basic search output. 
Additionally the facet numbers displayed are also incorrect.

*Solution*

It may help to make the ReIndex functionality to be made part of one of 
JAVA_PATCH handlers that can be applied only when end user notices a problem 
like described above.

 

  was:
*Background*

Every so often, we encounter cases where the Solr indexes are out of sync with 
the data stored in the database. The is leads basic search output. Additionally 
the facet numbers displayed are also incorrect.

*Solution*

It may help to make the ReIndex functionality to be made part of one of 
JAVA_PATCH handlers that can be applied only when end user notices a problem 
like described above.

 


> Indexes: Add Conditional Re-Indexing Patch
> --
>
> Key: ATLAS-4015
> URL: https://issues.apache.org/jira/browse/ATLAS-4015
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH-master.patch
>
>
> *Background*
> Every so often, we encounter cases where the Solr indexes are out of sync 
> with the data stored in the database. This leads to incorrect basic search 
> output. Additionally the facet numbers displayed are also incorrect.
> *Solution*
> It may help to make the ReIndex functionality to be made part of one of 
> JAVA_PATCH handlers that can be applied only when end user notices a problem 
> like described above.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/
---

(Updated Nov. 10, 2020, 12:21 a.m.)


Review request for atlas, Nikhil Bonte and Sarath Subramanian.


Changes
---

Updates include: 
- Addressed review comments.
- Fixed bug introduced by https://issues.apache.org/jira/browse/ATLAS-3109


Bugs: ATLAS-4006 and ATLAS-4007
https://issues.apache.org/jira/browse/ATLAS-4006
https://issues.apache.org/jira/browse/ATLAS-4007


Repository: atlas


Description
---

**Background**
Existing implementation does not support export and import of _Business 
Metadata_ (BM) attributes. 

**Implementation**
- Export: Updated existing flow to include detecting BM attributes and adding 
the types to the exported payload.
- Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
and update.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/impexp/AtlasServerService.java
 542106f36 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
0491a853a 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
 664af9166 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
 b65807742 
  
repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
 0d78dbe57 
  
repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
 f9b7cd11f 
  repository/src/test/resources/json/typesDef-bm.json PRE-CREATION 


Diff: https://reviews.apache.org/r/72991/diff/3/

Changes: https://reviews.apache.org/r/72991/diff/2-3/


Testing
---

**Unit tests**
New tests added.

**Functional testing**
End-to-end tests. (Export-import-export).

**Pre-commit Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/


File Attachments


Stocks with BM
  
https://reviews.apache.org/media/uploaded/files/2020/10/29/8ea9511f-3b0e-4b27-96cb-e5f2f50ba75d__stocks-bm.zip


Thanks,

Ashutosh Mestry

[jira] [Commented] (ATLAS-4010) Sort properties lexicographically in pom.xml for readability

[Radhika Kundam (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228863#comment-17228863
 ] 

Radhika Kundam commented on ATLAS-4010:
---

PC build: 
[https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/178/]

> Sort properties lexicographically in pom.xml for readability
> 
>
> Key: ATLAS-4010
> URL: https://issues.apache.org/jira/browse/ATLAS-4010
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Trivial
>
> Properties are in random order under  section in all pom.xml 
> files.
> For better readability, need to sort properties in lexicographic order.
> Below are the pom.xml files with  tag
> atlas/pom.xml
> atlas/distro/pom.xml
> atlas/docs/pom.xml
> atlas/webapp/pom.xml
> Need to sort all the properties inside the each  tag in 
> alphabetically ascending order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4010) Sort properties lexicographically in pom.xml for readability

[Radhika Kundam (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam updated ATLAS-4010:
--
Description: 
Properties are in random order under  section in all pom.xml files.

For better readability, need to sort properties in lexicographic order.

Below are the pom.xml files with  tag

atlas/pom.xml

atlas/distro/pom.xml

atlas/docs/pom.xml

atlas/webapp/pom.xml

Need to sort all the properties inside the each  tag in 
alphabetically ascending order.

  was:
Properties are in random order under  section in pom.xml

For better readability, need to sort properties in lexicographic order.


> Sort properties lexicographically in pom.xml for readability
> 
>
> Key: ATLAS-4010
> URL: https://issues.apache.org/jira/browse/ATLAS-4010
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Trivial
>
> Properties are in random order under  section in all pom.xml 
> files.
> For better readability, need to sort properties in lexicographic order.
> Below are the pom.xml files with  tag
> atlas/pom.xml
> atlas/distro/pom.xml
> atlas/docs/pom.xml
> atlas/webapp/pom.xml
> Need to sort all the properties inside the each  tag in 
> alphabetically ascending order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 72994: ATLAS-4010: Sort properties lexicographically in pom.xml for readability

[Radhika Kundam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72994/
---

(Updated Nov. 9, 2020, 2:17 p.m.)


Review request for atlas, Ashutosh Mestry and Madhan Neethiraj.


Bugs: ATLAS-4010
https://issues.apache.org/jira/browse/ATLAS-4010


Repository: atlas


Description
---

Properties are in random order under  section in pom.xml

For better readability, need to sort properties in lexicographic order.


Diffs
-

  distro/pom.xml db1f23acd 
  docs/pom.xml f22f9e2ff 
  pom.xml aca36aaee 
  webapp/pom.xml 5a8cfe616 


Diff: https://reviews.apache.org/r/72994/diff/2/


Testing (updated)
---

Build is successful.
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/178/


File Attachments


Removing extra spaces
  
https://reviews.apache.org/media/uploaded/files/2020/10/30/40e165c6-985c-48e0-a61a-558ef4d9b2a3__0002-ATLAS-4010-Sort-properties-in-pom-removing-extra-spa.patch


Thanks,

Radhika Kundam

[jira] [Updated] (ATLAS-4010) Sort properties lexicographically in pom.xml for readability

[Radhika Kundam (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam updated ATLAS-4010:
--
Component/s:  atlas-core

> Sort properties lexicographically in pom.xml for readability
> 
>
> Key: ATLAS-4010
> URL: https://issues.apache.org/jira/browse/ATLAS-4010
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Trivial
>
> Properties are in random order under  section in pom.xml
> For better readability, need to sort properties in lexicographic order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4010) Sort properties lexicographically in pom.xml for readability

[Radhika Kundam (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Radhika Kundam updated ATLAS-4010:
--
Affects Version/s: 2.1.0

> Sort properties lexicographically in pom.xml for readability
> 
>
> Key: ATLAS-4010
> URL: https://issues.apache.org/jira/browse/ATLAS-4010
> Project: Atlas
>  Issue Type: Task
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Radhika Kundam
>Assignee: Radhika Kundam
>Priority: Trivial
>
> Properties are in random order under  section in pom.xml
> For better readability, need to sort properties in lexicographic order.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4015) Indexes: Add Conditional Re-Indexing Patch

[Ashutosh Mestry (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4015:
---
Attachment: (was: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH.patch)

> Indexes: Add Conditional Re-Indexing Patch
> --
>
> Key: ATLAS-4015
> URL: https://issues.apache.org/jira/browse/ATLAS-4015
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH-master.patch
>
>
> *Background*
> Every so often, we encounter cases where the Solr indexes are out of sync 
> with the data stored in the database. The is leads basic search output. 
> Additionally the facet numbers displayed are also incorrect.
> *Solution*
> It may help to make the ReIndex functionality to be made part of one of 
> JAVA_PATCH handlers that can be applied only when end user notices a problem 
> like described above.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4015) Indexes: Add Conditional Re-Indexing Patch

[Ashutosh Mestry (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4015:
---
Attachment: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH-master.patch

> Indexes: Add Conditional Re-Indexing Patch
> --
>
> Key: ATLAS-4015
> URL: https://issues.apache.org/jira/browse/ATLAS-4015
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH-master.patch
>
>
> *Background*
> Every so often, we encounter cases where the Solr indexes are out of sync 
> with the data stored in the database. The is leads basic search output. 
> Additionally the facet numbers displayed are also incorrect.
> *Solution*
> It may help to make the ReIndex functionality to be made part of one of 
> JAVA_PATCH handlers that can be applied only when end user notices a problem 
> like described above.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73010: Re-Indexing Implemented as JAVA_PATCH

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73010/
---

Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and 
Sarath Subramanian.


Bugs: ATLAS-4015
https://issues.apache.org/jira/browse/ATLAS-4015


Repository: atlas


Description
---

**Background**
Please see JIRA.
Re-indexing within Atlas was implemented so far as an external tool. Using this 
tool had number of challenges. The biggest being the throughput of the tool. 
For a medium sized Atlas repository, the tool could take days to finish.

The implementation addresses the problems. (See results below.)

**Approach**
Re-indexing is now implemented as a JAVA_PATCH that is applied only when the 
property _atlas.patch.reindex.enabled_ is set to true.

*Modified* AtlasJanusGraphManagement: New method _reindex_ implements the 
re-indexing logic.
*New* _ReIndexPatch_ is a JAVA_PATCH that implements the reindexing logic. This 
uses the PC framework to enumerate vertices and edges. The patch application 
displays useful log messages indicating progress.

**Configuration**
_atlas.patch.reindex.enabled=true_


Diffs
-

  
graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasGraphManagement.java
 f7d2e273c 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphManagement.java
 2a2ef92a7 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 1c7915859 
  
repository/src/main/java/org/apache/atlas/repository/patches/AtlasPatchManager.java
 b142a2a4a 
  
repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java
 c6f0e6438 
  
repository/src/main/java/org/apache/atlas/repository/patches/ReIndexPatch.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/73010/diff/1/


Testing
---

**Test Setup**
Start with a known Atlas setup with known data. Ascetain that basic search 
yields results.

Use these CURL commands to delete Solr indexes:

curl http://:8983/solr/vertex_index/update?commit=true  -H "Content-Type: 
text/xml" --data-binary 'b2d_t:*'

curl http://:8983/solr/edge_index/update?commit=true  -H "Content-Type: 
text/xml" --data-binary '1151_t:*'

curl 
http://ve0128.halxg.cloudera.com:8983/solr/fulltext_index/update?commit=true  
-H "Content-Type: text/xml" --data-binary 
'14at_t:*'

This will delete solr indexes. If basic search is performed from within the web 
UI, it will not show any results.

Now set configuration parameter. Restart Atlas.

Server-side logs will indicate that the patch is run.

**Volume Testing**
Vertices: ~16M: Duration: ~5 hrs.
Edges: ~122M: ~6 hrs.

**PC Build**
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/177/


Thanks,

Ashutosh Mestry

[jira] [Commented] (ATLAS-2752) Atlas start up fail with error "Error creating bean with name 'graphTransactionAdvisor'

[Raymond Lee (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228732#comment-17228732
 ] 

Raymond Lee commented on ATLAS-2752:


Any resolution to this?  I have the same issue and don't know how to resolve 
this.  

> Atlas start up fail with error "Error creating bean with name 
> 'graphTransactionAdvisor'
> ---
>
> Key: ATLAS-2752
> URL: https://issues.apache.org/jira/browse/ATLAS-2752
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Affects Versions: 1.0.0
> Environment: test
>Reporter: Mahesh Kakol
>Priority: Major
>
> I am getting below while starting atlas  and graph stoage as cassandra
>  
>  
> 2018-06-11 11:54:21,226 WARN - [main:] ~ Using @Deprecated Class 
> org.springframework.web.util.Log4jConfigListener (DeprecationWarning:43)
> 2018-06-11 11:54:23,400 WARN - [main:] ~ Exception encountered during context 
> initialization - cancelling refresh attempt: 
> org.springframework.beans.factory.BeanCreationExceptio
> n: Error creating bean with name 
> 'org.springframework.context.event.internalEventListenerProcessor': 
> BeanPostProcessor before instantiation of bean failed; nested exception is or
> g.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionAdvisor' defined in URL 
> [jar:[file:/data/apache-atlas/apache-atlas-s|file:///data/apache-atlas/apache-atlas-s]
> ources-1.0.0/distro/target/apache-atlas-1.0.0-bin/apache-atlas-1.0.0/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0.jar!/org/apache/atlas/GraphTransactionAdvisor.class]:
> Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with n
> ame 'graphTransactionInterceptor' defined in URL 
> [jar:[file:/data/apache-atlas/apache-atlas-sources-1.0.0/distro/target/apache-atlas-1.0.0-bin/apache-atlas-1.0.0/server/webapp/atl|file:///data/apache-atlas/apache-atlas-sources-1.0.0/distro/target/apache-atlas-1.0.0-bin/apache-atlas-1.0.0/server/webapp/atl]
> as/WEB-INF/lib/atlas-repository-1.0.0.jar!/org/apache/atlas/GraphTransactionInterceptor.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception
> is org.springframework.beans.factory.BeanCreationException: Error creating 
> bean with name 'get' defined in 
> org.apache.atlas.repository.graph.AtlasGraphProvider: Bean instantiati
> on via factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.atlas.repository.graphdb.AtlasGraph]: Fa
> ctory method 'get' threw exception; nested exception is 
> java.lang.IllegalArgumentException: Could not instantiate implementation: 
> org.janusgraph.diskstorage.cassandra.astyanax.As
> tyanaxStoreManager (AbstractApplicationContext:551)
> 2018-06-11 11:54:23,402 ERROR - [main:] ~ Context initialization failed 
> (ContextLoader:350)
> org.springframework.beans.factory.BeanCreationException: Error creating bean 
> with name 'org.springframework.context.event.internalEventListenerProcessor': 
> BeanPostProcessor befor
> e instantiation of bean failed; nested exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionAdvisor' defi
> ned in URL 
> [jar:[file:/data/apache-atlas/apache-atlas-sources-1.0.0/distro/target/apache-atlas-1.0.0-bin/apache-atlas-1.0.0/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0|file:///data/apache-atlas/apache-atlas-sources-1.0.0/distro/target/apache-atlas-1.0.0-bin/apache-atlas-1.0.0/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0].
> jar!/org/apache/atlas/GraphTransactionAdvisor.class]: Unsatisfied dependency 
> expressed through constructor parameter 0; nested exception is 
> org.springframework.beans.factory.Unsa
> tisfiedDependencyException: Error creating bean with name 
> 'graphTransactionInterceptor' defined in URL 
> [jar:[file:/data/apache-atlas/apache-atlas-sources-1.0.0/distro/target/apach|file:///data/apache-atlas/apache-atlas-sources-1.0.0/distro/target/apach]
> e-atlas-1.0.0-bin/apache-atlas-1.0.0/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0.jar!/org/apache/atlas/GraphTransactionInterceptor.class]:
>  Unsatisfied dependency expre
> ssed through constructor parameter 0; nested exception is 
> org.springframework.beans.factory.BeanCreationException: Error creating bean 
> with name 'get' defined in org.apache.atlas
> .repository.graph.AtlasGraphProvider: Bean instantiation via factory method 
> failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiat
> e

[jira] [Commented] (ATLAS-2682) Atlas startup fails when configuring External HBase.

[Raymond Lee (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-2682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228730#comment-17228730
 ] 

Raymond Lee commented on ATLAS-2682:


Any resolution to this?   I downloaded the latest master and received the same 
issue.  I'm lost on how to fix it!  I don't have core-site.xml and 
hdfs-site.xml.   I built with hbase and solr prebuilt:

 

{{mvn clean -DskipTests package -Pdist,embedded-hbase-solr}}

> Atlas startup fails when configuring External HBase.
> 
>
> Key: ATLAS-2682
> URL: https://issues.apache.org/jira/browse/ATLAS-2682
> Project: Atlas
>  Issue Type: Bug
>Reporter: Kwangsik Lee
>Priority: Major
>
> Hi, guys. 
> I'm trying to set Atlas with our existing Hbase which is 1.0.0.
> I used Atlas-1.0.0-SNAPSHOT, but I encountered the error message with below 
> settings.
> Can you help me out to figure out what I can fix this issue?
> Thanks.
> {code:java}
> atlas.graph.storage.backend=hbase
> atlas.graph.storage.hbase.table=apache_atlas_janus
> #Hbase
> #For standalone mode , specify localhost
> #for distributed mode, specify zookeeper quorum here
> #atlas.graph.storage.hostname=localhost
> atlas.graph.storage.hostname=server:2181,server:2181,server:2181,server:2181,server:2181
> atlas.graph.storage.hbase.regions-per-server=1
> atlas.graph.storage.lock.wait-time=1
> {code}
> {code:java}
> export HBASE_CONF_DIR=/home/user/hbase/conf
> {code}
> {code:java}
> 2018-05-15 12:29:42,838 ERROR - [main:] ~ Context initialization failed 
> (ContextLoader:350) org.springframework.beans.factory.BeanCreationException: 
> Error creating bean with name 
> 'org.springframework.context.event.internalEventListenerProcessor': 
> BeanPostProcessor before instantiation of bean failed; nested exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionAdvisor' defined in URL 
> [jar:file:/home/suser/apache-atlas-1.0.0-SNAPSHOT/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0-SNAPSHOT.jar!/org/apache/atlas/GraphTransactionAdvisor.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is 
> org.springframework.beans.factory.UnsatisfiedDependencyException: Error 
> creating bean with name 'graphTransactionInterceptor' defined in URL 
> [jar:file:/home/suser/apache-atlas-1.0.0-SNAPSHOT/server/webapp/atlas/WEB-INF/lib/atlas-repository-1.0.0-SNAPSHOT.jar!/org/apache/atlas/GraphTransactionInterceptor.class]:
>  Unsatisfied dependency expressed through constructor parameter 0; nested 
> exception is org.springframework.beans.factory.BeanCreationException: Error 
> creating bean with name 'get' defined in 
> org.apache.atlas.repository.graph.AtlasGraphProvider: Bean instantiation via 
> factory method failed; nested exception is 
> org.springframework.beans.BeanInstantiationException: Failed to instantiate 
> [org.apache.atlas.repository.graphdb.AtlasGraph]: Factory method 'get' threw 
> exception; nested exception is java.lang.IllegalArgumentException: Could not 
> instantiate implementation: 
> org.janusgraph.diskstorage.hbase.HBaseStoreManager at 
> org.springframework.beans.factory.support.AbstractAutowireCapableBeanFactory.createBean(AbstractAutowireCapableBeanFactory.java:479)
>  at 
> org.springframework.beans.factory.support.AbstractBeanFactory$1.getObject(AbstractBeanFactory.java:306)
>  at 
> org.springframework.beans.factory.support.DefaultSingletonBeanRegistry.getSingleton(DefaultSingletonBeanRegistry.java:230)
>  at 
> org.springframework.beans.factory.support.AbstractBeanFactory.doGetBean(AbstractBeanFactory.java:302)
>  at 
> org.springframework.beans.factory.support.AbstractBeanFactory.getBean(AbstractBeanFactory.java:197)
>  at 
> org.springframework.beans.factory.support.DefaultListableBeanFactory.preInstantiateSingletons(DefaultListableBeanFactory.java:761)
>  at 
> org.springframework.context.support.AbstractApplicationContext.finishBeanFactoryInitialization(AbstractApplicationContext.java:866)
>  at 
> org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:542)
>  at 
> org.springframework.web.context.ContextLoader.configureAndRefreshWebApplicationContext(ContextLoader.java:443)
>  at 
> org.springframework.web.context.ContextLoader.initWebApplicationContext(ContextLoader.java:325)
>  at 
> org.springframework.web.context.ContextLoaderListener.contextInitialized(ContextLoaderListener.java:107)
>  at 
> org.apache.atlas.web.setup.KerberosAwareListener.contextInitialized(KerberosAwareListener.java:31)
>  at 
> org.eclipse.jetty.server.handler.ContextHandler.callContextInitialized(ContextHandler.java:843)
>  at 
> org.eclipse.jetty.servlet.ServletContextHandler.callContextInitialized(ServletContextHandler

Re: Review Request 73007: ATLAS-4016 Update authorization - 'admin-audits' for retrieving admin audits

[Sarath Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73007/#review222176
---




authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java
Lines 37 (patched)


consider moving the new enum value 'ADMIN_AUDITS' to the end (after line 
49) to avoid messing with enum ordinal


- Sarath Subramanian


On Nov. 9, 2020, 7:40 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73007/
> ---
> 
> (Updated Nov. 9, 2020, 7:40 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4016
> https://issues.apache.org/jira/browse/ATLAS-4016
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> For Atlas Admin Audits we need to add new privilege - "admin-audits" for 
> authorization
> 
> Similar permission needs to be updated in ranger atlas service-def.
> 
> 
> Diffs
> -
> 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
> 9dbcd32 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> f6a20c0 
> 
> 
> Diff: https://reviews.apache.org/r/73007/diff/1/
> 
> 
> Testing
> ---
> 
> Testing is done on the cluster with Atlas and Ranger services running.
> 
> First, When only Atlas side changes are applied on cluster and then Admin 
> tries to access the Admin Audits, It gets an Authorization error 403. Which 
> is expected.
> 
> Then after applying Ranger side changes on cluster, Admin could successfully 
> access the Admin Audits.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

[jira] [Commented] (ATLAS-4015) Indexes: Add Conditional Re-Indexing Patch

[Ashutosh Mestry (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17228711#comment-17228711
 ] 

Ashutosh Mestry commented on ATLAS-4015:


With the new implementation I am able to process 16M vertices in ~5 hrs. I will 
open RB item for regular review.

> Indexes: Add Conditional Re-Indexing Patch
> --
>
> Key: ATLAS-4015
> URL: https://issues.apache.org/jira/browse/ATLAS-4015
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH.patch
>
>
> *Background*
> Every so often, we encounter cases where the Solr indexes are out of sync 
> with the data stored in the database. The is leads basic search output. 
> Additionally the facet numbers displayed are also incorrect.
> *Solution*
> It may help to make the ReIndex functionality to be made part of one of 
> JAVA_PATCH handlers that can be applied only when end user notices a problem 
> like described above.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4015) Indexes: Add Conditional Re-Indexing Patch

[Ashutosh Mestry (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4015:
---
Attachment: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH.patch

> Indexes: Add Conditional Re-Indexing Patch
> --
>
> Key: ATLAS-4015
> URL: https://issues.apache.org/jira/browse/ATLAS-4015
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH.patch
>
>
> *Background*
> Every so often, we encounter cases where the Solr indexes are out of sync 
> with the data stored in the database. The is leads basic search output. 
> Additionally the facet numbers displayed are also incorrect.
> *Solution*
> It may help to make the ReIndex functionality to be made part of one of 
> JAVA_PATCH handlers that can be applied only when end user notices a problem 
> like described above.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4015) Indexes: Add Conditional Re-Indexing Patch

[Ashutosh Mestry (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4015?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4015:
---
Attachment: (was: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH.patch)

> Indexes: Add Conditional Re-Indexing Patch
> --
>
> Key: ATLAS-4015
> URL: https://issues.apache.org/jira/browse/ATLAS-4015
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4015-Add-Re-indexing-as-JAVA_PATCH.patch
>
>
> *Background*
> Every so often, we encounter cases where the Solr indexes are out of sync 
> with the data stored in the database. The is leads basic search output. 
> Additionally the facet numbers displayed are also incorrect.
> *Solution*
> It may help to make the ReIndex functionality to be made part of one of 
> JAVA_PATCH handlers that can be applied only when end user notices a problem 
> like described above.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

[Mandar Ambawane (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4016:
---
Attachment: ATLAS-4016.patch

> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4016.patch
>
>
>  
>   
>  For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73007: ATLAS-4016 Update authorization - 'admin-audits' for retrieving admin audits

[Mandar Ambawane]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73007/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4016
https://issues.apache.org/jira/browse/ATLAS-4016


Repository: atlas


Description
---

For Atlas Admin Audits we need to add new privilege - "admin-audits" for 
authorization

Similar permission needs to be updated in ranger atlas service-def.


Diffs
-

  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
9dbcd32 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
f6a20c0 


Diff: https://reviews.apache.org/r/73007/diff/1/


Testing
---

Testing is done on the cluster with Atlas and Ranger services running.

First, When only Atlas side changes are applied on cluster and then Admin tries 
to access the Admin Audits, It gets an Authorization error 403. Which is 
expected.

Then after applying Ranger side changes on cluster, Admin could successfully 
access the Admin Audits.


Thanks,

Mandar Ambawane

[jira] [Assigned] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

[Mandar Ambawane (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4016:
--

Assignee: Mandar Ambawane

> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Mandar Ambawane
>Priority: Major
>
>  
>   
>  For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4016:
---
Summary: Update authorization - "admin-audits" for retrieving admin audits  
(was: Update authorization - "admin-audit" for retrieving admin audits)

> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Major
>
>  
>  
> For Atlas Admin Audits we need to add new privilege - "*admin-audit*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

[Nixon Rodrigues (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4016:
---
Description: 
 
  
 For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
authorization

Similar permission needs to be updated in ranger atlas service-def .

  was:
 
 
For Atlas Admin Audits we need to add new privilege - "*admin-audit*"  for 
authorization

Similar permission needs to be updated in ranger atlas service-def .


> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Major
>
>  
>   
>  For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4016) Update authorization - "admin-audit" for retrieving admin audits

[Nixon Rodrigues (Jira)]

Nixon Rodrigues created ATLAS-4016:
--

 Summary: Update authorization - "admin-audit" for retrieving admin 
audits
 Key: ATLAS-4016
 URL: https://issues.apache.org/jira/browse/ATLAS-4016
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


 
 
For Atlas Admin Audits we need to add new privilege - "*admin-audit*"  for 
authorization

Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)