Re: Review Request 73046: ATLAS-4055 Basic search doesn't work if the search text has special characters

2020-11-25 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/#review42
---


Ship it!




Ship It!

- Sarath Subramanian


On Nov. 25, 2020, 10 p.m., Jayendra Parab wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73046/
> ---
> 
> (Updated Nov. 25, 2020, 10 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4055
> https://issues.apache.org/jira/browse/ATLAS-4055
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ] 
> ^ " ~ * ? : \ /), then we need to enclose the search text in double quotes. 
> This change is required in addition to the changes provided in ATLAS-3983
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4 
> 
> 
> Diff: https://reviews.apache.org/r/73046/diff/1/
> 
> 
> Testing
> ---
> 
> - Created entities with all the special characters in the name and qualified 
> name attribute
> - Tried basic search with attributes to search the name and qualified name
> - The search result included the appropriate entity that was matching the 
> search criteria
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>

Re: Review Request 73046: ATLAS-4055 Basic search doesn't work if the search text has special characters

2020-11-25 Thread Jayendra Parab 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/
---

(Updated Nov. 26, 2020, 6 a.m.)


Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
Subramanian.


Summary (updated)
-

ATLAS-4055 Basic search doesn't work if the search text has special characters


Bugs: ATLAS-4055
https://issues.apache.org/jira/browse/ATLAS-4055


Repository: atlas


Description
---

If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ] ^ 
" ~ * ? : \ /), then we need to enclose the search text in double quotes. This 
change is required in addition to the changes provided in ATLAS-3983


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4 


Diff: https://reviews.apache.org/r/73046/diff/1/


Testing
---

- Created entities with all the special characters in the name and qualified 
name attribute
- Tried basic search with attributes to search the name and qualified name
- The search result included the appropriate entity that was matching the 
search criteria


Thanks,

Jayendra Parab

[jira] [Updated] (ATLAS-4055) Basic search doesn't work if the search text has special characters

2020-11-25 Thread Jayendra Parab (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4055?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jayendra Parab updated ATLAS-4055:
--
Summary: Basic search doesn't work if the search text has special 
characters  (was: Basic search doesn't work if the basic search with attributes 
text has special characters)

> Basic search doesn't work if the search text has special characters
> ---
>
> Key: ATLAS-4055
> URL: https://issues.apache.org/jira/browse/ATLAS-4055
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Jayendra Parab
>Assignee: Jayendra Parab
>Priority: Major
>
> If the user tries to perform a search with text which has special characters 
> mentioned in [Lucene 
> documentation|https://lucene.apache.org/core/6_5_1/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#Escaping_Special_Characters],
>  then the results don't include entities matching the search text, even 
> though the document exists in Solr.
> The special characters are escaped as part of fix provided in ATLAS-3983, but 
> it also needs to be enclosed the search text in double quotes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73046: ATLAS-4055 Basic search doesn't work if the basic search with attributes text has special characters

2020-11-25 Thread Jayendra Parab 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73046/
---

Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath 
Subramanian.


Bugs: ATLAS-4055
https://issues.apache.org/jira/browse/ATLAS-4055


Repository: atlas


Description
---

If the search text has a special character (i.e, one of + - & | ! ( ) { } [ ] ^ 
" ~ * ? : \ /), then we need to enclose the search text in double quotes. This 
change is required in addition to the changes provided in ATLAS-3983


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 28d2e23c4 


Diff: https://reviews.apache.org/r/73046/diff/1/


Testing
---

- Created entities with all the special characters in the name and qualified 
name attribute
- Tried basic search with attributes to search the name and qualified name
- The search result included the appropriate entity that was matching the 
search criteria


Thanks,

Jayendra Parab

[jira] [Created] (ATLAS-4055) Basic search doesn't work if the basic search with attributes text has special characters

2020-11-25 Thread Jayendra Parab (Jira) 
Jayendra Parab created ATLAS-4055:
-

 Summary: Basic search doesn't work if the basic search with 
attributes text has special characters
 Key: ATLAS-4055
 URL: https://issues.apache.org/jira/browse/ATLAS-4055
 Project: Atlas
  Issue Type: Bug
Affects Versions: 2.1.0
Reporter: Jayendra Parab
Assignee: Jayendra Parab


If the user tries to perform a search with text which has special characters 
mentioned in [Lucene 
documentation|https://lucene.apache.org/core/6_5_1/queryparser/org/apache/lucene/queryparser/classic/package-summary.html#Escaping_Special_Characters],
 then the results don't include entities matching the search text, even though 
the document exists in Solr.

The special characters are escaped as part of fix provided in ATLAS-3983, but 
it also needs to be enclosed the search text in double quotes



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (ATLAS-3032) Importing an entity with tag attribute of type float data type fails with an BigDecimal Exception

2020-11-25 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-3032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry resolved ATLAS-3032.

Resolution: Fixed

Fixed by: https://issues.apache.org/jira/browse/ATLAS-1876

> Importing an entity with tag attribute of type float data type fails with an 
> BigDecimal Exception
> -
>
> Key: ATLAS-3032
> URL: https://issues.apache.org/jira/browse/ATLAS-3032
> Project: Atlas
>  Issue Type: Bug
>Reporter: Kapildeo Nayak
>Assignee: Ashutosh Mestry
>Priority: Critical
> Attachments: ATLAS-3032.patch
>
>
> # In source cluster , created a tag with float attribute.
>  2. Created an hive_db and associated the tag to the hive_db with value 
> "-3.4028235E+38"
>  3. On importing the exported hive_db entity, exception is seen and import 
> fails.
> Following stack trace is generated:
> {code:java}
> org.apache.atlas.repository.graphdb.AtlasSchemaViolationException: 
> com.thinkaurelius.titan.core.SchemaViolationException: Value [-3.4028235E+38] 
> is not an instance of the expected data type for property key 
> [tag_float.float] and cannot be converted. Expected: class java.lang.Float, 
> found: class java.math.BigDecimal{code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4054) Change Atlas config for atlas.jetty.request.buffer.size

2020-11-25 Thread chaitali borole (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4054:
---
Fix Version/s: 0.8.4

> Change Atlas config for atlas.jetty.request.buffer.size 
> 
>
> Key: ATLAS-4054
> URL: https://issues.apache.org/jira/browse/ATLAS-4054
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 0.8.4
>
>
> ATLAS-1081 seems to be implemented based on Jetty version 9.x with 
> HttpConfiguration. Jetty was upgraded to 9.2.12.v20150709 prior to this jira, 
> but due to some issues with the jetty version, it was reverted back to jetty 
> 8.1.19.v20160209, but code changes to set header size were incorrect,
> connector.setResponseBufferSize(bufferSize);
> connector.setRequestBufferSize(bufferSize);



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4054) Change Atlas config for atlas.jetty.request.buffer.size

2020-11-25 Thread chaitali borole (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4054:
---
Affects Version/s: 0.8.4

> Change Atlas config for atlas.jetty.request.buffer.size 
> 
>
> Key: ATLAS-4054
> URL: https://issues.apache.org/jira/browse/ATLAS-4054
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.8.4
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> ATLAS-1081 seems to be implemented based on Jetty version 9.x with 
> HttpConfiguration. Jetty was upgraded to 9.2.12.v20150709 prior to this jira, 
> but due to some issues with the jetty version, it was reverted back to jetty 
> 8.1.19.v20160209, but code changes to set header size were incorrect,
> connector.setResponseBufferSize(bufferSize);
> connector.setRequestBufferSize(bufferSize);



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4054) Change Atlas config atlas.jetty.request.buffer.size

2020-11-25 Thread chaitali borole (Jira) 
chaitali borole created ATLAS-4054:
--

 Summary: Change Atlas config atlas.jetty.request.buffer.size 
 Key: ATLAS-4054
 URL: https://issues.apache.org/jira/browse/ATLAS-4054
 Project: Atlas
  Issue Type: Improvement
Reporter: chaitali borole
Assignee: chaitali borole


ATLAS-1081 seems to be implemented based on Jetty version 9.x with 
HttpConfiguration. Jetty was upgraded to 9.2.12.v20150709 prior to this jira, 
but due to some issues with the jetty version, it was reverted back to jetty 
8.1.19.v20160209, but code changes to set header size were incorrect,

connector.setResponseBufferSize(bufferSize);
connector.setRequestBufferSize(bufferSize);



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4054) Change Atlas config for atlas.jetty.request.buffer.size

2020-11-25 Thread chaitali borole (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4054?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4054:
---
Summary: Change Atlas config for atlas.jetty.request.buffer.size   (was: 
Change Atlas config atlas.jetty.request.buffer.size )

> Change Atlas config for atlas.jetty.request.buffer.size 
> 
>
> Key: ATLAS-4054
> URL: https://issues.apache.org/jira/browse/ATLAS-4054
> Project: Atlas
>  Issue Type: Improvement
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> ATLAS-1081 seems to be implemented based on Jetty version 9.x with 
> HttpConfiguration. Jetty was upgraded to 9.2.12.v20150709 prior to this jira, 
> but due to some issues with the jetty version, it was reverted back to jetty 
> 8.1.19.v20160209, but code changes to set header size were incorrect,
> connector.setResponseBufferSize(bufferSize);
> connector.setRequestBufferSize(bufferSize);



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73030: ATLAS-4034: Export operation audit with result count 0 for empty exports is inconsistent ATLAS-4041: operation status info of IMPORT/EXPORT operation in the Admin import/expo

2020-11-25 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73030/#review37
---


Ship it!




Ship It!

- Nixon Rodrigues


On Nov. 20, 2020, 2:22 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73030/
> ---
> 
> (Updated Nov. 20, 2020, 2:22 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4034 and ATLAS-4041
> https://issues.apache.org/jira/browse/ATLAS-4034
> https://issues.apache.org/jira/browse/ATLAS-4041
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles 2 jiras.
> 
> 1. ATLAS-4034 Where if there is no data provided in the export json to 
> export, Atlas does not create any Audit entry for the Export operation
> 
> 2. ATLAS-4041 Where OperationStatus of Import/Export operations is provided 
> in the Audit entry.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 4db477e 
> 
> 
> Diff: https://reviews.apache.org/r/73030/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing Done
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>