[jira] [Commented] (ATLAS-4122) Advanced Search: Fix for within clause with Double Quote Values

2021-02-02 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277693#comment-17277693
 ] 

ASF subversion and git services commented on ATLAS-4122:


Commit 857ffa2df5d08b5c336ff641fa5c10b9e589be70 in atlas's branch 
refs/heads/branch-2.0 from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=857ffa2 ]

ATLAS-4122: Advanced Search: Literals with double-quotes.


> Advanced Search: Fix for within clause with Double Quote Values
> ---
>
> Key: ATLAS-4122
> URL: https://issues.apache.org/jira/browse/ATLAS-4122
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk, 2.1.0
>
> Attachments: 
> ATLAS-4122-Advanced-Search-Literals-with-double-quot.patch
>
>
> *Steps to Duplicate*
>  # In 'Advance Search' fire a query: _hive_db where name = ["Sales", 
> "Reporting"]_
> _Expected results:_ With appropriate data being present, the query should 
> return the correct results.
> _Actual results:_ Query is not recognized as valid query and no results are 
> returned.
> Root cause: The change is attributed to the implementation of ATLAS-2932, 
> where script execution was replaced with traversal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4122) Advanced Search: Fix for within clause with Double Quote Values

2021-02-02 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277687#comment-17277687
 ] 

ASF subversion and git services commented on ATLAS-4122:


Commit efcc31e8dcd5038eaa964386c3e123fb90f1b28b in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=efcc31e ]

ATLAS-4122: Advanced Search: Literals with double-quotes.


> Advanced Search: Fix for within clause with Double Quote Values
> ---
>
> Key: ATLAS-4122
> URL: https://issues.apache.org/jira/browse/ATLAS-4122
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk, 2.1.0
>
> Attachments: 
> ATLAS-4122-Advanced-Search-Literals-with-double-quot.patch
>
>
> *Steps to Duplicate*
>  # In 'Advance Search' fire a query: _hive_db where name = ["Sales", 
> "Reporting"]_
> _Expected results:_ With appropriate data being present, the query should 
> return the correct results.
> _Actual results:_ Query is not recognized as valid query and no results are 
> returned.
> Root cause: The change is attributed to the implementation of ATLAS-2932, 
> where script execution was replaced with traversal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Review Request 73169: ATLAS-4123: Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-02 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73169/
---

Review request for atlas, Ashutosh Mestry, Deep Singh, Madhan Neethiraj, 
Radhika Kundam, and Sarath Subramanian.


Bugs: ATLAS-4123
https://issues.apache.org/jira/browse/ATLAS-4123


Repository: atlas


Description
---

ATLAS-4123: Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive


Diffs
-

  addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
e48967d63 


Diff: https://reviews.apache.org/r/73169/diff/1/


Testing
---

Atlas hook topic message from the hive hook before fix:
===

{
"version": {
"version": "1.0.0",
"versionParts": [
1
]
},
"msgCompressionKind": "NONE",
"msgSplitIdx": 1,
"msgSplitCount": 1,
"msgSourceIP": "172.27.10.2",
"msgCreatedBy": "hive",
"msgCreationTime": 1612311707304,
"message": {
"type": "ENTITY_CREATE_V2",
"user": "hive",
"entities": {
"referredEntities": {
"-73285185733726514": {
"typeName": "hive_storagedesc",
"attributes": {
"qualifiedName": "default.test_mv_ctas_2@cm_storage",
"storedAsSubDirectories": false,
"location": 
"hdfs://sarath-secure-2.sarath-secure.root.hwx.site:8020/warehouse/tablespace/managed/hive/test_mv_ctas_2",
"compressed": false,
"inputFormat": 
"org.apache.hadoop.hive.ql.io.orc.OrcInputFormat",
"parameters": {},
"outputFormat": 
"org.apache.hadoop.hive.ql.io.orc.OrcOutputFormat",
"serdeInfo": {
"typeName": "hive_serde",
"attributes": {
"serializationLib": 
"org.apache.hadoop.hive.ql.io.orc.OrcSerde",
"name": null,
"parameters": {}
}
},
"numBuckets": -1
},
"guid": "-73285185733726514",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"table": {
"guid": "-73285185733726513",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_mv_ctas_2@cm"
},
"relationshipType": "hive_table_storagedesc"
}
},
"proxy": false
},
"-73285185733726515": {
"typeName": "hive_column",
"attributes": {
"owner": "admin",
"qualifiedName": "default.test_mv_ctas_2.id@cm",
"name": "id",
"comment": null,
"position": 0,
"type": "int"
},
"guid": "-73285185733726515",
"isIncomplete": false,
"provenanceType": 0,
"version": 0,
"relationshipAttributes": {
"table": {
"guid": "-73285185733726513",
"typeName": "hive_table",
"uniqueAttributes": {
"qualifiedName": "default.test_mv_ctas_2@cm"
},
"relationshipType": "hive_table_columns"
}
},
"proxy": false
}
},
"entities": [
{
"typeName": "hive_table",
"attributes": {
"owner": "admin",
"viewExpandedText": "select `test_1`.`id` from 
`default`.`test_1`",
"tableType": "MATERIALIZED_VIEW",
"temporary": false,
"lastAccessTime": 1612311707000,
"createTime": 1612311707000,
"qualifiedName": "default.test_mv_ctas_2@cm",
"name": "test_mv_ctas_2",
"comment": null,
"parameters": {
"transient_lastDdlTime": "1612311707",
"bucketing_version": "2",

[jira] [Created] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-02 Thread Sidharth Kumar Mishra (Jira) 
Sidharth Kumar Mishra created ATLAS-4123:


 Summary: Lineage missing in case of CREATE MATERIALIZED VIEW query 
at Hive
 Key: ATLAS-4123
 URL: https://issues.apache.org/jira/browse/ATLAS-4123
 Project: Atlas
  Issue Type: Bug
Reporter: Sidharth Kumar Mishra


Issue:

At hive run the below queries:

create table test_1 (id integer);
CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;

Expected behaviour:

At Atlas we should have the lineage created between hive_table entity test_1 
and test_mv_ctas_1

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-4123) Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive

2021-02-02 Thread Sidharth Kumar Mishra (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sidharth Kumar Mishra reassigned ATLAS-4123:


Assignee: Sidharth Kumar Mishra

> Lineage missing in case of CREATE MATERIALIZED VIEW query at Hive
> -
>
> Key: ATLAS-4123
> URL: https://issues.apache.org/jira/browse/ATLAS-4123
> Project: Atlas
>  Issue Type: Bug
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>
> Issue:
> At hive run the below queries:
> create table test_1 (id integer);
> CREATE MATERIALIZED VIEW test_mv_ctas_1 as select * from test_1;
> Expected behaviour:
> At Atlas we should have the lineage created between hive_table entity test_1 
> and test_mv_ctas_1
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4122) Advanced Search: Fix for within clause with Double Quote Values

2021-02-02 Thread Deep Singh (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277527#comment-17277527
 ] 

Deep Singh commented on ATLAS-4122:
---

+1 for the patch.

> Advanced Search: Fix for within clause with Double Quote Values
> ---
>
> Key: ATLAS-4122
> URL: https://issues.apache.org/jira/browse/ATLAS-4122
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk, 2.1.0
>
> Attachments: 
> ATLAS-4122-Advanced-Search-Literals-with-double-quot.patch
>
>
> *Steps to Duplicate*
>  # In 'Advance Search' fire a query: _hive_db where name = ["Sales", 
> "Reporting"]_
> _Expected results:_ With appropriate data being present, the query should 
> return the correct results.
> _Actual results:_ Query is not recognized as valid query and no results are 
> returned.
> Root cause: The change is attributed to the implementation of ATLAS-2932, 
> where script execution was replaced with traversal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4122) Advanced Search: Fix for within clause with Double Quote Values

2021-02-02 Thread Sarath Subramanian (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277521#comment-17277521
 ] 

Sarath Subramanian commented on ATLAS-4122:
---

thanks for the patch. Looks good. +1

> Advanced Search: Fix for within clause with Double Quote Values
> ---
>
> Key: ATLAS-4122
> URL: https://issues.apache.org/jira/browse/ATLAS-4122
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk, 2.1.0
>
> Attachments: 
> ATLAS-4122-Advanced-Search-Literals-with-double-quot.patch
>
>
> *Steps to Duplicate*
>  # In 'Advance Search' fire a query: _hive_db where name = ["Sales", 
> "Reporting"]_
> _Expected results:_ With appropriate data being present, the query should 
> return the correct results.
> _Actual results:_ Query is not recognized as valid query and no results are 
> returned.
> Root cause: The change is attributed to the implementation of ATLAS-2932, 
> where script execution was replaced with traversal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4122) Advanced Search: Fix for within clause with Double Quote Values

2021-02-02 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4122:
---
Attachment: ATLAS-4122-Advanced-Search-Literals-with-double-quot.patch

> Advanced Search: Fix for within clause with Double Quote Values
> ---
>
> Key: ATLAS-4122
> URL: https://issues.apache.org/jira/browse/ATLAS-4122
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk, 2.1.0
>
> Attachments: 
> ATLAS-4122-Advanced-Search-Literals-with-double-quot.patch
>
>
> *Steps to Duplicate*
>  # In 'Advance Search' fire a query: _hive_db where name = ["Sales", 
> "Reporting"]_
> _Expected results:_ With appropriate data being present, the query should 
> return the correct results.
> _Actual results:_ Query is not recognized as valid query and no results are 
> returned.
> Root cause: The change is attributed to the implementation of ATLAS-2932, 
> where script execution was replaced with traversal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4122) Advanced Search: Fix for within clause with Double Quote Values

2021-02-02 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4122:
---
  Component/s:  atlas-core
Fix Version/s: 2.1.0
   trunk
Affects Version/s: trunk
   2.1.0

> Advanced Search: Fix for within clause with Double Quote Values
> ---
>
> Key: ATLAS-4122
> URL: https://issues.apache.org/jira/browse/ATLAS-4122
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk, 2.1.0
>
>
> *Steps to Duplicate*
>  # In 'Advance Search' fire a query: _hive_db where name = ["Sales", 
> "Reporting"]_
> _Expected results:_ With appropriate data being present, the query should 
> return the correct results.
> _Actual results:_ Query is not recognized as valid query and no results are 
> returned.
> Root cause: The change is attributed to the implementation of ATLAS-2932, 
> where script execution was replaced with traversal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4122) Advanced Search: Fix for within clause with Double Quote Values

2021-02-02 Thread Ashutosh Mestry (Jira) 
Ashutosh Mestry created ATLAS-4122:
--

 Summary: Advanced Search: Fix for within clause with Double Quote 
Values
 Key: ATLAS-4122
 URL: https://issues.apache.org/jira/browse/ATLAS-4122
 Project: Atlas
  Issue Type: Bug
Reporter: Ashutosh Mestry
Assignee: Ashutosh Mestry


*Steps to Duplicate*
 # In 'Advance Search' fire a query: _hive_db where name = ["Sales", 
"Reporting"]_

_Expected results:_ With appropriate data being present, the query should 
return the correct results.

_Actual results:_ Query is not recognized as valid query and no results are 
returned.

Root cause: The change is attributed to the implementation of ATLAS-2932, where 
script execution was replaced with traversal.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4121) Import Service: Improve Speed of Ingest for replicatedTo Option

2021-02-02 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4121:
---
Attachment: (was: ATLAS-4121-Concurrent-Import.patch)

> Import Service: Improve Speed of Ingest for replicatedTo Option
> ---
>
> Key: ATLAS-4121
> URL: https://issues.apache.org/jira/browse/ATLAS-4121
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-4121-Concurrent-Import.patch
>
>
> *Background*
> For Import replication options that includes _skipLineage_ and 
> _replicatedTo_, __ current implementation uses one entity-at-time import 
> approach.
> This approach can be end up taking long time to import for large payloads.
> *Solution*
>  * Use an approach that allows for entity of a type to be concurrently 
> created. 
>  * This assumes that the incoming stream of entities to be imported is 
> topologically sorted (where parent entities appear before the child entities).
>  * Create entities of a type.
>  * Once all entities of a type are created, fetch next type.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4121) Import Service: Improve Speed of Ingest for replicatedTo Option

2021-02-02 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4121?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry updated ATLAS-4121:
---
Attachment: ATLAS-4121-Concurrent-Import.patch

> Import Service: Improve Speed of Ingest for replicatedTo Option
> ---
>
> Key: ATLAS-4121
> URL: https://issues.apache.org/jira/browse/ATLAS-4121
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: ATLAS-4121-Concurrent-Import.patch
>
>
> *Background*
> For Import replication options that includes _skipLineage_ and 
> _replicatedTo_, __ current implementation uses one entity-at-time import 
> approach.
> This approach can be end up taking long time to import for large payloads.
> *Solution*
>  * Use an approach that allows for entity of a type to be concurrently 
> created. 
>  * This assumes that the incoming stream of entities to be imported is 
> topologically sorted (where parent entities appear before the child entities).
>  * Create entities of a type.
>  * Once all entities of a type are created, fetch next type.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73160: ATLAS-4112 : Basic Search : Incorrect results when searching with value having special char and contains/beginsWith/endsWith operator

2021-02-02 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73160/#review222539
---




repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java
Line 461 (original), 462 (patched)


consider refactoring this method for better readability:

private boolean isIndexSearchable(FilterCriteria filterCriteria, 
AtlasStructType structType) throws AtlasBaseException {
String  attributeName  = filterCriteria.getAttributeName();
String  attributeValue = filterCriteria.getAttributeValue();
AtlasType   attributeType  = 
structType.getAttributeType(attributeName);
String  typeName   = attributeType.getTypeName();
String  qualifiedName  = 
structType.getVertexPropertyName(attributeName);
Set indexedKeys= context.getIndexedKeys();
boolean ret= indexedKeys != null && 
indexedKeys.contains(qualifiedName);

SearchParameters.Operator  operator  = 
filterCriteria.getOperator();
AtlasStructDef.AtlasAttributeDef.IndexType indexType = 
structType.getAttributeDef(attributeName).getIndexType();

if (ret) { // index exists
// for string type attributes, don't use index query in the 
following cases:
//   - operation is NEQ, as it might return fewer entries due 
to tokenization of vertex property value
//   - value-to-compare has special characters
if (AtlasBaseTypeDef.ATLAS_TYPE_STRING.equals(typeName)) {
if (operator == SearchParameters.Operator.NEQ || operator 
== SearchParameters.Operator.NOT_CONTAINS) {
if (LOG.isDebugEnabled()) {
LOG.debug("{} operator found for string attribute 
{}, deferring to in-memory or graph query (might cause poor performance)", 
operator, qualifiedName);
}

ret = false;
} else if (operator == SearchParameters.Operator.CONTAINS 
&& AtlasAttribute.hastokenizeChar(attributeValue) && indexType == null) {
if (LOG.isDebugEnabled()) {
LOG.debug("{} operator found for string (TEXT) 
attribute {} and special characters found in filter value {}, deferring to 
in-memory or graph query (might cause poor performance)", attributeValue);
}

ret = false;
}
}
}

if (LOG.isDebugEnabled()) {
if (!ret) {
LOG.debug("Not using index query for: attribute='{}', 
operator='{}', value='{}'", qualifiedName, operator, attributeValue);
}
}

return ret;
}



repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
Lines 32 (patched)


nit: review/remove unused imports


- Sarath Subramanian


On Jan. 27, 2021, 8:56 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73160/
> ---
> 
> (Updated Jan. 27, 2021, 8:56 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4112
> https://issues.apache.org/jira/browse/ATLAS-4112
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Problem:** While searching with wildcard search i.e contains, beginsWith, 
> endsWith operator, which has escape characters in search attribute value 
> gives incorrect results
> 
> **Example:** While searching qualifiedName beginsWith 
> "default.datagen_table_sensitive_725_1."
> 
> **Solution:** Remove quotes and wildcard '*' from query
> 
> **Steps to reproduce:**
> 1. Create a hive_table with name ends with a digit: 
> datagen_table_sensitive_725_1
> 2. Search By Type: hive_columns and select attribute filter: qualifiedName as 
> "default.datagen_table_sensitive_725_1." shows no Records found but if 
> qualifiedName is changed to "default.datagen_table_sensitive_725_1" it shows 
> results with qualifiedName of column 
> "default.datagen_table_sensitive_725_1.col1@cm"
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 050980994 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 01daf53d2 
>   
> repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
>  0da60d37f 
> 
> 
> Diff: https://reviews.apache.org/r/73160/diff/2/
> 
> 
> Testing
> ---
>

[jira] [Updated] (ATLAS-4052) Upgrade elasticsearch version

2021-02-02 Thread Sarath Subramanian (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4052:
--
Affects Version/s: (was: 3.0.0)
   2.1.0

> Upgrade elasticsearch version
> -
>
> Key: ATLAS-4052
> URL: https://issues.apache.org/jira/browse/ATLAS-4052
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> Currently Atlas is pulling in elasticsearch-rest-client 6.6.0 which is really 
> old.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4052) Upgrade elasticsearch version

2021-02-02 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277444#comment-17277444
 ] 

ASF subversion and git services commented on ATLAS-4052:


Commit fb28e8318815e24f1c9c8e48021cea982e32a658 in atlas's branch 
refs/heads/branch-2.0 from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=fb28e83 ]

ATLAS-4052: Upgrade elasticsearch version to 6.8.3

Signed-off-by: Sarath Subramanian 
(cherry picked from commit f0bab76e8ec18ccbdf98c1d2fa8cc765ffb346e7)


> Upgrade elasticsearch version
> -
>
> Key: ATLAS-4052
> URL: https://issues.apache.org/jira/browse/ATLAS-4052
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> Currently Atlas is pulling in elasticsearch-rest-client 6.6.0 which is really 
> old.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4052) Upgrade elasticsearch version

2021-02-02 Thread Sarath Subramanian (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4052:
--
Fix Version/s: 2.2.0

> Upgrade elasticsearch version
> -
>
> Key: ATLAS-4052
> URL: https://issues.apache.org/jira/browse/ATLAS-4052
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently Atlas is pulling in elasticsearch-rest-client 6.6.0 which is really 
> old.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4052) Upgrade elasticsearch version

2021-02-02 Thread Sarath Subramanian (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4052:
--
Component/s:  atlas-core

> Upgrade elasticsearch version
> -
>
> Key: ATLAS-4052
> URL: https://issues.apache.org/jira/browse/ATLAS-4052
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently Atlas is pulling in elasticsearch-rest-client 6.6.0 which is really 
> old.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4052) Upgrade elasticsearch version

2021-02-02 Thread ASF subversion and git services (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277443#comment-17277443
 ] 

ASF subversion and git services commented on ATLAS-4052:


Commit f0bab76e8ec18ccbdf98c1d2fa8cc765ffb346e7 in atlas's branch 
refs/heads/master from chaitali borole
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=f0bab76 ]

ATLAS-4052: Upgrade elasticsearch version to 6.8.3

Signed-off-by: Sarath Subramanian 


> Upgrade elasticsearch version
> -
>
> Key: ATLAS-4052
> URL: https://issues.apache.org/jira/browse/ATLAS-4052
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> Currently Atlas is pulling in elasticsearch-rest-client 6.6.0 which is really 
> old.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4116) UI should not allow the user to create a glossary with blank(" ") name

2021-02-02 Thread Prasad P. Pawar (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277187#comment-17277187
 ] 

Prasad P. Pawar commented on ATLAS-4116:


thanks [~kevalbhatt] for review comments,
There was one case in the edit glossary, where this button was getting enable 
on the change of not required input field, if the required field is empty.
so to check all the inputs required field, a Filter is used.
I have bind the *keyup* on *modal-body*, and the changes are made in the update 
patch.

> UI should not allow the user to create a glossary with blank(" ") name
> --
>
> Key: ATLAS-4116
> URL: https://issues.apache.org/jira/browse/ATLAS-4116
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4116-UI-UI-should-not-allow-the-user-to-create.patch, 
> 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch, 
> 0001-Atlas-4166-UI-V2-UI-should-not-allow-the-user-to-cre.patch, 
> Atlas-4116Fix.png
>
>
> When just space is input the "Create" button is not enabled, but when the 
> space is selected, then the "Create" button is enabled and User is allowed to 
> click on "*Create*".
> This results in un-necessary failures
> *
> {"errorCode":"ATLAS-400-00-079","errorMessage":"Attributes qualifiedName and 
> name are missing. Failed to derive a unique name for Glossary"}
> *
> It is better to not allow clicking on "Create" for such an input via UI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4116) UI should not allow the user to create a glossary with blank(" ") name

2021-02-02 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4116:
---
Attachment: 0001-Atlas-4166-UI-V2-UI-should-not-allow-the-user-to-cre.patch

> UI should not allow the user to create a glossary with blank(" ") name
> --
>
> Key: ATLAS-4116
> URL: https://issues.apache.org/jira/browse/ATLAS-4116
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4116-UI-UI-should-not-allow-the-user-to-create.patch, 
> 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch, 
> 0001-Atlas-4166-UI-V2-UI-should-not-allow-the-user-to-cre.patch, 
> Atlas-4116Fix.png
>
>
> When just space is input the "Create" button is not enabled, but when the 
> space is selected, then the "Create" button is enabled and User is allowed to 
> click on "*Create*".
> This results in un-necessary failures
> *
> {"errorCode":"ATLAS-400-00-079","errorMessage":"Attributes qualifiedName and 
> name are missing. Failed to derive a unique name for Glossary"}
> *
> It is better to not allow clicking on "Create" for such an input via UI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4116) UI should not allow the user to create a glossary with blank(" ") name

2021-02-02 Thread Keval Bhatt (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17277131#comment-17277131
 ] 

Keval Bhatt commented on ATLAS-4116:


Thanks [~prasadpp13] for the updated patch 
[^0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch]. 

Few review comments, do we need filter inside the binding event?

what if we only bind the *keyup* and with *modal-body input* so that "this" 
will point to input directly.

and the below call is the global pointer better to avoid it when we are 
creating a common listener.
{code:java}
$(".modal-footer").find('button.ok').removeAttr("disabled");
{code}
Example:
{code:java}
$('body').on('keyup', '.modal-body input', function (e) {
var $this = $(this);
if (this.getAttribute('placeholder') && 
this.getAttribute('placeholder').indexOf('require') >= 0) {
return (this.value.trim() == "");
}
var $footerButton = $this.parent(".modal").find('.modal-footer 
button.ok');
if (requiredInputField.length > 0) {
$footerButton.attr("disabled", "true");
} else {
$footerButton.removeAttr("disabled");   
}
});
{code}

> UI should not allow the user to create a glossary with blank(" ") name
> --
>
> Key: ATLAS-4116
> URL: https://issues.apache.org/jira/browse/ATLAS-4116
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4116-UI-UI-should-not-allow-the-user-to-create.patch, 
> 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch, 
> Atlas-4116Fix.png
>
>
> When just space is input the "Create" button is not enabled, but when the 
> space is selected, then the "Create" button is enabled and User is allowed to 
> click on "*Create*".
> This results in un-necessary failures
> *
> {"errorCode":"ATLAS-400-00-079","errorMessage":"Attributes qualifiedName and 
> name are missing. Failed to derive a unique name for Glossary"}
> *
> It is better to not allow clicking on "Create" for such an input via UI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4116) UI should not allow the user to create a glossary with blank(" ") name

2021-02-02 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar updated ATLAS-4116:
---
Attachment: 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch

> UI should not allow the user to create a glossary with blank(" ") name
> --
>
> Key: ATLAS-4116
> URL: https://issues.apache.org/jira/browse/ATLAS-4116
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4116-UI-UI-should-not-allow-the-user-to-create.patch, 
> 0001-ATLAS-4116-UI-V1-UI-should-not-allow-the-user-to-cre.patch, 
> Atlas-4116Fix.png
>
>
> When just space is input the "Create" button is not enabled, but when the 
> space is selected, then the "Create" button is enabled and User is allowed to 
> click on "*Create*".
> This results in un-necessary failures
> *
> {"errorCode":"ATLAS-400-00-079","errorMessage":"Attributes qualifiedName and 
> name are missing. Failed to derive a unique name for Glossary"}
> *
> It is better to not allow clicking on "Create" for such an input via UI



--
This message was sent by Atlassian Jira
(v8.3.4#803005)