Review Request 73179: ATLAS-4113: Atlas UI: Entity Lineage Details Box layout rendering and centring issue.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73179/ --- Review request for atlas, Jayendra Parab, keval bhatt, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-4113 https://issues.apache.org/jira/browse/ATLAS-4113 Repository: atlas Description --- The lineage layout doesn't seem to be centred on the page, also there is an effect where the lineage appears from top-right. This patch has the following fix: 1) Entity Lineage Detail box layout position fix. 2) White space from Detail box removed. 3) Add option Display full name in the Lineage settings panel. 4) https://issues.apache.org/jira/browse/ATLAS-4074 Diffs - dashboardv2/public/css/scss/graph.scss 19636c5 dashboardv2/public/js/external_lib/atlas-lineage/dist/index.js e82cb48 dashboardv2/public/js/external_lib/atlas-lineage/dist/styles.css 2cd29ed dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html f6f61e2 dashboardv2/public/js/templates/graph/TypeSystemTreeView_tmpl.html 005c061 dashboardv2/public/js/views/graph/LineageLayoutView.js aa26580 dashboardv2/public/js/views/graph/TypeSystemTreeView.js 90734a4 dashboardv3/public/css/scss/graph.scss ee774ce dashboardv3/public/js/external_lib/atlas-lineage/dist/index.js e82cb48 dashboardv3/public/js/external_lib/atlas-lineage/dist/styles.css 2cd29ed dashboardv3/public/js/templates/graph/LineageLayoutView_tmpl.html f6f61e2 dashboardv3/public/js/templates/graph/TypeSystemTreeView_tmpl.html 005c061 dashboardv3/public/js/views/graph/LineageLayoutView.js aa26580 dashboardv3/public/js/views/graph/TypeSystemTreeView.js 90734a4 Diff: https://reviews.apache.org/r/73179/diff/1/ Testing --- Tested Lineage View, Entity details panel layout position change to right, Entity details panel remove white space, Display full name option in lineage setting panel shows label in full name or trunc name, Export image selected node color fix. Thanks, Prasad Pawar
[jira] [Commented] (ATLAS-4113) Atlas UI: Entity Lineage Details Box layout rendering and centring issue.
[ https://issues.apache.org/jira/browse/ATLAS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281570#comment-17281570 ] Nixon Rodrigues commented on ATLAS-4113: +1 for the patch. thank [~prasadpp13] > Atlas UI: Entity Lineage Details Box layout rendering and centring issue. > - > > Key: ATLAS-4113 > URL: https://issues.apache.org/jira/browse/ATLAS-4113 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Nixon Rodrigues >Assignee: Prasad P. Pawar >Priority: Major > Fix For: 3.0.0 > > Attachments: > 0001-Atlas-4113-UI-Entity-Lineage-Details-Box-layout-rend.patch, > Atlas-4113_1.png, Atlas-4113_2.png, entity-detailpage.png > > > The lineage layout doesn't seem to be centred on the page, also there is an > effect where the lineage appears from top-right. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4113) Atlas UI: Entity Lineage Details Box layout rendering and centring issue.
[ https://issues.apache.org/jira/browse/ATLAS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281565#comment-17281565 ] Prasad P. Pawar commented on ATLAS-4113: Hi, This patch has the following fix: 1) Entity Lineage Detail box layout position fix. 2) White space from Detail box removed. 3) Add option Display full name in the Lineage settings panel. 4) https://issues.apache.org/jira/browse/ATLAS-4074 > Atlas UI: Entity Lineage Details Box layout rendering and centring issue. > - > > Key: ATLAS-4113 > URL: https://issues.apache.org/jira/browse/ATLAS-4113 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Nixon Rodrigues >Assignee: Prasad P. Pawar >Priority: Major > Fix For: 3.0.0 > > Attachments: > 0001-Atlas-4113-UI-Entity-Lineage-Details-Box-layout-rend.patch, > Atlas-4113_1.png, Atlas-4113_2.png, entity-detailpage.png > > > The lineage layout doesn't seem to be centred on the page, also there is an > effect where the lineage appears from top-right. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 73166: Clause Change for Glossary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73166/#review222578 --- Ship it! Ship It! - Pinal Shah On Feb. 3, 2021, 9:46 p.m., Ashutosh Mestry wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73166/ > --- > > (Updated Feb. 3, 2021, 9:46 p.m.) > > > Review request for atlas, Nikhil Bonte, Pinal Shah, and Sarath Subramanian. > > > Bugs: ATLAS-4109 > https://issues.apache.org/jira/browse/ATLAS-4109 > > > Repository: atlas > > > Description > --- > > Replaced _or_ with _where_ for simplicity. > > > Diffs > - > > repository/src/main/java/org/apache/atlas/query/GremlinClause.java > b7e5330ce > > repository/src/main/java/org/apache/atlas/query/executors/GremlinClauseToTraversalTranslator.java > 156a65ccb > > repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java > 3594e2f34 > > > Diff: https://reviews.apache.org/r/73166/diff/2/ > > > Testing > --- > > **Unit tests** > - Existing tests run. > - Updated _GremlinQueryComposer_ to include the new clause. > > **PC-build** > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/363/ > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/366/ > > > Thanks, > > Ashutosh Mestry > >
[jira] [Updated] (ATLAS-4113) Atlas UI: Entity Lineage Details Box layout rendering and centring issue.
[ https://issues.apache.org/jira/browse/ATLAS-4113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prasad P. Pawar updated ATLAS-4113: --- Attachment: Atlas-4113_1.png Atlas-4113_2.png > Atlas UI: Entity Lineage Details Box layout rendering and centring issue. > - > > Key: ATLAS-4113 > URL: https://issues.apache.org/jira/browse/ATLAS-4113 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Nixon Rodrigues >Assignee: Prasad P. Pawar >Priority: Major > Fix For: 3.0.0 > > Attachments: > 0001-Atlas-4113-UI-Entity-Lineage-Details-Box-layout-rend.patch, > Atlas-4113_1.png, Atlas-4113_2.png, entity-detailpage.png > > > The lineage layout doesn't seem to be centred on the page, also there is an > effect where the lineage appears from top-right. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4150) UI : __AtlasAuditEntry appearing in metrics window
[ https://issues.apache.org/jira/browse/ATLAS-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Kurup updated ATLAS-4150: --- Description: !Screenshot from 2021-02-09 10-38-46.png|width=584,height=432! As seen in the above screenshot, entries for AtlasAuditEntry are visible. That is an system internal entity and should ideally not be visible in the metrics UI. was: !Screenshot from 2021-02-09 10-38-46.png|width=584,height=432! As seen in the above screenshot, entries for AtlasAuditEntry, AtlasGlossary, AtlasGlossaryTerm and AtlasGlossaryCategory are visible. These are system internal entities and should ideally not be visible in the metrics UI. > UI : __AtlasAuditEntry appearing in metrics window > -- > > Key: ATLAS-4150 > URL: https://issues.apache.org/jira/browse/ATLAS-4150 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Priority: Minor > Attachments: Screenshot from 2021-02-09 10-38-46.png > > > !Screenshot from 2021-02-09 10-38-46.png|width=584,height=432! > As seen in the above screenshot, entries for AtlasAuditEntry are visible. > That is an system internal entity and should ideally not be visible in the > metrics UI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4150) UI : __AtlasAuditEntry appearing in metrics window
[ https://issues.apache.org/jira/browse/ATLAS-4150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rahul Kurup updated ATLAS-4150: --- Summary: UI : __AtlasAuditEntry appearing in metrics window (was: UI : __AtlasAuditEntry, AtlasGlossary and AtlasGlossaryTerm appearing in metrics window) > UI : __AtlasAuditEntry appearing in metrics window > -- > > Key: ATLAS-4150 > URL: https://issues.apache.org/jira/browse/ATLAS-4150 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Priority: Minor > Attachments: Screenshot from 2021-02-09 10-38-46.png > > > !Screenshot from 2021-02-09 10-38-46.png|width=584,height=432! > As seen in the above screenshot, entries for AtlasAuditEntry, AtlasGlossary, > AtlasGlossaryTerm and AtlasGlossaryCategory are visible. These are system > internal entities and should ideally not be visible in the metrics UI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ATLAS-4150) UI : __AtlasAuditEntry, AtlasGlossary and AtlasGlossaryTerm appearing in metrics window
Rahul Kurup created ATLAS-4150: -- Summary: UI : __AtlasAuditEntry, AtlasGlossary and AtlasGlossaryTerm appearing in metrics window Key: ATLAS-4150 URL: https://issues.apache.org/jira/browse/ATLAS-4150 Project: Atlas Issue Type: Bug Reporter: Rahul Kurup Attachments: Screenshot from 2021-02-09 10-38-46.png !Screenshot from 2021-02-09 10-38-46.png|width=584,height=432! As seen in the above screenshot, entries for AtlasAuditEntry, AtlasGlossary, AtlasGlossaryTerm and AtlasGlossaryCategory are visible. These are system internal entities and should ideally not be visible in the metrics UI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ATLAS-4133) [Atlas: Glossary Term Bulk Import] Disable the option to download upload template when category is chosen in glossary page
[ https://issues.apache.org/jira/browse/ATLAS-4133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Prasad P. Pawar reassigned ATLAS-4133: -- Assignee: Prasad P. Pawar > [Atlas: Glossary Term Bulk Import] Disable the option to download upload > template when category is chosen in glossary page > -- > > Key: ATLAS-4133 > URL: https://issues.apache.org/jira/browse/ATLAS-4133 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Reporter: Dharshana M Krishnamoorthy >Assignee: Prasad P. Pawar >Priority: Major > Attachments: Screenshot 2021-02-03 at 5.27.03 PM.png > > > Since we support only bulk import of glossary-terms, it will be good to > disable the option to download and import template in UI > !Screenshot 2021-02-03 at 5.27.03 PM.png|width=389,height=225! -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3725) Are UI pages considering i18n internationalization support?
[ https://issues.apache.org/jira/browse/ATLAS-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281477#comment-17281477 ] catherine commented on ATLAS-3725: -- HI EE, Do you have any updates about : Customer of ([[https://csh.cloudera.com/ccs/index.html#/case/744776/case-details)]] needs to use Chinese characters in Atlas label name. Thanks. Catherine Wang > Are UI pages considering i18n internationalization support? > --- > > Key: ATLAS-3725 > URL: https://issues.apache.org/jira/browse/ATLAS-3725 > Project: Atlas > Issue Type: Improvement > Components: atlas-webui >Affects Versions: 2.0.0 >Reporter: kangjunxiang >Priority: Major > > Are UI pages considering i18n internationalization support? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (ATLAS-4134) [Atlas:Glossary] Update conflict error message for glossary
[
https://issues.apache.org/jira/browse/ATLAS-4134?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chaitali borole reassigned ATLAS-4134:
--
Assignee: chaitali borole
> [Atlas:Glossary] Update conflict error message for glossary
> ---
>
> Key: ATLAS-4134
> URL: https://issues.apache.org/jira/browse/ATLAS-4134
> Project: Atlas
> Issue Type: Improvement
> Components: atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: chaitali borole
>Priority: Major
>
> Currently we display the following error message for conflicts:
> {code:java}
> {
> "errorCode":"ATLAS-409-00-007",
> "errorMessage":"Glossary with qualifiedName abc already exists"
> }
> {code}
> It will be user friendly if the message is "*Glossary with name abc already
> exists*"
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: Review Request 73176: ATLAS-4147 : [Atlas: Glossary Term Bulk Import] When un_supported file type is passed error message displays file type {0}/ATLAS-4148 : [Atlas: Glossary Term Bulk Import] Inc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73176/
---
(Updated Feb. 8, 2021, 5:09 p.m.)
Review request for atlas, Jayendra Parab, Nikhil Bonte, and Nixon Rodrigues.
Summary (updated)
-
ATLAS-4147 : [Atlas: Glossary Term Bulk Import] When un_supported file type is
passed error message displays file type {0}/ATLAS-4148 : [Atlas: Glossary Term
Bulk Import] Incorrect error code displayed when no data found in the uploaded
file/ATLAS-4134 : [Atlas:Glossary] Update conflict error me
Bugs: ATLAS-4147
https://issues.apache.org/jira/browse/ATLAS-4147
Repository: atlas
Description (updated)
---
Pass unsupported file type to the glossary term bulk import
curl --request POST -u user:password
'https:///api/atlas/v2/glossary/import' \
-H 'Accept: application/json' \
-H 'Cache-Control: no-cache' \
-H 'X-Requested-With: XMLHttpRequest' \
-H 'X-XSRF-HEADER: ""' \
-H 'Content-Type: multipart/form-data' \
-F file=@abc.py \
--compressed \
--insecure
Expectation:
Instead of "file type {0}" actual file type should be displayed
Suggestion:
Along with the above message, display the supported file format too
ATLAS-4148:
Steps to repro:
GlossaryName, TermName, ShortDescription, LongDescription, Examples,
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor,
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms,
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
This file is written for testing supported format with incorrect data format.
So this file contains some random text.
When this file is used as an input, the error code displayed is incorrect:
{
"errorCode":"ATLAS-404-00-014",
"errorMessage":"No data found in the uploaded file"
}
Expectation:
Since this is client side error 400 should be displayed
ATLAS-4134:
Currently we display the following error message for conflicts:
{
"errorCode":"ATLAS-409-00-007",
"errorMessage":"Glossary with qualifiedName abc already exists"
}
It will be user friendly if the message is "Glossary with name abc already
exists"
Diffs (updated)
-
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa917
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
82243e20f
repository/src/main/java/org/apache/atlas/util/FileUtils.java 71ac9e309
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
54e00a4bd
Diff: https://reviews.apache.org/r/73176/diff/3/
Changes: https://reviews.apache.org/r/73176/diff/2-3/
Testing
---
When passed above request:
{"errorCode":"ATLAS-400-00-098","errorMessage":"The provided file type:
template_2122.py is not supported expected file formats .csv, .xls."
Thanks,
chaitali
[jira] [Assigned] (ATLAS-4148) [Atlas: Glossary Term Bulk Import] Incorrect error code displayed when no data found in the uploaded file
[
https://issues.apache.org/jira/browse/ATLAS-4148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chaitali borole reassigned ATLAS-4148:
--
Assignee: chaitali borole
> [Atlas: Glossary Term Bulk Import] Incorrect error code displayed when no
> data found in the uploaded file
> -
>
> Key: ATLAS-4148
> URL: https://issues.apache.org/jira/browse/ATLAS-4148
> Project: Atlas
> Issue Type: Bug
> Components: atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: chaitali borole
>Priority: Major
>
> Steps to repro:
> {code:java}
> GlossaryName, TermName, ShortDescription, LongDescription, Examples,
> Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor,
> Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso,
> TranslatedTerms, IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
> This file is written for testing supported format with incorrect data format.
> So this file contains some random text.
> {code}
> When this file is used as an input, the error code displayed is incorrect:
> {code:java}
> {
> "errorCode":"ATLAS-404-00-014",
> "errorMessage":"No data found in the uploaded file"
> }{code}
> Expectation:
> Since this is client side error 400 should be displayed
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Review Request 73177: ATLAS-4148 : [Atlas: Glossary Term Bulk Import] Incorrect error code displayed when no data found in the uploaded file
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73177/
---
Review request for atlas, Jayendra Parab, Nixon Rodrigues, and Sarath
Subramanian.
Bugs: ATLAS-4148
https://issues.apache.org/jira/browse/ATLAS-4148
Repository: atlas
Description
---
This patch fix following bug :
GlossaryName, TermName, ShortDescription, LongDescription, Examples,
Abbreviation, Usage, AdditionalAttributes, TranslationTerms, ValidValuesFor,
Synonyms, ReplacedBy, ValidValues, ReplacementTerms, SeeAlso, TranslatedTerms,
IsA, Antonyms, Classifies, PreferredToTerms, PreferredTerms
This file is written for testing supported format with incorrect data format.
So this file contains some random text.
When this file is used as an input, the error code displayed is incorrect:
{
"errorCode":"ATLAS-404-00-014",
"errorMessage":"No data found in the uploaded file"
}
Expectation:
Since this is client side error 400 should be displayed
Diffs
-
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa917
Diff: https://reviews.apache.org/r/73177/diff/1/
Testing
---
Tested with above format data and expected errorcode was thrown
Thanks,
chaitali
Re: Review Request 73176: ATLAS-4147 : [Atlas: Glossary Term Bulk Import] When un_supported file type is passed error message displays "file type {0}"
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73176/
---
(Updated Feb. 8, 2021, 4:15 p.m.)
Review request for atlas, Jayendra Parab, Nikhil Bonte, and Nixon Rodrigues.
Bugs: ATLAS-4147
https://issues.apache.org/jira/browse/ATLAS-4147
Repository: atlas
Description
---
Pass unsupported file type to the glossary term bulk import
curl --request POST -u user:password
'https:///api/atlas/v2/glossary/import' \
-H 'Accept: application/json' \
-H 'Cache-Control: no-cache' \
-H 'X-Requested-With: XMLHttpRequest' \
-H 'X-XSRF-HEADER: ""' \
-H 'Content-Type: multipart/form-data' \
-F file=@abc.py \
--compressed \
--insecure
Expectation:
Instead of "file type {0}" actual file type should be displayed
Suggestion:
Along with the above message, display the supported file format too
Diffs (updated)
-
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa917
repository/src/main/java/org/apache/atlas/util/FileUtils.java 71ac9e309
repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java
54e00a4bd
repository/src/test/resources/csvFiles/incorrectEXT.py PRE-CREATION
Diff: https://reviews.apache.org/r/73176/diff/2/
Changes: https://reviews.apache.org/r/73176/diff/1-2/
Testing
---
When passed above request:
{"errorCode":"ATLAS-400-00-098","errorMessage":"The provided file type:
template_2122.py is not supported expected file formats .csv, .xls."
Thanks,
chaitali
Re: Review Request 73176: ATLAS-4147 : [Atlas: Glossary Term Bulk Import] When un_supported file type is passed error message displays "file type {0}"
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73176/#review222576
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 8, 2021, 1:38 a.m., chaitali wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73176/
> ---
>
> (Updated Feb. 8, 2021, 1:38 a.m.)
>
>
> Review request for atlas, Jayendra Parab, Nikhil Bonte, and Nixon Rodrigues.
>
>
> Bugs: ATLAS-4147
> https://issues.apache.org/jira/browse/ATLAS-4147
>
>
> Repository: atlas
>
>
> Description
> ---
>
> Pass unsupported file type to the glossary term bulk import
>
> curl --request POST -u user:password
> 'https:///api/atlas/v2/glossary/import' \
> -H 'Accept: application/json' \
> -H 'Cache-Control: no-cache' \
> -H 'X-Requested-With: XMLHttpRequest' \
> -H 'X-XSRF-HEADER: ""' \
> -H 'Content-Type: multipart/form-data' \
> -F file=@abc.py \
> --compressed \
> --insecure
>
> Expectation:
> Instead of "file type {0}" actual file type should be displayed
>
> Suggestion:
>
> Along with the above message, display the supported file format too
>
>
> Diffs
> -
>
> intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa917
> repository/src/main/java/org/apache/atlas/util/FileUtils.java 71ac9e309
>
>
> Diff: https://reviews.apache.org/r/73176/diff/1/
>
>
> Testing
> ---
>
> When passed above request:
> {"errorCode":"ATLAS-400-00-098","errorMessage":"The provided file type:
> template_2122.py is not supported expected file formats .csv, .xls."
>
>
> Thanks,
>
> chaitali
>
>
[jira] [Issue Comment Deleted] (ATLAS-3725) Are UI pages considering i18n internationalization support?
[ https://issues.apache.org/jira/browse/ATLAS-3725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Madhan Neethiraj updated ATLAS-3725: Comment: was deleted (was: HI EE, Customer of ([https://csh.cloudera.com/ccs/index.html#/case/744776/case-details)] needs to use Chinese characters in Atlas label name. Support and BL find the atlas label can not support chinese characters at the moment. So want to confirm with EE that if we have any ways to help customer to achieve this function? Thanks. Catherine Wang ) > Are UI pages considering i18n internationalization support? > --- > > Key: ATLAS-3725 > URL: https://issues.apache.org/jira/browse/ATLAS-3725 > Project: Atlas > Issue Type: Improvement > Components: atlas-webui >Affects Versions: 2.0.0 >Reporter: kangjunxiang >Priority: Major > > Are UI pages considering i18n internationalization support? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4138) While adding Classification to an entity, if user select and deselect the 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with text "Please fil
[ https://issues.apache.org/jira/browse/ATLAS-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17280975#comment-17280975 ] Durga Kadam commented on ATLAS-4138: +1 patch is working fine > While adding Classification to an entity, if user select and deselect the > 'Apply Validity Period' checkbox immediately, it keeps on showing pop-up with > text "Please fill the details" > -- > > Key: ATLAS-4138 > URL: https://issues.apache.org/jira/browse/ATLAS-4138 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Affects Versions: 2.1.0 >Reporter: Durga Kadam >Assignee: Prasad P. Pawar >Priority: Minor > Fix For: 3.0.0, 2.2.0 > > Attachments: > 0001-ATLAS-4138-UI-While-adding-Classification-to-an-enti.patch, > Validation_required_on_Add_button.webm > > > Steps to Reproduce the bugs:: > # Go to any entity detail page > # Click on Add Classification > # Click the checkbox - Add Validity Period (do not add any timestamp) > # Remove/Deselect the checkbox- Add Validity Period > # Click on Add button > Expected:: Classification should get added > Actual:: Keeps on showing the message "Please fill the details" > NOTE:: Until and unless user removes the validity input boxes it keeps on > showing the same message. We need to put a validation on Add button. > PFA evidence files -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4124) Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity
[ https://issues.apache.org/jira/browse/ATLAS-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandar Ambawane updated ATLAS-4124: --- Description: We can delete the entire BusinessMetadata TypeDef using the curl command. But that will affect the entities which already have Business Attributes from this Deleted Business Metadata. Those Business Attributes will be removed from the Entity. This patch will restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity. > Restrict user from deleting Business Metadata, if Business Metadata is > already associated with an entity > > > Key: ATLAS-4124 > URL: https://issues.apache.org/jira/browse/ATLAS-4124 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > Labels: BusinessMetadata > Attachments: ATLAS-4124.patch > > > We can delete the entire BusinessMetadata TypeDef using the curl command. > But that will affect the entities which already have Business Attributes from > this Deleted Business Metadata. > Those Business Attributes will be removed from the Entity. > This patch will restrict user from deleting Business Metadata, if Business > Metadata is already associated with an entity. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4124) Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity
[ https://issues.apache.org/jira/browse/ATLAS-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandar Ambawane updated ATLAS-4124: --- Fix Version/s: 3.0.0 > Restrict user from deleting Business Metadata, if Business Metadata is > already associated with an entity > > > Key: ATLAS-4124 > URL: https://issues.apache.org/jira/browse/ATLAS-4124 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > Labels: BusinessMetadata > Fix For: 3.0.0 > > Attachments: ATLAS-4124.patch > > > We can delete the entire BusinessMetadata TypeDef using the curl command. > But that will affect the entities which already have Business Attributes from > this Deleted Business Metadata. > Those Business Attributes will be removed from the Entity. > This patch will restrict user from deleting Business Metadata, if Business > Metadata is already associated with an entity. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4124) Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity
[ https://issues.apache.org/jira/browse/ATLAS-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandar Ambawane updated ATLAS-4124: --- Labels: BusinessMetadata (was: ) > Restrict user from deleting Business Metadata, if Business Metadata is > already associated with an entity > > > Key: ATLAS-4124 > URL: https://issues.apache.org/jira/browse/ATLAS-4124 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > Labels: BusinessMetadata > Attachments: ATLAS-4124.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4124) Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity
[ https://issues.apache.org/jira/browse/ATLAS-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandar Ambawane updated ATLAS-4124: --- Affects Version/s: 2.1.0 > Restrict user from deleting Business Metadata, if Business Metadata is > already associated with an entity > > > Key: ATLAS-4124 > URL: https://issues.apache.org/jira/browse/ATLAS-4124 > Project: Atlas > Issue Type: Improvement >Affects Versions: 2.1.0 >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > Attachments: ATLAS-4124.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (ATLAS-4124) Restrict user from deleting Business Metadata, if Business Metadata is already associated with an entity
[ https://issues.apache.org/jira/browse/ATLAS-4124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandar Ambawane updated ATLAS-4124: --- Component/s: atlas-core > Restrict user from deleting Business Metadata, if Business Metadata is > already associated with an entity > > > Key: ATLAS-4124 > URL: https://issues.apache.org/jira/browse/ATLAS-4124 > Project: Atlas > Issue Type: Improvement > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Mandar Ambawane >Assignee: Mandar Ambawane >Priority: Major > Attachments: ATLAS-4124.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
Review Request 73176: ATLAS-4147 : [Atlas: Glossary Term Bulk Import] When un_supported file type is passed error message displays "file type {0}"
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73176/
---
Review request for atlas, Jayendra Parab, Nikhil Bonte, and Nixon Rodrigues.
Bugs: ATLAS-4147
https://issues.apache.org/jira/browse/ATLAS-4147
Repository: atlas
Description
---
Pass unsupported file type to the glossary term bulk import
curl --request POST -u user:password
'https:///api/atlas/v2/glossary/import' \
-H 'Accept: application/json' \
-H 'Cache-Control: no-cache' \
-H 'X-Requested-With: XMLHttpRequest' \
-H 'X-XSRF-HEADER: ""' \
-H 'Content-Type: multipart/form-data' \
-F file=@abc.py \
--compressed \
--insecure
Expectation:
Instead of "file type {0}" actual file type should be displayed
Suggestion:
Along with the above message, display the supported file format too
Diffs
-
intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa917
repository/src/main/java/org/apache/atlas/util/FileUtils.java 71ac9e309
Diff: https://reviews.apache.org/r/73176/diff/1/
Testing
---
When passed above request:
{"errorCode":"ATLAS-400-00-098","errorMessage":"The provided file type:
template_2122.py is not supported expected file formats .csv, .xls."
Thanks,
chaitali
[jira] [Assigned] (ATLAS-4147) [Atlas: Glossary Term Bulk Import] When un_supported file type is passed error message displays "file type {0}"
[
https://issues.apache.org/jira/browse/ATLAS-4147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
chaitali borole reassigned ATLAS-4147:
--
Assignee: chaitali borole
> [Atlas: Glossary Term Bulk Import] When un_supported file type is passed
> error message displays "file type {0}"
> ---
>
> Key: ATLAS-4147
> URL: https://issues.apache.org/jira/browse/ATLAS-4147
> Project: Atlas
> Issue Type: Bug
> Components: atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: chaitali borole
>Priority: Major
>
>
> Repro steps:
> Pass unsupported file type to the glossary term bulk import
> {code:java}
> curl --request POST -u user:password
> 'https:///api/atlas/v2/glossary/import' \
> -H 'Accept: application/json' \
> -H 'Cache-Control: no-cache' \
> -H 'X-Requested-With: XMLHttpRequest' \
> -H 'X-XSRF-HEADER: ""' \
> -H 'Content-Type: multipart/form-data' \
> -F file=@abc.py \
> --compressed \
> --insecure{code}
> The following error message is displayed
> {code:java}
> {"errorCode":"ATLAS-400-00-098",
> "errorMessage":"The provided file type {0} is not supported."} {code}
> Expectation:
> Instead of "file type \{0}" actual file type should be displayed
> Suggestion:
> Along with the above message, display the supported file format too
> Example:
> {code:java}
> The provided file type .py is not supported. Supported file formats: .csv,
> .xls{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
