Re: Review Request 73076: Deferred Actions Implementation

[Ashutosh Mestry via Review Board]

> On March 9, 2021, 6:27 a.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/model/tasks/AtlasTask.java
> > Lines 184 (patched)
> > 
> >
> > - getTaskVertex() => getAdditionalInfo()?
> > - @JsonIgnore on additionalInfo: is it not necessary to 
> > serialize/deserialize additionalInfo?

I have removed this field and now using an explicit call to fetch vertex using 
guid.


> On March 9, 2021, 6:27 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/tasks/TaskExecutor.java
> > Lines 152 (patched)
> > 
> >
> > Is this commit() only for changes to task status? Or does this include 
> > entity/classfication updates too? In its later, then wouldn't graph DB 
> > status be incorrect in case of Exception i.e. block at #137?

This is only for task changes.


- Ashutosh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73076/#review222660
---


On March 8, 2021, 6:19 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73076/
> ---
> 
> (Updated March 8, 2021, 6:19 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3919
> https://issues.apache.org/jira/browse/ATLAS-3919
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Approach**
> Model: _TaskDef_
> - Definition of task.
> - Contains status of the task for querying.
> 
> _AbstractTask_
> - Takes TaskDef as input and calls run.
> - The concrete tasks has logic for doing real work.
> 
> _TaskFactory_
> 
> - Creates tasks given task type.
> - Enumerates all the tasks that are supported.
> 
> _TaskManagement_
> 
> - Component/Service. Constructed after all existing components are 
> constructed.
> - Provides a simple interface for adding tasks.
> - Processes tasks that are in pending state.
> - Supports HA mode, where the tasks are not executed on passive instance.
> 
> _TaskManagement.Registry_
> 
> - CRUD operations with TaskDef vertex.
> 
> _TaskManagement.Processor_
> - Provides mechanism for provides single queue for processing tasks in a way 
> that is non-blocking.
> - Uses task type and the associated TaskFactory to construct concrete task.
> 
> Changes to _EntityGraphMapper_
> There are 3 new methods added that use portion of existing classification 
> propagation logic and create a separate method.
> 
> New class _EntityGraphMapperWithTasks_ acts as a proxy for EntityGraphMapper. 
> All calls that operate without tasks get channeled to the existing 
> implementation. The ones involving tasks are modified to use the new task 
> framework.
> 
> **Concurrent Changes to Classifications**
> Via REST APIs and operations from web UI, it is possible to make changes to 
> the same entity. This situation will be more pronounced in the new setup.
> 
> The existing framework has 
> _GraphTransactionInterceptor.lockObjectAndReleasePostCommit_. This provides 
> ReentrantLock on an entity that is identified by the supplied GUID. This will 
> cause a lock on the entity and all the impacted vertices. This has potential 
> for adversely impacting scalability.
> 
> **REST APIs**
> +-++--+--+
> | api/admin/tasks   | GET  |  guids   |  (optional) List of guids to be 
> fetched. |
> |   |  |  | If list of guids supplied is empty 
> all tasks |
> |   |  |  | that are in PENDING state are 
> fetched. If list   |
> |   |  |  | guids is specified, tasks 
> corresponding to that guid are fetched.|
> +---+--+--+--+
> |api/admin/task |DELETE| guids| List of guids to be deleted. No 
> action is taken if list of guids |
> |   |  |  | supplied is empty or a Task guid does 
> not exist. |
> +---+--+--+--+
> 
> **New Updates**
> - Separate log file for tasks.
> - TaskDef now has _startTime_ and _endTime_ to indicating start and end of 
> task.
> - Refactored parameter passing during task creation. It now accepts Map 
> instead of Object array. Each task creates its own set of parameters.
> - Reduced use of TASKS_ENABLE flag 

Re: Review Request 73076: Deferred Actions Implementation

[Ashutosh Mestry via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73076/
---

(Updated March 11, 2021, 6:49 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, Nixon 
Rodrigues, and Sarath Subramanian.


Changes
---

Updates include:
- Addressed review comments.
- Simplified _TaskExecutor_ implementation.
- Additional unit tests.


Bugs: ATLAS-3919
https://issues.apache.org/jira/browse/ATLAS-3919


Repository: atlas


Description
---

**Approach**
Model: _TaskDef_
- Definition of task.
- Contains status of the task for querying.

_AbstractTask_
- Takes TaskDef as input and calls run.
- The concrete tasks has logic for doing real work.

_TaskFactory_

- Creates tasks given task type.
- Enumerates all the tasks that are supported.

_TaskManagement_

- Component/Service. Constructed after all existing components are constructed.
- Provides a simple interface for adding tasks.
- Processes tasks that are in pending state.
- Supports HA mode, where the tasks are not executed on passive instance.

_TaskManagement.Registry_

- CRUD operations with TaskDef vertex.

_TaskManagement.Processor_
- Provides mechanism for provides single queue for processing tasks in a way 
that is non-blocking.
- Uses task type and the associated TaskFactory to construct concrete task.

Changes to _EntityGraphMapper_
There are 3 new methods added that use portion of existing classification 
propagation logic and create a separate method.

New class _EntityGraphMapperWithTasks_ acts as a proxy for EntityGraphMapper. 
All calls that operate without tasks get channeled to the existing 
implementation. The ones involving tasks are modified to use the new task 
framework.

**Concurrent Changes to Classifications**
Via REST APIs and operations from web UI, it is possible to make changes to the 
same entity. This situation will be more pronounced in the new setup.

The existing framework has 
_GraphTransactionInterceptor.lockObjectAndReleasePostCommit_. This provides 
ReentrantLock on an entity that is identified by the supplied GUID. This will 
cause a lock on the entity and all the impacted vertices. This has potential 
for adversely impacting scalability.

**REST APIs**
+-++--+--+
| api/admin/tasks   | GET  |  guids   |  (optional) List of guids to be 
fetched. |
|   |  |  | If list of guids supplied is empty all 
tasks |
|   |  |  | that are in PENDING state are fetched. 
If list   |
|   |  |  | guids is specified, tasks corresponding 
to that guid are fetched.|
+---+--+--+--+
|api/admin/task |DELETE| guids| List of guids to be deleted. No action 
is taken if list of guids |
|   |  |  | supplied is empty or a Task guid does 
not exist. |
+---+--+--+--+

**New Updates**
- Separate log file for tasks.
- TaskDef now has _startTime_ and _endTime_ to indicating start and end of task.
- Refactored parameter passing during task creation. It now accepts Map instead 
of Object array. Each task creates its own set of parameters.
- Reduced use of TASKS_ENABLE flag checks.
- Added _AtlasEntity.getPendingTasks()_ that indicidate presence of tasks for a 
given entity.


Diffs (updated)
-

  common/src/main/java/org/apache/atlas/repository/Constants.java 771287f75 
  distro/src/conf/atlas-log4j.xml 7df963eb2 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 08d6c9d4a 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 4d8c94894 
  intg/src/main/java/org/apache/atlas/model/tasks/AtlasTask.java PRE-CREATION 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 27c7f7391 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4c7f8c681 
  intg/src/main/java/org/apache/atlas/type/Constants.java 7ee852086 
  intg/src/test/resources/atlas-application.properties 7e74d5107 
  repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
86b369fc9 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 d0ffb853f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2cfcc0bc1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 8208d11c2 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/MigrationImport.java
 fe8699dca 
  

[jira] [Updated] (ATLAS-4191) Creation of relations does not work for glossary import

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4191:
--
Affects Version/s: 2.1.0

> Creation of relations does not work for glossary import
> ---
>
> Key: ATLAS-4191
> URL: https://issues.apache.org/jira/browse/ATLAS-4191
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-4191.patch, Atlas BG template - smallish.csv
>
>
> When importing glossary data in CSV format, any relations within the imported 
> data lead to an error; import can only find referenced Terms that already 
> exist in Atlas.
> Example:  Term GA -> T1 has a 'seeAlso' relation to GA -> T2 and vice versa.
> (See also attached CSV file)
> This makes using relations with larger glossaries almost impossible to use: 
> there will be circular references (as with 'seeAlso'), so even a two-step 
> approach to import will not work.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4191) Creation of relations does not work for glossary import

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4191:
--
Component/s:  atlas-core

> Creation of relations does not work for glossary import
> ---
>
> Key: ATLAS-4191
> URL: https://issues.apache.org/jira/browse/ATLAS-4191
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
> Attachments: ATLAS-4191.patch, Atlas BG template - smallish.csv
>
>
> When importing glossary data in CSV format, any relations within the imported 
> data lead to an error; import can only find referenced Terms that already 
> exist in Atlas.
> Example:  Term GA -> T1 has a 'seeAlso' relation to GA -> T2 and vice versa.
> (See also attached CSV file)
> This makes using relations with larger glossaries almost impossible to use: 
> there will be circular references (as with 'seeAlso'), so even a two-step 
> approach to import will not work.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4191) Creation of relations does not work for glossary import

[Sarath Subramanian (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarath Subramanian updated ATLAS-4191:
--
Labels: glossary import  (was: )

> Creation of relations does not work for glossary import
> ---
>
> Key: ATLAS-4191
> URL: https://issues.apache.org/jira/browse/ATLAS-4191
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Sidharth Kumar Mishra
>Assignee: Sidharth Kumar Mishra
>Priority: Major
>  Labels: glossary, import
> Attachments: ATLAS-4191.patch, Atlas BG template - smallish.csv
>
>
> When importing glossary data in CSV format, any relations within the imported 
> data lead to an error; import can only find referenced Terms that already 
> exist in Atlas.
> Example:  Term GA -> T1 has a 'seeAlso' relation to GA -> T2 and vice versa.
> (See also attached CSV file)
> This makes using relations with larger glossaries almost impossible to use: 
> there will be circular references (as with 'seeAlso'), so even a two-step 
> approach to import will not work.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [atlas] sidharthkmishra commented on a change in pull request #127: Update objectPrefix isUnique for aws_s3_v2_directory to false

[GitBox]

sidharthkmishra commented on a change in pull request #127:
URL: https://github.com/apache/atlas/pull/127#discussion_r591753655



##
File path: addons/models/3000-Cloud/patches/007-s3_v2_update_attributes.json
##
@@ -0,0 +1,23 @@
+{
+  "patches": [
+{
+  "id": "TYPEDEF_PATCH_3000_007_001",
+  "description": "Update objectPrefix isUnique for aws_s3_v2_directory to 
false",
+  "action": "UPDATE_ATTRIBUTE",
+  "typeName": "aws_s3_v2_directory",
+  "applyToVersion": "1.1",
+  "updateToVersion": "1.2",

Review comment:
   Please change the aws_s3_v2_directory's objectPrefix attribute at 
3030-aws_s3_v2_typedefs.json file too and change the typeVersion. The patch 
file will ensure the model upgrade for older version and the new installation 
will be created with newer version from 3030-aws_s3_v2_typedefs.json 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Updated] (ATLAS-4194) [Read Type Auth] Metrics API shows the typecounts for types not readable by user

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole updated ATLAS-4194:
---
Affects Version/s: 3.0.0
   2.0.0

> [Read Type Auth] Metrics API shows the typecounts for types not readable by 
> user
> 
>
> Key: ATLAS-4194
> URL: https://issues.apache.org/jira/browse/ATLAS-4194
> Project: Atlas
>  Issue Type: Task
>Affects Versions: 2.0.0, 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
>
> user hrt_qa doesn't have permission to read any classification/entity type.
> But Metrics API shows wrong typecount and tagcount too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4194) [Read Type Auth] Metrics API shows the typecounts for types not readable by user

[chaitali borole (Jira)]

chaitali borole created ATLAS-4194:
--

 Summary: [Read Type Auth] Metrics API shows the typecounts for 
types not readable by user
 Key: ATLAS-4194
 URL: https://issues.apache.org/jira/browse/ATLAS-4194
 Project: Atlas
  Issue Type: Task
Reporter: chaitali borole
Assignee: chaitali borole


user hrt_qa doesn't have permission to read any classification/entity type.

But Metrics API shows wrong typecount and tagcount too.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-4180) [Atlas: Glossary Term Bulk Import] Update error message thrown while using "@" in glossary/term name

[chaitali borole (Jira)]

 [ 
https://issues.apache.org/jira/browse/ATLAS-4180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

chaitali borole reassigned ATLAS-4180:
--

Assignee: chaitali borole

> [Atlas: Glossary Term Bulk Import] Update error message thrown while using 
> "@" in glossary/term name
> 
>
> Key: ATLAS-4180
> URL: https://issues.apache.org/jira/browse/ATLAS-4180
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: chaitali borole
>Priority: Minor
>
> Input: *@ in term name*
> {code:java}
> "glossary_1","@term_1" {code}
> Error:
> {code:java}
> {"errorCode":"ATLAS-500-00-016","errorMessage":"Error occurred while creating 
> glossary term: {0}","errorCause":"name cannot contain following special chars 
> (@, .)"} {code}
> *Expectation*:
>  * Replace *{0}* with actual term name
>  * Convey the reason in error message
>  
> Input: *@ in glossary name*
> {code:java}
> "@glossary_1","term_1"{code}
> Error:
> {code:java}
> {"errorCode":"ATLAS-500-00-001","errorMessage":"The uploaded file has not 
> been processed due to the following errors : \n[The provided Glossary Name is 
> invalid : @glossary_1]"} {code}
> Expectation: 
>  * Keep it consistent with above message
>  * convey reason in error message
> Also these are client errors



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4166) Misalignment happened on entity page, when resized the browser window

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298670#comment-17298670
 ] 

ASF subversion and git services commented on ATLAS-4166:


Commit b26295430a4859584ff63ef73a8ebafccb0a85a5 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b262954 ]

ATLAS-4166:UI: Misalignment happened on entity page, when resized the browser 
window fixed

Signed-off-by: Nikhil Bonte 
(cherry picked from commit 62a295ad19a62ce45e005e55fed25c4e40fb4862)


> Misalignment happened on entity page, when resized the browser window
> -
>
> Key: ATLAS-4166
> URL: https://issues.apache.org/jira/browse/ATLAS-4166
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4166-UI-Misalignment-happened-on-entity-page-w.patch, 
> screenshot-newtab-2021.02.18-17_36_15.png
>
>
> On resizing the browser window, entity details page shows overlapped fields 
> (User-defined properties, Labels, Business Metadata) 
> PFA



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4166) Misalignment happened on entity page, when resized the browser window

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298668#comment-17298668
 ] 

ASF subversion and git services commented on ATLAS-4166:


Commit 62a295ad19a62ce45e005e55fed25c4e40fb4862 in atlas's branch 
refs/heads/master from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=62a295a ]

ATLAS-4166:UI: Misalignment happened on entity page, when resized the browser 
window fixed

Signed-off-by: Nikhil Bonte 


> Misalignment happened on entity page, when resized the browser window
> -
>
> Key: ATLAS-4166
> URL: https://issues.apache.org/jira/browse/ATLAS-4166
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4166-UI-Misalignment-happened-on-entity-page-w.patch, 
> screenshot-newtab-2021.02.18-17_36_15.png
>
>
> On resizing the browser window, entity details page shows overlapped fields 
> (User-defined properties, Labels, Business Metadata) 
> PFA



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4178) [UI] Save and Cancel buttons do not disappear after closing their respective sections in Entity Details page

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298618#comment-17298618
 ] 

ASF subversion and git services commented on ATLAS-4178:


Commit 5bd5ed0c24cf778e4cee68aca85c147447a7a0c3 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5bd5ed0 ]

ATLAS-4178:UI:V1 Save and Cancel buttons do not disappear after closing their 
respective sections in Entity Details page fixed.

Signed-off-by: Nikhil Bonte 
(cherry picked from commit 122be98b6f2348951e860aead8d7e0bf1b88de79)


> [UI] Save and Cancel buttons do not disappear after closing their respective 
> sections in Entity Details page
> 
>
> Key: ATLAS-4178
> URL: https://issues.apache.org/jira/browse/ATLAS-4178
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-4178-UI-Save-and-Cancel-buttons-do-not-disappe.patch, 
> 0001-ATLAS-4178-UI-V1-Save-and-Cancel-buttons-do-not-disa.patch, 
> save_cancel_entity_details_page.webm
>
>
> Steps:
> 1. Open any section like "User Defined Properties", "Labels" and "Business 
> Metadata"
> 2. Click on Add button
> 3.Save and Cancel button should show up 
> 4. Close the section 
> You will see the Save and Cancel buttons still remains on the page, and in 
> certain browser resolutions appear to be misaligned with other elements of 
> the page. The whole process can be seen in the attached video. They remain on 
> the page and are clickable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-3349) UI: Unable to edit AtlasServer entity with custom Required fields.

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-3349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298617#comment-17298617
 ] 

ASF subversion and git services commented on ATLAS-3349:


Commit 93cca70026a304653959ea41f492d56b3f7f172a in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=93cca70 ]

ATLAS-3349:UI: Unable to edit AtlasServer entity with custom Required 
fields.fixed

Signed-off-by: Nikhil Bonte 
(cherry picked from commit e71eee708538b054e4e42764992f5aef87eeb0d2)


> UI: Unable to edit AtlasServer entity with custom Required fields.
> --
>
> Key: ATLAS-3349
> URL: https://issues.apache.org/jira/browse/ATLAS-3349
> Project: Atlas
>  Issue Type: Bug
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Minor
> Attachments: 
> 0001-ATLAS-3349-UI-Unable-to-edit-AtlasServer-entity-with.patch, 
> editatlasserverentity.png
>
>
> User creates a AtlasServer entity through UI with the following parameters:
> "name": "$mycluster0",
> "fullName": "server",
> "displayName": "Myserver"
> Then, if the user attempts to edit the entity by clicking the edit button, 
> the user will get a blank edit window with endless loop.  (See attached 
> screenshot)
>  !editatlasserverentity.png|width=300, height=300! 
> The error in the console: 
> TypeError: that.entityData.get(...).relationshipAttributes is undefined



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4012) Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4012?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298619#comment-17298619
 ] 

ASF subversion and git services commented on ATLAS-4012:


Commit ac84e3782948811f9b07c9cd46944e2f281342e4 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ac84e37 ]

ATLAS-4012:UI:Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1 fixed

Signed-off-by: Nikhil Bonte 
(cherry picked from commit e5e4be43cdde92fa15ff8afcdf1909c49572ae51)


> Atlas - Upgrade bootstrap to 3.4.1 or 4.3.1
> ---
>
> Key: ATLAS-4012
> URL: https://issues.apache.org/jira/browse/ATLAS-4012
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: Prasad P. Pawar
>Priority: Major
> Attachments: 
> 0001-ATLAS-4012-UI-Atlas-Upgrade-bootstrap-to-3.4.1-or-4..patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4154) Atlas: UI Glossary changes & improvements

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/ATLAS-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298616#comment-17298616
 ] 

ASF subversion and git services commented on ATLAS-4154:


Commit 2c4587800a057562454eaad85583c246f3015766 in atlas's branch 
refs/heads/branch-2.0 from prasad pawar
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=2c45878 ]

ATLAS-4154:UI Glossary changes & improvements fixed V1

Signed-off-by: Nikhil Bonte 
(cherry picked from commit 4880939d4fd1f48508b981de46d55db8e5bc02be)


> Atlas: UI Glossary changes & improvements
> -
>
> Key: ATLAS-4154
> URL: https://issues.apache.org/jira/browse/ATLAS-4154
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Prasad P. Pawar
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: glossary
> Attachments: 
> 0001-ATLAS-4154-Atlas-UI-Glossary-changes-improvements-fi.patch, 
> 0001-ATLAS-4154-UI-Glossary-changes-improvements-fixed-V1.patch, 
> AssignButtonDisableFix.png, Atlas-4133Fix.png, CDPCD-22260Fix.png, 
> CDPD-22255_CDPD-22256fix.png, CDPD-22259_CDPD-22258Fix.png
>
>
> 1)[Atlas: Glossary Term Bulk Import] Rename upload window to "Import Glossary 
> Term"
> 2)[Atlas: Glossary Term Bulk Import] Adding supported file types in the 
> import window will be user friendly
> 3) [Atlas: Glossary Term Bulk Import] The file name becomes invisible as the 
> progress bar overlaps it during bulk glossary term import
> 4)[Atlas: Glossary] While adding the related term, self should not be allowed 
> to be selected
> 5)[Atlas: Glossary] On updating the related terms, UI allows the user to add 
> the already added term
> 6) [ATLAS-4133|https://issues.apache.org/jira/browse/ATLAS-4133]
> [Atlas: Glossary Term Bulk Import] Disable the option to download upload 
> template when the category is chosen on the glossary page
> 7) [ATLAS-4157|https://issues.apache.org/jira/browse/ATLAS-4157]
> UI: 'Assign' button in the 'Related Terms' window should be disabled once it 
> is clicked.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)