Re: Review Request 73426: ATLAS-4290 [Atlas: Glossary Term Bulk Import] There is not much info available in logs importing terms in bulk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73426/#review223168 --- Ship it! Ship It! - Sarath Subramanian On June 16, 2021, 5:36 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73426/ > --- > > (Updated June 16, 2021, 5:36 a.m.) > > > Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-4290 > https://issues.apache.org/jira/browse/ATLAS-4290 > > > Repository: atlas > > > Description > --- > > Added logging statement > > > Diffs > - > > repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java > 9c84598 > > > Diff: https://reviews.apache.org/r/73426/diff/1/ > > > Testing > --- > > > Thanks, > > Mandar Ambawane > >
Re: Review Request 73394: ATLAS-4317 : Upgrade curator jar version to 4.3.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73394/#review223167 --- Ship it! Ship It! - Sarath Subramanian On June 1, 2021, 9:06 a.m., chaitali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73394/ > --- > > (Updated June 1, 2021, 9:06 a.m.) > > > Review request for atlas, Jayendra Parab, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-4317 > https://issues.apache.org/jira/browse/ATLAS-4317 > > > Repository: atlas > > > Description > --- > > Upgrade curator jar version to 4.3.0 > > > Diffs > - > > pom.xml 91c23ee04 > > > Diff: https://reviews.apache.org/r/73394/diff/1/ > > > Testing > --- > > Atlas server running successfully > mvn clean install > mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip > > > Thanks, > > chaitali > >
Re: Review Request 73394: ATLAS-4317 : Upgrade curator jar version to 4.3.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73394/#review223166 --- Ship it! Ship It! - Ashutosh Mestry On June 1, 2021, 4:06 p.m., chaitali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73394/ > --- > > (Updated June 1, 2021, 4:06 p.m.) > > > Review request for atlas, Jayendra Parab, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-4317 > https://issues.apache.org/jira/browse/ATLAS-4317 > > > Repository: atlas > > > Description > --- > > Upgrade curator jar version to 4.3.0 > > > Diffs > - > > pom.xml 91c23ee04 > > > Diff: https://reviews.apache.org/r/73394/diff/1/ > > > Testing > --- > > Atlas server running successfully > mvn clean install > mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip > > > Thanks, > > chaitali > >
[jira] [Resolved] (ATLAS-3923) Exception in audit page
[ https://issues.apache.org/jira/browse/ATLAS-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nixon Rodrigues resolved ATLAS-3923. Fix Version/s: (was: trunk) Resolution: Fixed > Exception in audit page > --- > > Key: ATLAS-3923 > URL: https://issues.apache.org/jira/browse/ATLAS-3923 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Zhangyy >Priority: Minor > Labels: pull-request-available > Fix For: 3.0.0, 2.2.0 > > Attachments: bug.png, bug2.png > > Time Spent: 20m > Remaining Estimate: 0h > > 1. In debug mode, the audit page reports a NullPointException。 > 2. The bug exists in > org.apache.atlas.repository.audit.HBaseBasedAuditRepository, line 231 > 3. debug: auditAction.toString --> auditAction -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3923) Exception in audit page
[ https://issues.apache.org/jira/browse/ATLAS-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364319#comment-17364319 ] ASF subversion and git services commented on ATLAS-3923: Commit b5622afed500ae7b3f8990eff72ee79caec2d39c in atlas's branch refs/heads/branch-2.0 from zyyBjtu [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b5622af ] ATLAS-3923 : fix NullPointException in HBaseBasedAuditRepository.listEventsV2 (#108) Co-authored-by: zhangyy2255 (cherry picked from commit b0323398ff5e554b3818f18581651b140535ca88) > Exception in audit page > --- > > Key: ATLAS-3923 > URL: https://issues.apache.org/jira/browse/ATLAS-3923 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Zhangyy >Priority: Minor > Labels: pull-request-available > Fix For: trunk, 3.0.0, 2.2.0 > > Attachments: bug.png, bug2.png > > Time Spent: 20m > Remaining Estimate: 0h > > 1. In debug mode, the audit page reports a NullPointException。 > 2. The bug exists in > org.apache.atlas.repository.audit.HBaseBasedAuditRepository, line 231 > 3. debug: auditAction.toString --> auditAction -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-3923) Exception in audit page
[ https://issues.apache.org/jira/browse/ATLAS-3923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364317#comment-17364317 ] ASF subversion and git services commented on ATLAS-3923: Commit b0323398ff5e554b3818f18581651b140535ca88 in atlas's branch refs/heads/master from zyyBjtu [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=b032339 ] ATLAS-3923 : fix NullPointException in HBaseBasedAuditRepository.listEventsV2 (#108) Co-authored-by: zhangyy2255 > Exception in audit page > --- > > Key: ATLAS-3923 > URL: https://issues.apache.org/jira/browse/ATLAS-3923 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Affects Versions: 2.1.0 >Reporter: Zhangyy >Priority: Minor > Labels: pull-request-available > Fix For: trunk, 3.0.0, 2.2.0 > > Attachments: bug.png, bug2.png > > Time Spent: 20m > Remaining Estimate: 0h > > 1. In debug mode, the audit page reports a NullPointException。 > 2. The bug exists in > org.apache.atlas.repository.audit.HBaseBasedAuditRepository, line 231 > 3. debug: auditAction.toString --> auditAction -- This message was sent by Atlassian Jira (v8.3.4#803005)
Review Request 73426: ATLAS-4290 [Atlas: Glossary Term Bulk Import] There is not much info available in logs importing terms in bulk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73426/ --- Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-4290 https://issues.apache.org/jira/browse/ATLAS-4290 Repository: atlas Description --- Added logging statement Diffs - repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java 9c84598 Diff: https://reviews.apache.org/r/73426/diff/1/ Testing --- Thanks, Mandar Ambawane
[jira] [Resolved] (ATLAS-4203) [Business Metadata] Issue with saving floating point numbers in case of attributes of 'float' type
[ https://issues.apache.org/jira/browse/ATLAS-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mandar Ambawane resolved ATLAS-4203. Assignee: Mandar Ambawane Resolution: Won't Fix > [Business Metadata] Issue with saving floating point numbers in case of > attributes of 'float' type > --- > > Key: ATLAS-4203 > URL: https://issues.apache.org/jira/browse/ATLAS-4203 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Reporter: Umesh Padashetty >Assignee: Mandar Ambawane >Priority: Major > Attachments: After save.png, Before save.png > > > A value entered as -234567890123456.12 gets saved as -23456789400 > A value entered as 234567890123456.12 gets saved as 23456789400 > Screenshots attached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4203) [Business Metadata] Issue with saving floating point numbers in case of attributes of 'float' type
[ https://issues.apache.org/jira/browse/ATLAS-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364271#comment-17364271 ] Mandar Ambawane commented on ATLAS-4203: Hi [~umesh.padashetty] This behavior is not specific to Business Metadata attributes. This can be seen in all over the application where Floating point Data type is used. As Floating point numbers have a limited number of digits, they cannot represent all real numbers accurately. When there are more digits than the format allows, the number is rounded. > [Business Metadata] Issue with saving floating point numbers in case of > attributes of 'float' type > --- > > Key: ATLAS-4203 > URL: https://issues.apache.org/jira/browse/ATLAS-4203 > Project: Atlas > Issue Type: Bug > Components: atlas-core >Reporter: Umesh Padashetty >Priority: Major > Attachments: After save.png, Before save.png > > > A value entered as -234567890123456.12 gets saved as -23456789400 > A value entered as 234567890123456.12 gets saved as 23456789400 > Screenshots attached. -- This message was sent by Atlassian Jira (v8.3.4#803005)
Re: Review Request 73416: ATLAS-4336 Restrict attributes of type to be created starting with double underscore
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73416/ --- (Updated June 16, 2021, 8:35 a.m.) Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and Sarath Subramanian. Changes --- Code cleanup: removed logging statement Bugs: ATLAS-4336 https://issues.apache.org/jira/browse/ATLAS-4336 Repository: atlas Description --- Currently type can be updated with an attribute whose name starts with "__" like __guid. This gets mixed up with system attributes. Hence attribute names should not be allowed to be started with double underscore or following attribute names (system attribute names) should be restricted when a type is created or updated : __classificationNames __modifiedBy __createdBy __state __typeName __modificationTimestamp __propagatedClassificationNames __customAttributes __isIncomplete __guid __timestamp __labels Diffs (updated) - intg/src/test/java/org/apache/atlas/TestUtilsV2.java f0ec675 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasAbstractDefStoreV2.java 3dab120 repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java b51cbfc webapp/src/test/java/org/apache/atlas/web/adapters/TypeDefsRESTTest.java 962345b Diff: https://reviews.apache.org/r/73416/diff/5/ Changes: https://reviews.apache.org/r/73416/diff/4-5/ Testing --- PreCommit: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/664/consoleFull Thanks, Mandar Ambawane
Re: Review Request 73394: ATLAS-4317 : Upgrade curator jar version to 4.3.0
> On June 1, 2021, 4:22 p.m., Ashutosh Mestry wrote: > > Can you please add PC build details. https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/673/console - chaitali --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73394/#review223082 --- On June 1, 2021, 4:06 p.m., chaitali wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73394/ > --- > > (Updated June 1, 2021, 4:06 p.m.) > > > Review request for atlas, Jayendra Parab, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-4317 > https://issues.apache.org/jira/browse/ATLAS-4317 > > > Repository: atlas > > > Description > --- > > Upgrade curator jar version to 4.3.0 > > > Diffs > - > > pom.xml 91c23ee04 > > > Diff: https://reviews.apache.org/r/73394/diff/1/ > > > Testing > --- > > Atlas server running successfully > mvn clean install > mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip > > > Thanks, > > chaitali > >
[jira] [Commented] (ATLAS-4337) Atlas UI:Add entity icons for all the Kafka types
[ https://issues.apache.org/jira/browse/ATLAS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364104#comment-17364104 ] ASF subversion and git services commented on ATLAS-4337: Commit 92e3fefe47dea55898b85f3dab354c4830a21b7d in atlas's branch refs/heads/branch-2.0 from prasad pawar [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=92e3fef ] ATLAS-4337: UI: Add entity icons for all the Kafka types. Signed-off-by: nixonrodrigues (cherry picked from commit ddf3bcff29b903f1efc6671285ddf8f3cc10c7c3) > Atlas UI:Add entity icons for all the Kafka types > - > > Key: ATLAS-4337 > URL: https://issues.apache.org/jira/browse/ATLAS-4337 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Reporter: Prasad P. Pawar >Assignee: Prasad P. Pawar >Priority: Minor > Labels: entity-icons > Attachments: > 0001-ATLAS-4337-1-Atlas-UI-Add-entity-icons-for-all-the-K.patch > > > Create Entity icons for all the Kafka types. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4337) Atlas UI:Add entity icons for all the Kafka types
[ https://issues.apache.org/jira/browse/ATLAS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364102#comment-17364102 ] ASF subversion and git services commented on ATLAS-4337: Commit ddf3bcff29b903f1efc6671285ddf8f3cc10c7c3 in atlas's branch refs/heads/master from prasad pawar [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=ddf3bcf ] ATLAS-4337: UI: Add entity icons for all the Kafka types. Signed-off-by: nixonrodrigues > Atlas UI:Add entity icons for all the Kafka types > - > > Key: ATLAS-4337 > URL: https://issues.apache.org/jira/browse/ATLAS-4337 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Reporter: Prasad P. Pawar >Assignee: Prasad P. Pawar >Priority: Minor > Labels: entity-icons > Attachments: > 0001-ATLAS-4337-1-Atlas-UI-Add-entity-icons-for-all-the-K.patch > > > Create Entity icons for all the Kafka types. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (ATLAS-4337) Atlas UI:Add entity icons for all the Kafka types
[ https://issues.apache.org/jira/browse/ATLAS-4337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17364099#comment-17364099 ] Nixon Rodrigues commented on ATLAS-4337: +1 for the kafka types icons , thanks [~prasadpp13] for the patch > Atlas UI:Add entity icons for all the Kafka types > - > > Key: ATLAS-4337 > URL: https://issues.apache.org/jira/browse/ATLAS-4337 > Project: Atlas > Issue Type: Bug > Components: atlas-webui >Reporter: Prasad P. Pawar >Assignee: Prasad P. Pawar >Priority: Minor > Labels: entity-icons > Attachments: > 0001-ATLAS-4337-1-Atlas-UI-Add-entity-icons-for-all-the-K.patch > > > Create Entity icons for all the Kafka types. -- This message was sent by Atlassian Jira (v8.3.4#803005)
