[jira] [Updated] (ATLAS-4457) NullPointerException in EntityGraphMapper.updateClassifications

2021-10-19 Thread Robert Yokota (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Yokota updated ATLAS-4457:
-
Description: 
NullPointerException in EntityGraphMapper.updateClassifications when 
updatedTagPropagation is null, at this line 

[https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]

The code should probably be changed from
{code:java}
String propagationType = updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD 
: CLASSIFICATION_PROPAGATION_DELETE; {code}
to
{code:java}
String propagationType = updatedTagPropagation != null && updatedTagPropagation 
? CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
or perhaps nothing should happen if updatedTagPropagation is null...

  was:
NullPointerException in EntityGraphMapper.updateClassifications when 
updatedTagPropagation is null, at this line 

[https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]

The code should probably be changed from
{code:java}
String propagationType = updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD 
: CLASSIFICATION_PROPAGATION_DELETE; {code}
to
{code:java}
String propagationType = updatedTagPropagation != null && updatedTagPropagation 
? CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
 


> NullPointerException in EntityGraphMapper.updateClassifications
> ---
>
> Key: ATLAS-4457
> URL: https://issues.apache.org/jira/browse/ATLAS-4457
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Robert Yokota
>Priority: Major
>
> NullPointerException in EntityGraphMapper.updateClassifications when 
> updatedTagPropagation is null, at this line 
> [https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]
> The code should probably be changed from
> {code:java}
> String propagationType = updatedTagPropagation ? 
> CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
> to
> {code:java}
> String propagationType = updatedTagPropagation != null && 
> updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD : 
> CLASSIFICATION_PROPAGATION_DELETE; {code}
> or perhaps nothing should happen if updatedTagPropagation is null...



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4457) NullPointerException in EntityGraphMapper.updateClassifications

2021-10-19 Thread Robert Yokota (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Yokota updated ATLAS-4457:
-
Description: 
NullPointerException in EntityGraphMapper.updateClassifications at this line 

[https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]

The code should probably be changed from
{code:java}
String propagationType = updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD 
: CLASSIFICATION_PROPAGATION_DELETE; {code}
to
{code:java}
String propagationType = updatedTagPropagation != null && updatedTagPropagation 
? CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
 

  was:
NullPointerException in EntityGraphMapper.updateClassifications at this line 

[https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]

The code should probably be changed from
{code:java}
String propagationType = updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD 
: CLASSIFICATION_PROPAGATION_DELETE; {code}
to
{code:java}
String propagationType = updatedTagPropagation != null & updatedTagPropagation 
? CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
 


> NullPointerException in EntityGraphMapper.updateClassifications
> ---
>
> Key: ATLAS-4457
> URL: https://issues.apache.org/jira/browse/ATLAS-4457
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Robert Yokota
>Priority: Major
>
> NullPointerException in EntityGraphMapper.updateClassifications at this line 
> [https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]
> The code should probably be changed from
> {code:java}
> String propagationType = updatedTagPropagation ? 
> CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
> to
> {code:java}
> String propagationType = updatedTagPropagation != null && 
> updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD : 
> CLASSIFICATION_PROPAGATION_DELETE; {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4457) NullPointerException in EntityGraphMapper.updateClassifications

2021-10-19 Thread Robert Yokota (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Yokota updated ATLAS-4457:
-
Description: 
NullPointerException in EntityGraphMapper.updateClassifications when 
updatedTagPropagation is null, at this line 

[https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]

The code should probably be changed from
{code:java}
String propagationType = updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD 
: CLASSIFICATION_PROPAGATION_DELETE; {code}
to
{code:java}
String propagationType = updatedTagPropagation != null && updatedTagPropagation 
? CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
 

  was:
NullPointerException in EntityGraphMapper.updateClassifications at this line 

[https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]

The code should probably be changed from
{code:java}
String propagationType = updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD 
: CLASSIFICATION_PROPAGATION_DELETE; {code}
to
{code:java}
String propagationType = updatedTagPropagation != null && updatedTagPropagation 
? CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
 


> NullPointerException in EntityGraphMapper.updateClassifications
> ---
>
> Key: ATLAS-4457
> URL: https://issues.apache.org/jira/browse/ATLAS-4457
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Robert Yokota
>Priority: Major
>
> NullPointerException in EntityGraphMapper.updateClassifications when 
> updatedTagPropagation is null, at this line 
> [https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]
> The code should probably be changed from
> {code:java}
> String propagationType = updatedTagPropagation ? 
> CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
> to
> {code:java}
> String propagationType = updatedTagPropagation != null && 
> updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD : 
> CLASSIFICATION_PROPAGATION_DELETE; {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4457) NullPointerException in EntityGraphMapper.updateClassifications

2021-10-19 Thread Robert Yokota (Jira) 
Robert Yokota created ATLAS-4457:


 Summary: NullPointerException in 
EntityGraphMapper.updateClassifications
 Key: ATLAS-4457
 URL: https://issues.apache.org/jira/browse/ATLAS-4457
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.2.0
Reporter: Robert Yokota


NullPointerException in EntityGraphMapper.updateClassifications at this line 

[https://github.com/apache/atlas/blob/release-2.2.0-rc1/repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java#L2411]

The code should probably be changed from
{code:java}
String propagationType = updatedTagPropagation ? CLASSIFICATION_PROPAGATION_ADD 
: CLASSIFICATION_PROPAGATION_DELETE; {code}
to
{code:java}
String propagationType = updatedTagPropagation != null & updatedTagPropagation 
? CLASSIFICATION_PROPAGATION_ADD : CLASSIFICATION_PROPAGATION_DELETE; {code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-4456) Atlas fails to start if Solr wait-searcher property is not set

2021-10-19 Thread Ashutosh Mestry (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ashutosh Mestry reassigned ATLAS-4456:
--

Assignee: Ashutosh Mestry

> Atlas fails to start if Solr wait-searcher property is not set
> --
>
> Key: ATLAS-4456
> URL: https://issues.apache.org/jira/browse/ATLAS-4456
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Robert Yokota
>Assignee: Ashutosh Mestry
>Priority: Major
>
> Atlas fails to start if Solr wait-searcher property is not set.  This is due 
> to the following line 
> [https://github.com/apache/atlas/blob/release-2.2.0-rc1/intg/src/main/java/org/apache/atlas/ApplicationProperties.java#L365]
> which will throw the following exception:
> {code:java}
> Exception in thread "main" org.apache.atlas.AtlasException: Failed to load 
> application properties
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:150)
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:103)
> at org.apache.atlas.Atlas.main(Atlas.java:111)
> Caused by: java.util.NoSuchElementException: 
> 'atlas.graph.index.search.solr.wait-searcher' doesn't map to an existing 
> object
> at 
> org.apache.commons.configuration.AbstractConfiguration.getBoolean(AbstractConfiguration.java:644)
> at 
> org.apache.atlas.ApplicationProperties.setDefaults(ApplicationProperties.java:365)
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:141)
> ... 2 more
>  {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (ATLAS-4456) Atlas fails to start if Solr wait-searcher property is not set

2021-10-19 Thread Robert Yokota (Jira) 
Robert Yokota created ATLAS-4456:


 Summary: Atlas fails to start if Solr wait-searcher property is 
not set
 Key: ATLAS-4456
 URL: https://issues.apache.org/jira/browse/ATLAS-4456
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Affects Versions: 2.2.0
Reporter: Robert Yokota


Atlas fails to start if Solr wait-searcher property not set.  This is due to 
the following line 
[https://github.com/apache/atlas/blob/release-2.2.0-rc1/intg/src/main/java/org/apache/atlas/ApplicationProperties.java#L365]

which will throw the following exception:
{code:java}
Exception in thread "main" org.apache.atlas.AtlasException: Failed to load 
application properties
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:150)
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:103)
at org.apache.atlas.Atlas.main(Atlas.java:111)
Caused by: java.util.NoSuchElementException: 
'atlas.graph.index.search.solr.wait-searcher' doesn't map to an existing object
at 
org.apache.commons.configuration.AbstractConfiguration.getBoolean(AbstractConfiguration.java:644)
at 
org.apache.atlas.ApplicationProperties.setDefaults(ApplicationProperties.java:365)
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:141)
... 2 more
 {code}
 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ATLAS-4456) Atlas fails to start if Solr wait-searcher property is not set

2021-10-19 Thread Robert Yokota (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4456?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Yokota updated ATLAS-4456:
-
Description: 
Atlas fails to start if Solr wait-searcher property is not set.  This is due to 
the following line 
[https://github.com/apache/atlas/blob/release-2.2.0-rc1/intg/src/main/java/org/apache/atlas/ApplicationProperties.java#L365]

which will throw the following exception:
{code:java}
Exception in thread "main" org.apache.atlas.AtlasException: Failed to load 
application properties
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:150)
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:103)
at org.apache.atlas.Atlas.main(Atlas.java:111)
Caused by: java.util.NoSuchElementException: 
'atlas.graph.index.search.solr.wait-searcher' doesn't map to an existing object
at 
org.apache.commons.configuration.AbstractConfiguration.getBoolean(AbstractConfiguration.java:644)
at 
org.apache.atlas.ApplicationProperties.setDefaults(ApplicationProperties.java:365)
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:141)
... 2 more
 {code}
 

  was:
Atlas fails to start if Solr wait-searcher property not set.  This is due to 
the following line 
[https://github.com/apache/atlas/blob/release-2.2.0-rc1/intg/src/main/java/org/apache/atlas/ApplicationProperties.java#L365]

which will throw the following exception:
{code:java}
Exception in thread "main" org.apache.atlas.AtlasException: Failed to load 
application properties
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:150)
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:103)
at org.apache.atlas.Atlas.main(Atlas.java:111)
Caused by: java.util.NoSuchElementException: 
'atlas.graph.index.search.solr.wait-searcher' doesn't map to an existing object
at 
org.apache.commons.configuration.AbstractConfiguration.getBoolean(AbstractConfiguration.java:644)
at 
org.apache.atlas.ApplicationProperties.setDefaults(ApplicationProperties.java:365)
at 
org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:141)
... 2 more
 {code}
 


> Atlas fails to start if Solr wait-searcher property is not set
> --
>
> Key: ATLAS-4456
> URL: https://issues.apache.org/jira/browse/ATLAS-4456
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.2.0
>Reporter: Robert Yokota
>Priority: Major
>
> Atlas fails to start if Solr wait-searcher property is not set.  This is due 
> to the following line 
> [https://github.com/apache/atlas/blob/release-2.2.0-rc1/intg/src/main/java/org/apache/atlas/ApplicationProperties.java#L365]
> which will throw the following exception:
> {code:java}
> Exception in thread "main" org.apache.atlas.AtlasException: Failed to load 
> application properties
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:150)
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:103)
> at org.apache.atlas.Atlas.main(Atlas.java:111)
> Caused by: java.util.NoSuchElementException: 
> 'atlas.graph.index.search.solr.wait-searcher' doesn't map to an existing 
> object
> at 
> org.apache.commons.configuration.AbstractConfiguration.getBoolean(AbstractConfiguration.java:644)
> at 
> org.apache.atlas.ApplicationProperties.setDefaults(ApplicationProperties.java:365)
> at 
> org.apache.atlas.ApplicationProperties.get(ApplicationProperties.java:141)
> ... 2 more
>  {code}
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223634
---




graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
Lines 157 (patched)


Is there no functional impact in not implemeting this method?



graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java
Lines 685 (patched)


query.toString() => query
  - to avoid unnecessary cost of creating string



graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java
Lines 687 (patched)


var9  => ex
var10 => ex


- Madhan Neethiraj


On Oct. 19, 2021, 11:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> ---
> 
> (Updated Oct. 19, 2021, 11:27 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Upgrading janusgraph version  - 0.6.0
> Upgrading tinkerpop  version  - 3.5.1
> 
> 
> Diffs
> -
> 
>   graphdb/janus-hbase2/pom.xml 9ad64062f 
>   
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
>  9aa552d4a 
>   
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java
>  40bcd1ad3 
>   graphdb/janus/pom.xml f38c4e9a3 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  0d47e38fd 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
>  2d5bd8ae7 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
>  16fc4451b 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 81ae202f1 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
>  82ae67514 
>   pom.xml 84630e76b 
>   repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java 
> dd56ed141 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36 
>   tools/atlas-index-repair/pom.xml a723bfa0c 
> 
> 
> Diff: https://reviews.apache.org/r/73654/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean package -Pdist,embedded-hbase-solr- passes
> Quick start - passes
> 
> Precommit running - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
> 
> 
> Temporary changes for solrconfig.xml to pass PC
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223633
---


Ship it!




Ship It!

- Sarath Subramanian


On Oct. 19, 2021, 4:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> ---
> 
> (Updated Oct. 19, 2021, 4:27 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Upgrading janusgraph version  - 0.6.0
> Upgrading tinkerpop  version  - 3.5.1
> 
> 
> Diffs
> -
> 
>   graphdb/janus-hbase2/pom.xml 9ad64062f 
>   
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
>  9aa552d4a 
>   
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java
>  40bcd1ad3 
>   graphdb/janus/pom.xml f38c4e9a3 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  0d47e38fd 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
>  2d5bd8ae7 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
>  16fc4451b 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 81ae202f1 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
>  82ae67514 
>   pom.xml 84630e76b 
>   repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java 
> dd56ed141 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36 
>   tools/atlas-index-repair/pom.xml a723bfa0c 
> 
> 
> Diff: https://reviews.apache.org/r/73654/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean package -Pdist,embedded-hbase-solr- passes
> Quick start - passes
> 
> Precommit running - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
> 
> 
> Temporary changes for solrconfig.xml to pass PC
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

[jira] [Commented] (ATLAS-4450) [UI] Misalignment when the logged in user's name is greater than a certain length

2021-10-19 Thread Rahul Kurup (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430536#comment-17430536
 ] 

Rahul Kurup commented on ATLAS-4450:


+1

> [UI] Misalignment when the logged in user's name is greater than a certain 
> length
> -
>
> Key: ATLAS-4450
> URL: https://issues.apache.org/jira/browse/ATLAS-4450
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Reporter: Umesh Padashetty
>Assignee: Prasad P. Pawar
>Priority: Trivial
> Fix For: 3.0.0, 2.3.0
>
> Attachments: 
> 0001-ATLAS-4450-2-UI-Misalignment-when-the-logged-in-user.patch, 
> 0001-ATLAS-4450-UI-Misalignment-when-the-logged-in-user-s.patch, Screenshot 
> 2021-10-11 at 5.15.53 PM.png
>
>
> !Screenshot 2021-10-11 at 5.15.53 PM.png!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (ATLAS-4455) UI:(New UI) Dropdown and pop-over menus overlap

2021-10-19 Thread Rahul Kurup (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430535#comment-17430535
 ] 

Rahul Kurup commented on ATLAS-4455:


+1

> UI:(New UI) Dropdown and pop-over menus overlap
> ---
>
> Key: ATLAS-4455
> URL: https://issues.apache.org/jira/browse/ATLAS-4455
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: Atlas-UI
> Attachments: 
> 0001-ATLAS-4455-UI-1-New-UI-Dropdown-and-pop-over-menus-o.patch, 
> Overlapping_issue.webm
>
>
> In the new UI, it is is possible to have the drop-down and pop-over menus 
> appear in such a way that they overlap with each other. For example, clicking 
> the glossary options for a newly created glossary and then clicking the 
> ellipsis menu in the glossary section results in two menus overlapping each 
> other instead of one closing the other. See attached video for more examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/#review223630
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 19, 2021, 11:27 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73654/
> ---
> 
> (Updated Oct. 19, 2021, 11:27 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-4454
> https://issues.apache.org/jira/browse/ATLAS-4454
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Upgrading janusgraph version  - 0.6.0
> Upgrading tinkerpop  version  - 3.5.1
> 
> 
> Diffs
> -
> 
>   graphdb/janus-hbase2/pom.xml 9ad64062f 
>   
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
>  9aa552d4a 
>   
> graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java
>  40bcd1ad3 
>   graphdb/janus/pom.xml f38c4e9a3 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
>  0d47e38fd 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
>  2d5bd8ae7 
>   
> graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
>  16fc4451b 
>   graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
> 81ae202f1 
>   
> graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
>  82ae67514 
>   pom.xml 84630e76b 
>   repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java 
> dd56ed141 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36 
>   tools/atlas-index-repair/pom.xml a723bfa0c 
> 
> 
> Diff: https://reviews.apache.org/r/73654/diff/3/
> 
> 
> Testing
> ---
> 
> mvn clean package -Pdist,embedded-hbase-solr- passes
> Quick start - passes
> 
> Precommit running - 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900
> 
> 
> Temporary changes for solrconfig.xml to pass PC
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/
---

(Updated Oct. 19, 2021, 11:27 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
Subramanian.


Bugs: ATLAS-4454
https://issues.apache.org/jira/browse/ATLAS-4454


Repository: atlas


Description
---

Upgrading janusgraph version  - 0.6.0
Upgrading tinkerpop  version  - 3.5.1


Diffs
-

  graphdb/janus-hbase2/pom.xml 9ad64062f 
  
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
 9aa552d4a 
  
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java
 40bcd1ad3 
  graphdb/janus/pom.xml f38c4e9a3 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 0d47e38fd 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
 2d5bd8ae7 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
 16fc4451b 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
81ae202f1 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
 82ae67514 
  pom.xml 84630e76b 
  repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java 
dd56ed141 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36 
  tools/atlas-index-repair/pom.xml a723bfa0c 


Diff: https://reviews.apache.org/r/73654/diff/3/


Testing (updated)
---

mvn clean package -Pdist,embedded-hbase-solr- passes
Quick start - passes

Precommit running - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900


Temporary changes for solrconfig.xml to pass PC


Thanks,

Pinal Shah

[jira] [Commented] (ATLAS-4455) UI:(New UI) Dropdown and pop-over menus overlap

2021-10-19 Thread Prasad P. Pawar (Jira) 


[ 
https://issues.apache.org/jira/browse/ATLAS-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17430391#comment-17430391
 ] 

Prasad P. Pawar commented on ATLAS-4455:


Hi,
This fix is provided in the uploaded patch.

> UI:(New UI) Dropdown and pop-over menus overlap
> ---
>
> Key: ATLAS-4455
> URL: https://issues.apache.org/jira/browse/ATLAS-4455
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: Atlas-UI
> Attachments: 
> 0001-ATLAS-4455-UI-1-New-UI-Dropdown-and-pop-over-menus-o.patch, 
> Overlapping_issue.webm
>
>
> In the new UI, it is is possible to have the drop-down and pop-over menus 
> appear in such a way that they overlap with each other. For example, clicking 
> the glossary options for a newly created glossary and then clicking the 
> ellipsis menu in the glossary section results in two menus overlapping each 
> other instead of one closing the other. See attached video for more examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (ATLAS-4455) UI:(New UI) Dropdown and pop-over menus overlap

2021-10-19 Thread Prasad P. Pawar (Jira) 


 [ 
https://issues.apache.org/jira/browse/ATLAS-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Prasad P. Pawar reassigned ATLAS-4455:
--

   Attachment: 
0001-ATLAS-4455-UI-1-New-UI-Dropdown-and-pop-over-menus-o.patch
Affects Version/s: 2.3.0
   3.0.0
 Assignee: Prasad P. Pawar
   Labels: Atlas-UI  (was: )

> UI:(New UI) Dropdown and pop-over menus overlap
> ---
>
> Key: ATLAS-4455
> URL: https://issues.apache.org/jira/browse/ATLAS-4455
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0, 2.3.0
>Reporter: Rahul Kurup
>Assignee: Prasad P. Pawar
>Priority: Major
>  Labels: Atlas-UI
> Attachments: 
> 0001-ATLAS-4455-UI-1-New-UI-Dropdown-and-pop-over-menus-o.patch, 
> Overlapping_issue.webm
>
>
> In the new UI, it is is possible to have the drop-down and pop-over menus 
> appear in such a way that they overlap with each other. For example, clicking 
> the glossary options for a newly created glossary and then clicking the 
> ellipsis menu in the glossary section results in two menus overlapping each 
> other instead of one closing the other. See attached video for more examples



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Re: Review Request 73654: ATLAS-4454 : Upgrade JanusGraph version to 0.6.0

2021-10-19 Thread Pinal Shah 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73654/
---

(Updated Oct. 19, 2021, 7:45 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, and Sarath 
Subramanian.


Changes
---

addressed review comments


Bugs: ATLAS-4454
https://issues.apache.org/jira/browse/ATLAS-4454


Repository: atlas


Description
---

Upgrading janusgraph version  - 0.6.0
Upgrading tinkerpop  version  - 3.5.1


Diffs (updated)
-

  graphdb/janus-hbase2/pom.xml 9ad64062f 
  
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseKeyColumnValueStore.java
 9aa552d4a 
  
graphdb/janus-hbase2/src/main/java/org/janusgraph/diskstorage/hbase2/HBaseStoreManager.java
 40bcd1ad3 
  graphdb/janus/pom.xml f38c4e9a3 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraphDatabase.java
 0d47e38fd 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/migration/AtlasGraphSONReader.java
 2d5bd8ae7 
  
graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/query/NativeJanusGraphQuery.java
 16fc4451b 
  graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java 
81ae202f1 
  
graphdb/janus/src/test/java/org/apache/atlas/repository/graphdb/janus/migration/BaseUtils.java
 82ae67514 
  pom.xml 84630e76b 
  repository/src/test/java/org/apache/atlas/query/TraversalComposerTest.java 
dd56ed141 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml e7956cb36 
  tools/atlas-index-repair/pom.xml a723bfa0c 


Diff: https://reviews.apache.org/r/73654/diff/3/

Changes: https://reviews.apache.org/r/73654/diff/2-3/


Testing
---

mvn clean package -Pdist,embedded-hbase-solr- passes
Quick start - passes
Testing by removing janusgraph-cassandra dependency - left
Testing more combination of NEQ, NULL operators - left

Precommit running - 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/900


Temporary changes for solrconfig.xml to pass PC


Thanks,

Pinal Shah