Re: Review Request 74186: ATLAS-4692 - Upgrade Apache Commons Text to 1.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74186/#review224849 --- Ship it! Ship It! - Madhan Neethiraj On Oct. 31, 2022, 10:12 a.m., Jayendra Parab wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74186/ > --- > > (Updated Oct. 31, 2022, 10:12 a.m.) > > > Review request for atlas, Mandar Ambawane, Pinal Shah, Radhika Kundam, and > Sidharth Mishra. > > > Bugs: ATLAS-4692 > https://issues.apache.org/jira/browse/ATLAS-4692 > > > Repository: atlas > > > Description > --- > > Upgrading Commons Text library to 1.10.0 > > > Diffs > - > > addons/hbase-bridge/pom.xml d28f13dc3 > addons/hbase-testing-util/pom.xml af6eb8e57 > common/pom.xml 2562384cb > graphdb/api/pom.xml 7c6fff077 > graphdb/janus-hbase2/pom.xml 5a813de7e > graphdb/janus/pom.xml ae156fc5a > pom.xml be4068de9 > > > Diff: https://reviews.apache.org/r/74186/diff/1/ > > > Testing > --- > > Conducted a sanity check > Ran Pre-Commit link: > https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1268/ > > > Thanks, > > Jayendra Parab > >
Review Request 74186: ATLAS-4692 - Upgrade Apache Commons Text to 1.10.0
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74186/ --- Review request for atlas, Mandar Ambawane, Pinal Shah, Radhika Kundam, and Sidharth Mishra. Bugs: ATLAS-4692 https://issues.apache.org/jira/browse/ATLAS-4692 Repository: atlas Description --- Upgrading Commons Text library to 1.10.0 Diffs - addons/hbase-bridge/pom.xml d28f13dc3 addons/hbase-testing-util/pom.xml af6eb8e57 common/pom.xml 2562384cb graphdb/api/pom.xml 7c6fff077 graphdb/janus-hbase2/pom.xml 5a813de7e graphdb/janus/pom.xml ae156fc5a pom.xml be4068de9 Diff: https://reviews.apache.org/r/74186/diff/1/ Testing --- Conducted a sanity check Ran Pre-Commit link: https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1268/ Thanks, Jayendra Parab
[jira] [Commented] (ATLAS-4613) UI: After selecting checkboxes from Term page and then switching UI, page gets stuck in endless loading state.
[ https://issues.apache.org/jira/browse/ATLAS-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626497#comment-17626497 ] ASF subversion and git services commented on ATLAS-4613: Commit d821c879b3967a7980d43fc89e59e5ff4e23af6c in atlas's branch refs/heads/branch-2.0 from Farhan Khan [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d821c879b ] ATLAS-4693,ATLAS-4661,ATLAS-4613 : (UI)Switching within Terms page does not land you in the same tab Signed-off-by: Mandar Ambawane > UI: After selecting checkboxes from Term page and then switching UI, page > gets stuck in endless loading state. > -- > > Key: ATLAS-4613 > URL: https://issues.apache.org/jira/browse/ATLAS-4613 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > > Steps: > # In classic UI, Create a term > # Assign a term to any entity > # Go to the term page > # Mark all the checkboxes > # Perform switch to new UI > You will notice that the page gets stuck in endless loading accompanied by an > error : "expected type AtlasGlossaryCategory; found AtlasGlossaryTerm". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4693) UI: Redundant basic search filters in Terms page and classification page on both UIs
[ https://issues.apache.org/jira/browse/ATLAS-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626495#comment-17626495 ] ASF subversion and git services commented on ATLAS-4693: Commit d821c879b3967a7980d43fc89e59e5ff4e23af6c in atlas's branch refs/heads/branch-2.0 from Farhan Khan [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d821c879b ] ATLAS-4693,ATLAS-4661,ATLAS-4613 : (UI)Switching within Terms page does not land you in the same tab Signed-off-by: Mandar Ambawane > UI: Redundant basic search filters in Terms page and classification page on > both UIs > > > Key: ATLAS-4693 > URL: https://issues.apache.org/jira/browse/ATLAS-4693 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > > 1. When you view the terms page on either UI, you can see that the 'Exclude > Sub-classifications' and 'Exclude sub-types' basic search filters are > present, which are redundant as you are searching by term. They should be > removed from the Terms page to avoid confusion. > 2. Classification page in new UI should have the "Exclude Sub-types" filter > removed so as to maintain consistency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4661) UI: Switching within Terms page does not land you in the same tab.
[ https://issues.apache.org/jira/browse/ATLAS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626496#comment-17626496 ] ASF subversion and git services commented on ATLAS-4661: Commit d821c879b3967a7980d43fc89e59e5ff4e23af6c in atlas's branch refs/heads/branch-2.0 from Farhan Khan [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=d821c879b ] ATLAS-4693,ATLAS-4661,ATLAS-4613 : (UI)Switching within Terms page does not land you in the same tab Signed-off-by: Mandar Ambawane > UI: Switching within Terms page does not land you in the same tab. > -- > > Key: ATLAS-4661 > URL: https://issues.apache.org/jira/browse/ATLAS-4661 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4693-ATLAS-4661-ATLAS-4613-UI-Switching-within.patch > > > There are 4 tabs in a Terms Page: Entities, Properties, Classifications and > Related Terms. When the user attempts to switch from any of these tabs to the > other UI, the user always lands on the Entities tab. > This is inconsistent with the behaviour in Entities Details page where on UI > switch the user lands in the corresponding tab within the target UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4661) UI: Switching within Terms page does not land you in the same tab.
[ https://issues.apache.org/jira/browse/ATLAS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626492#comment-17626492 ] ASF subversion and git services commented on ATLAS-4661: Commit 3022242bb00b27c298c953d63256f237e15f3256 in atlas's branch refs/heads/master from Farhan Khan [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3022242bb ] ATLAS-4693,ATLAS-4661,ATLAS-4613 : (UI)Switching within Terms page does not land you in the same tab Signed-off-by: Mandar Ambawane > UI: Switching within Terms page does not land you in the same tab. > -- > > Key: ATLAS-4661 > URL: https://issues.apache.org/jira/browse/ATLAS-4661 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4693-ATLAS-4661-ATLAS-4613-UI-Switching-within.patch > > > There are 4 tabs in a Terms Page: Entities, Properties, Classifications and > Related Terms. When the user attempts to switch from any of these tabs to the > other UI, the user always lands on the Entities tab. > This is inconsistent with the behaviour in Entities Details page where on UI > switch the user lands in the corresponding tab within the target UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4613) UI: After selecting checkboxes from Term page and then switching UI, page gets stuck in endless loading state.
[ https://issues.apache.org/jira/browse/ATLAS-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626493#comment-17626493 ] ASF subversion and git services commented on ATLAS-4613: Commit 3022242bb00b27c298c953d63256f237e15f3256 in atlas's branch refs/heads/master from Farhan Khan [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3022242bb ] ATLAS-4693,ATLAS-4661,ATLAS-4613 : (UI)Switching within Terms page does not land you in the same tab Signed-off-by: Mandar Ambawane > UI: After selecting checkboxes from Term page and then switching UI, page > gets stuck in endless loading state. > -- > > Key: ATLAS-4613 > URL: https://issues.apache.org/jira/browse/ATLAS-4613 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > > Steps: > # In classic UI, Create a term > # Assign a term to any entity > # Go to the term page > # Mark all the checkboxes > # Perform switch to new UI > You will notice that the page gets stuck in endless loading accompanied by an > error : "expected type AtlasGlossaryCategory; found AtlasGlossaryTerm". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4693) UI: Redundant basic search filters in Terms page and classification page on both UIs
[ https://issues.apache.org/jira/browse/ATLAS-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626491#comment-17626491 ] ASF subversion and git services commented on ATLAS-4693: Commit 3022242bb00b27c298c953d63256f237e15f3256 in atlas's branch refs/heads/master from Farhan Khan [ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3022242bb ] ATLAS-4693,ATLAS-4661,ATLAS-4613 : (UI)Switching within Terms page does not land you in the same tab Signed-off-by: Mandar Ambawane > UI: Redundant basic search filters in Terms page and classification page on > both UIs > > > Key: ATLAS-4693 > URL: https://issues.apache.org/jira/browse/ATLAS-4693 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > > 1. When you view the terms page on either UI, you can see that the 'Exclude > Sub-classifications' and 'Exclude sub-types' basic search filters are > present, which are redundant as you are searching by term. They should be > removed from the Terms page to avoid confusion. > 2. Classification page in new UI should have the "Exclude Sub-types" filter > removed so as to maintain consistency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4661) UI: Switching within Terms page does not land you in the same tab.
[ https://issues.apache.org/jira/browse/ATLAS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626482#comment-17626482 ] Rahul Kurup commented on ATLAS-4661: +1 > UI: Switching within Terms page does not land you in the same tab. > -- > > Key: ATLAS-4661 > URL: https://issues.apache.org/jira/browse/ATLAS-4661 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4693-ATLAS-4661-ATLAS-4613-UI-Switching-within.patch > > > There are 4 tabs in a Terms Page: Entities, Properties, Classifications and > Related Terms. When the user attempts to switch from any of these tabs to the > other UI, the user always lands on the Entities tab. > This is inconsistent with the behaviour in Entities Details page where on UI > switch the user lands in the corresponding tab within the target UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (ATLAS-4661) UI: Switching within Terms page does not land you in the same tab.
[ https://issues.apache.org/jira/browse/ATLAS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626481#comment-17626481 ] Farhan Khan edited comment on ATLAS-4661 at 10/31/22 8:57 AM: -- The above added patch has the fix for this issue mentioned in the description and also consist fix for ATLAS-4693 and ATLAS-4613. All the issue were related to Glossary Detail page, hence created a single patch. was (Author: farhan khan): The above added patch has the fix for this issue mentioned in the description and also consist fix for ATLAS-4693 and ATLAS-4613. > UI: Switching within Terms page does not land you in the same tab. > -- > > Key: ATLAS-4661 > URL: https://issues.apache.org/jira/browse/ATLAS-4661 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4693-ATLAS-4661-ATLAS-4613-UI-Switching-within.patch > > > There are 4 tabs in a Terms Page: Entities, Properties, Classifications and > Related Terms. When the user attempts to switch from any of these tabs to the > other UI, the user always lands on the Entities tab. > This is inconsistent with the behaviour in Entities Details page where on UI > switch the user lands in the corresponding tab within the target UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4661) UI: Switching within Terms page does not land you in the same tab.
[ https://issues.apache.org/jira/browse/ATLAS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626481#comment-17626481 ] Farhan Khan commented on ATLAS-4661: The above added patch has the fix for this issue mentioned in the description and also consist fix for ATLAS-4693 and ATLAS-4613. > UI: Switching within Terms page does not land you in the same tab. > -- > > Key: ATLAS-4661 > URL: https://issues.apache.org/jira/browse/ATLAS-4661 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4693-ATLAS-4661-ATLAS-4613-UI-Switching-within.patch > > > There are 4 tabs in a Terms Page: Entities, Properties, Classifications and > Related Terms. When the user attempts to switch from any of these tabs to the > other UI, the user always lands on the Entities tab. > This is inconsistent with the behaviour in Entities Details page where on UI > switch the user lands in the corresponding tab within the target UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (ATLAS-4661) UI: Switching within Terms page does not land you in the same tab.
[ https://issues.apache.org/jira/browse/ATLAS-4661?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4661: --- Attachment: 0001-ATLAS-4693-ATLAS-4661-ATLAS-4613-UI-Switching-within.patch > UI: Switching within Terms page does not land you in the same tab. > -- > > Key: ATLAS-4661 > URL: https://issues.apache.org/jira/browse/ATLAS-4661 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > Attachments: > 0001-ATLAS-4693-ATLAS-4661-ATLAS-4613-UI-Switching-within.patch > > > There are 4 tabs in a Terms Page: Entities, Properties, Classifications and > Related Terms. When the user attempts to switch from any of these tabs to the > other UI, the user always lands on the Entities tab. > This is inconsistent with the behaviour in Entities Details page where on UI > switch the user lands in the corresponding tab within the target UI. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: Review Request 74185: ATLAS-4661 : (UI) Switching within Terms page does not land you in the same tab.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74185/#review224847 --- Ship it! Ship It! - Prasad Pawar On Oct. 31, 2022, 6:18 a.m., Farhan Khan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/74185/ > --- > > (Updated Oct. 31, 2022, 6:18 a.m.) > > > Review request for atlas and Prasad Pawar. > > > Bugs: ATLAS-4613, ATLAS-4661 and ATLAS-4693 > https://issues.apache.org/jira/browse/ATLAS-4613 > https://issues.apache.org/jira/browse/ATLAS-4661 > https://issues.apache.org/jira/browse/ATLAS-4693 > > > Repository: atlas > > > Description > --- > > here are 4 tabs in a Terms Page: Entities, Properties, Classifications and > Related Terms. When the user attempts to switch from any of these tabs to the > other UI, the user always lands on the Entities tab. > > This is inconsistent with the behaviour in Entities Details page where on UI > switch the user lands in the corresponding tab within the target UI. > > Also contains fix for ATLAS-4693 and ATLAS-4613 > > > Diffs > - > > dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html > b3c642e9b > dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html > 9b71d28e1 > dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 93b073da9 > dashboardv2/public/js/views/search/SearchResultLayoutView.js fd30281f9 > dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c780deb7d > dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html > 5933d1d2f > dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html > 876f5c26e > dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 11eb6ca2a > dashboardv3/public/js/views/search/SearchResultLayoutView.js e4857249f > dashboardv3/public/js/views/tag/TagDetailTableLayoutView.js 809c14392 > > > Diff: https://reviews.apache.org/r/74185/diff/1/ > > > Testing > --- > > Manually tested on both the UI. > > > Thanks, > > Farhan Khan > >
[jira] [Updated] (ATLAS-4613) UI: After selecting checkboxes from Term page and then switching UI, page gets stuck in endless loading state.
[ https://issues.apache.org/jira/browse/ATLAS-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Farhan Khan updated ATLAS-4613: --- Attachment: (was: 0001-ATLAS-4613-UI-After-selecting-checkboxes-from-Term-p.patch) > UI: After selecting checkboxes from Term page and then switching UI, page > gets stuck in endless loading state. > -- > > Key: ATLAS-4613 > URL: https://issues.apache.org/jira/browse/ATLAS-4613 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > > Steps: > # In classic UI, Create a term > # Assign a term to any entity > # Go to the term page > # Mark all the checkboxes > # Perform switch to new UI > You will notice that the page gets stuck in endless loading accompanied by an > error : "expected type AtlasGlossaryCategory; found AtlasGlossaryTerm". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4613) UI: After selecting checkboxes from Term page and then switching UI, page gets stuck in endless loading state.
[ https://issues.apache.org/jira/browse/ATLAS-4613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626422#comment-17626422 ] Farhan Khan commented on ATLAS-4613: Fix for the above mentioned issue is provided within the patch for ATLAS-4661. > UI: After selecting checkboxes from Term page and then switching UI, page > gets stuck in endless loading state. > -- > > Key: ATLAS-4613 > URL: https://issues.apache.org/jira/browse/ATLAS-4613 > Project: Atlas > Issue Type: Sub-task >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > > Steps: > # In classic UI, Create a term > # Assign a term to any entity > # Go to the term page > # Mark all the checkboxes > # Perform switch to new UI > You will notice that the page gets stuck in endless loading accompanied by an > error : "expected type AtlasGlossaryCategory; found AtlasGlossaryTerm". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (ATLAS-4693) UI: Redundant basic search filters in Terms page and classification page on both UIs
[ https://issues.apache.org/jira/browse/ATLAS-4693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17626420#comment-17626420 ] Farhan Khan commented on ATLAS-4693: Fix for the above mentioned issue is provided within the patch for ATLAS-4661. > UI: Redundant basic search filters in Terms page and classification page on > both UIs > > > Key: ATLAS-4693 > URL: https://issues.apache.org/jira/browse/ATLAS-4693 > Project: Atlas > Issue Type: Bug >Reporter: Rahul Kurup >Assignee: Farhan Khan >Priority: Minor > > 1. When you view the terms page on either UI, you can see that the 'Exclude > Sub-classifications' and 'Exclude sub-types' basic search filters are > present, which are redundant as you are searching by term. They should be > removed from the Terms page to avoid confusion. > 2. Classification page in new UI should have the "Exclude Sub-types" filter > removed so as to maintain consistency. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Review Request 74185: ATLAS-4661 : (UI) Switching within Terms page does not land you in the same tab.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/74185/ --- Review request for atlas and Prasad Pawar. Bugs: ATLAS-4613, ATLAS-4661 and ATLAS-4693 https://issues.apache.org/jira/browse/ATLAS-4613 https://issues.apache.org/jira/browse/ATLAS-4661 https://issues.apache.org/jira/browse/ATLAS-4693 Repository: atlas Description --- here are 4 tabs in a Terms Page: Entities, Properties, Classifications and Related Terms. When the user attempts to switch from any of these tabs to the other UI, the user always lands on the Entities tab. This is inconsistent with the behaviour in Entities Details page where on UI switch the user lands in the corresponding tab within the target UI. Also contains fix for ATLAS-4693 and ATLAS-4613 Diffs - dashboardv2/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html b3c642e9b dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 9b71d28e1 dashboardv2/public/js/views/glossary/GlossaryDetailLayoutView.js 93b073da9 dashboardv2/public/js/views/search/SearchResultLayoutView.js fd30281f9 dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c780deb7d dashboardv3/public/js/templates/glossary/GlossaryDetailLayoutView_tmpl.html 5933d1d2f dashboardv3/public/js/templates/search/SearchResultLayoutView_tmpl.html 876f5c26e dashboardv3/public/js/views/glossary/GlossaryDetailLayoutView.js 11eb6ca2a dashboardv3/public/js/views/search/SearchResultLayoutView.js e4857249f dashboardv3/public/js/views/tag/TagDetailTableLayoutView.js 809c14392 Diff: https://reviews.apache.org/r/74185/diff/1/ Testing --- Manually tested on both the UI. Thanks, Farhan Khan
