[jira] [Commented] (ATLAS-4721) Atlas - Upgrade jettison to 1.5.2

2023-01-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656468#comment-17656468
 ] 

ASF subversion and git services commented on ATLAS-4721:


Commit 5e71b8270621c89142c8a7d76fc7efeb5f07cd9a in atlas's branch 
refs/heads/branch-2.0 from vinayak.marraiya
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=5e71b8270 ]

ATLAS-4721 : Upgrade jettison to 1.5.2

Signed-off-by: Pinal Shah 
(cherry picked from commit 3cf04368f292482a1dbe539bcabe28ae71ad4ca9)


> Atlas - Upgrade jettison to 1.5.2
> -
>
> Key: ATLAS-4721
> URL: https://issues.apache.org/jira/browse/ATLAS-4721
> Project: Atlas
>  Issue Type: Improvement
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
>
> Currently atlas is using jettison  version 1.3.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (ATLAS-4721) Atlas - Upgrade jettison to 1.5.2

2023-01-09 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17656467#comment-17656467
 ] 

ASF subversion and git services commented on ATLAS-4721:


Commit 3cf04368f292482a1dbe539bcabe28ae71ad4ca9 in atlas's branch 
refs/heads/master from vinayak.marraiya
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3cf04368f ]

ATLAS-4721 : Upgrade jettison to 1.5.2

Signed-off-by: Pinal Shah 


> Atlas - Upgrade jettison to 1.5.2
> -
>
> Key: ATLAS-4721
> URL: https://issues.apache.org/jira/browse/ATLAS-4721
> Project: Atlas
>  Issue Type: Improvement
>Reporter: VINAYAK MARRAIYA
>Assignee: VINAYAK MARRAIYA
>Priority: Major
>
> Currently atlas is using jettison  version 1.3.7



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


Re: Review Request 74273: ATLAS-4721 :- Atlas - Upgrade jettison to 1.5.2

2023-01-09 Thread Jayendra Parab

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74273/#review225084
---


Ship it!




Ship It!

- Jayendra Parab


On Jan. 6, 2023, 11:43 a.m., Vinayak Marraiya wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74273/
> ---
> 
> (Updated Jan. 6, 2023, 11:43 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab and Pinal Shah.
> 
> 
> Bugs: ATLAS-4721
> https://issues.apache.org/jira/browse/ATLAS-4721
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently atlas is using jettison version 1.3.7
> 
> 
> Diffs
> -
> 
>   pom.xml f8558cf2a 
> 
> 
> Diff: https://reviews.apache.org/r/74273/diff/1/
> 
> 
> Testing
> ---
> 
> 1)mvn clean package -Pdist,embedded-hbase-solr -DskipTests -Drat.skip
>   Atlas server runnning
> 2)Quick started was passed successfully
> 
> Pre-commit :- 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1302/console
> 
> 
> Thanks,
> 
> Vinayak Marraiya
> 
>



Re: Review Request 73929: ATLAS-4576 Backward compatibility for check provided for AttributeName in Parent and Child TypeDef

2023-01-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73929/
---

(Updated Jan. 9, 2023, 8:16 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Paresh Devalia, Pinal Shah, Radhika Kundam, Sarath Subramanian, Sheetal Shah, 
and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-4576
https://issues.apache.org/jira/browse/ATLAS-4576


Repository: atlas


Description
---

Currently we have provided 2 checks for the Attribute Name:

https://issues.apache.org/jira/browse/ATLAS-3872 
Restrict typedef creation when a child type attribute conflicts with parent 
type attribute of same name

https://issues.apache.org/jira/browse/ATLAS-4522
Updating typedef with new supertype should be allowed only if attributes are 
unique compared to other existing supertypes

But in the earlier versions these checks were not there. So there may be a 
chance of Atlas environment having such data where these checks can cause 
problems at the time:
1. Atlas Startup.
2. Creating new typedefs

This patch handles these scenarios and provides backward compatibility for 
these 2 changes mentioned.


Diffs (updated)
-

  distro/src/conf/atlas-application.properties c92c619c9 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
17422cf95 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 76bee36f2 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 21ce23657 
  intg/src/test/java/org/apache/atlas/type/TestAtlasClassificationType.java 
b6055fa30 
  intg/src/test/java/org/apache/atlas/type/TestAtlasEntityType.java 742970390 


Diff: https://reviews.apache.org/r/73929/diff/6/

Changes: https://reviews.apache.org/r/73929/diff/5-6/


Testing
---

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1084/consoleFull

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/1293/consoleFull


Thanks,

Mandar Ambawane