Review Request 61980: ATLAS-2087: Allow Atlas server to bind on a specific address

2017-08-29 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61980/
---

Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2087
https://issues.apache.org/jira/browse/ATLAS-2087


Repository: atlas


Description
---

Allow users to use existing property "atlas.server.bind.address" to specify an 
address Atlas server binds to. If not specified, the default address "0.0.0.0" 
is used.


Diffs
-

  webapp/src/main/java/org/apache/atlas/Atlas.java e29254b0 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
467571e8 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
fa02e9b9 
  
webapp/src/test/java/org/apache/atlas/web/filters/AtlasAuthenticationKerberosFilterTest.java
 02a6fe40 
  
webapp/src/test/java/org/apache/atlas/web/security/BaseSSLAndKerberosTest.java 
d46aa2f9 
  webapp/src/test/java/org/apache/atlas/web/security/BaseSecurityTest.java 
ad87025d 
  webapp/src/test/java/org/apache/atlas/web/security/SSLTest.java 95720fdf 
  
webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTest.java 
dc3b936b 
  
webapp/src/test/java/org/apache/atlas/web/service/SecureEmbeddedServerTestBase.java
 41c3cb1b 


Diff: https://reviews.apache.org/r/61980/diff/1/


Testing
---

All unit tests pass.

Tested with following configurations:
```
atlas.server.bind.address=0.0.0.0

atlas.server.bind.address=127.0.0.1

atlas.server.bind.address=123.45.67.89

```
The last is an invalid address and the server will shutdown with an error 
message.


Thanks,

Richard Ding

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-25 Thread Richard Ding via Review Board 


> On Aug. 25, 2017, 9:55 a.m., Nigel Jones wrote:
> > distro/src/bin/atlas_start.py
> > Lines 134 (patched)
> > 
> >
> > I notice we have a hardcoded max time of 5 minutes. I wonder if there's 
> > any scenarios where we might expect longer, and whether we need to add a 
> > -maxtime nn parameter ?
> > 
> > As this is a script which the user can edit I'm not overly concerned 
> > but thought it worth mentioning

Thanks Nigel. It's hard to determine the timeout value. I've talked to Ambari 
developers about how Ambari handles service startup. Ambari delegates service 
startup functions to the service (as defined in Ambari common services). For 
example, Atlas service has following:
```
 
 scripts/metadata_server.py
 PYTHON
 1200
 
```
Each service also provides a server_check script which Ambari runs periodically 
to check server status. Atlas uses following command:
```
smoke_cmd = format('curl -k -s -o /dev/null -w "%{{http_code}}" 
{metadata_protocol}://{atlas_host}:{metadata_port}/')
```
This is similar to what we proposed.


- Richard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/#review183837
---


On Aug. 16, 2017, 11:15 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61561/
> ---
> 
> (Updated Aug. 16, 2017, 11:15 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1218
> https://issues.apache.org/jira/browse/ATLAS-1218
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch implements a wait_for_startup function modeled after 
> wait_for_shutdown function.
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py 1be9ca2b 
>   distro/src/bin/atlas_start.py a6a3455c 
> 
> 
> Diff: https://reviews.apache.org/r/61561/diff/4/
> 
> 
> Testing
> ---
> 
> Here are the output of atlas_start and atlas_stop script:
> ```
> starting atlas on port 21000
> 
> Apache Atlas Server started!!!
> ```
> and
> ```
> stopping atlas
> Apache Atlas Server stopped!!!
> ```
> 
> 
> Thanks,
> 
> Richard Ding
> 
>

Re: Review Request 61871: ATLAS-2083: Refactor AtlasDefStore classes to reduce code duplication

2017-08-25 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61871/
---

(Updated Aug. 25, 2017, 6:44 p.m.)


Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

Uploaded a new patch rebased on the latest master branch.


Bugs: ATLAS-2083
https://issues.apache.org/jira/browse/ATLAS-2083


Repository: atlas


Description
---

1. Use generic interface to reduce code duplication
2. Move the common code in the implementation classes to the base class
3. Tighten the types required in the interface methods 
4. Move two test classes to the correct package


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
 92a59f39 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
 08391ba5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
 d0f98e2f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStore.java
 df67958b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
 ebd2b706 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 f5e16182 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
 baf23092 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
 89445048 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
 d6cb2fd4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
 39c4dd93 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 bdde58bc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
 62729e79 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 ab738495 
  repository/src/test/java/org/apache/atlas/TestModules.java 4bc14872 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java
 5f011362 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStoreV1Test.java
 00d49779 


Diff: https://reviews.apache.org/r/61871/diff/2/

Changes: https://reviews.apache.org/r/61871/diff/1-2/


Testing
---

All unit tests passed.


Thanks,

Richard Ding

Review Request 61871: ATLAS-2083: Refactor AtlasDefStore classes to reduce code duplication

2017-08-23 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61871/
---

Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2083
https://issues.apache.org/jira/browse/ATLAS-2083


Repository: atlas


Description
---

1. Use generic interface to reduce code duplication
2. Move the common code in the implementation classes to the base class
3. Tighten the types required in the interface methods 
4. Move two test classes to the correct package


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
 92a59f39 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
 08391ba5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
 d0f98e2f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStore.java
 df67958b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
 ebd2b706 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 22e14436 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
 baf23092 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
 89445048 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
 d6cb2fd4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
 39c4dd93 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 bdde58bc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
 62729e79 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 50a42166 
  repository/src/test/java/org/apache/atlas/TestModules.java 4bc14872 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java
 5f011362 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStoreV1Test.java
 00d49779 


Diff: https://reviews.apache.org/r/61871/diff/1/


Testing
---

All unit tests passed.


Thanks,

Richard Ding

Review Request 61795: ATLAS-2060: Fix logger class name typos

2017-08-21 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61795/
---

Review request for atlas, David Radley and Madhan Neethiraj.


Bugs: ATLAS-2060
https://issues.apache.org/jira/browse/ATLAS-2060


Repository: atlas


Description
---

Fix typos


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasMapType.java 90c898a3 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java ad1e09ea 


Diff: https://reviews.apache.org/r/61795/diff/1/


Testing
---


Thanks,

Richard Ding

Review Request 61794: ATLAS-2076: Add RELATIONSHIP type to search filters

2017-08-21 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61794/
---

Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2076
https://issues.apache.org/jira/browse/ATLAS-2076


Repository: atlas


Description
---

Added missing Relationship type support for TypeREST API


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 7a0bbca1 
  repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 
54d6b405 


Diff: https://reviews.apache.org/r/61794/diff/1/


Testing
---

Run the following commands to verify the issues are fixed:
```
curl -X GET -u admin:admin 
http://localhost:21000/api/atlas/v2/types/typedefs/headers?type=relationship

curl -X GET -u admin:admin 
http://localhost:21000/api/atlas/v2/types/typedef/name/falcon_cluster_feed_creation

```


Thanks,

Richard Ding

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/
---

(Updated Aug. 16, 2017, 11:15 p.m.)


Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
Subramanian.


Changes
---

This patch fixed the empty string issue.


Bugs: ATLAS-1218
https://issues.apache.org/jira/browse/ATLAS-1218


Repository: atlas


Description
---

This patch implements a wait_for_startup function modeled after 
wait_for_shutdown function.


Diffs (updated)
-

  distro/src/bin/atlas_config.py 1be9ca2b 
  distro/src/bin/atlas_start.py a6a3455c 


Diff: https://reviews.apache.org/r/61561/diff/4/

Changes: https://reviews.apache.org/r/61561/diff/3-4/


Testing
---

Here are the output of atlas_start and atlas_stop script:
```
starting atlas on port 21000

Apache Atlas Server started!!!
```
and
```
stopping atlas
Apache Atlas Server stopped!!!
```


Thanks,

Richard Ding

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-16 Thread Richard Ding via Review Board 


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 71 (patched)
> > 
> >
> > I am uncomfortable duplicating the default port values here. I suggest 
> > moving this logic to the java class that already has the default port values
> 
> Richard Ding wrote:
> The default ports are hard-coded in Java class:
> ```
> appPort = StringUtils.isEmpty(enableTLSFlag) || 
> enableTLSFlag.equals("true") ?
> configuration.getInt(ATLAS_SERVER_HTTPS_PORT, 21443) :
> configuration.getInt(ATLAS_SERVER_HTTP_PORT, 21000);
> ```
> It's also difficult to access Java class from python code.
> 
> David Radley wrote:
> hi Richard , unless you move the polling logic into Java code (in a 
> separate thread) - so you have more control over it. I assume the process 
> starts right away, but the delay is in web server code prior to it opening 
> the port. all the best, David.

You are right. The polling logic is in the startup python script which has no 
access to Java classes. 

The process is started by the python script (atlas_start.py) and the script has 
no way to know when the server initialization is complete. So inside the 
startup script the best we can do is to ping the port. After changing the code 
to use socket module, the code is simplified and it appears to work well even 
with SSL port.


- Richard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/#review182676
---


On Aug. 15, 2017, 10:08 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61561/
> ---
> 
> (Updated Aug. 15, 2017, 10:08 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1218
> https://issues.apache.org/jira/browse/ATLAS-1218
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch implements a wait_for_startup function modeled after 
> wait_for_shutdown function.
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py 1be9ca2b 
>   distro/src/bin/atlas_start.py a6a3455c 
> 
> 
> Diff: https://reviews.apache.org/r/61561/diff/3/
> 
> 
> Testing
> ---
> 
> Here are the output of atlas_start and atlas_stop script:
> ```
> starting atlas on port 21000
> 
> Apache Atlas Server started!!!
> ```
> and
> ```
> stopping atlas
> Apache Atlas Server stopped!!!
> ```
> 
> 
> Thanks,
> 
> Richard Ding
> 
>

Re: Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-14 Thread Richard Ding via Review Board 


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 71 (patched)
> > 
> >
> > I am uncomfortable duplicating the default port values here. I suggest 
> > moving this logic to the java class that already has the default port values

The default ports are hard-coded in Java class:
```
appPort = StringUtils.isEmpty(enableTLSFlag) || enableTLSFlag.equals("true") ?
configuration.getInt(ATLAS_SERVER_HTTPS_PORT, 21443) :
configuration.getInt(ATLAS_SERVER_HTTP_PORT, 21000);
```
It's also difficult to access Java class from python code.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 454 (patched)
> > 
> >
> > is this going to work if -port was specified on the atlas_start command?

Good catch! The new patch handles -port option.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 473 (patched)
> > 
> >
> > I was hoping we would be able to be notified when Atlas was started or 
> > the startup time reduced, by understanding why there is a delay and 
> > minimizing it.
> > 
> > Once we understand that and decide that polling is the appropriate 
> > resolution - I suggest a 1 second poll - as we can do nothing with Atlas 
> > until it is  started.

Good point. Right now the atlas_start.py script just launches a process 
asynchronously without knowning when the Atlas server will complete the 
initialization (e.g. creating hbase tables, solr indexes and typedefs). This 
solution is to let the startup script ping the endpoint of the web server. 

I'll change the ping interval to 1 sec.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 475 (patched)
> > 
> >
> > I am not expert on all the ways Atlas can be started, does this work 
> > with OAuth and does Knox work with this?

The script just ping the Atlas server endpoint without performing the login. It 
should work with SSO solutions. It also assumes that the script runs on the 
same host as the Atlas server and is able to access directly to the server 
endpoint.


> On Aug. 11, 2017, 11:11 a.m., David Radley wrote:
> > distro/src/bin/atlas_config.py
> > Lines 477 (patched)
> > 
> >
> > If we have failures during startup, how can we tell  the polling to 
> > cease?

Just like _wait_for_shutdown_, the polling has a timeout setting (5 mins). The 
timeout is the only way to stop the polling. There is no callbacks from the 
server. Maybe we can try to tail and grep the log file to see there is any 
failures during startup.


- Richard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/#review182676
---


On Aug. 10, 2017, 5:47 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61561/
> ---
> 
> (Updated Aug. 10, 2017, 5:47 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-1218
> https://issues.apache.org/jira/browse/ATLAS-1218
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch implements a wait_for_startup function modeled after 
> wait_for_shutdown function.
> 
> 
> Diffs
> -
> 
>   distro/src/bin/atlas_config.py 1be9ca2b 
>   distro/src/bin/atlas_start.py a6a3455c 
> 
> 
> Diff: https://reviews.apache.org/r/61561/diff/1/
> 
> 
> Testing
> ---
> 
> Here are the output of atlas_start and atlas_stop script:
> ```
> starting atlas on port 21000
> 
> Apache Atlas Server started!!!
> ```
> and
> ```
> stopping atlas
> Apache Atlas Server stopped!!!
> ```
> 
> 
> Thanks,
> 
> Richard Ding
> 
>

Re: Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-11 Thread Richard Ding via Review Board 


> On Aug. 11, 2017, 9:22 a.m., David Radley wrote:
> > common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java
> > Lines 54 (patched)
> > 
> >
> > Hi Richard, this looks good - please could you generate the swagger and 
> > make sure that it tolerates the markup you have added.

The following mvn command runs successfully after applying the patch: 
>mvn -DskipTests -DskipEnunciate=false clean package 

The swagger docs are generated in the directory:
>webapp/target/api/v2/apidocs


- Richard


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61568/#review182672
---


On Aug. 10, 2017, 6:15 p.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61568/
> ---
> 
> (Updated Aug. 10, 2017, 6:15 p.m.)
> 
> 
> Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-2003
> https://issues.apache.org/jira/browse/ATLAS-2003
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch added Javadoc format to the following class summaries: 
> ```
> InMemoryJAASConfiguration.java 
> TitanGraphQuery.java   
> AtlasRelationshipDef.java  
> NotificationInterface.java 
> ExpandAndsOptimization.java 
> HBaseBasedAuditRepository.java   
> ```
> 
> 
> Diffs
> -
> 
>   
> common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java 
> c65048fa 
>   
> graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
>  c38f6cc8 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java 
> c17e875d 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
>  ef8ee275 
>   
> repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandAndsOptimization.java
>  7cf97110 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  06e518ee 
> 
> 
> Diff: https://reviews.apache.org/r/61568/diff/1/
> 
> 
> Testing
> ---
> 
> Verified with Javadoc build.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>

Review Request 61568: ATLAS-2003: Add Javadoc format to class summaries

2017-08-10 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61568/
---

Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-2003
https://issues.apache.org/jira/browse/ATLAS-2003


Repository: atlas


Description
---

This patch added Javadoc format to the following class summaries: 
```
InMemoryJAASConfiguration.java 
TitanGraphQuery.java   
AtlasRelationshipDef.java  
NotificationInterface.java 
ExpandAndsOptimization.java 
HBaseBasedAuditRepository.java   
```


Diffs
-

  common/src/main/java/org/apache/atlas/security/InMemoryJAASConfiguration.java 
c65048fa 
  
graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/titan/query/TitanGraphQuery.java
 c38f6cc8 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasRelationshipDef.java 
c17e875d 
  
notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
 ef8ee275 
  
repository/src/main/java/org/apache/atlas/gremlin/optimizer/ExpandAndsOptimization.java
 7cf97110 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 06e518ee 


Diff: https://reviews.apache.org/r/61568/diff/1/


Testing
---

Verified with Javadoc build.


Thanks,

Richard Ding

Review Request 61566: ATLAS-1867: org.apache.atlas.AtlasClientV2.deleteAtlasTypeDefs gives an exception

2017-08-10 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61566/
---

Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-1867
https://issues.apache.org/jira/browse/ATLAS-1867


Repository: atlas


Description
---

This patch returns the correct HTTP code ""204 No Content" instead of "200 OK"


Diffs
-

  client/src/main/java/org/apache/atlas/AtlasClientV2.java 13533571 


Diff: https://reviews.apache.org/r/61566/diff/1/


Testing
---

All unit tests pass after applying the patch.


Thanks,

Richard Ding

Review Request 61561: ATLAS-1218: Atlas says it is started but does not accept REST requests

2017-08-10 Thread Richard Ding via Review Board 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61561/
---

Review request for atlas, David Radley, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-1218
https://issues.apache.org/jira/browse/ATLAS-1218


Repository: atlas


Description
---

This patch implements a wait_for_startup function modeled after 
wait_for_shutdown function.


Diffs
-

  distro/src/bin/atlas_config.py 1be9ca2b 
  distro/src/bin/atlas_start.py a6a3455c 


Diff: https://reviews.apache.org/r/61561/diff/1/


Testing
---

Here are the output of atlas_start and atlas_stop script:
```
starting atlas on port 21000

Apache Atlas Server started!!!
```
and
```
stopping atlas
Apache Atlas Server stopped!!!
```


Thanks,

Richard Ding