Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

2020-06-25 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72614/#review221069 --- Ship it! Ship It! - Sarath Subramanian On June 24, 2020, 8

Re: Review Request 72619: ATLAS-3863: Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Sarath Subramanian
) After patch : 46.92 secs 83% performance improvement seen. Thanks, Sarath Subramanian

[jira] [Updated] (ATLAS-3863) Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3863: -- Description: Tag propagation is re-evaluated every time when a relationship (edge

Review Request 72619: ATLAS-3863: Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Sarath Subramanian
-Build-Test/1978/console Thanks, Sarath Subramanian

[jira] [Updated] (ATLAS-3863) Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3863: -- Attachment: ATLAS-3863.001.patch > Avoid re-evaluating tag propagation when delet

[jira] [Updated] (ATLAS-3863) Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3863: -- Labels: classification tagpropagation (was: ) > Avoid re-evaluating tag propagat

[jira] [Updated] (ATLAS-3863) Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3863: -- Description: Tag propagation is re-evaluated every time when a relationship (edge

[jira] [Created] (ATLAS-3863) Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3863: - Summary: Avoid re-evaluating tag propagation when deleting relationship (edge) Key: ATLAS-3863 URL: https://issues.apache.org/jira/browse/ATLAS-3863

[jira] [Updated] (ATLAS-3652) Quick Search: API requirement for GET request on multiple entity types

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3652: -- Labels: quicksearch (was: ) > Quick Search: API requirement for GET requ

[jira] [Updated] (ATLAS-3652) Quick Search: API requirement for GET request on multiple entity types

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3652: -- Fix Version/s: 2.1.0 > Quick Search: API requirement for GET request on multi

[jira] [Updated] (ATLAS-3652) Quick Search: API requirement for GET request on multiple entity types

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3652: -- Affects Version/s: 2.0.0 > Quick Search: API requirement for GET request on multi

[jira] [Updated] (ATLAS-3652) Quick Search: API requirement for GET request on multiple entity types

2020-06-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3652: -- Component/s: atlas-core > Quick Search: API requirement for GET request on multi

Re: Review Request 72614: ATLAS-3856 Create new entity types for Apache Ozone

2020-06-23 Thread Sarath Subramanian
9851> does "length" type needs to be of string type? addons/models/3000-Cloud/3050-ozone-typedefs.json Lines 49 (patched) <https://reviews.apache.org/r/72614/#comment309854> ozone => Ozone - Sarath Subramanian On June 22, 2020, 10:45 p.m., Nikhil Bonte wr

[jira] [Updated] (ATLAS-3845) Audit API returns the audit information for an unauthorised entity

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3845: -- Labels: audit (was: ) > Audit API returns the audit information for an unauthori

[jira] [Updated] (ATLAS-3845) Audit API returns the audit information for an unauthorised entity

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3845: -- Affects Version/s: (was: 3.0.0) 2.0.0 > Audit API retu

[jira] [Updated] (ATLAS-3845) Audit API returns the audit information for an unauthorised entity

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3845: -- Component/s: atlas-core > Audit API returns the audit informat

[jira] [Updated] (ATLAS-3845) Audit API returns the audit information for an unauthorised entity

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3845: -- Fix Version/s: 2.1.0 > Audit API returns the audit information for an unauthori

[jira] [Resolved] (ATLAS-3854) Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3854. --- Resolution: Fixed > Upgrade Spring Security version to 4.2

[jira] [Updated] (ATLAS-3854) Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3854: -- Fix Version/s: 2.1.0 > Upgrade Spring Security version to 4.2

[jira] [Updated] (ATLAS-3854) Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3854: -- Component/s: atlas-core > Upgrade Spring Security version to 4.2

[jira] [Updated] (ATLAS-3854) Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3854: -- Affects Version/s: 2.0.0 > Upgrade Spring Security version to 4.2

Re: Review Request 72601: ATLAS-3845 : Audit API returns the audit information for an unauthorised entity

2020-06-22 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72601/#review221045 --- Ship it! Ship It! - Sarath Subramanian On June 22, 2020, 7

Re: Review Request 72612: ATLAS-3854: Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72612/#review221044 --- Ship it! Ship It! - Sarath Subramanian On June 22, 2020, 7

Re: Review Request 72597: ATLAS-3844 :- Ignore relationship attribute while fetching entities in Import Hive bridge.

2020-06-18 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72597/#review221032 --- Ship it! Ship It! - Sarath Subramanian On June 17, 2020, 5

Re: Review Request 72601: ATLAS-3845 : Audit API returns the audit information for an unauthorised entity

2020-06-18 Thread Sarath Subramanian
Line 808 (original), 811 (patched) <https://reviews.apache.org/r/72601/#comment309813> consider replacing 811 and 812 with: entitiesStore.getHeaderById(guid); this internally checks for authorization. - Sarath Subramanian On June 17, 2020, 7:48 a.m., chaitali

Re: Review Request 72566: ATLAS-1798 : Fix Findbugs problems in repository module

2020-06-16 Thread Sarath Subramanian
ws.apache.org/r/72566/#comment309793> these checks are confusing, revert to old one. repository/src/main/java/org/apache/atlas/util/FileUtils.java Lines 36 (patched) <https://reviews.apache.org/r/72566/#comment309795> nit: unused import. consider removing it. - Sarath Subramania

Re: Review Request 72593: ATLAS-3841 Response Headers: Code refactoring

2020-06-16 Thread Sarath Subramanian
consider using the following to get file extension: ``` String fileExtension = FilenameUtils.getExtension(path); if (!isFileExtensionExcluded(fileExtension)) { setHeaders((HttpServletResponse) response); } ``` - Sarath Subramanian On June 16, 2020, 7:37 a.m., Man

Re: Review Request 72595: ATLAS-3833 : Packaging for atlas index repair tool

2020-06-16 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72595/#review221015 --- Ship it! Ship It! - Sarath Subramanian On June 16, 2020, 6

Re: Review Request 72581: Upgrade maven-deploy-plugin version from 2.7 to 2.8.2 to enable

2020-06-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72581/#review220996 --- Ship it! Ship It! - Sarath Subramanian On June 10, 2020, 11

Re: [DRAFT] Board report for Apache Atlas: June 2020

2020-06-10 Thread Sarath Subramanian
Thanks Madhan for putting this together. The report looks good. +1 Thanks, Sarath On Wed, Jun 10, 2020 at 11:34 AM Madhan Neethiraj wrote: > Atlas team, > > Please review the draft board report below and send your feedback/comments. > > Thanks, > Madhan > > > ## Description: > Apache Atlas

[jira] [Created] (ATLAS-3836) Create new entity types for Apache Ozone and update hive hook to handle reference to Ozone path

2020-06-10 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3836: - Summary: Create new entity types for Apache Ozone and update hive hook to handle reference to Ozone path Key: ATLAS-3836 URL: https://issues.apache.org/jira/browse

Re: Review Request 72576: ATLAS-3826: Basic search not using index query for string tokenized attributes

2020-06-08 Thread Sarath Subramanian
/ Changes: https://reviews.apache.org/r/72576/diff/1-2/ Testing --- manually validated, string tokenized attributes uses index query. Precommit - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1957/console Thanks, Sarath Subramanian

Review Request 72576: ATLAS-3826: Basic search not using index query for string tokenized attributes

2020-06-08 Thread Sarath Subramanian
uses index query. Precommit - https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1957/console Thanks, Sarath Subramanian

[jira] [Updated] (ATLAS-3826) Basic search not using index query for string tokenized attributes

2020-06-08 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3826: -- Labels: BasicSearch (was: ) > Basic search not using index query for string tokeni

[jira] [Updated] (ATLAS-3826) Basic search not using index query for string tokenized attributes

2020-06-08 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3826?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3826: -- Description: Basic search not using index query for string tokenized attributes

[jira] [Created] (ATLAS-3826) Basic search not using index query for string tokenized attributes

2020-06-08 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3826: - Summary: Basic search not using index query for string tokenized attributes Key: ATLAS-3826 URL: https://issues.apache.org/jira/browse/ATLAS-3826 Project

Re: [VOTE] Release Apache Atlas version 2.1.0 - rc1

2020-06-07 Thread Sarath Subramanian
+1 for Apache Atlas 2.1 RC1 Validated the following: - No binaries in source - Verified source checksum - md5 and sha512 - Verified signature - Build was successful on the source (mvn clean -DskipTests package -Pdist,embedded-hbase-solr) - Ran quickStart and validated types and

Re: Review Request 72565: ATLAS-3825: updated import business-metadata to set business attribute values on appropriate entities

2020-06-03 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72565/#review220954 --- Ship it! Ship It! - Sarath Subramanian On June 3, 2020, 5

[jira] [Commented] (ATLAS-3824) update README.txt to replace earlier version references to 2.1.0

2020-06-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17125359#comment-17125359 ] Sarath Subramanian commented on ATLAS-3824: --- +1. Thanks [~madhan] > update README.

Re: Review Request 72559: ATLAS-3808: updated version in pom.xml from 2.1.0-SNAPSHOT to 2.1.0

2020-06-01 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72559/#review220931 --- Ship it! Ship It! - Sarath Subramanian On June 1, 2020, 9

[jira] [Updated] (ATLAS-3780) Change 'Status' from Classification System Attributes to EntityStatus

2020-06-01 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3780: -- Labels: BasicSearch (was: ) > Change 'Status' from Classification System Attribu

[jira] [Updated] (ATLAS-3780) Change 'Status' from Classification System Attributes to EntityStatus

2020-06-01 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3780: -- Fix Version/s: 3.0.0 2.1.0 > Change 'Status' from Classificat

[jira] [Updated] (ATLAS-3780) Change 'Status' from Classification System Attributes to EntityStatus

2020-06-01 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3780: -- Affects Version/s: 2.0.0 > Change 'Status' from Classification System Attribu

Re: Review Request 72486: ATLAS-3780 : Change 'Status' from Classification System Attributes to EntityStatus

2020-06-01 Thread Sarath Subramanian
/atlas/discovery/ClassificationSearchProcessor.java Lines 336 (patched) <https://reviews.apache.org/r/72486/#comment309647> change string literal "ACTIVE" to AtlasEntity.Status.ACTIVE.name() - Sarath Subramanian On May 11, 2020, 7:01 a.m.,

[jira] [Updated] (ATLAS-3806) Classifications information missing in notification events during entity create/update

2020-05-31 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3806?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3806: -- Affects Version/s: 2.0.0 > Classifications information missing in notification eve

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72540/#review220908 --- Ship it! Ship It! - Sarath Subramanian On May 28, 2020, 4

Re: Review Request 72546: ATLAS-3813 Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System

2020-05-27 Thread Sarath Subramanian
/HiveMetaStoreBridge.java Lines 306 (patched) <https://reviews.apache.org/r/72546/#comment309618> 'importCount' ignores successfull database import. If valid database with no tables exists, importCount returns 0. Please review. - Sarath Subramanian On May 27, 2020, 2:58 a.m., Mandar Am

[jira] [Commented] (ATLAS-3803) Update tag propagation to NONE for relationshipDefs in aws_s3_v2 and azure_adls_gen2 models

2020-05-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112657#comment-17112657 ] Sarath Subramanian commented on ATLAS-3803: --- [^ATLAS-3803.002.patch] updates azure adls models

[jira] [Updated] (ATLAS-3803) Update tag propagation to NONE for relationshipDefs in aws_s3_v2 and azure_adls_gen2 models

2020-05-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3803: -- Attachment: ATLAS-3803.002.patch > Update tag propagation to NONE for relationshipD

[jira] [Updated] (ATLAS-3803) Update tag propagation to NONE for relationshipDefs in aws_s3_v2 and azure_adls_gen2 models

2020-05-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3803: -- Summary: Update tag propagation to NONE for relationshipDefs in aws_s3_v2

[jira] [Updated] (ATLAS-3803) Update tag propagation to NONE between aws_s3_v2_container and aws_s3_v2_contained type

2020-05-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3803: -- Attachment: ATLAS-3803.001.patch > Update tag propagation to NONE betw

[jira] [Created] (ATLAS-3803) Update tag propagation to NONE between aws_s3_v2_container and aws_s3_v2_contained type

2020-05-20 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3803: - Summary: Update tag propagation to NONE between aws_s3_v2_container and aws_s3_v2_contained type Key: ATLAS-3803 URL: https://issues.apache.org/jira/browse/ATLAS-3803

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

2020-05-19 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220829 --- Please add some unit tests - Sarath Subramanian On May 19

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

2020-05-19 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220828 --- Ship it! Ship It! - Sarath Subramanian On May 19, 2020, 4

[jira] [Updated] (ATLAS-3788) BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-15 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3788: -- Labels: BasicSearch (was: ) > BasicSearch: Classification with System attrib

[jira] [Updated] (ATLAS-3788) BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-15 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3788: -- Component/s: atlas-core > BasicSearch: Classification with System attribute(inde

[jira] [Updated] (ATLAS-3788) BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-15 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3788: -- Affects Version/s: 2.0.0 > BasicSearch: Classification with System attribute(inde

[jira] [Updated] (ATLAS-3788) BasicSearch: Classification with System attribute(indexed) filters has pagination issue

2020-05-15 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3788?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3788: -- Fix Version/s: 2.1.0 > BasicSearch: Classification with System attribute(inde

[jira] [Updated] (ATLAS-3800) AWS scheme is missing the aws account id that contains the S3 bucket

2020-05-15 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3800: -- Fix Version/s: 2.1.0 > AWS scheme is missing the aws account id that contains the

[jira] [Updated] (ATLAS-3800) AWS scheme is missing the aws account id that contains the S3 bucket

2020-05-15 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3800: -- Affects Version/s: 2.0.0 > AWS scheme is missing the aws account id that conta

[jira] [Updated] (ATLAS-3800) AWS scheme is missing the aws account id that contains the S3 bucket

2020-05-15 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3800: -- Component/s: atlas-core > AWS scheme is missing the aws account id that conta

Re: Review Request 72515: ATLAS-3785: Modify the AWS s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional

2020-05-14 Thread Sarath Subramanian
-aws_s3_v2_typedefs.json Line 262 (original), 271 (patched) <https://reviews.apache.org/r/72515/#comment309480> revert to version 1.0 - Sarath Subramanian On May 14, 2020, 7:31 p.m., Sidharth Mishra wrote: > > --- > This is a

Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions

2020-05-14 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72474/#review220768 --- Ship it! Ship It! - Sarath Subramanian On May 14, 2020, 2

[jira] [Commented] (ATLAS-3796) Migration Import Display: StatusReporter Does not Remove Processed Items

2020-05-13 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17106704#comment-17106704 ] Sarath Subramanian commented on ATLAS-3796: --- +1 for the patch  [^ATLAS-3796-Status-Reporter

Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions

2020-05-12 Thread Sarath Subramanian
/atlas/query/RegistryBasedLookup.java Lines 127 (patched) <https://reviews.apache.org/r/72474/#comment309398> consider renaming the variable: et => entityType ret => attribute direction => ret (return value should be ret to avoid confusion) - Sarath Subramanian

Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions

2020-05-11 Thread Sarath Subramanian
6> both if and else condition executes the same statement. please review. repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java Lines 591 (patched) <https://reviews.apache.org/r/72474/#comment309338> same here. remove if/else condition - Sarath Subramanian

[jira] [Updated] (ATLAS-3783) DSL query search should return results for both the relationship edge directions

2020-05-11 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3783: -- Labels: AdvancedSearch DSL (was: ) > DSL query search should return results for b

[jira] [Updated] (ATLAS-3783) DSL query search should return results for both the relationship edge directions

2020-05-11 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3783: -- Fix Version/s: 2.1.0 > DSL query search should return results for b

[jira] [Updated] (ATLAS-3783) DSL query search should return results for both the relationship edge directions

2020-05-11 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3783: -- Affects Version/s: (was: 3.0.0) 2.0.0 > DSL query sea

[jira] [Updated] (ATLAS-3783) DSL query search should return results for both the relationship edge directions

2020-05-11 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3783?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3783: -- Component/s: atlas-core > DSL query search should return results for b

Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions

2020-05-11 Thread Sarath Subramanian
#comment309328> why change ex.getMessage()? revert if not intended. - Sarath Subramanian On May 9, 2020, 1:13 a.m., chaitali wrote: > > --- > This is an automatically generated e-mail. To reply,

[jira] [Resolved] (ATLAS-3764) Set default value for "atlas.graph.index.search.max-result-set-size" in ApplicationProperties

2020-05-07 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian resolved ATLAS-3764. --- Resolution: Fixed > Set default value for "atlas.graph.index.search.max-re

[jira] [Commented] (ATLAS-3764) Set default value for "atlas.graph.index.search.max-result-set-size" in ApplicationProperties

2020-05-07 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101797#comment-17101797 ] Sarath Subramanian commented on ATLAS-3764: --- Thanks +1 for [^ATLAS-3764-3.patch] > Set defa

Re: Review Request 72441: Support solr in standalone (http) mode

2020-05-06 Thread Sarath Subramanian
apache.org/r/72441/ > --- > > (Updated April 29, 2020, 3:32 a.m.) > > > Review request for atlas, Ashutosh Mestry, Bolke de Bruin, madhan, and Sarath > Subramanian. > > > Repository: atlas > > > Description > --- > > Atlas does not support running Solr

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-06 Thread Sarath Subramanian
/EntitySearchProcessor.java Lines 369 (patched) <https://reviews.apache.org/r/72459/#comment309226> typo maybe? => 'return -1' - Sarath Subramanian On May 5, 2020, 3:11 p.m., Damian Warszawski wrote: > > --- > This is an automat

[jira] [Updated] (ATLAS-3777) Classic UI , Regression : On clicking tag filters , the dialog window says "No Attributes are available !"

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3777: -- Affects Version/s: 2.0.0 > Classic UI , Regression : On clicking tag filt

[jira] [Updated] (ATLAS-3777) Classic UI , Regression : On clicking tag filters , the dialog window says "No Attributes are available !"

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3777: -- Component/s: atlas-webui > Classic UI , Regression : On clicking tag filt

[jira] [Commented] (ATLAS-3777) Classic UI , Regression : On clicking tag filters , the dialog window says "No Attributes are available !"

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17098683#comment-17098683 ] Sarath Subramanian commented on ATLAS-3777: --- Thanks for the patch Keval. +1 > Classic

Re: Review Request 72464: ATLAS-3778: Improve performance during classification delete

2020-05-03 Thread Sarath Subramanian
--- Manually tested on delete classification with 400 classifications associated to entity. Performance improvement seen from 19 mins to 29 secs Thanks, Sarath Subramanian

[jira] [Updated] (ATLAS-3778) Improve performance during classification delete

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3778: -- Fix Version/s: 2.1.0 > Improve performance during classification del

[jira] [Updated] (ATLAS-3778) Improve performance during classification delete

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3778: -- Component/s: atlas-core > Improve performance during classification del

[jira] [Updated] (ATLAS-3778) Improve performance during classification delete

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3778: -- Affects Version/s: 2.0.0 > Improve performance during classification del

Review Request 72464: ATLAS-3778: Improve performance during classification delete

2020-05-03 Thread Sarath Subramanian
improvement seen from 19 mins to 29 secs Thanks, Sarath Subramanian

[jira] [Assigned] (ATLAS-3778) Improve performance during classification delete

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian reassigned ATLAS-3778: - Assignee: Sarath Subramanian > Improve performance during classification del

[jira] [Updated] (ATLAS-3778) Improve performance during classification delete

2020-05-03 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3778?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3778: -- Summary: Improve performance during classification delete (was: Improve performance

[jira] [Created] (ATLAS-3778) Improve performance when deleting classification from 'TRAIT_NAMES_PROPERTY_KEY' and 'PROPAGATED_TRAIT_NAMES_PROPERTY_KEY'

2020-05-03 Thread Sarath Subramanian (Jira)
Sarath Subramanian created ATLAS-3778: - Summary: Improve performance when deleting classification from 'TRAIT_NAMES_PROPERTY_KEY' and 'PROPAGATED_TRAIT_NAMES_PROPERTY_KEY' Key: ATLAS-3778 URL: https

Re: Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-05-01 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72458/#review220583 --- Ship it! Ship It! - Sarath Subramanian On May 1, 2020, 10

[jira] [Updated] (ATLAS-3748) UI: Add new UI feature into Classic UI

2020-04-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3748: -- Affects Version/s: 2.0.0 > UI: Add new UI feature into Classic

[jira] [Updated] (ATLAS-3748) UI: Add new UI feature into Classic UI

2020-04-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3748: -- Component/s: atlas-webui > UI: Add new UI feature into Classic

[jira] [Updated] (ATLAS-3748) UI: Add new UI feature into Classic UI

2020-04-24 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3748: -- Fix Version/s: 2.1.0 > UI: Add new UI feature into Classic

[jira] [Updated] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3747: -- Component/s: atlas-core > Atlas Admin Purge API should take list of guids as b

[jira] [Updated] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3747: -- Fix Version/s: 2.1.0 > Atlas Admin Purge API should take list of guids as b

[jira] [Updated] (ATLAS-3747) Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3747: -- Affects Version/s: 2.0.0 > Atlas Admin Purge API should take list of guids as b

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72411/#review220409 --- Ship it! Ship It! - Sarath Subramanian On April 21, 2020, 2

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as query param instead of body

2020-04-21 Thread Sarath Subramanian
erence: GlossaryRest:disassociateTermAssignmentFromEntities() - Sarath Subramanian On April 21, 2020, 1:22 p.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

[jira] [Commented] (ATLAS-3735) CustomAttributes: Conditionally Allow Setting of Values Larger than Default Length

2020-04-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088249#comment-17088249 ] Sarath Subramanian commented on ATLAS-3735: --- +1 > CustomAttributes: Conditionally Al

[jira] [Commented] (ATLAS-3735) CustomAttributes: Conditionally Allow Setting of Values Larger than Default Length

2020-04-20 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17088188#comment-17088188 ] Sarath Subramanian commented on ATLAS-3735: --- Review comments: # change 'return' to 'continue

[jira] [Updated] (ATLAS-3695) [Business Metadata] Special characters are being allowed in Attribute Name

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3695: -- Fix Version/s: 2.1.0 > [Business Metadata] Special characters are being allo

[jira] [Assigned] (ATLAS-3695) [Business Metadata] Special characters are being allowed in Attribute Name

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian reassigned ATLAS-3695: - Assignee: Mandar Ambawane > [Business Metadata] Special characters are be

[jira] [Updated] (ATLAS-3695) [Business Metadata] Special characters are being allowed in Attribute Name

2020-04-17 Thread Sarath Subramanian (Jira)
[ https://issues.apache.org/jira/browse/ATLAS-3695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarath Subramanian updated ATLAS-3695: -- Affects Version/s: 2.0.0 > [Business Metadata] Special characters are being allo

<    1   2   3   4   5   6   7   8   9   10   >