BasedExecutor.java
Lines 103 (patched)
<https://reviews.apache.org/r/73128/#comment311518>
can there be a case where query contains 'offset' and no 'limit' set?
- Sarath Subramanian
On Jan. 12, 2021, 3:49 p.m., Ashutosh Mestry wrote:
>
> -
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73058/#review222468
---
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 13, 2021, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73146/#review222492
---
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 15, 2021, 8
- Sarath Subramanian
On Jan. 15, 2021, 9:33 a.m., Deep Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73142/#review222460
---
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 13, 2021, 3
)
<https://reviews.apache.org/r/73058/#comment311500>
can we add a new section and examples for relationship search?
- Sarath Subramanian
On Jan. 12, 2021, 3:54 a.m., Pinal Shah wrote:
>
> ---
> This is an automatically g
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73140/#review222450
---
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 12, 2021, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73147/#review222541
---
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 31, 2021, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73169/#review222548
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 2, 2021, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73160/#review222551
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 3, 2021, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73170/#review222555
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 3, 2021, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73151/#review222534
---
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 21, 2021, 7
usage of this method (which needs
credstore provider path).
For fetching LDAP creds, you can pass the hadoop provider path explicitly.
- Sarath Subramanian
On Jan. 21, 2021, 7:58 a.m., Nixon Rodrigues
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73151/#review222538
---
Ship it!
Ship It!
- Sarath Subramanian
On Jan. 28, 2021, 7
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73394/#review223167
---
Ship it!
Ship It!
- Sarath Subramanian
On June 1, 2021, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73426/#review223168
---
Ship it!
Ship It!
- Sarath Subramanian
On June 16, 2021, 5
/job/Atlas/job/PreCommit-ATLAS-Build-Test/624/console
Manually verified lag information is updated correctly on metrics page and
periodically printed on log
Thanks,
Sarath Subramanian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73404/#review223135
---
Ship it!
Ship It!
- Sarath Subramanian
On June 8, 2021, 4
% perf imrpovement with this change.
Thanks,
Sarath Subramanian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73431/#review223182
---
Ship it!
Ship It!
- Sarath Subramanian
On June 22, 2021, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73341/#review222972
---
Ship it!
Ship It!
- Sarath Subramanian
On May 9, 2021, 6:09
type already contains inputs/outputs as relationship attribute.
This will possibly conflict with those attribute. Consider renaming
inputs/outputs
- Sarath Subramanian
On April 30, 2021, 12:39 a.m., Josh Yeh wrote:
>
> ---
> Thi
t;https://reviews.apache.org/r/73340/#comment312144>
probably longest method name seen in Atlas code :)
consider renaming to: cacheRelatedTermQNameGuid()
- Sarath Subramanian
On May 10, 2021, 12:52 p.m., Sidharth Mishra wrote:
>
> --
/AtlasGlossaryTerm.java
Lines 428 (patched)
<https://reviews.apache.org/r/73340/#comment312131>
avoid adding copy logic here to model class (AtlasGlossaryTerm) consider
moving to GlossaryTermUtils
- Sarath Subramanian
On May 8, 2021, 9:58 a.m., Sidharth Mishra
MsgTimestamp);
if (timestampDifference < minTimestamp) {
minTimestamp = timestampDifference;
ret = entityGuid;
}
}
return ret;
}
```
- Sarath Subramanian
On May 10, 2021, 10:22 p.m., Ashuto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73340/#review222984
---
Ship it!
Ship It!
- Sarath Subramanian
On May 12, 2021, 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73329/#review223021
---
Ship it!
Ship It!
- Sarath Subramanian
On May 20, 2021, 3
9/#comment312173>
dbRelationship => dbObject
webapp/src/main/java/org/apache/atlas/notification/preprocessor/HiveTableDDLPreprocessor.java
Lines 38 (patched)
<https://reviews.apache.org/r/73329/#comment312174>
tableObject
- Sarath Subramanian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73356/#review223020
---
Ship it!
Ship It!
- Sarath Subramanian
On May 14, 2021, 9
/atlas/glossary/GlossaryTermUtils.java
Lines 729 (patched)
<https://reviews.apache.org/r/73358/#comment312159>
"Invalid relationship specified for Term. Term cannot have a relationship
with self"
- Sarath Subramanian
On May 17, 2021, 10:45 p.m., Sidha
CACHE:
---
QName | Guid |
---
T1@cl1 | [7:00: guid1], [7:40: guid2]
---
6:50 - CTAS (T5) FROM T1 (guid1)
7:20 - CTAS (T6) FROM T1 (guid2)
- Sarath Subramanian
On May 17, 2021, 10:
rg/apache/atlas/web/rest/EntityREST.java
Lines 856 (patched)
<https://reviews.apache.org/r/73376/#comment312206>
this empty/null check may not be needed, we check this in
entitiesStore.addClassification() method. review and remove.
- Sarath Subramanian
On May 25, 2021, 5:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73292/#review223040
---
Ship it!
Ship It!
- Sarath Subramanian
On May 13, 2021, 8
:)
- Sarath Subramanian
On June 3, 2021, 7:23 a.m., Mandar Ambawane wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73376/#review223054
---
Ship it!
Ship It!
- Sarath Subramanian
On May 26, 2021, 11
types would
avoid this. Please review.
- Sarath Subramanian
On June 3, 2021, 2:52 p.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> http
-
>
> (Updated July 6, 2021, 9:28 p.m.)
>
>
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues,
> and Sarath Subramanian.
>
>
> Bugs: ATLAS-4347
> https://issues.apac
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73439/#review223207
---
Ship it!
Ship It!
- Sarath Subramanian
On July 6, 2021, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73445/#review223204
---
Ship it!
Ship It!
- Sarath Subramanian
On July 8, 2021, 3
o read:
List list = AtlasGraphUtilsV2.getEncodedProperty(edge, property,
List.class);
- Sarath Subramanian
On April 25, 2021, 8:29 p.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73258/#review222868
---
Ship it!
Ship It!
- Sarath Subramanian
On April 26, 2021, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73302/#review222869
---
Ship it!
Ship It!
- Sarath Subramanian
On April 26, 2021
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73296/#review222872
---
Ship it!
Ship It!
- Sarath Subramanian
On April 26, 2021, 4
queryBuilder.append("+").append(indexFieldName).append(attrValuePrefix).append(attributeValue).append("
");
```
- Sarath Subramanian
On April 29, 2021, 3:46 a.m., Pinal Shah wrote:
>
> ---
> This is an a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73310/#review222912
---
Ship it!
Ship It!
- Sarath Subramanian
On April 29, 2021
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73313/#review222913
---
Ship it!
Ship It!
- Sarath Subramanian
On April 29, 2021
is propagated to source entity to which term is
assigned and also to all downstream entities.
Also validated use case to create a new table from existing table (having term
with classification assigned), verified that classification propagated.
Thanks,
Sarath Subramanian
https://reviews.apache.org/r/73316/#review222917
---
On April 29, 2021, 9:01 p.m., Sarath Subramanian wrote:
>
> ---
> This is an automatically generated e-ma
/Atlas/job/PreCommit-ATLAS-Build-Test/532/console
Manually validated in circular lineage
Thanks,
Sarath Subramanian
://reviews.apache.org/r/73316/diff/1/
Testing
---
Precommit:
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/532/console
Manually validated in circular lineage
Thanks,
Sarath Subramanian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72933/#review222850
---
Ship it!
Ship It!
- Sarath Subramanian
On April 22, 2021, 8
ipEdge,
PENDING_TASKS_PROPERTY_KEY, List.class);
if (taskIds == null) {
taskIds = new ArrayList();
}
taskIds.add(task.getGuid())
AtlasGraphUtilsV2.addEncodedProperty(relationshipEdge,
PENDING_TASKS_PROPERTY_KEY, taskIds);
- Sarath Subramanian
On April 23, 2021, 10:05 a.m., Ashutosh
skGuid());
- Sarath Subramanian
On April 23, 2021, 10:05 a.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
ckward compatability for existing usage of methods)
- Sarath Subramanian
On April 23, 2021, 6:59 a.m., Deep Singh wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
reviews.apache.org/r/73258/#comment312013>
getVertexAttributeIgnoreInactive => getVertexAttributeIgnoreDeleted
- Sarath Subramanian
On April 23, 2021, 6:59 a.m., Deep Singh wrote:
>
> ---
> This is an automatically generat
apache/atlas/glossary/GlossaryTermUtils.java
Line 646 (original), 666 (patched)
<https://reviews.apache.org/r/73304/#comment312071>
nit: add space between if and open braces:
else if (!populateRelations)
- Sarath Subramanian
On April 27, 2021, 2:20 p.m., Sidharth
= true;
}
repository/src/main/java/org/apache/atlas/glossary/GlossaryService.java
Lines 1186 (patched)
<https://reviews.apache.org/r/73304/#comment312073>
this method is unused, please review remove.
- Sarath Subramanian
On April 27, 2021, 6:30 p.m., Sidharth
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73304/#review222903
---
Ship it!
Ship It!
- Sarath Subramanian
On April 28, 2021, 6
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73176/#review222576
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 8, 2021, 1
-
>
> (Updated Jan. 25, 2021, 3:08 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte,
> Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3919
> https://issues.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73179/#review222580
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 8, 2021, 11
saving an
already assigned 'Term'.
- Sarath Subramanian
On Feb. 10, 2021, 5 a.m., Mandar Ambawane wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
/GlossaryService.java
Lines 1055 (patched)
<https://reviews.apache.org/r/73181/#comment311697>
why qualifiedName needs to be sent back? if 'duplicateTermHeaders' has any
value then this confirms the terms are duplicated? Please review.
- Sarath Subramanian
On Feb. 10, 2021, 5 a.m., Mandar Ambawane
', value='{}'", qualifiedName, operator, attributeValue);
}
}
return ret;
}
repository/src/test/java/org/apache/atlas/discovery/AtlasDiscoveryServiceTest.java
Lines 32 (patched)
<https://reviews.apache.org/r/73160/#comment311644>
nit: review/remove
. To reply, visit:
> https://reviews.apache.org/r/73239/
> -----------
>
> (Updated March 22, 2021, 10:23 a.m.)
>
>
> Review request for atlas, Madhan Neethiraj and Sarath Subramanian.
>
>
> Bugs: ATLAS-420
_index
- Sarath Subramanian
On April 1, 2021, 3:52 a.m., chaitali wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
configurable collection
names. Please review.
- Sarath Subramanian
On April 1, 2021, 3:52 a.m., chaitali wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
> On April 1, 2021, 4:12 p.m., Sarath Subramanian wrote:
> >
Add Unit test coverage with example of circular relationship import.
- Sarath
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apa
s => processRelations
- Sarath Subramanian
On March 31, 2021, 3:44 p.m., Sidharth Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
/utils/AtlasPathExtractorUtil.java
Line 220 (original), 234 (patched)
<https://reviews.apache.org/r/73261/#comment311933>
is this intentional change in aws?
- Sarath Subramanian
On March 30, 2021, 4:37 p.m., Sidharth Mishra
views.apache.org/r/73257/#comment311932>
review all "string" type attributes to enable isIndexable -> true
- Sarath Subramanian
On March 30, 2021, 5:09 p.m., Sidharth Mishra wrote:
>
> ---
> This is an automat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73257/#review222755
---
Ship it!
Ship It!
- Sarath Subramanian
On March 30, 2021, 5
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73261/#review222756
---
Ship it!
Ship It!
- Sarath Subramanian
On March 30, 2021, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73218/#review222768
---
Ship it!
Ship It!
- Sarath Subramanian
On March 31, 2021, 3
and check for glossaryTerm.containsRelationship() in caller (line# 1153)
- Sarath Subramanian
On April 2, 2021, 11:49 a.m., Sidharth Mishra wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://revie
Vertex,
PENDING_TASKS_PROPERTY_KEY, taskGuid);
- Sarath Subramanian
On March 10, 2021, 10:49 p.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
; https://reviews.apache.org/r/73076/
> ---
>
> (Updated March 10, 2021, 10:49 p.m.)
>
>
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte,
> Nixon Rodrigues, and Sarath Subramanian.
>
>
> Bugs: ATLAS-3919
> https://issues.apache.org
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73231/#review222688
---
Ship it!
Ship It!
- Sarath Subramanian
On March 16, 2021
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73233/#review222705
---
Ship it!
Ship It!
- Sarath Subramanian
On March 18, 2021, 8
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73248/#review222726
---
Ship it!
Ship It!
- Sarath Subramanian
On March 21, 2021
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73244/#review222720
---
Ship it!
Ship It!
- Sarath Subramanian
On March 18, 2021, 9
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73233/#review222696
---
Ship it!
Ship It!
- Sarath Subramanian
On March 17, 2021
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73229/#review222697
---
Ship it!
Ship It!
- Sarath Subramanian
On March 15, 2021, 5
.java
Lines 199 (patched)
<https://reviews.apache.org/r/73076/#comment311822>
REPORT_FREQUENCEY => REPORT_FREQUENCY
- Sarath Subramanian
On Feb. 25, 2021, 10:08 p.m., Ashutosh Mestry wrote:
>
> ---
> This is an autom
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73076/#review222659
---
Ship it!
Ship It!
- Sarath Subramanian
On March 8, 2021, 10
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73218/#review222784
---
Ship it!
Ship It!
- Sarath Subramanian
On April 6, 2021, 9
ilter can be specific to hive, consider renaming to
'HiveEntityFilter'
- Sarath Subramanian
On April 2, 2021, 9:18 a.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated e-ma
Please checkout REST API doc - http://atlas.apache.org/api/v2/index.html
There are APIs to bulk add classifications to entity.
Thanks,
Sarath
On Wed, Apr 7, 2021 at 11:08 AM Madhan lal wrote:
> Hi
> I would like to know if it is possible to add a list of new classifications
> or Tags
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73239/#review222801
---
Ship it!
Ship It!
- Sarath Subramanian
On April 9, 2021, 4
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73275/#review222798
---
Ship it!
Ship It!
- Sarath Subramanian
On April 9, 2021, 2
7 (patched)
<https://reviews.apache.org/r/73239/#comment311973>
unused method - review and remove.
intg/src/main/java/org/apache/atlas/utils/AtlasJson.java
Lines 161 (patched)
<https://reviews.apache.org/r/73239/#comment311974>
unused method.
- Sarath Subramanian
On April 9, 2021, 2:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73176/#review222597
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 16, 2021, 12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73182/#review222598
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 15, 2021, 11
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73181/#review222599
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 10, 2021, 5
g/r/73185/#comment311716>
consider adding to 'lastCommittedPartitionOffset' after successful commit.
=> move line 920 after 921.
- Sarath Subramanian
On Feb. 17, 2021, 11:12 a.m., Ashuto
java/org/apache/atlas/tasks/TaskManagement.java
Lines 89 (patched)
<https://reviews.apache.org/r/73076/#comment311738>
this method dispatches all taskDefs, consider renaming to "dispatchAllTasks"
- Sarath Subramanian
On Feb.
/v2/EntityGraphMapper.java
Lines 2780 (patched)
<https://reviews.apache.org/r/73076/#comment311731>
the taskDef guid should be removed from
CLASSIFICATION_VERTEX_PENDING_PROPAGATIONS_KEY in classification vertex once
the deferred action is complete. Please review.
- Sarath Subra
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73193/#review222616
---
Ship it!
Ship It!
- Sarath Subramanian
On Feb. 18, 2021, 6
"classificationVertexIds" => "classificationVertexId"
- Sarath Subramanian
On Feb. 11, 2021, 11:12 a.m., Ashutosh Mestry wrote:
>
> ---
> This is an automatically generated
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73529/#review223356
---
Ship it!
Ship It!
- Sarath Subramanian
On Aug. 18, 2021, 2
801 - 900 of 2302 matches
Mail list logo
