Re: Review Request 72994: ATLAS-4010: Sort properties lexicographically in pom.xml for readability

2020-10-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72994/#review222145 --- distro/pom.xml Line 51 (original), 39 (patched)

Re: Review Request 72993: Cache getGuid and getStatus in GraphTransactionInterceptor

2020-10-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72993/#review222139 ---

Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-27 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72991/ --- Review request for atlas, Nikhil Bonte and Sarath Subramanian. Summary

Re: Review Request 72988: ATLAS-3427: pom updates to fix duplicate definition of log4j.version

2020-10-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72988/#review222123 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 23, 2020, 9:03

Re: Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

2020-10-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72987/#review222121 --- Ship it! Can you please add per-commit build details. -

Re: Review Request 72893: ATLAS-3427: Hook Enhancements for Improved Resiliency

2020-10-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72893/ --- (Updated Oct. 22, 2020, 9:05 p.m.) Review request for atlas, Deep Singh,

Re: Review Request 72893: ATLAS-3427: Hook Enhancements for Improved Resiliency

2020-10-21 Thread Ashutosh Mestry via Review Board
> On Oct. 20, 2020, 6:59 p.m., Sarath Subramanian wrote: > > notification/src/main/java/org/apache/atlas/notification/spool/IndexManagement.java > > Lines 59 (patched) > > > > > > consider replacing exceptions in

Re: Review Request 72893: ATLAS-3427: Hook Enhancements for Improved Resiliency

2020-10-21 Thread Ashutosh Mestry via Review Board
> On Oct. 20, 2020, 7:19 p.m., Madhan Neethiraj wrote: > > notification/src/main/java/org/apache/atlas/notification/spool/IndexManagement.java > > Lines 351 (patched) > > > > > > Exception

Re: Review Request 72893: ATLAS-3427: Hook Enhancements for Improved Resiliency

2020-10-14 Thread Ashutosh Mestry via Review Board
> On Oct. 12, 2020, 7:21 a.m., Madhan Neethiraj wrote: > > notification/src/main/java/org/apache/atlas/notification/LogConfigUtils.java > > Lines 48 (patched) > > > > > > Atlas log4j configuration is likely to have

Re: Review Request 72937: ATLAS-3971 :- Move authorization check for Business Metadata def before type exist check

2020-10-06 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72937/#review221998 --- Ship it! Ship It! - Ashutosh Mestry On Oct. 7, 2020, 5:15

Re: Review Request 72932: ATLAS-3964: Fix for regression caused by earlier patch

2020-10-05 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72932/#review221994 --- LGTM. I will let Keval review it. Perhaps there is some JS where

Re: Review Request 72920: ATLAS-3965:Relationships with null values are missing in entity relationshipAttributes

2020-10-01 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72920/#review221982 --- Ship it! This seems to be fine: MyClass aClass = null;

Re: Review Request 72636: NotificationHookConsumer: Concurrent Message Processing

2020-08-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72636/ --- (Updated Aug. 3, 2020, 11:18 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-31 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 31, 2020, 3:57 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-31 Thread Ashutosh Mestry via Review Board
> On July 30, 2020, 11:58 p.m., Sarath Subramanian wrote: > > good memory improvement fix! Thanks! - Ashutosh --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/#review221431

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 30, 2020, 10:58 p.m.) Review request for atlas, Madhan

Re: Review Request 72722: Index Consistency: Java Patch Handler Implementation

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72722/ --- (Updated July 30, 2020, 10:49 p.m.) Review request for atlas, Damian

Re: Review Request 72722: Index Consistency: Java Patch Handler Implementation

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72722/ --- (Updated July 30, 2020, 8:45 p.m.) Review request for atlas, Damian

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 30, 2020, 5:55 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72722: Index Consistency: Java Patch Handler Implementation

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72722/ --- (Updated July 30, 2020, 5:42 p.m.) Review request for atlas, Damian

Review Request 72722: Index Consistency: Java Patch Handler Implementation

2020-07-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72722/ --- Review request for atlas, Damian Warszawski, Madhan Neethiraj, Nikhil Bonte,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-29 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 9:16 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java > > Lines 409 (patched) > > > > > > should we reset/clear these

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-29 Thread Ashutosh Mestry via Review Board
> On July 24, 2020, 7:14 a.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java > > Lines 67 (patched) > > > > > > incrementCapacityBy is already an instance member, line #29

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 29, 2020, 6:23 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 9:28 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Line 39 (original), 39 (patched) > > > > > > We will need to

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-24 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 4:52 a.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/repository/patches/ConcurrentPatchProcessor.java > > Lines 44 (patched) > > > > > > I suggest use AtlasConfiguration

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 24, 2020, 5:18 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221338 ---

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 23, 2020, 6:48 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-23 Thread Ashutosh Mestry via Review Board
> On July 23, 2020, 5:59 p.m., Sarath Subramanian wrote: > > intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java > > Lines 33 (patched) > > > > > > ArrayList => List I would prefer to keep it buffer since

Review Request 72703: Import Service: UpdateVertexGuid Now Makes Updates to AtlasEntityWithExtInfo

2020-07-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72703/ --- Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221323 ---

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
> On July 21, 2020, 8:38 p.m., Ashutosh Mestry wrote: > > Here's what I have tried so far: > > - Concurrent entity creation using my own test rig. This creates entities > > concurrently but it does not allow for entity with same qualifiedName to be > > created by different workers. > > -

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
> On July 22, 2020, 4:30 p.m., Ashutosh Mestry wrote: > > I attempted to create same entity (entity with same qualifiedName) from > > multiple requests. > > > > I did this experiment: > > - Created an entity payload. > > - Used bulk entity CURL calls from 5 different requests. > > > >

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221314 --- I attempted to create same entity (entity with same

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-22 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 22, 2020, 4:16 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-22 Thread Ashutosh Mestry via Review Board
> On July 20, 2020, 10:54 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Line 649 (original), 662 (patched) > > > > > > Consider replacing this

Re: Review Request 72695: Optional configuration to support locks on JanusGraph to ensure data consitency.

2020-07-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72695/#review221296 --- Here's what I have tried so far: - Concurrent entity creation

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 20, 2020, 11:46 p.m.) Review request for atlas, Madhan

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221273 ---

Re: Review Request 72636: NotificationHookConsumer: Concurrent Message Processing

2020-07-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72636/ --- (Updated July 20, 2020, 10:44 p.m.) Review request for atlas, Nikhil Bonte,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-13 Thread Ashutosh Mestry via Review Board
> On July 10, 2020, 8:11 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/utils/FixedBufferList.java > > Lines 38 (patched) > > > > > > 'bufferElementClass' can be derived from the generic, as

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 13, 2020, 7:45 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-10 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 10, 2020, 4:43 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72666: Notification: Solution to Memory Build-up

2020-07-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- (Updated July 9, 2020, 6:17 p.m.) Review request for atlas, Madhan Neethiraj,

Review Request 72666: Notification: Solution to Memory Build-up

2020-07-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72666/ --- Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-06 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72638/#review221139 ---

Re: Review Request 72636: NotificationHookConsumer: Concurrent Message Processing

2020-07-06 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72636/ --- (Updated July 6, 2020, 5:23 p.m.) Review request for atlas, Nikhil Bonte,

Review Request 72636: NotificationHookConsumer: Concurrent Message Processing

2020-07-01 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72636/ --- Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.

Re: Review Request 72619: ATLAS-3863: Avoid re-evaluating tag propagation when deleting relationship (edge)

2020-06-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72619/#review221066 ---

Re: Review Request 72527: Refactoring Kafka JAAS Configuration

2020-05-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72527/#review220830 ---

Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions

2020-05-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72474/#review220788 --- Ship it! Is this change needed at all? What is implemented is

Re: Review Request 72512: Edge Creation: Refactoring

2020-05-15 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72512/ --- (Updated May 15, 2020, 5:19 p.m.) Review request for atlas. Changes ---

Re: Review Request 72512: Edge Creation: Refactoring

2020-05-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72512/ --- (Updated May 14, 2020, 10:41 p.m.) Review request for atlas. Changes ---

Re: Review Request 72512: Edge Creation: Refactoring

2020-05-14 Thread Ashutosh Mestry via Review Board
> On May 14, 2020, 6:44 p.m., Sidharth Mishra wrote: > > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusGraph.java > > Lines 183 (patched) > > > > > > Kindly change this to somthing

Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions

2020-05-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72474/#review220769 ---

Review Request 72512: Edge Creation: Refactoring

2020-05-14 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72512/ --- Review request for atlas. Bugs: ATLAS-3797

Re: Review Request 72474: ATLAS-3783 : DSL query search should return results for both the relationship edge directions

2020-05-11 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72474/#review220706 ---

Re: Review Request 72486: ATLAS-3680 : Change 'Status' from Classification System Attributes to EntityStatus

2020-05-08 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72486/#review220698 ---

Re: Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-05-01 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72458/ --- (Updated May 1, 2020, 5:18 p.m.) Review request for atlas, Madhan Neethiraj,

Review Request 72458: Shadow Attributes Update Post-Migration from 0.8

2020-04-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72458/ --- Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and

Re: Review Request 72452: Efficiently Searching for Edges Between Vertices

2020-04-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72452/ --- (Updated April 30, 2020, 4:04 a.m.) Review request for atlas, Madhan

Re: Review Request 72452: Efficiently Searching for Edges Between Vertices

2020-04-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72452/ --- (Updated April 29, 2020, 9:17 p.m.) Review request for atlas, Madhan

Re: Review Request 72452: Efficiently Searching for Edges Between Vertices

2020-04-29 Thread Ashutosh Mestry via Review Board
> On April 29, 2020, 7:57 p.m., Sidharth Mishra wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasRelationshipStoreV2.java > > Lines 780 (patched) > > > > > > Just thinking the

Review Request 72452: Efficiently Searching for Edges Between Vertices

2020-04-29 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72452/ --- Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues,

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72384/ --- (Updated April 24, 2020, 8:10 p.m.) Review request for atlas, Madhan

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-24 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72384/ --- (Updated April 24, 2020, 5 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-23 Thread Ashutosh Mestry via Review Board
> On April 22, 2020, 11:39 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > > Lines 1032 (patched) > > > > > > Processing

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-23 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72384/ --- (Updated April 23, 2020, 3:22 p.m.) Review request for atlas, Madhan

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-23 Thread Ashutosh Mestry via Review Board
> On April 22, 2020, 11:39 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > > Lines 1032 (patched) > > > > > > Processing

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-21 Thread Ashutosh Mestry via Review Board
> On April 19, 2020, 11:39 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasGraphUtilsV2.java > > Line 272 (original), 272 (patched) > > > > > > It seems

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72384/ --- (Updated April 22, 2020, 4:58 a.m.) Review request for atlas, Madhan

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-21 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72384/ --- (Updated April 21, 2020, 10:33 p.m.) Review request for atlas, Madhan

Re: Review Request 72384: Refactoring: Support multiple instances of AtlasGraph

2020-04-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72384/ --- (Updated April 20, 2020, 5:50 a.m.) Review request for atlas, Madhan

Re: Review Request 72330: ATLAS-3715: Improve Performance of Primitive Attribute Assignment

2020-04-07 Thread Ashutosh Mestry via Review Board
> On April 7, 2020, 5:42 p.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java > > Lines 1068 (patched) > > > > > > Not populating uniqPropName

Review Request 72330: ATLAS-3715: Improve Performance of Primitive Attribute Assignment

2020-04-07 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72330/ --- Review request for atlas, Madhan Neethiraj, Nikhil Bonte, and Nixon Rodrigues.

Re: Review Request 72300: ATLAS-3696 : [Business Metadata] No option to check/uncheck Business Metadata field in search results

2020-04-07 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72300/#review220240 ---

Re: Review Request 72287: Edge Creation Improvements

2020-04-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72287/ --- (Updated April 2, 2020, 6:14 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72287: Edge Creation Improvements

2020-04-02 Thread Ashutosh Mestry via Review Board
> On April 2, 2020, 5:39 a.m., Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java > > Lines 344 (patched) > > > > > > edgeLabel is typicallu used to

Re: Review Request 72287: Edge Creation Improvements

2020-04-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72287/ --- (Updated April 2, 2020, 3:27 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72294: ATLAS-3712: Add 'isAppendOnPartialUpdate' option in ML model to append updates

2020-03-31 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72294/#review220159 --- Ship it! Ship It! - Ashutosh Mestry On March 31, 2020, 7:47

Review Request 72287: Edge Creation Improvements

2020-03-30 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72287/ --- Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and

Re: Review Request 72235: ZipFileMigrator: Automatic Resume During Migration

2020-03-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72235/ --- (Updated March 13, 2020, 9:56 p.m.) Review request for atlas, Nikhil Bonte,

Review Request 72235: ZipFileMigrator: Automatic Resume During Migration

2020-03-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72235/ --- Review request for atlas, Nikhil Bonte, Nixon Rodrigues, and Sarath Subramanian.

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-05 Thread Ashutosh Mestry via Review Board
> On March 5, 2020, 9:30 a.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/repository/graph/IFullTextMapper.java > > Lines 34 (patched) > > > > > > methods defined here looks more of like

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-05 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/ --- (Updated March 5, 2020, 5:43 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-04 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/ --- (Updated March 5, 2020, 6:09 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-03 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/ --- (Updated March 4, 2020, 6:30 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/ --- (Updated March 3, 2020, 5:13 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-03-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review219725 --- Ship it! Fix it. - Ashutosh Mestry On Feb. 26, 2020, 9:21

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-03-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/ --- (Updated March 2, 2020, 6:57 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72177: Import Service: Support zipDirect Format

2020-03-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72177/ --- (Updated March 2, 2020, 6:18 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-03-02 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review219723 --- repository/src/test/java/org/apache/atlas/TestModules.java Line

Review Request 72180: PC Framework: Add Status Reporting

2020-02-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72180/ --- Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and

Re: Review Request 72177: Import Service: Support zipDirect Format

2020-02-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72177/ --- (Updated Feb. 28, 2020, 9:52 p.m.) Review request for atlas, Madhan Neethiraj,

Review Request 72177: Import Service: Support zipDirect Format

2020-02-28 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72177/ --- Review request for atlas, Madhan Neethiraj, Nikhil Bonte, Nixon Rodrigues, and

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-02-19 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/ --- (Updated Feb. 20, 2020, 4:53 a.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 71025: Import Service: Support Concurrent Ingest

2020-02-17 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71025/ --- (Updated Feb. 17, 2020, 5:54 p.m.) Review request for atlas, Madhan Neethiraj,

Re: Review Request 72117: ATLAS-3613: updated search to support namespace attributes

2020-02-16 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72117/#review219597 --- Ship it! Can you please add examples for DSL and Basic Search

Re: Review Request 72039: ATLAS-3595, ATLAS-3603 Migration import: support zip file for data migration

2020-02-13 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72039/#review219586 --- Ship it! Ship It! - Ashutosh Mestry On Feb. 13, 2020, 1:02

  1   2   >