[jira] [Assigned] (ATLAS-4103) While listing Purge operation records in Administration-Audits, shows 'Something went wrong' message

2021-01-14 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4103:
--

Assignee: Mandar Ambawane

> While listing Purge operation records in Administration-Audits, shows 
> 'Something went wrong' message
> 
>
> Key: ATLAS-4103
> URL: https://issues.apache.org/jira/browse/ATLAS-4103
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: Something_went_wrong_for_purge_operation_listing.png
>
>
> Steps to Reproduce ::
>  # Soft delete/Purge any entity (purged through postman)
>  # Go to Administration-Audits tab to see the above record
>  # In Filter select Operation(atlas_operation)=Purge
> Expected: The deleted entity details should have listed
> Actual: Shows 'Something went wrong' message on UI and console shows '500 
> Internal Server Error'



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73115: ATLAS-4069 Export/Importing a recreated deleted entity has the relationshipStatus set to ACTIVE instead of DELETED for deleted entity

2021-01-07 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73115/
---

(Updated Jan. 7, 2021, 12:42 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-4069
https://issues.apache.org/jira/browse/ATLAS-4069


Repository: atlas


Description
---

In method DeleteHandlerV1.deleteVertex()
Currently code fetches only Incoming edges of the Vertex to be deleted.

This patch does the following

1. Fetches all the Outgoing edges of the Vertex.
2. Iterates on each edge and then fetches the Vertex on the other side of the 
edge (InVertex)
3. It checks the status of that particular vertex.
4. If that vertex is already deleted then only the current edge goes for soft 
deletion.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 7b2e2d3 


Diff: https://reviews.apache.org/r/73115/diff/2/

Changes: https://reviews.apache.org/r/73115/diff/1-2/


Testing
---

Manual Testing is done.

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/291/console


Thanks,

Mandar Ambawane



Re: Review Request 73115: ATLAS-4069 Export/Importing a recreated deleted entity has the relationshipStatus set to ACTIVE instead of DELETED for deleted entity

2021-01-06 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73115/
---

(Updated Jan. 7, 2021, 7:05 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-4069
https://issues.apache.org/jira/browse/ATLAS-4069


Repository: atlas


Description
---

In method DeleteHandlerV1.deleteVertex()
Currently code fetches only Incoming edges of the Vertex to be deleted.

This patch does the following

1. Fetches all the Outgoing edges of the Vertex.
2. Iterates on each edge and then fetches the Vertex on the other side of the 
edge (InVertex)
3. It checks the status of that particular vertex.
4. If that vertex is already deleted then only the current edge goes for soft 
deletion.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
 7b2e2d3 


Diff: https://reviews.apache.org/r/73115/diff/1/


Testing
---

Manual Testing is done.

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/291/console


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-4092) Remove unused attributes and add right attributes to the atlas admin audit api

2021-01-06 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4092:
---
Attachment: ATLAS-4092.patch

> Remove unused attributes and add right attributes to the atlas admin audit api
> --
>
> Key: ATLAS-4092
> URL: https://issues.apache.org/jira/browse/ATLAS-4092
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4092.patch
>
>
> {code:java|title=Sample payload:}
> {
>   "currentPage": "page",
>   "pageSize": "per_page",
>   "totalPages": "total_pages",
>   "totalRecords": "total_entries",
>   "sortKey": "sort_by",
>   "order": "order",
>   "directions": {
> "1": "desc",
> "-1": "asc"
>   },
>   "auditFilters": {
> "condition": "AND",
> "criterion": [
>   {
> "attributeName": "operation",
> "operator": "eq",
> "attributeValue": "TYPE_DEF_CREATE"
>   }
> ]
>   },
>   "limit": 25,
>   "offset": 0
> }
> {code}
> Here the following attributes do not work:
> {code}
> "sortKey": "sort_by",
> "order": "order",
> {code}
> Instead the following works
> {code}
> "sortBy" : "startTime",
> "sortOrder" : "DESCENDING",
> {code}
> sortKey and order has to be removed and sortBy and sortOrder has to be added



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4092) Remove unused attributes and add right attributes to the atlas admin audit api

2021-01-06 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4092?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4092:
---
Attachment: (was: ATLAS-4092.patch)

> Remove unused attributes and add right attributes to the atlas admin audit api
> --
>
> Key: ATLAS-4092
> URL: https://issues.apache.org/jira/browse/ATLAS-4092
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
>
> {code:java|title=Sample payload:}
> {
>   "currentPage": "page",
>   "pageSize": "per_page",
>   "totalPages": "total_pages",
>   "totalRecords": "total_entries",
>   "sortKey": "sort_by",
>   "order": "order",
>   "directions": {
> "1": "desc",
> "-1": "asc"
>   },
>   "auditFilters": {
> "condition": "AND",
> "criterion": [
>   {
> "attributeName": "operation",
> "operator": "eq",
> "attributeValue": "TYPE_DEF_CREATE"
>   }
> ]
>   },
>   "limit": 25,
>   "offset": 0
> }
> {code}
> Here the following attributes do not work:
> {code}
> "sortKey": "sort_by",
> "order": "order",
> {code}
> Instead the following works
> {code}
> "sortBy" : "startTime",
> "sortOrder" : "DESCENDING",
> {code}
> sortKey and order has to be removed and sortBy and sortOrder has to be added



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4092) Remove unused attributes and add right attributes to the atlas admin audit api

2021-01-05 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-4092:
--

 Summary: Remove unused attributes and add right attributes to the 
atlas admin audit api
 Key: ATLAS-4092
 URL: https://issues.apache.org/jira/browse/ATLAS-4092
 Project: Atlas
  Issue Type: Improvement
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane


{code:java|title=Sample payload:}
{
  "currentPage": "page",
  "pageSize": "per_page",
  "totalPages": "total_pages",
  "totalRecords": "total_entries",
  "sortKey": "sort_by",
  "order": "order",
  "directions": {
"1": "desc",
"-1": "asc"
  },
  "auditFilters": {
"condition": "AND",
"criterion": [
  {
"attributeName": "operation",
"operator": "eq",
"attributeValue": "TYPE_DEF_CREATE"
  }
]
  },
  "limit": 25,
  "offset": 0
}
{code}
Here the following attributes do not work:
{code}
"sortKey": "sort_by",
"order": "order",
{code}

Instead the following works
{code}
"sortBy" : "startTime",
"sortOrder" : "DESCENDING",
{code}

sortKey and order has to be removed and sortBy and sortOrder has to be added



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73022: ATLAS-4032 Filter group option in the Admin Audit tab is not giving the expected output

2020-12-13 Thread Mandar Ambawane


> On Dec. 10, 2020, 8:01 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
> > Lines 192 (patched)
> > <https://reviews.apache.org/r/73022/diff/1/?file=2241987#file2241987line206>
> >
> > include invalid attribute name in error code message

Hi Sarath, this error is thrown when the name of attribute is not found (null)


> On Dec. 10, 2020, 8:01 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
> > Lines 194 (patched)
> > <https://reviews.apache.org/r/73022/diff/1/?file=2241987#file2241987line208>
> >
> > include invalid operator in error code message

Hi Sarath, this error is thrown when the operator of attribute is not found 
(null)


> On Dec. 10, 2020, 8:01 p.m., Sarath Subramanian wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
> > Lines 196 (patched)
> > <https://reviews.apache.org/r/73022/diff/1/?file=2241987#file2241987line210>
> >
> > include invalid attribute value in error code message

Hi Sarath, this error is thrown when the value of attribute is not found (null)


- Mandar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73022/#review222320
---


On Nov. 19, 2020, 4:06 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73022/
> ---
> 
> (Updated Nov. 19, 2020, 4:06 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4032
> https://issues.apache.org/jira/browse/ATLAS-4032
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> In the existing code we are not including the Inner Criterias of the Filter.
> 
> Also the Condition of the Outer filter was getting applied to the Inner 
> Filters groups.
> 
> In this patch, code refactoring is done. The code which populate the Filter 
> Criteria is now removed.
> 
> Instead of doing it from Server end, This patch keeps the Filter Criteria in 
> the same format which UI has sent.
> 
> Additionally this patch provides validation for the Filter Criteria 
> 1.Attribute Name 2. Attribute Value and 3.Operator
> This validation goes until the last level of the Inner Filter Criterias.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa9 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  d843204 
> 
> 
> Diff: https://reviews.apache.org/r/73022/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing is done for the scenarios where Filter Groups are included.
> 
> Earlier it was not giving expected search result.
> 
> With this patch we can get the expected result in the Admin Audit Search.
> 
> PreCommit: 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/203/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 73072: ATLAS-4065 TYPE_DEF_UPDATE audit does not reflect the right values

2020-12-13 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73072/
---

(Updated Dec. 14, 2020, 3:34 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-4065
https://issues.apache.org/jira/browse/ATLAS-4065


Repository: atlas


Description
---

This issue is coming from the Atlas Framework itself.

For every TypeDef Create operation there is subsequent Update call.

Similarly for every TypeDef Update operation there is subsequent Update call.

Some attributes are not getting set in the first Create / Update call of the 
TypeDef. Instead, they are getting set in the subsequent Update call.

This patch handles all these scenarios.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 4fe9f59 


Diff: https://reviews.apache.org/r/73072/diff/2/

Changes: https://reviews.apache.org/r/73072/diff/1-2/


Testing
---


Thanks,

Mandar Ambawane



[jira] [Assigned] (ATLAS-4070) hive_column_lineage .json and impala_column_lineage .json files are missing in /admin/export zip file

2020-12-09 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4070:
--

Assignee: Mandar Ambawane

> hive_column_lineage .json and impala_column_lineage .json files 
> are missing in /admin/export zip file
> -
>
> Key: ATLAS-4070
> URL: https://issues.apache.org/jira/browse/ATLAS-4070
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Umesh Padashetty
>Assignee: Mandar Ambawane
>Priority: Major
>
> Currently hive_column_lineage .json and impala_column_lineage 
> .json files are missing in /admin/export zip file. 
> It is to be noted that spark_column_lineage .json is getting created 
> fine
> But the important thing to note is, even though the hive_column_lineage 
> .json and impala_column_lineage .json files are missing in 
> /admin/export zip file, the hive_column_lineage and impala_column_lineage is 
> getting imported to the target cluster properly.
> In the HDP world, we used to create the file hive_column_lineage .json, 
> but we are no more creating it. Wanted to check if this is expected behaviour.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4069) Export/Importing a recreated deleted entity has the relationshipStatus set to ACTIVE instead of DELETED for deleted entity

2020-12-09 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4069?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4069:
--

Assignee: Mandar Ambawane  (was: Ashutosh Mestry)

> Export/Importing a recreated deleted entity has the relationshipStatus set to 
> ACTIVE instead of DELETED for deleted entity
> --
>
> Key: ATLAS-4069
> URL: https://issues.apache.org/jira/browse/ATLAS-4069
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: 2.1.0
>Reporter: Umesh Padashetty
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: Screenshot 2020-12-09 at 5.51.10 PM.png
>
>
> Run the below queries:
>  # create database IF NOT EXISTS database34_${var:rand_str};
>  # create table IF NOT EXISTS 
> database34_${var:rand_str}.table_${var:rand_str}_34(id int,name string,dob 
> date);
>  # drop table database34_${var:rand_str}.table_${var:rand_str}_34;
>  # drop database database34_${var:rand_str};
>  # create database IF NOT EXISTS database34_${var:rand_str};
>  # create table IF NOT EXISTS 
> database34_${var:rand_str}.table_${var:rand_str}_34(id int,name string,dob 
> date);
> As you can see, create a database/table, followed by drop statements, and 
> then recreated them.
> Hence, there are 2 entities with same name, but the state is different (1 is 
> ACTIVE, 1 is DELETED).
> Text compare:  !Screenshot 2020-12-09 at 5.51.10 PM.png|width=799,height=134!
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4065) TYPE_DEF_UPDATE audit does not reflect the right values

2020-12-08 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4065:
---
Attachment: ATLAS-4065.patch

> TYPE_DEF_UPDATE audit does not reflect the right values
> ---
>
> Key: ATLAS-4065
> URL: https://issues.apache.org/jira/browse/ATLAS-4065
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4065.patch
>
>
> 1) Create a type as user_1 and update it as user_2
> The update audit should reflects user_2 in the update audit
> userName field reflects the right value but the result field displays the 
> incorrect value
> 2) There is a mismatch in the Version



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 73072: ATLAS-4065 TYPE_DEF_UPDATE audit does not reflect the right values

2020-12-08 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73072/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4065
https://issues.apache.org/jira/browse/ATLAS-4065


Repository: atlas


Description
---

This issue is coming from the Atlas Framework itself.

For every TypeDef Create operation there is subsequent Update call.

Similarly for every TypeDef Update operation there is subsequent Update call.

Some attributes are not getting set in the first Create / Update call of the 
TypeDef. Instead, they are getting set in the subsequent Update call.

This patch handles all these scenarios.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 4fe9f59 


Diff: https://reviews.apache.org/r/73072/diff/1/


Testing
---


Thanks,

Mandar Ambawane



[jira] [Assigned] (ATLAS-4065) TYPE_DEF_UPDATE audit does not reflect the right values

2020-12-07 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4065:
--

Assignee: Mandar Ambawane

> TYPE_DEF_UPDATE audit does not reflect the right values
> ---
>
> Key: ATLAS-4065
> URL: https://issues.apache.org/jira/browse/ATLAS-4065
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>    Assignee: Mandar Ambawane
>Priority: Major
>
> 1) Create a type as user_1 and update it as user_2
> The update audit should reflects user_2 in the update audit
> userName field reflects the right value but the result field displays the 
> incorrect value
> 2) There is a mismatch in the Version



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (ATLAS-4047) Audits Framework: Handling Long List

2020-11-24 Thread Mandar Ambawane (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238492#comment-17238492
 ] 

Mandar Ambawane edited comment on ATLAS-4047 at 11/25/20, 3:46 AM:
---

Hi [~amestry]
We have addressed this issue in [#https://reviews.apache.org/r/72903/]


was (Author: mandar_va):
Hi [~amestry]
We have addressed this issue in [#https://reviews.apache.org/r/72903/]

> Audits Framework: Handling Long List
> 
>
> Key: ATLAS-4047
> URL: https://issues.apache.org/jira/browse/ATLAS-4047
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4047-AtlasAuditService-Handling-large-strings.patch
>
>
> *Background*
> Existing _AtlasAuditService_ implementation, accepts list of GUIDs (object 
> ids) and attempts to store it in a vertex.
> *Steps to Duplicate*
> Setup:
>  * Create an export payload with 50 tables each with about 50 columns.
> Steps to duplicate:
>  * Attempt to import. Import succeeds.
> Expected result: Import completes successfully.
> Actual result: Following exception is seen within the log, import returns and 
> error code:
> {code:java}
> at 
> org.apache.atlas.GraphTransactionInterceptor.doCommitOrRollback(GraphTransactionInterceptor.java:177)
>  at 
> org.apache.atlas.GraphTransactionInterceptor.doCommitOrRollback(GraphTransactionInterceptor.java:177)
>  at 
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:116)
>  at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
>  at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:672)
>  at 
> org.apache.atlas.repository.store.graph.v2.AtlasEntityStoreV2$$EnhancerBySpringCGLIB$$f28200fc.createOrUpdate()
>  at org.apache.atlas.repository.ogm.DataAccess.saveNoLoad(DataAccess.java:73) 
> at 
> org.apache.atlas.repository.audit.AtlasAuditService.save(AtlasAuditService.java:62)
>  at 
> org.apache.atlas.repository.audit.AtlasAuditService.add(AtlasAuditService.java:82)
>  at 
> org.apache.atlas.repository.audit.AtlasAuditService$$FastClassBySpringCGLIB$$2eddda47.invoke()
>  at 
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204){code}
>  CC: [~mandar.ambaw...@freestoneinfotech.com]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-4047) Audits Framework: Handling Long List

2020-11-24 Thread Mandar Ambawane (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17238492#comment-17238492
 ] 

Mandar Ambawane commented on ATLAS-4047:


Hi [~amestry]
We have addressed this issue in [#https://reviews.apache.org/r/72903/]

> Audits Framework: Handling Long List
> 
>
> Key: ATLAS-4047
> URL: https://issues.apache.org/jira/browse/ATLAS-4047
> Project: Atlas
>  Issue Type: Bug
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-4047-AtlasAuditService-Handling-large-strings.patch
>
>
> *Background*
> Existing _AtlasAuditService_ implementation, accepts list of GUIDs (object 
> ids) and attempts to store it in a vertex.
> *Steps to Duplicate*
> Setup:
>  * Create an export payload with 50 tables each with about 50 columns.
> Steps to duplicate:
>  * Attempt to import. Import succeeds.
> Expected result: Import completes successfully.
> Actual result: Following exception is seen within the log, import returns and 
> error code:
> {code:java}
> at 
> org.apache.atlas.GraphTransactionInterceptor.doCommitOrRollback(GraphTransactionInterceptor.java:177)
>  at 
> org.apache.atlas.GraphTransactionInterceptor.doCommitOrRollback(GraphTransactionInterceptor.java:177)
>  at 
> org.apache.atlas.GraphTransactionInterceptor.invoke(GraphTransactionInterceptor.java:116)
>  at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:179)
>  at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:672)
>  at 
> org.apache.atlas.repository.store.graph.v2.AtlasEntityStoreV2$$EnhancerBySpringCGLIB$$f28200fc.createOrUpdate()
>  at org.apache.atlas.repository.ogm.DataAccess.saveNoLoad(DataAccess.java:73) 
> at 
> org.apache.atlas.repository.audit.AtlasAuditService.save(AtlasAuditService.java:62)
>  at 
> org.apache.atlas.repository.audit.AtlasAuditService.add(AtlasAuditService.java:82)
>  at 
> org.apache.atlas.repository.audit.AtlasAuditService$$FastClassBySpringCGLIB$$2eddda47.invoke()
>  at 
> org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:204){code}
>  CC: [~mandar.ambaw...@freestoneinfotech.com]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-20 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73029/#review19
---


Ship it!




Ship It!

- Mandar Ambawane


On Nov. 20, 2020, 4:05 p.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73029/
> ---
> 
> (Updated Nov. 20, 2020, 4:05 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4036 and ATLAS-4037
> https://issues.apache.org/jira/browse/ATLAS-4036
> https://issues.apache.org/jira/browse/ATLAS-4037
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> For System operations like TYPE_DEF_CREATE, TYPE_DEF_UPDATE, SERVER_START and 
> SERVER_STATE_ACTIVE the users field and client Id was empty. With this fix, 
> we now have falback strategies. We first try to get user from request 
> context, if it is not found then it is assumed that the operation is donw by 
> system user(atlas). Similarly clientId is first determined using IP address 
> information in request context, if not found we fallback to JDK InetAddress 
> apis to fetch hostname and ip address, if not found there as well, we log 
> clientId as "unknown"
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  d843204f2 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
>  bfc300ec9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  ed17b927e 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java befd726ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 4db477eef 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 1d1e08e43 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 
> 93e6513ff 
> 
> 
> Diff: https://reviews.apache.org/r/73029/diff/2/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Deep Singh
> 
>



[jira] [Updated] (ATLAS-4041) It will be good to have the operation status info of EXPORT operation in the Admin export audits

2020-11-20 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4041:
---
Attachment: ATLAS-4034-ATLAS-4041.patch

> It will be good to have the operation status info of EXPORT operation in the 
> Admin export audits
> 
>
> Key: ATLAS-4041
> URL: https://issues.apache.org/jira/browse/ATLAS-4041
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4034-ATLAS-4041.patch
>
>
> Currently we do not have information if the export operation is "PASS" or 
> "FAIL" or "PARTIAL_PASS"
> It will be good to have this information
> Current output:
> {code}
>  {
>  "guid": "",
>  "userName": "",
>  "operation": "EXPORT",
>  "params": "\{\"fetchType\":\"FULL\",\"matchType\":\"startsWith\"}",
>  "startTime": 1605089955917,
>  "endTime": 1605089957959,
>  "clientId": "",
>  "result": "\{\"hdfs_path\":1,\"dharshana\":1,\"hive_db\":1}",
>  "resultCount": 3
>  }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4034) Export operation audit with result count 0 for empty exports is inconsistent

2020-11-20 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4034:
---
Attachment: ATLAS-4034-ATLAS-4041.patch

> Export operation audit with result count 0 for empty exports is inconsistent
> 
>
> Key: ATLAS-4034
> URL: https://issues.apache.org/jira/browse/ATLAS-4034
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4034-ATLAS-4041.patch
>
>
> Export operation creates an audit with *count 0* for the following request:
> {code:java}
> {
>  "itemsToExport": [
>  
>  ]
> }
> {code}
> But the following input does not create any audit entry : Please note the 
> *{}* in the *itemsToExport* array
> {code:java}
> {
>  "itemsToExport": [
>    {}
>  ]
> }
>  {code}
> We need to keep the result consistent. Either create entry for the later with 
> result count 0 or do not create an entry for the former



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 73030: ATLAS-4034: Export operation audit with result count 0 for empty exports is inconsistent ATLAS-4041: operation status info of IMPORT/EXPORT operation in the Admin import/export a

2020-11-20 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73030/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4034 and ATLAS-4041
https://issues.apache.org/jira/browse/ATLAS-4034
https://issues.apache.org/jira/browse/ATLAS-4041


Repository: atlas


Description
---

This patch handles 2 jiras.

1. ATLAS-4034 Where if there is no data provided in the export json to export, 
Atlas does not create any Audit entry for the Export operation

2. ATLAS-4041 Where OperationStatus of Import/Export operations is provided in 
the Audit entry.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
4db477e 


Diff: https://reviews.apache.org/r/73030/diff/1/


Testing
---

Manual Testing Done


Thanks,

Mandar Ambawane



[jira] [Assigned] (ATLAS-4034) Export operation audit with result count 0 for empty exports is inconsistent

2020-11-20 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4034:
--

Assignee: Mandar Ambawane

> Export operation audit with result count 0 for empty exports is inconsistent
> 
>
> Key: ATLAS-4034
> URL: https://issues.apache.org/jira/browse/ATLAS-4034
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>    Assignee: Mandar Ambawane
>Priority: Major
>
> Export operation creates an audit with *count 0* for the following request:
> {code:java}
> {
>  "itemsToExport": [
>  
>  ]
> }
> {code}
> But the following input does not create any audit entry : Please note the 
> *{}* in the *itemsToExport* array
> {code:java}
> {
>  "itemsToExport": [
>    {}
>  ]
> }
>  {code}
> We need to keep the result consistent. Either create entry for the later with 
> result count 0 or do not create an entry for the former



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-4041) It will be good to have the operation status info of EXPORT operation in the Admin export audits

2020-11-20 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4041?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4041:
--

Assignee: Mandar Ambawane  (was: Deep Singh)

> It will be good to have the operation status info of EXPORT operation in the 
> Admin export audits
> 
>
> Key: ATLAS-4041
> URL: https://issues.apache.org/jira/browse/ATLAS-4041
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Mandar Ambawane
>Priority: Major
>
> Currently we do not have information if the export operation is "PASS" or 
> "FAIL" or "PARTIAL_PASS"
> It will be good to have this information
> Current output:
> {code}
>  {
>  "guid": "",
>  "userName": "",
>  "operation": "EXPORT",
>  "params": "\{\"fetchType\":\"FULL\",\"matchType\":\"startsWith\"}",
>  "startTime": 1605089955917,
>  "endTime": 1605089957959,
>  "clientId": "",
>  "result": "\{\"hdfs_path\":1,\"dharshana\":1,\"hive_db\":1}",
>  "resultCount": 3
>  }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73029: ATLAS-4036, ATLAS-4037, Fix for empty Users and Client Id field in Admin Audit

2020-11-20 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73029/#review17
---




repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
Lines 77 (patched)
<https://reviews.apache.org/r/73029/#comment311265>

Please consider replacing 
if (clientId == null || clientId.isEmpty()) 
>
if (StringUtils.isEmpty(clientId))



repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
Lines 86 (patched)
<https://reviews.apache.org/r/73029/#comment311266>

Please remove unused obect variable "entry"



server-api/src/main/java/org/apache/atlas/RequestContext.java
Lines 132 (patched)
<https://reviews.apache.org/r/73029/#comment311267>

Consider adding one more fallback before fetching from property file or 
hardcoding username string.

if (StringUtils.isBlank(ret)) {
try {
ret = 
UserGroupInformation.getLoginUser().getShortUserName();
} catch (IOException e) {
LOG.error("Exception occurred while retrieving Login User");
}
if (StringUtils.isNotBlank(ret)) {
return ret;
}
ret = System.getProperty("user.name");
if (StringUtils.isBlank(ret)) {
ret = "atlas";
}
}


- Mandar Ambawane


On Nov. 20, 2020, 4:49 a.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73029/
> ---
> 
> (Updated Nov. 20, 2020, 4:49 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Mandar Ambawane, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4036 and ATLAS-4037
> https://issues.apache.org/jira/browse/ATLAS-4036
> https://issues.apache.org/jira/browse/ATLAS-4037
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> For System operations like TYPE_DEF_CREATE, TYPE_DEF_UPDATE, SERVER_START and 
> SERVER_STATE_ACTIVE the users field and client Id was empty. With this fix, 
> we now have falback strategies. We first try to get user from request 
> context, if it is not found then it is assumed that the operation is donw by 
> system user(atlas). Similarly clientId is first determined using IP address 
> information in request context, if not found we fallback to JDK InetAddress 
> apis to fetch hostname and ip address, if not found there as well, we log 
> clientId as "unknown"
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  d843204f2 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
>  bfc300ec9 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  ed17b927e 
>   server-api/src/main/java/org/apache/atlas/RequestContext.java befd726ae 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 4db477eef 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 1d1e08e43 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 
> 93e6513ff 
> 
> 
> Diff: https://reviews.apache.org/r/73029/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing done
> 
> 
> Thanks,
> 
> Deep Singh
> 
>



[jira] [Updated] (ATLAS-4032) Filter group option in the Admin Audit tab is not giving the expected output

2020-11-19 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4032:
---
Attachment: ATLAS-4032.patch

> Filter group option in the Admin Audit tab is not giving the expected output
> 
>
> Key: ATLAS-4032
> URL: https://issues.apache.org/jira/browse/ATLAS-4032
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core, atlas-webui
>Reporter: Dharshana M Krishnamoorthy
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4032.patch, image-2020-11-18-14-05-05-000.png
>
>
> When we filter results using filter groups, the output received is the output 
> of the first group
> Criteria used:
> !image-2020-11-18-14-05-05-000.png|width=558,height=159!
> Expected output:
> The audits of operation that are either SERVER_START or SERVER_STATE_ACTIVE
>  
> Observed Output:
> The audits of SERVER_START operation 
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 73022: ATLAS-4032 Filter group option in the Admin Audit tab is not giving the expected output

2020-11-18 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73022/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-4032
https://issues.apache.org/jira/browse/ATLAS-4032


Repository: atlas


Description
---

In the existing code we are not including the Inner Criterias of the Filter.

Also the Condition of the Outer filter was getting applied to the Inner Filters 
groups.

In this patch, code refactoring is done. The code which populate the Filter 
Criteria is now removed.

Instead of doing it from Server end, This patch keeps the Filter Criteria in 
the same format which UI has sent.

Additionally this patch provides validation for the Filter Criteria 1.Attribute 
Name 2. Attribute Value and 3.Operator
This validation goes until the last level of the Inner Filter Criterias.


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java ad67fa9 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 d843204 


Diff: https://reviews.apache.org/r/73022/diff/1/


Testing
---

Manual testing is done for the scenarios where Filter Groups are included.

Earlier it was not giving expected search result.

With this patch we can get the expected result in the Admin Audit Search.


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-3813) Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System

2020-11-12 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3813?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3813:
---
Attachment: ATLAS-3813-V4.patch

> Import-.sh script shows wrong message of Import success even when 
> there are no database/table/topic are imported in the System
> --
>
> Key: ATLAS-3813
> URL: https://issues.apache.org/jira/browse/ATLAS-3813
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3813-V4.patch
>
>
> While importing Hive-data from the file, if file has db names and table names 
> which are not in the Hive. Application still shows message as "Hive Meta Data 
> imported successfully!!!"
> While importing Kafka-Topic data from the file, if file has Topic names  
> which are not present in Kafka. Application still shows message as "Kafka 
> Data Model imported successfully!!!"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

2020-11-11 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4016:
---
Attachment: ATLAS-4016-V2.patch

> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4016-V2.patch, ATLAS-4016.patch
>
>
>  
>   
>  For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 73007: ATLAS-4016 Update authorization - 'admin-audits' for retrieving admin audits

2020-11-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73007/
---

(Updated Nov. 10, 2020, 7:55 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-4016
https://issues.apache.org/jira/browse/ATLAS-4016


Repository: atlas


Description
---

For Atlas Admin Audits we need to add new privilege - "admin-audits" for 
authorization

Similar permission needs to be updated in ranger atlas service-def.


Diffs (updated)
-

  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
9dbcd32 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
f6a20c0 


Diff: https://reviews.apache.org/r/73007/diff/2/

Changes: https://reviews.apache.org/r/73007/diff/1-2/


Testing
---

Testing is done on the cluster with Atlas and Ranger services running.

First, When only Atlas side changes are applied on cluster and then Admin tries 
to access the Admin Audits, It gets an Authorization error 403. Which is 
expected.

Then after applying Ranger side changes on cluster, Admin could successfully 
access the Admin Audits.


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

2020-11-09 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-4016:
---
Attachment: ATLAS-4016.patch

> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-4016.patch
>
>
>  
>   
>  For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 73007: ATLAS-4016 Update authorization - 'admin-audits' for retrieving admin audits

2020-11-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73007/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-4016
https://issues.apache.org/jira/browse/ATLAS-4016


Repository: atlas


Description
---

For Atlas Admin Audits we need to add new privilege - "admin-audits" for 
authorization

Similar permission needs to be updated in ranger atlas service-def.


Diffs
-

  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
9dbcd32 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
f6a20c0 


Diff: https://reviews.apache.org/r/73007/diff/1/


Testing
---

Testing is done on the cluster with Atlas and Ranger services running.

First, When only Atlas side changes are applied on cluster and then Admin tries 
to access the Admin Audits, It gets an Authorization error 403. Which is 
expected.

Then after applying Ranger side changes on cluster, Admin could successfully 
access the Admin Audits.


Thanks,

Mandar Ambawane



[jira] [Assigned] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

2020-11-09 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-4016:
--

Assignee: Mandar Ambawane

> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>  Issue Type: Bug
>Reporter: Nixon Rodrigues
>Assignee: Mandar Ambawane
>Priority: Major
>
>  
>   
>  For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3935) Use Audit framework to capture audit entries for Import/Export operations

2020-10-26 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane resolved ATLAS-3935.

Resolution: Fixed

> Use Audit framework to capture audit entries for Import/Export operations
> -
>
> Key: ATLAS-3935
> URL: https://issues.apache.org/jira/browse/ATLAS-3935
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3935-V2.patch, ATLAS-3935-V3.patch
>
>
> By using Audit Framework, capture audit entries for Import/Export operations.
> These audit entries can be seen under the "Audits" tab of Admin section.
> *Add Import and Export specific information in Audit entry*
> * Total no. of entities imported/ exported
> * Total no. of entities imported/ exported of specific TypeDef
> * Export operation Fetch Type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3943) UI: Show Import/Export operations in administration audit.

2020-10-26 Thread Mandar Ambawane (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220500#comment-17220500
 ] 

Mandar Ambawane commented on ATLAS-3943:


+1 for the patch

> UI: Show Import/Export operations in administration audit.
> --
>
> Key: ATLAS-3943
> URL: https://issues.apache.org/jira/browse/ATLAS-3943
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3943-1.patch, ATLAS-3943-2.patch, 
> ATLAS-3943-3.patch, ATLAS-3943-4.patch, ATLAS-3943.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-22 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 22, 2020, 9:01 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Some formatting changes.


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/5/

Changes: https://reviews.apache.org/r/72908/diff/4-5/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console


Thanks,

Mandar Ambawane



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-21 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

(Updated Oct. 22, 2020, 5:34 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/4/

Changes: https://reviews.apache.org/r/72938/diff/3-4/


Testing
---

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console


Thanks,

Mandar Ambawane



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-21 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

(Updated Oct. 21, 2020, 1:19 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/3/

Changes: https://reviews.apache.org/r/72938/diff/2-3/


Testing
---

PreCommit: 
https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/81/console


Thanks,

Mandar Ambawane



Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-21 Thread Mandar Ambawane


> On Oct. 21, 2020, 4:31 a.m., Sarath Subramanian wrote:
> > webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java
> > Lines 128 (patched)
> > <https://reviews.apache.org/r/72908/diff/3/?file=2240561#file2240561line128>
> >
> > consider moving initialization lines - 128 and 129 to the constructor

These lines cannot be moved to the constructor because at that moment Spring 
ApplicationContext container is yet to be populated.
Hence we get NPE in BeanUtil.java where ApplicationContext is still null.


- Mandar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/#review222083
---


On Oct. 21, 2020, 10:56 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72908/
> ---
> 
> (Updated Oct. 21, 2020, 10:56 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3957
> https://issues.apache.org/jira/browse/ATLAS-3957
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> 
> These audit entries can be seen under the "Audits" tab of Admin section.
> 
> 
> Diffs
> -
> 
>   addons/models/-Area0/0010-base_model.json 1de9e57 
>   
> addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
>  a27525e 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 9ed4168 
>   test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
>   webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 6985291 
>   webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 
> 
> 
> Diff: https://reviews.apache.org/r/72908/diff/4/
> 
> 
> Testing
> ---
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-21 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 21, 2020, 10:56 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/4/

Changes: https://reviews.apache.org/r/72908/diff/3-4/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/75/console


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-3957) Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-16 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3957:
---
Attachment: ATLAS-3957-V3.patch

> Use Audit framework to capture audit entries for "Server Start" and "Server 
> In Active mode" (HA)
> 
>
> Key: ATLAS-3957
> URL: https://issues.apache.org/jira/browse/ATLAS-3957
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3957-V3.patch, ATLAS-3957.patch
>
>
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> These audit entries can be seen under the "Audits" tab of Admin section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3935) Use Audit framework to capture audit entries for Import/Export operations

2020-10-16 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3935:
---
Attachment: ATLAS-3935-V3.patch

> Use Audit framework to capture audit entries for Import/Export operations
> -
>
> Key: ATLAS-3935
> URL: https://issues.apache.org/jira/browse/ATLAS-3935
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3935-V2.patch, ATLAS-3935-V3.patch
>
>
> By using Audit Framework, capture audit entries for Import/Export operations.
> These audit entries can be seen under the "Audits" tab of Admin section.
> *Add Import and Export specific information in Audit entry*
> * Total no. of entities imported/ exported
> * Total no. of entities imported/ exported of specific TypeDef
> * Export operation Fetch Type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3935) Use Audit framework to capture audit entries for Import/Export operations

2020-10-16 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3935?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3935:
---
Attachment: ATLAS-3935-V2.patch

> Use Audit framework to capture audit entries for Import/Export operations
> -
>
> Key: ATLAS-3935
> URL: https://issues.apache.org/jira/browse/ATLAS-3935
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3935-V2.patch
>
>
> By using Audit Framework, capture audit entries for Import/Export operations.
> These audit entries can be seen under the "Audits" tab of Admin section.
> *Add Import and Export specific information in Audit entry*
> * Total no. of entities imported/ exported
> * Total no. of entities imported/ exported of specific TypeDef
> * Export operation Fetch Type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3984) Add UI Date Timezone and UI Date Format in Session api

2020-10-16 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3984?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3984:
---
Attachment: ATLAS-3984-V2.patch

> Add UI Date Timezone and UI Date Format in Session api
> --
>
> Key: ATLAS-3984
> URL: https://issues.apache.org/jira/browse/ATLAS-3984
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3984-V2.patch
>
>
> Add UI Date Timezone and UI Date Format in Session api.
> Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
> values from property file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (ATLAS-3986) UI Allow user to update the date format from JAVA property file

2020-10-14 Thread Mandar Ambawane (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213966#comment-17213966
 ] 

Mandar Ambawane edited comment on ATLAS-3986 at 10/14/20, 2:40 PM:
---

+1 for the patch


was (Author: mandar_va):
+1

> UI Allow user to update the date format from JAVA property file
> ---
>
> Key: ATLAS-3986
> URL: https://issues.apache.org/jira/browse/ATLAS-3986
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3986.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3986) UI Allow user to update the date format from JAVA property file

2020-10-14 Thread Mandar Ambawane (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213966#comment-17213966
 ] 

Mandar Ambawane commented on ATLAS-3986:


+1

> UI Allow user to update the date format from JAVA property file
> ---
>
> Key: ATLAS-3986
> URL: https://issues.apache.org/jira/browse/ATLAS-3986
> Project: Atlas
>  Issue Type: Sub-task
>Affects Versions: 2.1.0
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3986.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 9, 2020, 2:46 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/3/

Changes: https://reviews.apache.org/r/72908/diff/2-3/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/66/consoleFull


Thanks,

Mandar Ambawane



Re: Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

(Updated Oct. 9, 2020, 6:21 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

UI date format changed from "MM/dd/ hh:mm:ss tt" to "MM/DD/ hh:mm:ss A"


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/2/

Changes: https://reviews.apache.org/r/72938/diff/1-2/


Testing
---


Thanks,

Mandar Ambawane



Review Request 72938: ATLAS-3984 Add UI Date Timezone and UI Date Format in Session api

2020-10-07 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72938/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3984
https://issues.apache.org/jira/browse/ATLAS-3984


Repository: atlas


Description
---

Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72938/diff/1/


Testing
---


Thanks,

Mandar Ambawane



[jira] [Created] (ATLAS-3984) Add UI Date Timezone and UI Date Format in Session api

2020-10-07 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3984:
--

 Summary: Add UI Date Timezone and UI Date Format in Session api
 Key: ATLAS-3984
 URL: https://issues.apache.org/jira/browse/ATLAS-3984
 Project: Atlas
  Issue Type: Improvement
  Components:  atlas-core
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane


Add UI Date Timezone and UI Date Format in Session api.

Provide a way to user to read these "UI Date Timezone" and "UI Date Format" 
values from property file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-10-07 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

(Updated Oct. 7, 2020, 8:39 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

1. Added Host name and Host address.
2. Changed Server start time.


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/2/

Changes: https://reviews.apache.org/r/72908/diff/1-2/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-3957) Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-09-28 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3957?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3957:
---
Attachment: ATLAS-3957.patch

> Use Audit framework to capture audit entries for "Server Start" and "Server 
> In Active mode" (HA)
> 
>
> Key: ATLAS-3957
> URL: https://issues.apache.org/jira/browse/ATLAS-3957
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Attachments: ATLAS-3957.patch
>
>
> By using Audit Framework, capture audit entries for "Server Start" and 
> "Server In Active mode" (HA)
> These audit entries can be seen under the "Audits" tab of Admin section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72908: ATLAS-3957 Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-09-24 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72908/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3957
https://issues.apache.org/jira/browse/ATLAS-3957


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.


Diffs
-

  addons/models/-Area0/0010-base_model.json 1de9e57 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 a27525e 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 9ed4168 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 7cbfbd9 
  webapp/src/main/java/org/apache/atlas/BeanUtil.java PRE-CREATION 
  webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 6985291 
  webapp/src/main/java/org/apache/atlas/web/service/ServiceState.java 113b2b2 


Diff: https://reviews.apache.org/r/72908/diff/1/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/35/console


Thanks,

Mandar Ambawane



[jira] [Created] (ATLAS-3957) Use Audit framework to capture audit entries for "Server Start" and "Server In Active mode" (HA)

2020-09-24 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3957:
--

 Summary: Use Audit framework to capture audit entries for "Server 
Start" and "Server In Active mode" (HA)
 Key: ATLAS-3957
 URL: https://issues.apache.org/jira/browse/ATLAS-3957
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
        Reporter: Mandar Ambawane
        Assignee: Mandar Ambawane


By using Audit Framework, capture audit entries for "Server Start" and "Server 
In Active mode" (HA)

These audit entries can be seen under the "Audits" tab of Admin section.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72903: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations. Remove Import Audit params.

2020-09-23 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72903/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3935
https://issues.apache.org/jira/browse/ATLAS-3935


Repository: atlas


Description
---

Remove list of guids which are stored in the params atrribute of 
AtlasAuditEntry in case of Import operation.


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a6139f 


Diff: https://reviews.apache.org/r/72903/diff/1/


Testing
---

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/32/console


Thanks,

Mandar Ambawane



Review Request 72849: ATLAS-3937 Add Test Cases for Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-09-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72849/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3937
https://issues.apache.org/jira/browse/ATLAS-3937


Repository: atlas


Description
---

This patch addresses Test cases for newly added funtionality ATLAS-3583 Use 
Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE


Diffs
-

  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 0b1317a 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  webapp/src/test/java/org/apache/atlas/web/adapters/TypeDefsRESTTest.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72849/diff/1/


Testing
---


Thanks,

Mandar Ambawane



[jira] [Created] (ATLAS-3937) Add Test Cases for Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-09-09 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3937:
--

 Summary: Add Test Cases for Audit framework to generate audit 
entries for TypeDefs CREATE, UPDATE and DELETE
 Key: ATLAS-3937
 URL: https://issues.apache.org/jira/browse/ATLAS-3937
 Project: Atlas
  Issue Type: Test
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72821: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations

2020-09-09 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72821/
---

(Updated Sept. 9, 2020, 10:04 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3935
https://issues.apache.org/jira/browse/ATLAS-3935


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for Import/Export operations.

These audit entries can be seen under the "Audits" tab of Admin section.

Add Import and Export specific information in Audit entry

Total no. of entities imported/ exported
Total no. of entities imported/ exported of specific TypeDef
Export operation Fetch Type


Diffs (updated)
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a5ae5c 


Diff: https://reviews.apache.org/r/72821/diff/2/

Changes: https://reviews.apache.org/r/72821/diff/1-2/


Testing
---


Thanks,

Mandar Ambawane



Re: Review Request 72821: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations

2020-09-08 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72821/
---

(Updated Sept. 8, 2020, 2:18 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, and 
Sarath Subramanian.


Bugs: ATLAS-3935
https://issues.apache.org/jira/browse/ATLAS-3935


Repository: atlas


Description
---

By using Audit Framework, capture audit entries for Import/Export operations.

These audit entries can be seen under the "Audits" tab of Admin section.

Add Import and Export specific information in Audit entry

Total no. of entities imported/ exported
Total no. of entities imported/ exported of specific TypeDef
Export operation Fetch Type


Diffs
-

  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
3a5ae5c 


Diff: https://reviews.apache.org/r/72821/diff/1/


Testing
---


Thanks,

Mandar Ambawane



[jira] [Created] (ATLAS-3935) Use Audit framework to capture audit entries for Import/Export operations

2020-08-31 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3935:
--

 Summary: Use Audit framework to capture audit entries for 
Import/Export operations
 Key: ATLAS-3935
 URL: https://issues.apache.org/jira/browse/ATLAS-3935
 Project: Atlas
  Issue Type: Bug
  Components:  atlas-core
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane


By using Audit Framework, capture audit entries for Import/Export operations.

These audit entries can be seen under the "Audits" tab of Admin section.

*Add Import and Export specific information in Audit entry*
* Total no. of entities imported/ exported
* Total no. of entities imported/ exported of specific TypeDef
* Export operation Fetch Type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3583) Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-08-15 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3583:
---
Description: 
By using Audit Framework, capture audit entries when Type defs are created/ 
updated/ deleted.

These audit entries can be seen under the "Audits" tab of Admin section.

If there are mutiple Typedefs created/ updated/ deleted in a single request, 
Then only one audit entry will be recorded. 
This audit entry will consist of entire information about all the included 
Typedefs.

> Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and 
> DELETE
> 
>
> Key: ATLAS-3583
> URL: https://issues.apache.org/jira/browse/ATLAS-3583
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3583-V3.patch, ATLAS-3583-V8.patch
>
>
> By using Audit Framework, capture audit entries when Type defs are created/ 
> updated/ deleted.
> These audit entries can be seen under the "Audits" tab of Admin section.
> If there are mutiple Typedefs created/ updated/ deleted in a single request, 
> Then only one audit entry will be recorded. 
> This audit entry will consist of entire information about all the included 
> Typedefs.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-08-14 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated Aug. 14, 2020, 4:34 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff 


Diff: https://reviews.apache.org/r/72477/diff/9/

Changes: https://reviews.apache.org/r/72477/diff/8-9/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-3583) Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-08-14 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3583:
---
Attachment: ATLAS-3583-V8.patch

> Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and 
> DELETE
> 
>
> Key: ATLAS-3583
> URL: https://issues.apache.org/jira/browse/ATLAS-3583
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3583-V3.patch, ATLAS-3583-V8.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-08-14 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated Aug. 14, 2020, 2:06 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Reverted Test case changes because of issues in execution.
Planning to include those in subsequent patch.


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff 


Diff: https://reviews.apache.org/r/72477/diff/8/

Changes: https://reviews.apache.org/r/72477/diff/7-8/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console


Thanks,

Mandar Ambawane



Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-08-10 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated Aug. 11, 2020, 5:25 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments

Updated below index field names for FreetextSearchProcessor to resolve Test 
case failures.

"Referenceable.qualifiedName" -> "3k05_t"
"Asset.__s_name" -> "3r45_s"
"Asset.description" -> "3u9x_t"


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  test-tools/src/main/resources/solr/core-template/solrconfig.xml 8ebbeff 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/7/

Changes: https://reviews.apache.org/r/72477/diff/6-7/


Testing (updated)
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2100/console


Thanks,

Mandar Ambawane



Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-08-08 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated Aug. 8, 2020, 2:42 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Test cases failing issue resolved.


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f5270 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/6/

Changes: https://reviews.apache.org/r/72477/diff/5-6/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2082/console


Thanks,

Mandar Ambawane



Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

2020-08-05 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/
---

(Updated Aug. 5, 2020, 5:37 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Test cases failing issue resolved.


Bugs: ATLAS-3872
https://issues.apache.org/jira/browse/ATLAS-3872


Repository: atlas


Description
---

Cause of the problem:
Type-def Column is created by quick-start script.

Here in this case, Type-def Column has the attribute "name". And it has 
property isOptional = true

Type-def Column is a child of Type-def Asset which also has the attribute 
"name". And it has property isOptional = false

Now while creating Entity of Type-def Column from UI, it does not show 
attribute "name" in the mandatory fields because for Type-def Column its 
property isOptional = true

But while validating the attributes from server side we iterate through all the 
attributes of Entity type (Including Parent's attributes)
In this case, while validating Type-def Asset's attribute "name" (which has 
property isOptional = false) we get an error because its value is sent as 
"null" from UI side.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java e0843cb 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java b0d88fc 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  intg/src/test/java/org/apache/atlas/model/ModelTestUtil.java 5df9525 
  repository/src/test/resources/logging-v1-full.zip 
69c54eec000964a1f6f3fef96b26cca188a28ba1 
  repository/src/test/resources/sales-v1-full.zip 
07afbf6ecae312a840b54cae5ab01335c513d180 
  repository/src/test/resources/salesNewTypeAttrs-next.zip 
e4c8505be1587fb7cc8b6354bdda701e9557da99 
  repository/src/test/resources/salesNewTypeAttrs.zip 
a4467e641fffb10189288fb2f26dc4fbc06bbd42 
  webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
6db6b58 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypedefsJerseyResourceIT.java
 0cd707f 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
 7c820e7 


Diff: https://reviews.apache.org/r/72644/diff/6/

Changes: https://reviews.apache.org/r/72644/diff/5-6/


Testing (updated)
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2083/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2088/console


Thanks,

Mandar Ambawane



Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

2020-08-05 Thread Mandar Ambawane


> On Aug. 5, 2020, 8:04 a.m., Madhan Neethiraj wrote:
> > Ship It!

Hi Madhan,
With current changes some test cases are failing. I have resolved this issue. 
Currently Pre-commit build is going on for the same. Once this pre-commit build 
is successful I will update the review board.


- Mandar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/#review221474
---


On Aug. 4, 2020, 6:14 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72644/
> ---
> 
> (Updated Aug. 4, 2020, 6:14 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3872
> https://issues.apache.org/jira/browse/ATLAS-3872
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Cause of the problem:
> Type-def Column is created by quick-start script.
> 
> Here in this case, Type-def Column has the attribute "name". And it has 
> property isOptional = true
> 
> Type-def Column is a child of Type-def Asset which also has the attribute 
> "name". And it has property isOptional = false
> 
> Now while creating Entity of Type-def Column from UI, it does not show 
> attribute "name" in the mandatory fields because for Type-def Column its 
> property isOptional = true
> 
> But while validating the attributes from server side we iterate through all 
> the attributes of Entity type (Including Parent's attributes)
> In this case, while validating Type-def Asset's attribute "name" (which has 
> property isOptional = false) we get an error because its value is sent as 
> "null" from UI side.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a 
>   intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java 
> e0843cb 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee458 
>   repository/src/test/resources/sales-v1-full.zip 
> 07afbf6ecae312a840b54cae5ab01335c513d180 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
>   webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
> 6db6b58 
>   
> webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
>  7c820e7 
> 
> 
> Diff: https://reviews.apache.org/r/72644/diff/5/
> 
> 
> Testing
> ---
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console
> 
> PreCommit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2083/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

2020-08-04 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/
---

(Updated Aug. 4, 2020, 6:14 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3872
https://issues.apache.org/jira/browse/ATLAS-3872


Repository: atlas


Description
---

Cause of the problem:
Type-def Column is created by quick-start script.

Here in this case, Type-def Column has the attribute "name". And it has 
property isOptional = true

Type-def Column is a child of Type-def Asset which also has the attribute 
"name". And it has property isOptional = false

Now while creating Entity of Type-def Column from UI, it does not show 
attribute "name" in the mandatory fields because for Type-def Column its 
property isOptional = true

But while validating the attributes from server side we iterate through all the 
attributes of Entity type (Including Parent's attributes)
In this case, while validating Type-def Asset's attribute "name" (which has 
property isOptional = false) we get an error because its value is sent as 
"null" from UI side.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java e0843cb 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee458 
  repository/src/test/resources/sales-v1-full.zip 
07afbf6ecae312a840b54cae5ab01335c513d180 
  webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
6db6b58 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
 7c820e7 


Diff: https://reviews.apache.org/r/72644/diff/5/

Changes: https://reviews.apache.org/r/72644/diff/4-5/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console


Thanks,

Mandar Ambawane



Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-07-31 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated July 31, 2020, 12:01 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Changes to create single audit entry when multiple typedefs of different 
categories are created in a single request


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f5270 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/5/

Changes: https://reviews.apache.org/r/72477/diff/4-5/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console


Thanks,

Mandar Ambawane



Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

2020-07-31 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/
---

(Updated July 31, 2020, 11:56 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3872
https://issues.apache.org/jira/browse/ATLAS-3872


Repository: atlas


Description
---

Cause of the problem:
Type-def Column is created by quick-start script.

Here in this case, Type-def Column has the attribute "name". And it has 
property isOptional = true

Type-def Column is a child of Type-def Asset which also has the attribute 
"name". And it has property isOptional = false

Now while creating Entity of Type-def Column from UI, it does not show 
attribute "name" in the mandatory fields because for Type-def Column its 
property isOptional = true

But while validating the attributes from server side we iterate through all the 
attributes of Entity type (Including Parent's attributes)
In this case, while validating Type-def Asset's attribute "name" (which has 
property isOptional = false) we get an error because its value is sent as 
"null" from UI side.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a 
  intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java e0843cb 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 58de4cc 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 61ee458 
  repository/src/test/resources/sales-v1-full.zip 
07afbf6ecae312a840b54cae5ab01335c513d180 
  webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
6db6b58 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
 7c820e7 


Diff: https://reviews.apache.org/r/72644/diff/4/

Changes: https://reviews.apache.org/r/72644/diff/3-4/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console


Thanks,

Mandar Ambawane



Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-07-27 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated July 27, 2020, 2:42 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f5270 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/4/


Testing (updated)
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2071/console


Thanks,

Mandar Ambawane



Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-07-27 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated July 27, 2020, 2:31 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

"006-base_model_add_atlas_operation_attributes.json" patch to add additional 
atlas operation elements in enum type "atlas_operation"


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  
addons/models/-Area0/patches/006-base_model_add_atlas_operation_attributes.json
 PRE-CREATION 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 8e7c1b3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f5270 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/4/

Changes: https://reviews.apache.org/r/72477/diff/3-4/


Testing
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-3583) Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-07-20 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3583:
---
Attachment: ATLAS-3583-V3.patch

> Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and 
> DELETE
> 
>
> Key: ATLAS-3583
> URL: https://issues.apache.org/jira/browse/ATLAS-3583
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3583-V3.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3583) Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-07-20 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3583:
---
Attachment: (was: ATLAS-3583-V3.patch)

> Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and 
> DELETE
> 
>
> Key: ATLAS-3583
> URL: https://issues.apache.org/jira/browse/ATLAS-3583
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Fix For: 3.0.0
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3583) Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-07-20 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3583:
---
Attachment: ATLAS-3583-V3.patch

> Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and 
> DELETE
> 
>
> Key: ATLAS-3583
> URL: https://issues.apache.org/jira/browse/ATLAS-3583
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>    Reporter: Mandar Ambawane
>Assignee: Mandar Ambawane
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3583-V3.patch
>
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-3738) [Business Metadata] Suggestions does not honour Business Metadata Attribute's Search Weight value

2020-07-16 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-3738:
--

Assignee: Mandar Ambawane

> [Business Metadata] Suggestions does not honour Business Metadata Attribute's 
> Search Weight value
> -
>
> Key: ATLAS-3738
> URL: https://issues.apache.org/jira/browse/ATLAS-3738
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Umesh Padashetty
>Assignee: Mandar Ambawane
>Priority: Critical
> Attachments: Screenshot 2020-04-20 at 4.02.28 PM.png, Screenshot 
> 2020-04-20 at 4.02.36 PM.png
>
>
> In the new Business Metadata UI, the user can provide the search weight for 
> each attribute. This search weight is used in quick search and suggestions 
> API, to list the values based on their search weight. An attribute with a 
> search weight 10 appears before the attribute with a search weight of 9, when 
> they have the same attribute values. 
> Defined BM attributes, with search weight in the following order 
>  * Test2A1 = Test2A3 > Test1A1 > Test3A1 > Test4A1
> where Test1, Test2... are the Business Metadatas.
> Added these BM attributes to the entities with values +value for 
> better clarity. 
> As per the functionality, suggestions should be listed in below order when I 
> enter "test"
>  * test2a1value
>  * test2a3value
>  * test1a1value
>  * test3a1value
>  * test4a1value
> but they are listed as 
>  * test2a1value
>  * test3a1value
>  * test1a1value
>  * test4a1value
>  * test2a3value
> Quick search, on the other hand, works fine. Also, the following logs were 
> observed in atlas/application.log when I enter a search pattern in quick 
> search/suggestion box.
> {code:java}
> 2020-04-20 10:39:15,969 WARN  - [etp851765426-201 - 
> 56181e81-11e6-4e02-a23a-d72940f3703c:] ~ Could not convert given VERTEX index 
> query: [test1a1value] (IndexSerializer:626)
> 2020-04-20 10:39:15,978 WARN  - [etp851765426-201 - 
> 56181e81-11e6-4e02-a23a-d72940f3703c:] ~ Could not convert given VERTEX index 
> query: [test1a1value] (IndexSerializer:626)
> 2020-04-20 10:39:24,733 WARN  - [etp851765426-160 - 
> d0030733-2fb9-4dfc-8659-7a3c62415ee0:] ~ Could not convert given VERTEX index 
> query: [test1a1value*] (IndexSerializer:626)
> 2020-04-20 10:39:24,784 WARN  - [etp851765426-160 - 
> d0030733-2fb9-4dfc-8659-7a3c62415ee0:] ~ Could not convert given VERTEX index 
> query: [test1a1value*] (IndexSerializer:626)
> 2020-04-20 10:39:26,831 WARN  - [etp851765426-201 - 
> 7d11aa19-e517-4157-a86c-9ce25a19c1ab:] ~ Could not convert given VERTEX index 
> query: [te*] (IndexSerializer:626)
> 2020-04-20 10:39:26,861 WARN  - [etp851765426-201 - 
> 7d11aa19-e517-4157-a86c-9ce25a19c1ab:] ~ Could not convert given VERTEX index 
> query: [te*] (IndexSerializer:626)
> 2020-04-20 10:39:27,342 WARN  - [etp851765426-160 - 
> 66c8be42-f375-4707-bc51-5f0c592828dc:] ~ Could not convert given VERTEX index 
> query: [test*] (IndexSerializer:626) {code}
> Attached screenshots.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [VOTE] Release Apache Atlas version 2.1.0 - rc3

2020-07-13 Thread Mandar Ambawane
+1 for Apache Atlas 2.1.0 RC3 release

Validated the following:
1. Verified the source SHA512 and MD5 checksum
2. Verified the build with -Pdist,embedded-hbase-solr
3. Started Atlas server successfully
4. Verified quick_start.py, all entities and tag get created successfully
5. Created Business metadata and associated with an entity.
6. Checked Basic and advanced search

Thanks,
Mandar

On Mon, Jul 13, 2020 at 12:39 PM Jayendra Parab 
wrote:

> +1 for Apache Atlas 2.1.0 RC3 release
>
> Validated the following:
> 1. Verified the source SHA512 and MD5 checksum
> 2. Verified the build with -Pdist,embedded-hbase-solr
> 3. Started Atlas server successfully
> 4. Verified quick_start.py, all entities and tag get created successfully
> 5. Created entities, applied tags from UI
> 6. Checked Basic and advanced search
>
> Regards,
> Jayendra.
>
> On Mon, Jul 13, 2020 at 12:17 PM Sarath Subramanian 
> wrote:
>
> > +1 for Apache Atlas 2.1 rc3
> >
> > Validated the following:
> > - Validated MD5 checksum
> > - Validated sha512 hash
> > - Verified PGP signature
> > - No binaries in extracted source
> > - Built successfully using embedded-hbase and solr profile
> > - Ran quick start and tested basic sanity - saved search, basic/advanced
> > search, Glossary, tag propagation, Admin purge, system attribute search
> >
> >
> >
> > On Thu, Jul 9, 2020 at 9:59 PM Madhan Neethiraj 
> wrote:
> >
> > > Atlas team,
> > >
> > > Apache Atlas 2.1.0 rc3, with following fixes since rc2, is now
> available
> > > for vote within dev community.
> > >   ATLAS-3877: Purged entity audit throws 404 Entity not found error
> > >   ATLAS-3882: Classic UI: Loader not disappearing while assigning
> > category
> > > to term
> > >
> > > Links to the release artifacts are given below. Please review and vote.
> > >
> > > The vote will be open for at least 72 hours or until necessary votes
> are
> > > reached.
> > >   [ ] +1 Approve
> > >   [ ] +0 No opinion
> > >   [ ] -1 Disapprove (and reason why)
> > >
> > > Thanks,
> > > Madhan
> > >
> > >
> > > List of all issues addressed in this release:
> > > https://issues.apache.org/jira/issues/?jql=project=ATLAS AND
> > > status=Resolved AND fixVersion=2.1.0 ORDER BY key DESC
> > >
> > > Git tag for the release:
> > > https://github.com/apache/atlas/tree/release-2.1.0-rc3
> > > Sources for the release:
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc3/apache-atlas-2.1.0-sources.tar.gz
> > >
> > > Source release verification:
> > >   PGP Signature:
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc3/apache-atlas-2.1.0-sources.tar.gz.asc
> > >   SHA512 Hash:
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc3/apache-atlas-2.1.0-sources.tar.gz.sha512
> > >   MD5 Hash:
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc3/apache-atlas-2.1.0-sources.tar.gz.md5
> > >
> > > Keys to verify the signature of the release artifacts are available at:
> > > https://dist.apache.org/repos/dist/release/atlas/KEYS
> > >
> > > New features/enhancements:
> > >   - Quick Search: provides a simpler search experience with type-ahead
> > > suggestions
> > >   - Business Metadata: enables augmenting entity-types with additional
> > > attributes, search entities using these attributes
> > >   - Labels: ability to add/remove labels on entities, and search
> entities
> > > using labels
> > >   - Custom Attributes: ability to add entity instance specific custom
> > > attributes i.e. attributes not defined in entity-def or business
> metadata
> > >   - Entity Purge: added REST APIs to purge deleted entities
> > >
> > > Enhancements:
> > >   - Search: ability to find entities by more than one classification
> > >   - Performance: improvements in lineage retrieval and
> > > classification-propagation
> > >   - Notification: ability to process notifications from multiple Kafka
> > > topics
> > >   - Hive Hook: tracks process-executions via hive_process_execution
> > > entities
> > >   - Hive Hook: captures DDL operations via hive_db_ddl and
> hive_table_ddl
> > > entities
> > >   - Notification: introduced shell entities to record references to
> > > non-existing entities in notifications
> > >   - Spark: added model to capture Spark entities, processes and
> > > relationships
> > >   - AWS S3: introduced updated model to capture AWS S3 entities and
> > > relationships
> > >   - ADLS-Gen2: introduced model to capture Azure Data Lake Storage Gen2
> > > entities and relationships
> > >   - Dependencies: JanusGraph 0.5.1, Tinkerpop 3.4.6, Spring Framework
> > > 4.3.20
> > >   - Authorization: updated to cover new features, like: business
> > metadata,
> > > labels, purge
> > >   - UI: multiple UI improvements, including a beta UI
> > >
> > >
> > >
> >
>


-- 
Thanks and Regards,
Mandar V. Ambawane.


Re: Review Request 72648: ATLAS-3841 Response Headers: Code refactoring

2020-07-08 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72648/
---

(Updated July 8, 2020, 7:07 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3841
https://issues.apache.org/jira/browse/ATLAS-3841


Repository: atlas


Description
---

Currently headers setting code is scattered at different places.
In this patch, code refactoring is done to set response headers from 
AtlasHeaderFilter.java

Currently js/ html files come under the unauthorized urls.
Therefore, these files do not have headers which are applied by default by 
spring security.

To overcome this problem, In this patch we are applying all the spring security 
headers to these unauthorized urls explicitly.
We are doing this by mapping all the urls (authorized + unauthorized) to go 
through one servlet filter which is AtlasHeaderFilter.

In case of authorized urls, spring by default set some of the headers. To avoid 
overwriting of these headers in authorized urls, those headers are skipped in 
the AtlasHeaderFilter.

Also this patch provides flexibility to select file formats to be excluded from 
applying response headers.


Diffs (updated)
-

  distro/src/conf/atlas-application.properties e06e74a 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 d9b1c82 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java
 df3fce6 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java
 c629a7e 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java 
fa7218c 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
 1944a9f 
  webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationFailureHandler.java
 a117df6 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java
 e7a5d66 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e9 
  webapp/src/main/webapp/WEB-INF/web.xml 2595a15 


Diff: https://reviews.apache.org/r/72648/diff/2/

Changes: https://reviews.apache.org/r/72648/diff/1-2/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2015/console

Basic testing done for authorized as well as unauthorized urls, checked whether 
all the response headers are setting or not.

Similar testing done on the knox sso cluster.

Also tested from Curl calls.


Thanks,

Mandar Ambawane



[jira] [Updated] (ATLAS-3841) Response Headers: Code refactoring

2020-07-07 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3841:
---
Description: (was: Currently headers setting code is scattered at 
different places.
In this patch, code refactoring is done to set response headers from 
AtlasHeaderFilter.java

This patch provides flexibility to select response headers to be excluded.
Also this patch provides flexibility to select file formats to be excluded from 
applying response headers.)

> Response Headers: Code refactoring
> --
>
> Key: ATLAS-3841
> URL: https://issues.apache.org/jira/browse/ATLAS-3841
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3841) Response Headers: Code refactoring

2020-07-07 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3841:
---
Description: 
Currently headers setting code is scattered at different places.
In this patch, code refactoring is done to set response headers from 
AtlasHeaderFilter.java

Currently js/ html files come under the unauthorized urls.
Therefore, these files do not have headers which are applied by default by 
spring security.

To overcome this problem, In this patch we are applying all the spring security 
headers to these unauthorized urls explicitly.
We are doing this by mapping all the urls (authorized + unauthorized) to go 
through one servlet filter which is AtlasHeaderFilter.

In case of authorized urls, spring by default set some of the headers. To avoid 
overwriting of these headers in authorized urls, those headers are skipped in 
the AtlasHeaderFilter.

Also this patch provides flexibility to select file formats to be excluded from 
applying response headers.

> Response Headers: Code refactoring
> --
>
> Key: ATLAS-3841
> URL: https://issues.apache.org/jira/browse/ATLAS-3841
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
>
> Currently headers setting code is scattered at different places.
> In this patch, code refactoring is done to set response headers from 
> AtlasHeaderFilter.java
> Currently js/ html files come under the unauthorized urls.
> Therefore, these files do not have headers which are applied by default by 
> spring security.
> To overcome this problem, In this patch we are applying all the spring 
> security headers to these unauthorized urls explicitly.
> We are doing this by mapping all the urls (authorized + unauthorized) to go 
> through one servlet filter which is AtlasHeaderFilter.
> In case of authorized urls, spring by default set some of the headers. To 
> avoid overwriting of these headers in authorized urls, those headers are 
> skipped in the AtlasHeaderFilter.
> Also this patch provides flexibility to select file formats to be excluded 
> from applying response headers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72644: ATLAS-3872 Restrict typedef creation when a child type attribute conflicts with parent type attribute of same name

2020-07-07 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72644/
---

(Updated July 7, 2020, 9:30 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3872
https://issues.apache.org/jira/browse/ATLAS-3872


Repository: atlas


Description
---

Cause of the problem:
Type-def Column is created by quick-start script.

Here in this case, Type-def Column has the attribute "name". And it has 
property isOptional = true

Type-def Column is a child of Type-def Asset which also has the attribute 
"name". And it has property isOptional = false

Now while creating Entity of Type-def Column from UI, it does not show 
attribute "name" in the mandatory fields because for Type-def Column its 
property isOptional = true

But while validating the attributes from server side we iterate through all the 
attributes of Entity type (Including Parent's attributes)
In this case, while validating Type-def Asset's attribute "name" (which has 
property isOptional = false) we get an error because its value is sent as 
"null" from UI side.


Diffs
-

  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6f 
  repository/src/test/resources/sales-v1-full.zip 
07afbf6ecae312a840b54cae5ab01335c513d180 
  webapp/src/main/java/org/apache/atlas/examples/QuickStart.java 82a9f5c 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java d5cf9b7 
  webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java 
6800288 
  
webapp/src/test/java/org/apache/atlas/web/integration/TypesJerseyResourceIT.java
 7c820e7 


Diff: https://reviews.apache.org/r/72644/diff/3/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2007/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2014/console


Thanks,

Mandar Ambawane



Re: Review Request 72648: ATLAS-3841 Response Headers: Code refactoring

2020-07-07 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72648/
---

(Updated July 7, 2020, 9:30 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Bugs: ATLAS-3841
https://issues.apache.org/jira/browse/ATLAS-3841


Repository: atlas


Description
---

Currently headers setting code is scattered at different places.
In this patch, code refactoring is done to set response headers from 
AtlasHeaderFilter.java

This patch provides flexibility to select response headers to be excluded.
Also this patch provides flexibility to select file formats to be excluded from 
applying response headers.


Diffs
-

  distro/src/conf/atlas-application.properties e06e74a 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 d9b1c82 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasCSRFPreventionFilter.java
 df3fce6 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java
 c629a7e 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java 
fa7218c 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
 1944a9f 
  webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationFailureHandler.java
 a117df6 
  
webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationSuccessHandler.java
 e7a5d66 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e9 
  webapp/src/main/webapp/WEB-INF/web.xml 2595a15 


Diff: https://reviews.apache.org/r/72648/diff/1/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2015/console


Thanks,

Mandar Ambawane



Re: [VOTE] Release Apache Atlas version 2.1.0 - rc2

2020-07-07 Thread Mandar Ambawane
+1 for Apache Atlas 2.1.0 RC2 release

Validated the following:
1. Verified the source SHA512 and MD5 checksum
2. Verified the build with -Pdist,embedded-hbase-solr
3. Started Atlas server successfully
4. Verified quick_start.py, all entities and tag get created successfully
5. Created Business metadata and associated with an entity.
6. Checked Basic and advanced search

Thanks,
Mandar

On Tue, Jul 7, 2020 at 12:37 PM vishal suvagia
 wrote:

>  Thank-you Madhan for putting Apache Atlas 2.1.0 release candidate #2.+1
> for Apache Atlas 2.1.0 RC#2.Verified clean compilation and
> rat-checks.Validated the source checksums and hash.
>
> RegardsVishal Suvagia.
>
>
> On Tuesday, 7 July, 2020, 11:56:50 AM IST, Sameer Shaikh <
> sameer.sha...@freestoneinfotech.com> wrote:
>
>  +1 for Apache Atlas 2.1.0 RC2 release
>
> Validated the following:
> 1. Verified the source SHA512,  MD5, and Signature.
> 2. Able to build Atlas successfully.
> 3. Started the Atlas server successfully.
> 4. Done sanitary tests like creating and update the entities,
> classification.
> 5. Test Basic and advanced search.
>
> Thanks & Regards
> Sameer Shaikh
>
> On Tue, Jul 7, 2020 at 10:58 AM Jayendra Parab 
> wrote:
>
> > +1 for Apache Atlas 2.1.0 RC2 release
> >
> > Validated the following:
> > 1. Verified the source SHA512 and MD5 checksum
> > 2. Verified the build with -Pdist,embedded-hbase-solr
> > 3. Started Atlas server successfully
> > 4. Verified quick_start.py, all entities and tag get created successfully
> > 5. Created entities, applied tags from UI
> > 6. Checked Basic and advanced search
> >
> > Regards,
> > Jayendra.
> >
> > On Tue, Jul 7, 2020 at 9:44 AM Nikhil Bonte <
> > nikhil.bo...@freestoneinfotech.com> wrote:
> >
> > > +1 for Apache Atlas 2.1.0 - rc2 release
> > >
> > > Validated the following items.
> > >
> > >- Verified PGP signature.
> > >- Verified md5 and SHA512 digests.
> > >- Packaged with embedded-hbase-solr
> > >- Verified entity creation & tag associations using quick_start.py
> > >- Tested basic, quick & advanced search.
> > >- Tested tag dissociation
> > >
> > > Thanks
> > > Nikhil P. Bonte
> > >
> > > On Mon, Jul 6, 2020 at 12:11 PM Ramesh Mani  wrote:
> > >
> > > > +1 for Apache Atlas 2.1.0 rc2 release.
> > > >
> > > > - Build successfully with the source
> > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz
> > > > - Verified PGP signature.
> > > > - Verified md5 and SHA512 digests.
> > > >
> > > > Thanks.
> > > > Ramesh
> > > >
> > > > On Sat, Jul 4, 2020 at 11:50 PM Madhan Neethiraj 
> > > > wrote:
> > > >
> > > > > Atlas team,
> > > > >
> > > > > Apache Atlas 2.1.0 rc2 is now available for vote within dev
> > community.
> > > > >
> > > > > Links to the release artifacts are given below. Please review and
> > vote.
> > > > >
> > > > > The vote will be open for at least 72 hours or until necessary
> votes
> > > are
> > > > > reached.
> > > > >  [ ] +1 Approve
> > > > >  [ ] +0 No opinion
> > > > >  [ ] -1 Disapprove (and reason why)
> > > > >
> > > > > Thanks,
> > > > > Madhan
> > > > >
> > > > >
> > > > > List of all issues addressed in this release:
> > > > > https://issues.apache.org/jira/issues/?jql=project=ATLAS AND
> > > > > status=Resolved AND fixVersion=2.1.0 ORDER BY key DESC
> > > > >
> > > > > Git tag for the release:
> > > > > https://github.com/apache/atlas/tree/release-2.1.0-rc2
> > > > > Sources for the release:
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz
> > > > >
> > > > > Source release verification:
> > > > >  PGP Signature:
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz.asc
> > > > >  SHA512 Hash:
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz.sha512
> > > > >  MD5 Hash:
> > > > >
> > > >
> > >
> >
> https://dist.apache.org/repos/dist/dev/atlas/2.1.0-rc2/apache-atlas-2.1.0-sources.tar.gz.md5
> > > > >
> > > > > Keys to verify the signature of the release artifacts are available
> > at:
> > > > > https://dist.apache.org/repos/dist/release/atlas/KEYS
> > > > >
> > > > > New features/enhancements:
> > > > >  - Quick Search: provides a simpler search experience with
> > type-ahead
> > > > > suggestions
> > > > >  - Business Metadata: enables augmenting entity-types with
> > additional
> > > > > attributes, search entities using these attributes
> > > > >  - Labels: ability to add/remove labels on entities, and search
> > > entities
> > > > > using labels
> > > > >  - Custom Attributes: ability to add entity instance specific
> custom
> > > > > attributes i.e. attributes not defined in entity-def or business
> > > metadata
> > > > >  - Entity Purge: added REST APIs to purge deleted entities
> > > > >
> > > > > Enhancements:
> > > > >  - Search: ability to find entities by more than one 

[jira] [Updated] (ATLAS-3841) Response Headers: Code refactoring

2020-07-06 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3841:
---
Description: 
Currently headers setting code is scattered at different places.
In this patch, code refactoring is done to set response headers from 
AtlasHeaderFilter.java

This patch provides flexibility to select response headers to be excluded.
Also this patch provides flexibility to select file formats to be excluded from 
applying response headers.

> Response Headers: Code refactoring
> --
>
> Key: ATLAS-3841
> URL: https://issues.apache.org/jira/browse/ATLAS-3841
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
>
> Currently headers setting code is scattered at different places.
> In this patch, code refactoring is done to set response headers from 
> AtlasHeaderFilter.java
> This patch provides flexibility to select response headers to be excluded.
> Also this patch provides flexibility to select file formats to be excluded 
> from applying response headers.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3872) While creating Column entity shows error message

2020-07-04 Thread Mandar Ambawane (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17151320#comment-17151320
 ] 

Mandar Ambawane commented on ATLAS-3872:


*Cause of the problem:*
Type-def Column is created by quick-start script.

Here in this case, Type-def Column has the attribute "name". And it has 
property isOptional = true

Type-def Column is a child of Type-def Asset which also has the attribute 
"name". And it has property isOptional = false

Now while creating Entity of Type-def Column from UI, it does not show 
attribute "name" in the mandatory fields because for Type-def Column its 
property isOptional = true

But while validating the attributes from server side we iterate through all the 
attributes of Entity type (Including Parent's attributes)
In this case, while validating Type-def Asset's attribute "name" (which has 
property isOptional = false) we get an error because its value is sent as 
"null" from UI side.

> While creating Column entity shows error message
> 
>
> Key: ATLAS-3872
> URL: https://issues.apache.org/jira/browse/ATLAS-3872
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Durga Kadam
>Assignee: Mandar Ambawane
>Priority: Minor
> Attachments: column_entity_name_field_issue.ogv
>
>
> Description:: While creating Column entity(whose entity-type has been 
> generated from running quick_start.py) if user does not provide the 'name'(by 
> enabling the toggle 'Required All') it shows below error message.
> Error message:: 
> Invalid instance creation/updation parameters passed : Column.name: mandatory 
> attribute value missing in type Asset
> Steps to reproduce issue::
>  # Go to Create  entity
>  # Select 'Column' type
>  # Enter 'QualifiedName(string)' and select the 'Table(Table)' from drop-down
>  # Click on Create buttonIt will show error message
> Note-
>  # If user provides the 'name' which is listed inside the 'Required All' tab 
> it will allow user to save the entity. PFA attached video.
>  # Working fine for Hive_column and Hbase_column as user provides the 
> mandatory name field which is listed outside the 'Required All' tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-3872) While creating Column entity shows error message

2020-06-30 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-3872:
--

Assignee: Mandar Ambawane

> While creating Column entity shows error message
> 
>
> Key: ATLAS-3872
> URL: https://issues.apache.org/jira/browse/ATLAS-3872
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 3.0.0
>Reporter: Durga Kadam
>    Assignee: Mandar Ambawane
>Priority: Minor
> Attachments: column_entity_name_field_issue.ogv
>
>
> Description:: While creating Column entity(whose entity-type has been 
> generated from running quick_start.py) if user does not provide the 'name'(by 
> enabling the toggle 'Required All') it shows below error message.
> Error message:: 
> Invalid instance creation/updation parameters passed : Column.name: mandatory 
> attribute value missing in type Asset
> Steps to reproduce issue::
>  # Go to Create  entity
>  # Select 'Column' type
>  # Enter 'QualifiedName(string)' and select the 'Table(Table)' from drop-down
>  # Click on Create buttonIt will show error message
> Note-
>  # If user provides the 'name' which is listed inside the 'Required All' tab 
> it will allow user to save the entity. PFA attached video.
>  # Working fine for Hive_column and Hbase_column as user provides the 
> mandatory name field which is listed outside the 'Required All' tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72612: ATLAS-3854: Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72612/
---

(Updated June 22, 2020, 2:53 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Summary (updated)
-

ATLAS-3854: Upgrade Spring Security version to 4.2.16


Bugs: ATLAS-3854
https://issues.apache.org/jira/browse/ATLAS-3854


Repository: atlas


Description
---

Spring Security versions 5.3.x prior to 5.3.2, 5.2.x prior to 5.2.4, 5.1.x 
prior to 5.1.10, 5.0.x prior to 5.0.16 and 4.2.x prior to 4.2.16 use a fixed 
null initialization vector with CBC Mode in the implementation of the queryable 
text encryptor. A malicious user with access to the data that has been 
encrypted using such an encryptor may be able to derive the unencrypted values 
using a dictionary attack.

To resolve this need to upgrade Spring security to 4.2.16


Diffs
-

  pom.xml 8d02a6f 


Diff: https://reviews.apache.org/r/72612/diff/1/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1970/console


Thanks,

Mandar Ambawane



[jira] [Created] (ATLAS-3854) Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3854:
--

 Summary: Upgrade Spring Security version to 4.2.16
 Key: ATLAS-3854
 URL: https://issues.apache.org/jira/browse/ATLAS-3854
 Project: Atlas
  Issue Type: Bug
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane


Spring Security versions 5.3.x prior to 5.3.2, 5.2.x prior to 5.2.4, 5.1.x 
prior to 5.1.10, 5.0.x prior to 5.0.16 and 4.2.x prior to 4.2.16 use a fixed 
null initialization vector with CBC Mode in the implementation of the queryable 
text encryptor. A malicious user with access to the data that has been 
encrypted using such an encryptor may be able to derive the unencrypted values 
using a dictionary attack.
To resolve this need to upgrade Spring security to 4.2.16



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3854) Upgrade Spring Security version to 4.2.16

2020-06-22 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane updated ATLAS-3854:
---
Description: 
Spring Security versions 5.3.x prior to 5.3.2, 5.2.x prior to 5.2.4, 5.1.x 
prior to 5.1.10, 5.0.x prior to 5.0.16 and 4.2.x prior to 4.2.16 use a fixed 
null initialization vector with CBC Mode in the implementation of the queryable 
text encryptor. A malicious user with access to the data that has been 
encrypted using such an encryptor may be able to derive the unencrypted values 
using a dictionary attack.


 To resolve this need to upgrade Spring security to 4.2.16

  was:
Spring Security versions 5.3.x prior to 5.3.2, 5.2.x prior to 5.2.4, 5.1.x 
prior to 5.1.10, 5.0.x prior to 5.0.16 and 4.2.x prior to 4.2.16 use a fixed 
null initialization vector with CBC Mode in the implementation of the queryable 
text encryptor. A malicious user with access to the data that has been 
encrypted using such an encryptor may be able to derive the unencrypted values 
using a dictionary attack.
To resolve this need to upgrade Spring security to 4.2.16


> Upgrade Spring Security version to 4.2.16
> -
>
> Key: ATLAS-3854
> URL: https://issues.apache.org/jira/browse/ATLAS-3854
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
>
> Spring Security versions 5.3.x prior to 5.3.2, 5.2.x prior to 5.2.4, 5.1.x 
> prior to 5.1.10, 5.0.x prior to 5.0.16 and 4.2.x prior to 4.2.16 use a fixed 
> null initialization vector with CBC Mode in the implementation of the 
> queryable text encryptor. A malicious user with access to the data that has 
> been encrypted using such an encryptor may be able to derive the unencrypted 
> values using a dictionary attack.
>  To resolve this need to upgrade Spring security to 4.2.16



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72593: ATLAS-3841 Response Headers: Code refactoring

2020-06-16 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72593/
---

(Updated June 16, 2020, 2:37 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3841
https://issues.apache.org/jira/browse/ATLAS-3841


Repository: atlas


Description
---

Currently headers setting code is scattered at different places.
In this patch, code refactoring is done to set response headers from 
AtlasHeaderFilter.java

Also this patch provides flexibility to select file formats to be excluded from 
applying response headers.


Diffs
-

  distro/src/conf/atlas-application.properties e06e74a 
  intg/src/main/java/org/apache/atlas/AtlasConfiguration.java 2c007ca 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthenticationFilter.java
 d9b1c82 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasDelegatingAuthenticationEntryPoint.java
 c629a7e 
  webapp/src/main/java/org/apache/atlas/web/filters/AtlasHeaderFilter.java 
fa7218c 
  
webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java
 1944a9f 
  webapp/src/main/java/org/apache/atlas/web/filters/HeadersUtil.java 1f8845d 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e9 
  webapp/src/main/webapp/WEB-INF/web.xml 2595a15 


Diff: https://reviews.apache.org/r/72593/diff/1/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1964/console


Thanks,

Mandar Ambawane



[jira] [Assigned] (ATLAS-3841) Response Headers: Code refactoring

2020-06-15 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-3841:
--

Assignee: Mandar Ambawane

> Response Headers: Code refactoring
> --
>
> Key: ATLAS-3841
> URL: https://issues.apache.org/jira/browse/ATLAS-3841
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3841) Response Headers: Code refactoring

2020-06-15 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3841:
--

 Summary: Response Headers: Code refactoring
 Key: ATLAS-3841
 URL: https://issues.apache.org/jira/browse/ATLAS-3841
 Project: Atlas
  Issue Type: Bug
Reporter: Mandar Ambawane






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72582: ATLAS-3835 Atlas security headers missing in .js and .html file apis

2020-06-10 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72582/
---

Review request for atlas, Jayendra Parab and Nixon Rodrigues.


Bugs: ATLAS-3835
https://issues.apache.org/jira/browse/ATLAS-3835


Repository: atlas


Description
---

Mapped AtlasHeaderFilter to .js and .html file apis


Diffs
-

  webapp/src/main/webapp/WEB-INF/web.xml 2595a15 


Diff: https://reviews.apache.org/r/72582/diff/1/


Testing
---


Thanks,

Mandar Ambawane



[jira] [Assigned] (ATLAS-3835) Atlas security headers missing in .js and .html file apis

2020-06-10 Thread Mandar Ambawane (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mandar Ambawane reassigned ATLAS-3835:
--

Assignee: Mandar Ambawane

> Atlas security headers missing in .js and .html file apis
> -
>
> Key: ATLAS-3835
> URL: https://issues.apache.org/jira/browse/ATLAS-3835
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Mandar Ambawane
>    Assignee: Mandar Ambawane
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3835) Atlas security headers missing in .js and .html file apis

2020-06-10 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3835:
--

 Summary: Atlas security headers missing in .js and .html file apis
 Key: ATLAS-3835
 URL: https://issues.apache.org/jira/browse/ATLAS-3835
 Project: Atlas
  Issue Type: Bug
Reporter: Mandar Ambawane






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72546: ATLAS-3813 Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System

2020-06-02 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72546/
---

(Updated June 2, 2020, 1:35 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Changes done for: If atleast one metadata out of listed metadatas in the file 
is imported, then show message as Successful.


Bugs: ATLAS-3813
https://issues.apache.org/jira/browse/ATLAS-3813


Repository: atlas


Description
---

While importing Hive-data from the file, if file has db names and table names 
which are not in the Hive. Application still shows message as "Hive Meta Data 
imported successfully!!!"

While importing Kafka-Topic data from the file, if file has Topic names  which 
are not present in Kafka. Application still shows message as "Kafka Data Model 
imported successfully!!!"


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 eb691dc 
  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 40b1fee 


Diff: https://reviews.apache.org/r/72546/diff/4/

Changes: https://reviews.apache.org/r/72546/diff/3-4/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1920/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1922/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1940/console


Thanks,

Mandar Ambawane



[jira] [Created] (ATLAS-3822) UI changes: Audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-06-01 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3822:
--

 Summary: UI changes: Audit entries for TypeDefs CREATE, UPDATE and 
DELETE
 Key: ATLAS-3822
 URL: https://issues.apache.org/jira/browse/ATLAS-3822
 Project: Atlas
  Issue Type: Bug
Reporter: Mandar Ambawane
Assignee: Keval Bhatt






--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72546: ATLAS-3813 Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System

2020-06-01 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72546/
---

(Updated June 1, 2020, 6:35 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3813
https://issues.apache.org/jira/browse/ATLAS-3813


Repository: atlas


Description
---

While importing Hive-data from the file, if file has db names and table names 
which are not in the Hive. Application still shows message as "Hive Meta Data 
imported successfully!!!"

While importing Kafka-Topic data from the file, if file has Topic names  which 
are not present in Kafka. Application still shows message as "Kafka Data Model 
imported successfully!!!"


Diffs (updated)
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 eb691dc 
  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 40b1fee 


Diff: https://reviews.apache.org/r/72546/diff/3/

Changes: https://reviews.apache.org/r/72546/diff/2-3/


Testing
---

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1920/console

PreCommit: https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1922/console


Thanks,

Mandar Ambawane



Review Request 72546: ATLAS-3813 Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System

2020-05-27 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72546/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3813
https://issues.apache.org/jira/browse/ATLAS-3813


Repository: atlas


Description
---

While importing Hive-data from the file, if file has db names and table names 
which are not in the Hive. Application still shows message as "Hive Meta Data 
imported successfully!!!"

While importing Kafka-Topic data from the file, if file has Topic names  which 
are not present in Kafka. Application still shows message as "Kafka Data Model 
imported successfully!!!"


Diffs
-

  
addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
 eb691dc 
  addons/kafka-bridge/pom.xml 7b95aa3 
  
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java
 40b1fee 


Diff: https://reviews.apache.org/r/72546/diff/1/


Testing
---


Thanks,

Mandar Ambawane



[jira] [Created] (ATLAS-3813) Import-.sh script shows wrong message of Import success even when there are no database/table/topic are imported in the System

2020-05-27 Thread Mandar Ambawane (Jira)
Mandar Ambawane created ATLAS-3813:
--

 Summary: Import-.sh script shows wrong message of 
Import success even when there are no database/table/topic are imported in the 
System
 Key: ATLAS-3813
 URL: https://issues.apache.org/jira/browse/ATLAS-3813
 Project: Atlas
  Issue Type: Bug
Reporter: Mandar Ambawane
Assignee: Mandar Ambawane


While importing Hive-data from the file, if file has db names and table names 
which are not in the Hive. Application still shows message as "Hive Meta Data 
imported successfully!!!"

While importing Kafka-Topic data from the file, if file has Topic names  which 
are not present in Kafka. Application still shows message as "Kafka Data Model 
imported successfully!!!"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-05-13 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated May 13, 2020, 9:13 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f5270 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/3/

Changes: https://reviews.apache.org/r/72477/diff/2-3/


Testing (updated)
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1888/console


Thanks,

Mandar Ambawane



Re: Review Request 72477: ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, UPDATE and DELETE

2020-05-13 Thread Mandar Ambawane

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72477/
---

(Updated May 13, 2020, 3:02 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
Sarath Subramanian, and Sidharth Mishra.


Changes
---

Changes to store entire TypeDef json in AuditEntry.
Added Test cases.


Bugs: ATLAS-3583
https://issues.apache.org/jira/browse/ATLAS-3583


Repository: atlas


Description
---

ATLAS-3583 Use Audit framework to generate audit entries for TypeDefs CREATE, 
UPDATE and DELETE


Diffs (updated)
-

  addons/models/-Area0/0010-base_model.json 9777b7a 
  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java a95cf4e 
  intg/src/main/java/org/apache/atlas/model/audit/AuditSearchParameters.java 
9120062 
  intg/src/test/java/org/apache/atlas/TestUtilsV2.java 2b9cf6e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 a0dc816 
  
repository/src/main/java/org/apache/atlas/repository/audit/TypeDefAuditListener.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f5270 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 0dc3193 
  repository/src/test/java/org/apache/atlas/TestModules.java a298934 
  webapp/src/test/java/org/apache/atlas/web/adapters/TestTypeDefsREST.java 
PRE-CREATION 


Diff: https://reviews.apache.org/r/72477/diff/2/

Changes: https://reviews.apache.org/r/72477/diff/1-2/


Testing (updated)
---

Basic testing is done.

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1871/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1885/console


Thanks,

Mandar Ambawane



  1   2   3   >