Re: Review Request 73057: ATLAS-3913 Swagger documentation for APIs

2020-12-03 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73057/#review86
---


Ship it!




Ship It!

- Nixon Rodrigues


On Dec. 3, 2020, 12:29 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73057/
> ---
> 
> (Updated Dec. 3, 2020, 12:29 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sameer Shaikh, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3913
> https://issues.apache.org/jira/browse/ATLAS-3913
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Currently, swagger documentation is not available with packaging.
> This change will allow atlas server deployment to host its REST API doc using 
> Swagger.
> 
> ## Approach:
> 
> * Update enuntiate plugin version from 2.11.1 to 2.13.2
> * Download latest swagger-ui from 
> https://github.com/swagger-api/swagger-ui/archive/v3.36.2.zip & extract.
> * Move swagger-ui-3.36.2/dist/ to 
> build-tools/src/main/resources/ui-dist
> * Update swagger tag in enuntiate.xml
> * Inside build-tools/src/main/resources/ui-dist :
> * Create index.js
> * Modify SwaggerUIBundle object in ui-dist/index.html to load 
> index.js along with following:
> 1 modify url to load swagger.json
> 2 Add requestInterceptor
> * Updated Header.js, UrlLinks.js, Header.html to add API documentation menu.
> 
> 
> ## How to navigate to the documentation page?
> 
> -> Once Atlas UI is loaded, goto Logged-in-User -> Help -> API Documentation 
> (see attached screenshot for reference)
> 
> 
> Diffs
> -
> 
>   3party-licenses/normalize.css-LICENSE PRE-CREATION 
>   3party-licenses/swagger-ui-LECENSE PRE-CREATION 
>   build-tools/src/main/resources/enunciate.xml 8a9383a01 
>   build-tools/src/main/resources/ui-dist/index.html PRE-CREATION 
>   build-tools/src/main/resources/ui-dist/index.js PRE-CREATION 
>   build-tools/src/main/resources/ui-dist/swagger-ui-bundle.js PRE-CREATION 
>   build-tools/src/main/resources/ui-dist/swagger-ui-standalone-preset.js 
> PRE-CREATION 
>   build-tools/src/main/resources/ui-dist/swagger-ui.css PRE-CREATION 
>   dashboardv2/public/js/templates/site/Header.html 97e124aaa 
>   dashboardv2/public/js/utils/UrlLinks.js 6d3c07952 
>   dashboardv2/public/js/views/site/Header.js 2d6b55d47 
>   dashboardv3/public/js/templates/site/Header.html 6d5e6efac 
>   dashboardv3/public/js/utils/UrlLinks.js 69e527442 
>   dashboardv3/public/js/views/site/Header.js cce00c730 
>   pom.xml ba9450c16 
>   webapp/pom.xml fe5dc0bdb 
> 
> 
> Diff: https://reviews.apache.org/r/73057/diff/3/
> 
> 
> Testing
> ---
> 
> Tested few APIs (POST | GET| DELETE) manually.
> 
> 
> File Attachments
> 
> 
> How-to-navigate-to-the-documentation-page
>   
> https://reviews.apache.org/media/uploaded/files/2020/12/02/8fe22101-fbf8-4ab2-87d9-6bfee0949845__99964008-a62afe80-2db8-11eb-8ecd-cea617fe7f4a.png
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>



Re: Review Request 73047: ATLAS-4054 : Change Atlas config for atlas.jetty.request.buffer.size

2020-12-03 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73047/#review79
---


Ship it!




Ship It!

- Nixon Rodrigues


On Dec. 3, 2020, 12:53 p.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73047/
> ---
> 
> (Updated Dec. 3, 2020, 12:53 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4054
> https://issues.apache.org/jira/browse/ATLAS-4054
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Jetty was upgraded to 9.2.x prior to this jira, but due to some issues with 
> the jetty version, it was reverted back to jetty 8.x, but code changes to set 
> header size were incorrect,
> 
> connector.setResponseBufferSize(bufferSize);
> connector.setRequestBufferSize(bufferSize);
> 
> Prior to change Atlas responds with 413 code even with the header size less 
> than 8K (default header size in jetty 8 is 6K)
> 
> curl -w % {size_header} -u admin:'admin' -H "X-LongHeader: $(cat /dev/urandom 
> | tr -dc 'a-zA-Z0-9' | fold -w 6000 | head -n 1)" 
> hostname:21000/api/atlas/admin/session
> Error: Request Entity Too Large: head99[root@c116-node8 ~]#
> 
> After code changes and setting buffer.size to 16000:
> 
> #curl -w %{size_header}
> -u admin:'admin' -H "X-LongHeader: $(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | 
> fold -w 16000 | head -n 1)" hostname:21000/api/atlas/admin/session
> [root]# curl -w %
> 
> {size_header}
> -u admin:'admin' -H "X-LongHeader: $(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | 
> fold -w 15000 | head -n 1)" hostname:21000/api/atlas/admin/session
> 
> {"atlas.rest-csrf.enabled":true,"atlas.rest-csrf.browser-useragents-regex":"^Mozilla.*,^Opera.*,^Chrome","atlas.rest-csrf.methods-to-ignore":"GET,OPTIONS,HEAD,TRACE","atlas.rest-csrf.custom-header":"X-XSRF-HEADER","atlas.feature.taxonomy.enable":false,"atlas.entity.update.allowed":true,"atlas.entity.create.allowed":true,"atlas.ui.editable.entity.types":"hdfs_path,hbase_table,hbase_column,hbase_column_family,kafka_topic","userName":"admin","groups":["ROLE_ADMIN"]}
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 5724ad131 
> 
> 
> Diff: https://reviews.apache.org/r/73047/diff/2/
> 
> 
> Testing
> ---
> 
> Precommit:
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/228/console
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 73047: ATLAS-4054 : Change Atlas config for atlas.jetty.request.buffer.size

2020-12-02 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73047/#review76
---


Ship it!




Ship It!

- Nixon Rodrigues


On Dec. 1, 2020, 8:12 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73047/
> ---
> 
> (Updated Dec. 1, 2020, 8:12 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4054
> https://issues.apache.org/jira/browse/ATLAS-4054
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Jetty was upgraded to 9.2.x prior to this jira, but due to some issues with 
> the jetty version, it was reverted back to jetty 8.x, but code changes to set 
> header size were incorrect,
> 
> connector.setResponseBufferSize(bufferSize);
> connector.setRequestBufferSize(bufferSize);
> 
> Prior to change Atlas responds with 413 code even with the header size less 
> than 8K (default header size in jetty 8 is 6K)
> 
> curl -w % {size_header} -u admin:'admin' -H "X-LongHeader: $(cat /dev/urandom 
> | tr -dc 'a-zA-Z0-9' | fold -w 6000 | head -n 1)" 
> hostname:21000/api/atlas/admin/session
> Error: Request Entity Too Large: head99[root@c116-node8 ~]#
> 
> After code changes and setting buffer.size to 16000:
> 
> #curl -w %{size_header}
> -u admin:'admin' -H "X-LongHeader: $(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | 
> fold -w 16000 | head -n 1)" hostname:21000/api/atlas/admin/session
> [root]# curl -w %
> 
> {size_header}
> -u admin:'admin' -H "X-LongHeader: $(cat /dev/urandom | tr -dc 'a-zA-Z0-9' | 
> fold -w 15000 | head -n 1)" hostname:21000/api/atlas/admin/session
> 
> {"atlas.rest-csrf.enabled":true,"atlas.rest-csrf.browser-useragents-regex":"^Mozilla.*,^Opera.*,^Chrome","atlas.rest-csrf.methods-to-ignore":"GET,OPTIONS,HEAD,TRACE","atlas.rest-csrf.custom-header":"X-XSRF-HEADER","atlas.feature.taxonomy.enable":false,"atlas.entity.update.allowed":true,"atlas.entity.create.allowed":true,"atlas.ui.editable.entity.types":"hdfs_path,hbase_table,hbase_column,hbase_column_family,kafka_topic","userName":"admin","groups":["ROLE_ADMIN"]}
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/service/EmbeddedServer.java 
> 5724ad131 
> 
> 
> Diff: https://reviews.apache.org/r/73047/diff/1/
> 
> 
> Testing
> ---
> 
> Precommit:
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/228/console
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 73030: ATLAS-4034: Export operation audit with result count 0 for empty exports is inconsistent ATLAS-4041: operation status info of IMPORT/EXPORT operation in the Admin import/expo

2020-11-25 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73030/#review37
---


Ship it!




Ship It!

- Nixon Rodrigues


On Nov. 20, 2020, 2:22 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73030/
> ---
> 
> (Updated Nov. 20, 2020, 2:22 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4034 and ATLAS-4041
> https://issues.apache.org/jira/browse/ATLAS-4034
> https://issues.apache.org/jira/browse/ATLAS-4041
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch handles 2 jiras.
> 
> 1. ATLAS-4034 Where if there is no data provided in the export json to 
> export, Atlas does not create any Audit entry for the Export operation
> 
> 2. ATLAS-4041 Where OperationStatus of Import/Export operations is provided 
> in the Audit entry.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 4db477e 
> 
> 
> Diff: https://reviews.apache.org/r/73030/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing Done
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



[jira] [Commented] (ATLAS-4022) Atlas UI: After d3 verion upgrade profile tab not working

2020-11-18 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17234636#comment-17234636
 ] 

Nixon Rodrigues commented on ATLAS-4022:


+1 for the patch. [~kevalbhatt] thanks

> Atlas UI: After d3 verion upgrade profile tab not working
> -
>
> Key: ATLAS-4022
> URL: https://issues.apache.org/jira/browse/ATLAS-4022
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-4022.patch
>
>
> The Profile tab only shows loader.
> Removing nvd3 dependency from atlas.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4020) Exclude calcite-core jar

2020-11-17 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4020:
---
Fix Version/s: 2.2.0

> Exclude calcite-core jar 
> -
>
> Key: ATLAS-4020
> URL: https://issues.apache.org/jira/browse/ATLAS-4020
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> solr-test-framework is pulling in Calcite 1.13.0 in atlas



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4017) Atlas - Use latest Solr 8.x version

2020-11-10 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4017?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4017:
---
Summary: Atlas - Use  latest Solr 8.x version  (was: Atlas - Use internal 
Solr version or latest Solr 8.x version)

> Atlas - Use  latest Solr 8.x version
> 
>
> Key: ATLAS-4017
> URL: https://issues.apache.org/jira/browse/ATLAS-4017
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 3.0.0
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 3.0.0
>
>
> upgrade solr.version and lucene-solr.version to 8.x version



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

2020-11-09 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4016:
---
Summary: Update authorization - "admin-audits" for retrieving admin audits  
(was: Update authorization - "admin-audit" for retrieving admin audits)

> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>      Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Major
>
>  
>  
> For Atlas Admin Audits we need to add new privilege - "*admin-audit*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-4016) Update authorization - "admin-audits" for retrieving admin audits

2020-11-09 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4016:
---
Description: 
 
  
 For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
authorization

Similar permission needs to be updated in ranger atlas service-def .

  was:
 
 
For Atlas Admin Audits we need to add new privilege - "*admin-audit*"  for 
authorization

Similar permission needs to be updated in ranger atlas service-def .


> Update authorization - "admin-audits" for retrieving admin audits
> -
>
> Key: ATLAS-4016
> URL: https://issues.apache.org/jira/browse/ATLAS-4016
> Project: Atlas
>      Issue Type: Bug
>Reporter: Nixon Rodrigues
>Priority: Major
>
>  
>   
>  For Atlas Admin Audits we need to add new privilege - "*admin-audits*"  for 
> authorization
> Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-4016) Update authorization - "admin-audit" for retrieving admin audits

2020-11-09 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-4016:
--

 Summary: Update authorization - "admin-audit" for retrieving admin 
audits
 Key: ATLAS-4016
 URL: https://issues.apache.org/jira/browse/ATLAS-4016
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


 
 
For Atlas Admin Audits we need to add new privilege - "*admin-audit*"  for 
authorization

Similar permission needs to be updated in ranger atlas service-def .



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72943: ATLAS-3988 : REST GET entity API with type's GUID throws NPE

2020-11-03 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72943/#review222163
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 21, 2020, 6:51 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72943/
> ---
> 
> (Updated Oct. 21, 2020, 6:51 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3988
> https://issues.apache.org/jira/browse/ATLAS-3988
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue :
> GET on /api/atlas/v2/entity/guid/ throws invalid GUID exception.
> 
> BUT GET on /api/atlas/v2/entity/guid/ throws NPE.
> 
>  
> 2020-01-14 02:19:07,272 ERROR - [pool-2-thread-3 - 
> a0b7457e-d43f-4fca-9581-8db695ef7af3:] ~ graph rollback due to exception 
> (GraphTransactionInterceptor:167)
> java.lang.NullPointerException
> at org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:94)
> at 
> org.apache.atlas.repository.store.graph.v2.EntityGraphRetriever.mapAttributes(EntityGraphRetriever.java:608)
> at 
> org.apache.atlas.repository.store.graph.v2.EntityGraphRetriever.mapVertexToAtlasEntity(EntityGraphRetriever.java:448)
> 
> This patch fixes the issue by adding a null check for typename exists or not 
> for the guid passed.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  2199277ad 
> 
> 
> Diff: https://reviews.apache.org/r/72943/diff/2/
> 
> 
> Testing
> ---
> 
> Tested with GET call GET on /api/atlas/v2/entity/guid/  by 
> passing typename guid to this entity call.
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 72943: ATLAS-3988 : REST GET entity API with type's GUID throws NPE

2020-11-03 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72943/#review222162
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 21, 2020, 6:51 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72943/
> ---
> 
> (Updated Oct. 21, 2020, 6:51 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3988
> https://issues.apache.org/jira/browse/ATLAS-3988
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Issue :
> GET on /api/atlas/v2/entity/guid/ throws invalid GUID exception.
> 
> BUT GET on /api/atlas/v2/entity/guid/ throws NPE.
> 
>  
> 2020-01-14 02:19:07,272 ERROR - [pool-2-thread-3 - 
> a0b7457e-d43f-4fca-9581-8db695ef7af3:] ~ graph rollback due to exception 
> (GraphTransactionInterceptor:167)
> java.lang.NullPointerException
> at org.apache.atlas.type.AtlasTypeRegistry.getType(AtlasTypeRegistry.java:94)
> at 
> org.apache.atlas.repository.store.graph.v2.EntityGraphRetriever.mapAttributes(EntityGraphRetriever.java:608)
> at 
> org.apache.atlas.repository.store.graph.v2.EntityGraphRetriever.mapVertexToAtlasEntity(EntityGraphRetriever.java:448)
> 
> This patch fixes the issue by adding a null check for typename exists or not 
> for the guid passed.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java a14e43a1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  2199277ad 
> 
> 
> Diff: https://reviews.apache.org/r/72943/diff/2/
> 
> 
> Testing
> ---
> 
> Tested with GET call GET on /api/atlas/v2/entity/guid/  by 
> passing typename guid to this entity call.
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 72993: Cache getGuid and getStatus in GraphTransactionInterceptor

2020-10-29 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72993/#review222147
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 29, 2020, 9:34 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72993/
> ---
> 
> (Updated Oct. 29, 2020, 9:34 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, madhan, Nixon 
> Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-4008
> https://issues.apache.org/jira/browse/ATLAS-4008
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Problem Statement:
> 
> GraphHelper.getGuid() & GraphHelper.getStatus() causes overhead when called 
> multiple times in a same request.
> 
>  
> 
> Approach:
> 
> Implement a caching mechanism in GraphTransactionInterceptor to cache the 
> following mappings:
> 
> * vertexID -> guid
> * vertexID -> entityStatus
> * edgeId   -> status
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/GraphTransactionInterceptor.java 
> 57e454a8e 
>   repository/src/main/java/org/apache/atlas/repository/graph/GraphHelper.java 
> ca46d0fdb 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
>  9360dd3c9 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasComplexAttributesTest.java
>  ad5fa92bd 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2Test.java
>  b9cbef1b0 
> 
> 
> Diff: https://reviews.apache.org/r/72993/diff/2/
> 
> 
> Testing
> ---
> 
> PC build : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/167/console
>  - Finished: SUCCESS
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>



Re: Review Request 72991: Export/Import: Add Support for BusinessMetadata Attributes

2020-10-27 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72991/#review222134
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 27, 2020, 8:21 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72991/
> ---
> 
> (Updated Oct. 27, 2020, 8:21 p.m.)
> 
> 
> Review request for atlas, Nikhil Bonte and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4006 and ATLAS-4007
> https://issues.apache.org/jira/browse/ATLAS-4006
> https://issues.apache.org/jira/browse/ATLAS-4007
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Background**
> Existing implementation does not support export and import of _Business 
> Metadata_ (BM) attributes. 
> 
> **Implementation**
> - Export: Updated existing flow to include detecting BM attributes and adding 
> the types to the exported payload.
> - Import: Updated _TypeAttributeDifference_ to include BM attribute detection 
> and update.
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  0491a853a 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  664af9166 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ImportTypeDefProcessor.java
>  b65807742 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/TypeAttributeDifference.java
>  0d78dbe57 
>   
> repository/src/test/java/org/apache/atlas/repository/impexp/TypeAttributeDifferenceTest.java
>  f9b7cd11f 
> 
> 
> Diff: https://reviews.apache.org/r/72991/diff/1/
> 
> 
> Testing
> ---
> 
> **Unit tests**
> New tests added.
> 
> **Functional testing**
> End-to-end tests. (Export-import-export).
> 
> **Pre-commit Build**
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/154/
> 
> 
> Thanks,
> 
> Ashutosh Mestry
> 
>



[jira] [Updated] (ATLAS-4009) Atlas Build with -Pdist,embedded-hbase-solr option fails on master.

2020-10-27 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4009:
---
Description: 
* Atlas Build with -Pdist,embedded-hbase-solr option fails on master with 
Failed to execute goal 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy (copy-hook) on 
project storm-bridge: Unable to parse configuration of mojo 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy

 
{noformat}
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Atlas Server Build Tools 1.0  SUCCESS [  0.876 s]
[INFO] apache-atlas 3.0.0-SNAPSHOT  SUCCESS [ 22.974 s]
[INFO] Apache Atlas Integration ... SUCCESS [ 27.070 s]
[INFO] Apache Atlas Test Utility Tools  SUCCESS [ 14.643 s]
[INFO] Apache Atlas Common  SUCCESS [ 12.393 s]
[INFO] Apache Atlas Client  SUCCESS [  1.135 s]
[INFO] atlas-client-common  SUCCESS [  7.428 s]
[INFO] atlas-client-v1  SUCCESS [  7.253 s]
[INFO] Apache Atlas Server API  SUCCESS [  9.529 s]
[INFO] Apache Atlas Notification .. SUCCESS [ 15.347 s]
[INFO] atlas-client-v2  SUCCESS [  7.187 s]
[INFO] Apache Atlas Graph Database Projects ... SUCCESS [  0.759 s]
[INFO] Apache Atlas Graph Database API  SUCCESS [  6.837 s]
[INFO] Graph Database Common Code . SUCCESS [  5.506 s]
[INFO] Apache Atlas JanusGraph-HBase2 Module .. SUCCESS [  8.404 s]
[INFO] Apache Atlas JanusGraph DB Impl  SUCCESS [ 19.948 s]
[INFO] Apache Atlas Graph Database Implementation Dependencies SUCCESS [  2.546 
s]
[INFO] Apache Atlas Authorization . SUCCESS [ 10.379 s]
[INFO] Apache Atlas Repository  SUCCESS [ 41.996 s]
[INFO] Apache Atlas UI  SUCCESS [ 47.226 s]
[INFO] Apache Atlas New UI  SUCCESS [ 47.325 s]
[INFO] Apache Atlas Web Application ... SUCCESS [01:37 min]
[INFO] Apache Atlas Documentation . SUCCESS [ 14.091 s]
[INFO] Apache Atlas FileSystem Model .. SUCCESS [  4.903 s]
[INFO] Apache Atlas Plugin Classloader  SUCCESS [  8.600 s]
[INFO] Apache Atlas Hive Bridge Shim .. SUCCESS [  9.450 s]
[INFO] Apache Atlas Hive Bridge ... SUCCESS [ 25.791 s]
[INFO] Apache Atlas Falcon Bridge Shim  SUCCESS [  7.541 s]
[INFO] Apache Atlas Falcon Bridge . SUCCESS [ 10.681 s]
[INFO] Apache Atlas Sqoop Bridge Shim . SUCCESS [  5.474 s]
[INFO] Apache Atlas Sqoop Bridge .. SUCCESS [ 18.287 s]
[INFO] Apache Atlas Storm Bridge Shim . SUCCESS [  5.192 s]
[INFO] Apache Atlas Storm Bridge .. FAILURE [  6.924 s]
[INFO] Apache Atlas Hbase Bridge Shim . SKIPPED
[INFO] Apache Atlas Hbase Bridge .. SKIPPED
[INFO] Apache HBase - Testing Util  SKIPPED
[INFO] Apache Atlas Kafka Bridge .. SKIPPED
[INFO] Apache Atlas classification updater  SKIPPED
[INFO] Apache Atlas index repair tool . SKIPPED
[INFO] Apache Atlas Impala Hook API ... SKIPPED
[INFO] Apache Atlas Impala Bridge Shim  SKIPPED
[INFO] Apache Atlas Impala Bridge . SKIPPED
[INFO] Apache Atlas Distribution .. SKIPPED
[INFO] atlas-examples . SKIPPED
[INFO] sample-app 3.0.0-SNAPSHOT .. SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 08:52 min
[INFO] Finished at: 2020-10-27T13:27:10+05:30
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy (copy-hook) on 
project storm-bridge: Unable to parse configuration of mojo 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy for parameter 
exclusions: Cannot find 'exclusions' in class 
org.apache.maven.plugins.dependency.fromConfiguration.ArtifactItem -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy (copy-hook) on 
project storm-bridge: Unable to parse configuration of mojo 
org.apache.maven.plugins:maven-dependency-plugin:3.

[jira] [Updated] (ATLAS-4009) Atlas Build with -Pdist,embedded-hbase-solr option fails on master.

2020-10-27 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4009:
---
Summary: Atlas Build with -Pdist,embedded-hbase-solr  option fails on 
master.   (was: Atlas Build with -Pdist,embedded-hbase-solr  options fail on 
master )

> Atlas Build with -Pdist,embedded-hbase-solr  option fails on master. 
> -
>
> Key: ATLAS-4009
> URL: https://issues.apache.org/jira/browse/ATLAS-4009
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>Priority: Major
> Attachments: Screenshot from 2020-10-27 19-24-54.png
>
>
> Atlas Build with -Pdist,embedded-hbase-solr options fail on master with 
> Failed to execute goal 
> org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy (copy-hook) on 
> project storm-bridge: Unable to parse configuration of mojo 
> org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy
>  
> {noformat}
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Atlas Server Build Tools 1.0  SUCCESS [  0.876 
> s]
> [INFO] apache-atlas 3.0.0-SNAPSHOT  SUCCESS [ 22.974 
> s]
> [INFO] Apache Atlas Integration ... SUCCESS [ 27.070 
> s]
> [INFO] Apache Atlas Test Utility Tools  SUCCESS [ 14.643 
> s]
> [INFO] Apache Atlas Common  SUCCESS [ 12.393 
> s]
> [INFO] Apache Atlas Client  SUCCESS [  1.135 
> s]
> [INFO] atlas-client-common  SUCCESS [  7.428 
> s]
> [INFO] atlas-client-v1  SUCCESS [  7.253 
> s]
> [INFO] Apache Atlas Server API  SUCCESS [  9.529 
> s]
> [INFO] Apache Atlas Notification .. SUCCESS [ 15.347 
> s]
> [INFO] atlas-client-v2  SUCCESS [  7.187 
> s]
> [INFO] Apache Atlas Graph Database Projects ... SUCCESS [  0.759 
> s]
> [INFO] Apache Atlas Graph Database API  SUCCESS [  6.837 
> s]
> [INFO] Graph Database Common Code . SUCCESS [  5.506 
> s]
> [INFO] Apache Atlas JanusGraph-HBase2 Module .. SUCCESS [  8.404 
> s]
> [INFO] Apache Atlas JanusGraph DB Impl  SUCCESS [ 19.948 
> s]
> [INFO] Apache Atlas Graph Database Implementation Dependencies SUCCESS [  
> 2.546 s]
> [INFO] Apache Atlas Authorization . SUCCESS [ 10.379 
> s]
> [INFO] Apache Atlas Repository  SUCCESS [ 41.996 
> s]
> [INFO] Apache Atlas UI  SUCCESS [ 47.226 
> s]
> [INFO] Apache Atlas New UI  SUCCESS [ 47.325 
> s]
> [INFO] Apache Atlas Web Application ... SUCCESS [01:37 
> min]
> [INFO] Apache Atlas Documentation . SUCCESS [ 14.091 
> s]
> [INFO] Apache Atlas FileSystem Model .. SUCCESS [  4.903 
> s]
> [INFO] Apache Atlas Plugin Classloader  SUCCESS [  8.600 
> s]
> [INFO] Apache Atlas Hive Bridge Shim .. SUCCESS [  9.450 
> s]
> [INFO] Apache Atlas Hive Bridge ... SUCCESS [ 25.791 
> s]
> [INFO] Apache Atlas Falcon Bridge Shim  SUCCESS [  7.541 
> s]
> [INFO] Apache Atlas Falcon Bridge . SUCCESS [ 10.681 
> s]
> [INFO] Apache Atlas Sqoop Bridge Shim . SUCCESS [  5.474 
> s]
> [INFO] Apache Atlas Sqoop Bridge .. SUCCESS [ 18.287 
> s]
> [INFO] Apache Atlas Storm Bridge Shim . SUCCESS [  5.192 
> s]
> [INFO] Apache Atlas Storm Bridge .. FAILURE [  6.924 
> s]
> [INFO] Apache Atlas Hbase Bridge Shim . SKIPPED
> [INFO] Apache Atlas Hbase Bridge .. SKIPPED
> [INFO] Apache HBase - Testing Util  SKIPPED
> [INFO] Apache Atlas Kafka Bridge .. SKIPPED
> [INFO] Apache Atlas classification updater  SKIPPED
> [INFO] Apache Atlas index repair tool . SKIPPED
> [INFO] Apache Atlas Impala Hook API ... SKIPPED
> [INFO] Apache Atlas Impala Bridge Shim  SKIPPED
> [INFO] Apache Atlas Impala Bridge . SKIPPED
> [INFO] Apache Atlas Distribution

[jira] [Updated] (ATLAS-4009) Atlas Build with -Pdist,embedded-hbase-solr options fail on master

2020-10-27 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-4009?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-4009:
---
Attachment: Screenshot from 2020-10-27 19-24-54.png

> Atlas Build with -Pdist,embedded-hbase-solr  options fail on master 
> 
>
> Key: ATLAS-4009
> URL: https://issues.apache.org/jira/browse/ATLAS-4009
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>Priority: Major
> Attachments: Screenshot from 2020-10-27 19-24-54.png
>
>
> Atlas Build with -Pdist,embedded-hbase-solr options fail on master with 
> Failed to execute goal 
> org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy (copy-hook) on 
> project storm-bridge: Unable to parse configuration of mojo 
> org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy
>  
> {noformat}
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] Apache Atlas Server Build Tools 1.0  SUCCESS [  0.876 
> s]
> [INFO] apache-atlas 3.0.0-SNAPSHOT  SUCCESS [ 22.974 
> s]
> [INFO] Apache Atlas Integration ... SUCCESS [ 27.070 
> s]
> [INFO] Apache Atlas Test Utility Tools  SUCCESS [ 14.643 
> s]
> [INFO] Apache Atlas Common  SUCCESS [ 12.393 
> s]
> [INFO] Apache Atlas Client  SUCCESS [  1.135 
> s]
> [INFO] atlas-client-common  SUCCESS [  7.428 
> s]
> [INFO] atlas-client-v1  SUCCESS [  7.253 
> s]
> [INFO] Apache Atlas Server API  SUCCESS [  9.529 
> s]
> [INFO] Apache Atlas Notification .. SUCCESS [ 15.347 
> s]
> [INFO] atlas-client-v2  SUCCESS [  7.187 
> s]
> [INFO] Apache Atlas Graph Database Projects ... SUCCESS [  0.759 
> s]
> [INFO] Apache Atlas Graph Database API  SUCCESS [  6.837 
> s]
> [INFO] Graph Database Common Code . SUCCESS [  5.506 
> s]
> [INFO] Apache Atlas JanusGraph-HBase2 Module .. SUCCESS [  8.404 
> s]
> [INFO] Apache Atlas JanusGraph DB Impl  SUCCESS [ 19.948 
> s]
> [INFO] Apache Atlas Graph Database Implementation Dependencies SUCCESS [  
> 2.546 s]
> [INFO] Apache Atlas Authorization . SUCCESS [ 10.379 
> s]
> [INFO] Apache Atlas Repository  SUCCESS [ 41.996 
> s]
> [INFO] Apache Atlas UI  SUCCESS [ 47.226 
> s]
> [INFO] Apache Atlas New UI  SUCCESS [ 47.325 
> s]
> [INFO] Apache Atlas Web Application ... SUCCESS [01:37 
> min]
> [INFO] Apache Atlas Documentation . SUCCESS [ 14.091 
> s]
> [INFO] Apache Atlas FileSystem Model .. SUCCESS [  4.903 
> s]
> [INFO] Apache Atlas Plugin Classloader  SUCCESS [  8.600 
> s]
> [INFO] Apache Atlas Hive Bridge Shim .. SUCCESS [  9.450 
> s]
> [INFO] Apache Atlas Hive Bridge ... SUCCESS [ 25.791 
> s]
> [INFO] Apache Atlas Falcon Bridge Shim  SUCCESS [  7.541 
> s]
> [INFO] Apache Atlas Falcon Bridge . SUCCESS [ 10.681 
> s]
> [INFO] Apache Atlas Sqoop Bridge Shim . SUCCESS [  5.474 
> s]
> [INFO] Apache Atlas Sqoop Bridge .. SUCCESS [ 18.287 
> s]
> [INFO] Apache Atlas Storm Bridge Shim . SUCCESS [  5.192 
> s]
> [INFO] Apache Atlas Storm Bridge .. FAILURE [  6.924 
> s]
> [INFO] Apache Atlas Hbase Bridge Shim . SKIPPED
> [INFO] Apache Atlas Hbase Bridge .. SKIPPED
> [INFO] Apache HBase - Testing Util  SKIPPED
> [INFO] Apache Atlas Kafka Bridge .. SKIPPED
> [INFO] Apache Atlas classification updater  SKIPPED
> [INFO] Apache Atlas index repair tool . SKIPPED
> [INFO] Apache Atlas Impala Hook API ... SKIPPED
> [INFO] Apache Atlas Impala Bridge Shim  SKIPPED
> [INFO] Apache Atlas Impala Bridge . SKIPPED
> [INFO] Apache Atlas Distribution .. SKIPPED
> [INFO] atlas-examples . SKIPPED
> [INFO] sample-app 3.0.0-SNAPSHOT .

[jira] [Created] (ATLAS-4009) Atlas Build with -Pdist,embedded-hbase-solr options fail on master

2020-10-27 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-4009:
--

 Summary: Atlas Build with -Pdist,embedded-hbase-solr  options fail 
on master 
 Key: ATLAS-4009
 URL: https://issues.apache.org/jira/browse/ATLAS-4009
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues
 Attachments: Screenshot from 2020-10-27 19-24-54.png

Atlas Build with -Pdist,embedded-hbase-solr options fail on master with Failed 
to execute goal org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy 
(copy-hook) on project storm-bridge: Unable to parse configuration of mojo 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy

 
{noformat}
[INFO] Reactor Summary:
[INFO] 
[INFO] Apache Atlas Server Build Tools 1.0  SUCCESS [  0.876 s]
[INFO] apache-atlas 3.0.0-SNAPSHOT  SUCCESS [ 22.974 s]
[INFO] Apache Atlas Integration ... SUCCESS [ 27.070 s]
[INFO] Apache Atlas Test Utility Tools  SUCCESS [ 14.643 s]
[INFO] Apache Atlas Common  SUCCESS [ 12.393 s]
[INFO] Apache Atlas Client  SUCCESS [  1.135 s]
[INFO] atlas-client-common  SUCCESS [  7.428 s]
[INFO] atlas-client-v1  SUCCESS [  7.253 s]
[INFO] Apache Atlas Server API  SUCCESS [  9.529 s]
[INFO] Apache Atlas Notification .. SUCCESS [ 15.347 s]
[INFO] atlas-client-v2  SUCCESS [  7.187 s]
[INFO] Apache Atlas Graph Database Projects ... SUCCESS [  0.759 s]
[INFO] Apache Atlas Graph Database API  SUCCESS [  6.837 s]
[INFO] Graph Database Common Code . SUCCESS [  5.506 s]
[INFO] Apache Atlas JanusGraph-HBase2 Module .. SUCCESS [  8.404 s]
[INFO] Apache Atlas JanusGraph DB Impl  SUCCESS [ 19.948 s]
[INFO] Apache Atlas Graph Database Implementation Dependencies SUCCESS [  2.546 
s]
[INFO] Apache Atlas Authorization . SUCCESS [ 10.379 s]
[INFO] Apache Atlas Repository  SUCCESS [ 41.996 s]
[INFO] Apache Atlas UI  SUCCESS [ 47.226 s]
[INFO] Apache Atlas New UI  SUCCESS [ 47.325 s]
[INFO] Apache Atlas Web Application ... SUCCESS [01:37 min]
[INFO] Apache Atlas Documentation . SUCCESS [ 14.091 s]
[INFO] Apache Atlas FileSystem Model .. SUCCESS [  4.903 s]
[INFO] Apache Atlas Plugin Classloader  SUCCESS [  8.600 s]
[INFO] Apache Atlas Hive Bridge Shim .. SUCCESS [  9.450 s]
[INFO] Apache Atlas Hive Bridge ... SUCCESS [ 25.791 s]
[INFO] Apache Atlas Falcon Bridge Shim  SUCCESS [  7.541 s]
[INFO] Apache Atlas Falcon Bridge . SUCCESS [ 10.681 s]
[INFO] Apache Atlas Sqoop Bridge Shim . SUCCESS [  5.474 s]
[INFO] Apache Atlas Sqoop Bridge .. SUCCESS [ 18.287 s]
[INFO] Apache Atlas Storm Bridge Shim . SUCCESS [  5.192 s]
[INFO] Apache Atlas Storm Bridge .. FAILURE [  6.924 s]
[INFO] Apache Atlas Hbase Bridge Shim . SKIPPED
[INFO] Apache Atlas Hbase Bridge .. SKIPPED
[INFO] Apache HBase - Testing Util  SKIPPED
[INFO] Apache Atlas Kafka Bridge .. SKIPPED
[INFO] Apache Atlas classification updater  SKIPPED
[INFO] Apache Atlas index repair tool . SKIPPED
[INFO] Apache Atlas Impala Hook API ... SKIPPED
[INFO] Apache Atlas Impala Bridge Shim  SKIPPED
[INFO] Apache Atlas Impala Bridge . SKIPPED
[INFO] Apache Atlas Distribution .. SKIPPED
[INFO] atlas-examples . SKIPPED
[INFO] sample-app 3.0.0-SNAPSHOT .. SKIPPED
[INFO] 
[INFO] BUILD FAILURE
[INFO] 
[INFO] Total time: 08:52 min
[INFO] Finished at: 2020-10-27T13:27:10+05:30
[INFO] 
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy (copy-hook) on 
project storm-bridge: Unable to parse configuration of mojo 
org.apache.maven.plugins:maven-dependency-plugin:3.1.0:copy for parameter 
exclusions: Cannot find 'exclusions' in class 
org.apache.maven.plugins.dependency.fromConfiguration.ArtifactItem -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Fai

Re: Review Request 72987: ATLAS-4005 DSL search gives error if select clause contains attributes with null values

2020-10-26 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72987/#review222124
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 23, 2020, 5:43 p.m., Jayendra Parab wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72987/
> ---
> 
> (Updated Oct. 23, 2020, 5:43 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-4005
> https://issues.apache.org/jira/browse/ATLAS-4005
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> - The exception mentioned in the issue comes because the generated gremlin 
> query uses it.value() to get the values for an attribute of a vertex, If the 
> value isn't present, then it throws the mentioned exception
> - In the fix provided, a check is added in the generated gremlin script, 
> where property.isPresent(), is checked before getting any value
> - In ATLAS-2354, a similar issue was fixed, but because of that change there 
> are no results fetched for the scenario mentioned in ATLAS-4005. 
> - As part of fix for ATLAS-2354, whatever columns are present in select 
> clause, those columns were implicitly added to the where part of query, 
> because this no entities are selected
> - So this review request reverts that change so that selected values are 
> shown for entities matching the where clause
> - Also, after reverting the change one DSL Query test case was failing 
> because qualifiedName was null for columns which don't exist. So added a 
> check in GremilinQueryComposer.process() method to fix that testcase failure
> 
> 
> Diffs
> -
> 
>   repository/src/main/java/org/apache/atlas/query/GremlinClause.java 
> 55ccabd23 
>   repository/src/main/java/org/apache/atlas/query/GremlinQueryComposer.java 
> 801e89806 
>   repository/src/main/java/org/apache/atlas/query/SelectClauseComposer.java 
> fc7414802 
>   repository/src/test/java/org/apache/atlas/query/DSLQueriesTest.java 
> 5ace37944 
>   
> repository/src/test/java/org/apache/atlas/query/GremlinQueryComposerTest.java 
> 959aa1149 
> 
> 
> Diff: https://reviews.apache.org/r/72987/diff/2/
> 
> 
> Testing
> ---
> 
> - All the testcases in DSLQueriesTest are passing
> - Tested with different queries from UI, like 
> "from hdfs_path where name="testPath" select name"
> "from hdfs_path where name="testPath" select name, owner"
> "from hdfs_path where name="testPath" select name, owner, description"
> all give expected results with any exceptions
> - Tried the above queries different scenarios
>   with all entites having the selected attributes set 
>   with some entities having the selected attribute set
>   with all entities having owner value as null
> all scenarios worked as expected
> 
> 
> Thanks,
> 
> Jayendra Parab
> 
>



[jira] [Commented] (ATLAS-4006) Support for Business Metadata in Atlas Export API

2020-10-26 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-4006?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17220566#comment-17220566
 ] 

Nixon Rodrigues commented on ATLAS-4006:


+1 for the patch. Thanks [~amestry]

> Support for Business Metadata in Atlas Export API
> -
>
> Key: ATLAS-4006
> URL: https://issues.apache.org/jira/browse/ATLAS-4006
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.1.0
>Reporter: Umesh Padashetty
>Assignee: Ashutosh Mestry
>Priority: Critical
> Attachments: 
> ATLAS-4006-ATLAS-4007-Export-Import-Added-support-for-Business-.patch
>
>
> Business metadata definition and Entity's Business metadata details are not 
> exported currently via Atlas Export API, we need to build support for this.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72903: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations. Remove Import Audit params.

2020-10-23 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72903/#review222112
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 23, 2020, 3:22 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72903/
> ---
> 
> (Updated Sept. 23, 2020, 3:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3935
> https://issues.apache.org/jira/browse/ATLAS-3935
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Remove list of guids which are stored in the params atrribute of 
> AtlasAuditEntry in case of Import operation.
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 3a6139f 
> 
> 
> Diff: https://reviews.apache.org/r/72903/diff/1/
> 
> 
> Testing
> ---
> 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/32/console
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



[jira] [Resolved] (ATLAS-3995) Atlas should support additional keystore/truststores types besides JKS

2020-10-22 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3995.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> Atlas should support additional keystore/truststores types besides JKS
> --
>
> Key: ATLAS-3995
> URL: https://issues.apache.org/jira/browse/ATLAS-3995
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
> types. There are additional keystore/truststore types used for different 
> applications like for FIPS crypto algorithms.
> Atlas server should support the default keystore type specified for the JDK 
> and have option to configure other keystore/truststore  types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72893: ATLAS-3427: Hook Enhancements for Improved Resiliency

2020-10-20 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72893/#review222076
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 6, 2020, 5:47 p.m., Ashutosh Mestry wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72893/
> ---
> 
> (Updated Oct. 6, 2020, 5:47 p.m.)
> 
> 
> Review request for atlas, Deep Singh, Madhan Neethiraj, mayank jain, Nikhil 
> Bonte, Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3427
> https://issues.apache.org/jira/browse/ATLAS-3427
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> (Internal review) 
> **Description**
> Integration: _AtlasHook_ receives enhanced _NotificationInterface_ in the 
> form of _AtlasFileSpool_. This capability can be optionally set using: 
> _atlas.hook.spool.dir_ configuration property.
> 
> _AtlasFileSpool_: Enhances default hook functionality by encapsulating the 
> default _NotificationInterface_ with file spooling capability. In case of 
> destination being unavailable, the messages received will be spooled to local 
> file system.
> 
> What is spool?
> - These are files containg data (messages in this specific case).
> 
> Files on the disk that are managed using index files. Index files have 
> special structure that is used to describe the spool files. 
> 
> Who generates spool files?
> _AtlasHook_ is base class from which all hooks. It is responsible for sending 
> messages to a destination (mostly Kafka). If destination is down, an 
> exception is raised by the destination. Before the implementation, the 
> message was logged after retry. With this implementation, the message will be 
> spooled, and when the destination is up, it is sent to the destination.
> 
> How are spool file stored?
> - Spool files and index files are store on disk in local file system.
> 
> Structure of _AtlasFileSpool_:
> - _IndexManagement_: Storage and retrieval of index files. Provides Spooler 
> (see below) with _PrintWriter_ to write messages to the disk.
> - _Spooler_: 
>   - Interacts with _IndexManagement_ to receive _PrintWriter_. 
>   - Serializes messages and writes to the spool file. 
> - _Publisher_: 
>   - Interacts with _IndexManagement_ to receive _IndexRecord_ that is ready 
> to be published.
>   - Reads messages from the spool file that is described in the _IndexRecord_ 
> and attempts to send it to the destination.
>   - If destination is down, it waits for destination to be up.
> - _SpoolConfiguration_: Stores configuration specific to the implementation.
> - _SpoolUtils_: Utility methods for file storage.
> 
> 
> **Impacted Areas**
> Hooks:
> - Hive: HS2
> - Hive: HMS
> - Impala.
> - HBase.
> - Spark.
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveHook.java 
> 651323490 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveMetastoreHookImpl.java
>  3c0f0c106 
>   notification/pom.xml 8affd59a2 
>   notification/src/main/java/org/apache/atlas/hook/AtlasHook.java 8659126eb 
>   notification/src/main/java/org/apache/atlas/hook/FailedMessagesLogger.java 
> b319e81b8 
>   notification/src/main/java/org/apache/atlas/kafka/NotificationProvider.java 
> 2dd970ef7 
>   
> notification/src/main/java/org/apache/atlas/notification/AbstractNotification.java
>  45a66bf07 
>   
> notification/src/main/java/org/apache/atlas/notification/LogConfigUtils.java 
> PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationException.java
>  2dd9c9fa0 
>   
> notification/src/main/java/org/apache/atlas/notification/NotificationInterface.java
>  6caf7e2d5 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/Archiver.java 
> PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/AtlasFileSpool.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/FileOperations.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/IndexManagement.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/Publisher.java 
> PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/SpoolConfiguration.java
>  PRE-CREATION 
>   
> notification/src/main/java/org/apache/atlas/notification/spool/SpoolUtils.java
>  PRE-C

Re: Review Request 72962: ATLAS-3995 :- Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72962/
---

(Updated Oct. 14, 2020, 4:39 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Changes
---

addressed review comment from Madhan


Repository: atlas


Description
---

Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
types. There are additional keystore/truststore types used for different 
applications like for FIPS crypto algorithms.

Atlas server should support the default keystore type specified for the JDK and 
have option to configure other keystore/truststore  types.

This patch makes its configurable to add other keystore/truststore types via 
atlas-application.properties.

keystore.type=bcfks
truststore.type=bcfks


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
2e953eb02 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
34086aed8 


Diff: https://reviews.apache.org/r/72962/diff/2/

Changes: https://reviews.apache.org/r/72962/diff/1-2/


Testing
---

Tested Atlas with bcfks type keystores.


Thanks,

Nixon Rodrigues



Review Request 72962: ATLAS-3995 :- Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72962/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Repository: atlas


Description
---

Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
types. There are additional keystore/truststore types used for different 
applications like for FIPS crypto algorithms.

Atlas server should support the default keystore type specified for the JDK and 
have option to configure other keystore/truststore  types.

This patch makes its configurable to add other keystore/truststore types via 
atlas-application.properties.

keystore.type=bcfks
truststore.type=bcfks


Diffs
-

  intg/src/main/java/org/apache/atlas/security/SecurityProperties.java 
2e953eb02 
  webapp/src/main/java/org/apache/atlas/web/service/SecureEmbeddedServer.java 
34086aed8 


Diff: https://reviews.apache.org/r/72962/diff/1/


Testing
---

Tested Atlas with bcfks type keystores.


Thanks,

Nixon Rodrigues



[jira] [Commented] (ATLAS-3990) UI: When user clicks to view hive-table details, shown some wrong tabs

2020-10-14 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17213862#comment-17213862
 ] 

Nixon Rodrigues commented on ATLAS-3990:


+1 for the patch. Thanks [~kevalbhatt]

> UI: When user clicks to view hive-table details, shown some wrong tabs
> --
>
> Key: ATLAS-3990
> URL: https://issues.apache.org/jira/browse/ATLAS-3990
> Project: Atlas
>  Issue Type: Bug
>Reporter: Durga Kadam
>Assignee: Keval Bhatt
>Priority: Major
> Attachments: ATLAS-3990.patch, wrong_tabs_showing_on_clicks.mkv
>
>
> Steps to reproduce::
>  # Have a hive_db with at least one table
>  # Click on 'Tables' tab
>  # Click on one of the tables listed in the tab
>  # The page renders the table details, including addition of 'Schema' tab
>  # However, 'Tables' tab is still visible; this tab needs to be hidden
>  # Also, on clicking the db link in Properties page of hive_table, 'Schema' 
> tab is still visible. This should be hidden
> PFA evidence file attached - wrong_tabs_showing_on_clicks.mkv



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-3995) Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reassigned ATLAS-3995:
--

Assignee: Nixon Rodrigues

> Atlas should support additional keystore/truststores types besides JKS
> --
>
> Key: ATLAS-3995
> URL: https://issues.apache.org/jira/browse/ATLAS-3995
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
>
> Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
> types. There are additional keystore/truststore types used for different 
> applications like for FIPS crypto algorithms.
> Atlas server should support the default keystore type specified for the JDK 
> and have option to configure other keystore/truststore  types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3995) Atlas should support additional keystore/truststores types besides JKS

2020-10-14 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3995:
--

 Summary: Atlas should support additional keystore/truststores 
types besides JKS
 Key: ATLAS-3995
 URL: https://issues.apache.org/jira/browse/ATLAS-3995
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


Currently Atlas server (through Jetty) only supports JKS keystore/truststore 
types. There are additional keystore/truststore types used for different 
applications like for FIPS crypto algorithms.

Atlas server should support the default keystore type specified for the JDK and 
have option to configure other keystore/truststore  types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72933: ATLAS-3982 : Upgrade Atlas Spring framework version to 4.3.29.RELEASE

2020-10-11 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72933/#review222011
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 9, 2020, 10:49 a.m., chaitali wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72933/
> ---
> 
> (Updated Oct. 9, 2020, 10:49 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3982
> https://issues.apache.org/jira/browse/ATLAS-3982
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Upgrading Apache atlas spring framework version to prevent attacks from  
> CVE-2020-5421
> 
> 
> Diffs
> -
> 
>   pom.xml 6b5d2fde6 
> 
> 
> Diff: https://reviews.apache.org/r/72933/diff/1/
> 
> 
> Testing
> ---
> 
> Tested with following scenario :
> Created entities eg from Hive shell
> mvn clean install
> mvn clean package -Pdist,embedded-hbase-solr -DskipTests
> Atlas server is running successfully
> 
> 
> Thanks,
> 
> chaitali
> 
>



Re: Review Request 72942: ATLAS-3987: Atlas client export API does not pass server response code in case of failure

2020-10-09 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72942/#review222007
---


Ship it!




Ship It!

- Nixon Rodrigues


On Oct. 9, 2020, 8:16 a.m., Deep Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72942/
> ---
> 
> (Updated Oct. 9, 2020, 8:16 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3987
> https://issues.apache.org/jira/browse/ATLAS-3987
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> For Atlas export, Admin priveledges are required. If such priveledges are not 
> there, then Export API fails with 403 status. However, the atlasClient does 
> not pass this information in the exception.
> 
> AtlasServiceException did not have any constructon with another 
> AtlasServiceException object as parameter. 
> There is a constructon which takes generic Exception parameter, and does not 
> care about the status in the exception.
> 
> I have added a new constructor which retains the status of passed exception.
> 
> 
> Diffs
> -
> 
>   client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java 6e03669ef 
>   client/common/src/main/java/org/apache/atlas/AtlasServiceException.java 
> 6b4dd1165 
>   
> webapp/src/test/java/org/apache/atlas/web/resources/AdminExportImportTestIT.java
>  e53f9a8a6 
> 
> 
> Diff: https://reviews.apache.org/r/72942/diff/1/
> 
> 
> Testing
> ---
> 
> Unit testing
> Additional unit tests added.
> 
> 
> Thanks,
> 
> Deep Singh
> 
>



[jira] [Resolved] (ATLAS-3971) Move authorization check for Business Metadata before type exist check

2020-10-08 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3971.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> Move authorization check for Business Metadata before type exist check
> --
>
> Key: ATLAS-3971
> URL: https://issues.apache.org/jira/browse/ATLAS-3971
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3971.patch
>
>
> Refactor authorization check for Business Metadata before type exist check, 
> so that enduser is aware that a duplicate type creation is being attempted 
> which exist he is authorized to.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3977) Migration Script: Deleted entities in Atlas1.0 miss few attributes after migrated to Atlas2.0

2020-10-07 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17209392#comment-17209392
 ] 

Nixon Rodrigues commented on ATLAS-3977:


+1 for the patch, thanks [~amestry] for the patch

> Migration Script: Deleted entities in Atlas1.0 miss few attributes after 
> migrated to Atlas2.0
> -
>
> Key: ATLAS-3977
> URL: https://issues.apache.org/jira/browse/ATLAS-3977
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Sharmadha S
>Assignee: Ashutosh Mestry
>Priority: Major
> Attachments: ATLAS-3977-Addressed-patch-processing-for.patch, 
> am2cm_deleted_active_entity.png
>
>
> table6 is DELETED in Atlas1.0 and it is migrated to Atals2.0
> Attributes like name , db , owner are missing in DELETED entities whereas 
> they are populated correctly in ACTIVE entities.
> Attaching the screenshot.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72937: ATLAS-3971 :- Move authorization check for Business Metadata def before type exist check

2020-10-06 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72937/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nikhil Bonte, Pinal Shah, and Sarath Subramanian.


Bugs: ATLAS-3971
https://issues.apache.org/jira/browse/ATLAS-3971


Repository: atlas


Description
---

This patch moves authorization check for Business Metadata def before type 
exist check, so that end-user is only aware that a duplicate type creation is 
being attempted if he is authorized to.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java
 23964f414 


Diff: https://reviews.apache.org/r/72937/diff/1/


Testing
---

Test duplicate Business Metadata def creation with authorized and unauthorized 
creation


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-3971) Move authorization check for Business Metadata before type exist check

2020-10-05 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3971:
---
Attachment: ATLAS-3971.patch

> Move authorization check for Business Metadata before type exist check
> --
>
> Key: ATLAS-3971
> URL: https://issues.apache.org/jira/browse/ATLAS-3971
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3971.patch
>
>
> Refactor authorization check for Business Metadata before type exist check, 
> so that enduser is aware that a duplicate type creation is being attempted 
> which exist he is authorized to.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3971) Move authorization check for Business Metadata before type exist check

2020-10-05 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3971:
---
Summary: Move authorization check for Business Metadata before type exist 
check  (was: Refactor authorization check for Business Metadata before type 
exist check)

> Move authorization check for Business Metadata before type exist check
> --
>
> Key: ATLAS-3971
> URL: https://issues.apache.org/jira/browse/ATLAS-3971
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
>
> Refactor authorization check for Business Metadata before type exist check, 
> so that enduser is aware that a duplicate type creation is being attempted 
> which exist he is authorized to.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3971) Refactor authorization check for Business Metadata before type exist check

2020-10-05 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3971:
--

 Summary: Refactor authorization check for Business Metadata before 
type exist check
 Key: ATLAS-3971
 URL: https://issues.apache.org/jira/browse/ATLAS-3971
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


Refactor authorization check for Business Metadata before type exist check, so 
that enduser is aware that a duplicate type creation is being attempted which 
exist he is authorized to.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-3971) Refactor authorization check for Business Metadata before type exist check

2020-10-05 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reassigned ATLAS-3971:
--

Assignee: Nixon Rodrigues

> Refactor authorization check for Business Metadata before type exist check
> --
>
> Key: ATLAS-3971
> URL: https://issues.apache.org/jira/browse/ATLAS-3971
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
>
> Refactor authorization check for Business Metadata before type exist check, 
> so that enduser is aware that a duplicate type creation is being attempted 
> which exist he is authorized to.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3968) When un-authorised reader reads a type using the guid, the error message mentions about the type name instead of the guid

2020-10-05 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3968.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> When un-authorised reader reads a type using the guid, the error message 
> mentions about the type name instead of the guid
> -
>
> Key: ATLAS-3968
> URL: https://issues.apache.org/jira/browse/ATLAS-3968
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> On firing a request for /api/atlas/v2/types/businessmetadatadef/guid/ 
> as an unauthorised user, the following error message is displayed
> {code:java}
> {
> u'errorCode': u'ATLAS-403-00-001',
> u'errorMessage': u'hrt_20 is not authorized to perform read type bm_123'
> }
> {code}
> Since we are firing the request using guid, it will be better to mention the 
> guid instead of the type name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72923: ATLAS-3968 : - Refactor the typedef API authorization error message with type guid instead type name for call with guid as parameter

2020-10-01 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72923/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3968
https://issues.apache.org/jira/browse/ATLAS-3968


Repository: atlas


Description
---

Bug details - When un-authorised reader reads a type using the guid, the error 
message mentions about the type name instead of the guid.

This patch refactor's the typedef API authorization error message with type 
guid instead type name for call with guid as parameter.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 9aa8fbcf5 


Diff: https://reviews.apache.org/r/72923/diff/1/


Testing
---

Tested typedef of all categorty API with guid and name paramter for authorized 
and unauthorized users.


Thanks,

Nixon Rodrigues



[jira] [Assigned] (ATLAS-3968) When un-authorised reader reads a type using the guid, the error message mentions about the type name instead of the guid

2020-10-01 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3968?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reassigned ATLAS-3968:
--

Assignee: Nixon Rodrigues

> When un-authorised reader reads a type using the guid, the error message 
> mentions about the type name instead of the guid
> -
>
> Key: ATLAS-3968
> URL: https://issues.apache.org/jira/browse/ATLAS-3968
> Project: Atlas
>  Issue Type: Bug
>Reporter: Dharshana M Krishnamoorthy
>    Assignee: Nixon Rodrigues
>Priority: Major
>
> On firing a request for /api/atlas/v2/types/businessmetadatadef/guid/ 
> as an unauthorised user, the following error message is displayed
> {code:java}
> {
> u'errorCode': u'ATLAS-403-00-001',
> u'errorMessage': u'hrt_20 is not authorized to perform read type bm_123'
> }
> {code}
> Since we are firing the request using guid, it will be better to mention the 
> guid instead of the type name



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-3952) Authorize Super And SubTypes and depend entityType for type-read access while creating Classificationdef

2020-09-29 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reassigned ATLAS-3952:
--

Fix Version/s: 2.2.0
   3.0.0
 Assignee: Nixon Rodrigues
   Resolution: Fixed

> Authorize Super And SubTypes and depend entityType for type-read access while 
> creating Classificationdef
> 
>
> Key: ATLAS-3952
> URL: https://issues.apache.org/jira/browse/ATLAS-3952
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3952.patch
>
>
> User is able to create a type with a super type though he doesn't have read 
> permission on super type , subtype



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3963) Atlas api 'atlas/v2/types/typedefs/headers' does not give information about business metadata

2020-09-29 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3963.

Resolution: Duplicate

> Atlas api 'atlas/v2/types/typedefs/headers' does not give information about 
> business metadata
> -
>
> Key: ATLAS-3963
> URL: https://issues.apache.org/jira/browse/ATLAS-3963
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Assignee: Nixon Rodrigues
>Priority: Major
>
> While trying to fetch headers of all types, data about business metadata is 
> not fetched via "*atlas/v2/types/typedefs/headers*"
> We could verify is there is business metadata in 
> "api/atlas/v2/types/typedefs?type=business_metadata" though
>  
> This holds true for 
> '[api/atlas/v2/types/typedefs/headers?type=business_metadata'|https://quasar-oczlgo-1.quasar-oczlgo.root.hwx.site:31443/api/atlas/v2/types/typedefs/headers?type=business_metadata%27]
>  as well
>  * [|https://jira.cloudera.com/secure/AddComment!default.jspa?id=917333]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3962) Include business metadata def header in typdefs headers API

2020-09-29 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3962?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3962.

Fix Version/s: 2.2.0
   3.0.0
   Resolution: Fixed

> Include business metadata def header in typdefs headers API
> ---
>
> Key: ATLAS-3962
> URL: https://issues.apache.org/jira/browse/ATLAS-3962
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> While trying to fetch headers of all types, data about business metadata is 
> not fetched via "*atlas/v2/types/typedefs/headers*"
> We could verify is there is business metadata in 
> "api/atlas/v2/types/typedefs?type=business_metadata" though



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72912: ATLAS-3962 : Include business metadata def header in typdefs headers API

2020-09-28 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72912/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-3962
https://issues.apache.org/jira/browse/ATLAS-3962


Repository: atlas


Description
---

Bug details:- While trying to fetch headers of all types, data about business 
metadata is not fetched via "atlas/v2/types/typedefs/headers" .We could verify 
is there is business metadata in 
"api/atlas/v2/types/typedefs?type=business_metadata" though

The patch provided fix to add business metadata def header in typdefs headers.


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 9abcd3449 


Diff: https://reviews.apache.org/r/72912/diff/1/


Testing
---


Thanks,

Nixon Rodrigues



[jira] [Created] (ATLAS-3962) Include business metadata def header in typdefs headers API

2020-09-28 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3962:
--

 Summary: Include business metadata def header in typdefs headers 
API
 Key: ATLAS-3962
 URL: https://issues.apache.org/jira/browse/ATLAS-3962
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues


While trying to fetch headers of all types, data about business metadata is not 
fetched via "*atlas/v2/types/typedefs/headers*"

We could verify is there is business metadata in 
"api/atlas/v2/types/typedefs?type=business_metadata" though



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3960) Testcase failing [testGetDefinition(org.apache.atlas.web.integration.TypedefsJerseyResourceIT)]

2020-09-28 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3960:
--

 Summary: Testcase failing 
[testGetDefinition(org.apache.atlas.web.integration.TypedefsJerseyResourceIT)] 
 Key: ATLAS-3960
 URL: https://issues.apache.org/jira/browse/ATLAS-3960
 Project: Atlas
  Issue Type: Bug
Affects Versions: 0.8.4
Reporter: Nixon Rodrigues


Testcase failing with mvn clean install

 
{noformat}
testGetDefinition(org.apache.atlas.web.integration.TypedefsJerseyResourceIT)  
Time elapsed: 0.004 sec  <<< FAILURE!
java.lang.AssertionError: Get byName should've succeeded
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:420)
at 
org.apache.atlas.AtlasBaseClient.callAPIWithResource(AtlasBaseClient.java:350)
at org.apache.atlas.AtlasBaseClient.callAPI(AtlasBaseClient.java:254)
at 
org.apache.atlas.AtlasClientV2.getTypeDefByName(AtlasClientV2.java:428)
at 
org.apache.atlas.AtlasClientV2.getClassificationDefByName(AtlasClientV2.java:159)
at 
org.apache.atlas.web.integration.TypedefsJerseyResourceIT.verifyByNameAndGUID(TypedefsJerseyResourceIT.java:339)
at 
org.apache.atlas.web.integration.TypedefsJerseyResourceIT.testGetDefinition(TypedefsJerseyResourceIT.java:185)
{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3959) Upgrade Atlas to Spring Framework version 4.3.16.release

2020-09-28 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203024#comment-17203024
 ] 

Nixon Rodrigues commented on ATLAS-3959:


+1 for the patch, Thanks [~chaitali]

> Upgrade Atlas to Spring Framework version 4.3.16.release
> 
>
> Key: ATLAS-3959
> URL: https://issues.apache.org/jira/browse/ATLAS-3959
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 0.8.1
>Reporter: chaitali borole
>Assignee: chaitali borole
>Priority: Major
> Fix For: 0.8.1
>
> Attachments: ATLAS-3959.patch
>
>
> Existing Spring version 4.3.8.release is vulnerable to CVE-2018-1270



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72873: ATLAS-3938 : Deletion of non existing hive entities

2020-09-27 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72873/#review221964
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 17, 2020, 4:40 a.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72873/
> ---
> 
> (Updated Sept. 17, 2020, 4:40 a.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3938
> https://issues.apache.org/jira/browse/ATLAS-3938
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Problem:** Whenever database or table is dropped in hive, and HiveHook is 
> not enabled, we dont have anyway to get the database and table sync with hive.
> 
> **Workaround:** Added support to delete hive entities in Atlas which are 
> dropped in hive.
> 
> **Usage:** ./import-hive.sh -deleteNonExisting
> 
> **NOTE:** **atlas.hook.hive.page.limit** property is added to configure the 
> pageSize/limit while fetching entities from Atlas
> 
> 
> Diffs
> -
> 
>   addons/hive-bridge/src/bin/import-hive.sh b1660ea65 
>   
> addons/hive-bridge/src/main/java/org/apache/atlas/hive/bridge/HiveMetaStoreBridge.java
>  24e06dc2b 
>   client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java 
> 18811f8c7 
> 
> 
> Diff: https://reviews.apache.org/r/72873/diff/3/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



[jira] [Commented] (ATLAS-3958) When updating a type with non-existing super type as an un-authorized user gives in-correct message in response

2020-09-25 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17202010#comment-17202010
 ] 

Nixon Rodrigues commented on ATLAS-3958:


ATLAS-3952 will be fix this issue which under review 
https://reviews.apache.org/r/72894/

> When updating a type with non-existing super type as an un-authorized user 
> gives in-correct message in response
> ---
>
> Key: ATLAS-3958
> URL: https://issues.apache.org/jira/browse/ATLAS-3958
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Reporter: Dharshana M Krishnamoorthy
>Priority: Minor
>
> When an unauthorised  user updates a type, by adding a non-existing 
> super-type, incorret error message is thrown
> *Repro steps:*
> Create a classification (as authorised user)
> Update the classification  as un-authorised user(*hrt_1*), by adding a 
> non-existing super type *qqq*
> *Observed error message:*
> {code}
> {
> "errorCode": "ATLAS-400-00-029",
> "errorMessage": "Given typename qqq was invalid"
> }
> {code}
> *Expected error message:*
> {code}
> {
> "errorCode": "ATLAS-403-00-001",
> "errorMessage": "hrt_1 is not authorized to perform update classification-def 
> child"
> }
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72894: ATLAS-3952 :- Authorize Super And SubTypes and depend entityType for type-read access while creating Classificationdef

2020-09-25 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72894/
---

(Updated Sept. 25, 2020, 8:53 a.m.)


Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, Nikhil 
Bonte, and Sarath Subramanian.


Changes
---

updated patch for review comments from Madhan


Bugs: ATLAS-3952
https://issues.apache.org/jira/browse/ATLAS-3952


Repository: atlas


Description
---

This patch consist two fixes.
1) Authorize Super And SubTypes and entityType for type-read access before 
creating Classificationdef.
2) Move create-type access check before duplicate "Given type _ already exists" 
validation.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java
 9ffede4e3 


Diff: https://reviews.apache.org/r/72894/diff/4/

Changes: https://reviews.apache.org/r/72894/diff/3-4/


Testing
---

Tested creating classification while superTypes/ subTypes and entityType with 
valid/invalid read-Type access.
Testing duplicate classification while valid/invalid create-type access.


Thanks,

Nixon Rodrigues



Re: Review Request 72890: ATLAS-3949 : Relationship search API, add parameter to get classification attributes in search results

2020-09-24 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72890/#review221947
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 21, 2020, 1:26 p.m., Pinal Shah wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72890/
> ---
> 
> (Updated Sept. 21, 2020, 1:26 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3949
> https://issues.apache.org/jira/browse/ATLAS-3949
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> **Improvement:** Adding boolean parameter 'includeClassificationAttributes' 
> in Relationship search Api to get all attributes of the classification 
> associated to the entity.
> 
> **Example of api:** 
> /api/atlas/v2/search/relationship?guid={guid}=tables=10=true
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/AtlasDiscoveryService.java
>  4d97a0859 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java
>  f8143453a 
>   webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java dd9980a82 
> 
> 
> Diff: https://reviews.apache.org/r/72890/diff/1/
> 
> 
> Testing
> ---
> 
> Precommit : 
> https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/27
> 
> 
> Thanks,
> 
> Pinal Shah
> 
>



[jira] [Commented] (ATLAS-3955) Read Type Auth, UI : detailsPage doesn't load for user who has read permission for entity but no read auth for entity's type

2020-09-24 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201371#comment-17201371
 ] 

Nixon Rodrigues commented on ATLAS-3955:


+1 for the patch. [~kevalbhatt] thanks.

> Read Type Auth, UI : detailsPage doesn't load for user who has read 
> permission for entity but no read auth for entity's type
> 
>
> Key: ATLAS-3955
> URL: https://issues.apache.org/jira/browse/ATLAS-3955
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: ATLAS-3955.patch
>
>
> -
> Simple scenario
> -
> 1 . hive_table employee is created.
> 2. USER has permissions to read the employee table entity
> 3. USER doesn't have permissions to read type hive_table
> 4. USER logs into Atlas and searches for _ALL___ENTITY_TYPES , which lists 
> the hive_table entity "employee"
> 5. Clicking on it, UI throws following error in Console tab and UI keeps 
> loading.
> {code:java}
> DetailPageLayoutView.js?bust=1600212682027:109 Uncaught TypeError: Cannot 
> read property 'toJSON' of undefined
> at N.d. (DetailPageLayoutView.js?bust=1600212682027:109)
> at s (backbone-min.js?bust=1600212682027:1)
> at r (backbone-min.js?bust=1600212682027:1)
> at m (backbone-min.js?bust=1600212682027:1)
> at N.d.k.trigger (backbone-min.js?bust=1600212682027:1)
> at N.d.reset (backbone-min.js?bust=1600212682027:1)
> at Object. (backbone.paginator.min.js?bust=1600212682027:1)
> at s (backbone-min.js?bust=1600212682027:1)
> at r (backbone-min.js?bust=1600212682027:1)
> at m (backbone-min.js?bust=1600212682027:1) {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72894: ATLAS-3952 :- Authorize Super And SubTypes and depend entityType for type-read access while creating Classificationdef

2020-09-23 Thread Nixon Rodrigues


> On Sept. 22, 2020, 4 p.m., Madhan Neethiraj wrote:
> > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java
> > Line 753 (original)
> > <https://reviews.apache.org/r/72894/diff/1/?file=2239801#file2239801line753>
> >
> > I suggest to not remove this validation from here. BTW, has this 
> > validation been moved to else where?

validation is removed from here so that authorization can be done before the 
TYPE_ALREADY_EXISTS check and user who do not have read access do not know 
about this typedef.

TYPE_ALREADY_EXISTS check is also done in preCreate method of 
AtlasClassificationDefStoreV2 which handle duplicate check.
It also avaialble in precreate of AtlasEntityDefStoreV2 , AtlasEnumDefStoreV2 , 
AtlasRelationshipDefStoreV2, AtlasBusinessMetadataDefStoreV2, 
AtlasStructDefStoreV2


> On Sept. 22, 2020, 4 p.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java
> > Lines 379 (patched)
> > <https://reviews.apache.org/r/72894/diff/1/?file=2239802#file2239802line381>
> >
> > When multiple classifications are created in one REST call, 
> > typeRegistry.getTypeDefByName(typeName) will return null when typeName is 
> > one of the newly created type. For example:
> > 
> >   {
> > "classificationDefs": [
> >   {
> > "name": "tagBase"
> >   },
> >   {
> > "name": "tagDerived",
> > "superTypes": [ "typeBase" ]
> >   }
> > ]
> >   }
> > 
> > Please validate above.

{
  "classificationDefs": [
{
  "name": "PII2_parent",
  "description": "PII2_parent",
  "superTypes": [],
  "attributeDefs": [],
  "entityTypes": [
"hdfs_path",
"hive_table"
  ],
  "category": "CLASSIFICATION"
},
{
  "name": "PII2_child",
  "description": "PII2_child",
  "superTypes": [
"PII2_parent"
  ],
  "attributeDefs": [],
  "entityTypes": [
"hdfs_path",
"hive_table"
  ],
  "category": "CLASSIFICATION"
}
  ],
  "entityDefs": [],
  "enumDefs": [],
  "structDefs": []
}

Tested with above case for creating classfications. 

typeRegistry.getTypeDefByName("PII2_parent") return AtlasBaseTypeDef object 
correctly. also I have added null check for def object.


- Nixon


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72894/#review221921
---


On Sept. 23, 2020, 6:42 p.m., Nixon Rodrigues wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72894/
> ---
> 
> (Updated Sept. 23, 2020, 6:42 p.m.)
> 
> 
> Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, Nikhil 
> Bonte, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3952
> https://issues.apache.org/jira/browse/ATLAS-3952
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch consist two fixes.
> 1) Authorize Super And SubTypes and entityType for type-read access before 
> creating Classificationdef.
> 2) Move create-type access check before duplicate "Given type _ already 
> exists" validation.
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java
>  9ffede4e3 
> 
> 
> Diff: https://reviews.apache.org/r/72894/diff/2/
> 
> 
> Testing
> ---
> 
> Tested creating classification while superTypes/ subTypes and entityType with 
> valid/invalid read-Type access.
> Testing duplicate classification while valid/invalid create-type access.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>



Re: Review Request 72894: ATLAS-3952 :- Authorize Super And SubTypes and depend entityType for type-read access while creating Classificationdef

2020-09-23 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72894/
---

(Updated Sept. 23, 2020, 6:42 p.m.)


Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, Nikhil 
Bonte, and Sarath Subramanian.


Changes
---

This patch addressed review comments from Madhan.


Bugs: ATLAS-3952
https://issues.apache.org/jira/browse/ATLAS-3952


Repository: atlas


Description
---

This patch consist two fixes.
1) Authorize Super And SubTypes and entityType for type-read access before 
creating Classificationdef.
2) Move create-type access check before duplicate "Given type _ already exists" 
validation.


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java
 9ffede4e3 


Diff: https://reviews.apache.org/r/72894/diff/2/

Changes: https://reviews.apache.org/r/72894/diff/1-2/


Testing
---

Tested creating classification while superTypes/ subTypes and entityType with 
valid/invalid read-Type access.
Testing duplicate classification while valid/invalid create-type access.


Thanks,

Nixon Rodrigues



Re: Review Request 72892: ATLAS-3951 : Authorize entity-type for type-read permission before creating entity of that type.

2020-09-22 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72892/
---

(Updated Sept. 22, 2020, 12:17 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
and Sarath Subramanian.


Bugs: ATLAS-3951
https://issues.apache.org/jira/browse/ATLAS-3951


Repository: atlas


Description
---

Bug :- User is able to create entities of type though he doesn't have read 
permissions on the type.

This patch updates the createOrUpdate entities flow to add type-read 
authorization for entity-type of the entity tobe created.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 7cf77ea04 


Diff: https://reviews.apache.org/r/72892/diff/1/


Testing
---

Tried Creating entities with non authorized and authorized entity types.


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-3952) Authorize Super And SubTypes and depend entityType for type-read access while creating Classificationdef

2020-09-22 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3952:
---
Attachment: ATLAS-3952.patch

> Authorize Super And SubTypes and depend entityType for type-read access while 
> creating Classificationdef
> 
>
> Key: ATLAS-3952
> URL: https://issues.apache.org/jira/browse/ATLAS-3952
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3952.patch
>
>
> User is able to create a type with a super type though he doesn't have read 
> permission on super type , subtype



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72894: ATLAS-3952 :- Authorize Super And SubTypes and depend entityType for type-read access while creating Classificationdef

2020-09-22 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72894/
---

Review request for atlas, chaitali, Jayendra Parab, Madhan Neethiraj, Nikhil 
Bonte, and Sarath Subramanian.


Bugs: ATLAS-3952
https://issues.apache.org/jira/browse/ATLAS-3952


Repository: atlas


Description
---

This patch consist two fixes.
1) Authorize Super And SubTypes and entityType for type-read access before 
creating Classificationdef.
2) Move create-type access check before duplicate "Given type _ already exists" 
validation.


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java
 9ffede4e3 


Diff: https://reviews.apache.org/r/72894/diff/1/


Testing
---

Tested creating classification while superTypes/ subTypes and entityType with 
valid/invalid read-Type access.
Testing duplicate classification while valid/invalid create-type access.


Thanks,

Nixon Rodrigues



[jira] [Created] (ATLAS-3952) Authorize Super And SubTypes and depend entityType for type-read access while creating Classificationdef

2020-09-22 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3952:
--

 Summary: Authorize Super And SubTypes and depend entityType for 
type-read access while creating Classificationdef
 Key: ATLAS-3952
 URL: https://issues.apache.org/jira/browse/ATLAS-3952
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


User is able to create a type with a super type though he doesn't have read 
permission on super type , subtype



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3911) UI: Type system management

2020-09-22 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199949#comment-17199949
 ] 

Nixon Rodrigues commented on ATLAS-3911:


+1 for the patch, [~kevalbhatt] thanks

> UI: Type system management
> --
>
> Key: ATLAS-3911
> URL: https://issues.apache.org/jira/browse/ATLAS-3911
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3911-1.patch, ATLAS-3911-2.patch, 
> ATLAS-3911.patch, Type_System_Tree.png, Type_System_Tree_Details.png
>
>
> !Type_System_Tree.png|width=482,height=237!
>  
> !Type_System_Tree_Details.png|width=509,height=249!



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3951) Authorize entity-type for type-read permission before creating entity of that type.

2020-09-21 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3951:
---
Attachment: ATLAS-3951.patch

> Authorize entity-type for type-read permission before creating entity of that 
> type.
> ---
>
> Key: ATLAS-3951
> URL: https://issues.apache.org/jira/browse/ATLAS-3951
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3951.patch
>
>
> User is able to create entities of type though he doesn't have read 
> permissions on the type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (ATLAS-3951) Authorize entity-type for type-read permission before creating entity of that type.

2020-09-21 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3951?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reassigned ATLAS-3951:
--

Assignee: Nixon Rodrigues

> Authorize entity-type for type-read permission before creating entity of that 
> type.
> ---
>
> Key: ATLAS-3951
> URL: https://issues.apache.org/jira/browse/ATLAS-3951
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3951.patch
>
>
> User is able to create entities of type though he doesn't have read 
> permissions on the type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3951) Authorize entity-type for type-read permission before creating entity of that type.

2020-09-21 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3951:
--

 Summary: Authorize entity-type for type-read permission before 
creating entity of that type.
 Key: ATLAS-3951
 URL: https://issues.apache.org/jira/browse/ATLAS-3951
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues


User is able to create entities of type though he doesn't have read permissions 
on the type



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-19 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
---

(Updated Sept. 19, 2020, 5:21 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Changes
---

Handled review comment from Madhan for refactoring the code.


Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946


Repository: atlas


Description
---

Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.

This patch filterTypeDefs after authorization and updates the data for required 
types.


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
7917f32e5 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e93a 


Diff: https://reviews.apache.org/r/72879/diff/4/

Changes: https://reviews.apache.org/r/72879/diff/3-4/


Testing
---

Tested Statistics UI from different users with different policies for 
entityType and classfication.

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console


Thanks,

Nixon Rodrigues



Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-18 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
---

(Updated Sept. 18, 2020, 8:59 a.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Changes
---

Handled review comment from Madhan for

>> Shouldn't entityDefs be used here, instead of 
>> typeRegistry.getAllEntityTypes()? Please review.

Used filtered entityDefs instead typeRegistry.getAllEntityTypes()


Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946


Repository: atlas


Description
---

Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.

This patch filterTypeDefs after authorization and updates the data for required 
types.


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
7917f32e5 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e93a 


Diff: https://reviews.apache.org/r/72879/diff/3/

Changes: https://reviews.apache.org/r/72879/diff/2-3/


Testing
---

Tested Statistics UI from different users with different policies for 
entityType and classfication.

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console


Thanks,

Nixon Rodrigues



Re: Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
---

(Updated Sept. 17, 2020, 5:24 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Changes
---

Updated patch with review comment from Madhan.


Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946


Repository: atlas


Description
---

Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.

This patch filterTypeDefs after authorization and updates the data for required 
types.


Diffs (updated)
-

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
7917f32e5 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e93a 


Diff: https://reviews.apache.org/r/72879/diff/2/

Changes: https://reviews.apache.org/r/72879/diff/1-2/


Testing
---

Tested Statistics UI from different users with different policies for 
entityType and classfication.

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-3947) Skip authorization for read _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3947?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3947:
---
Attachment: ATLAS-3947.patch

> Skip authorization for read _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES 
> types
> -
>
> Key: ATLAS-3947
> URL: https://issues.apache.org/jira/browse/ATLAS-3947
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3947.patch
>
>
> Skip authorization for read of _ALL_ENTITY_TYPES type of entity type  and 
> _ALL_CLASSIFICATION_TYPES type of classification type.
>  This are internally required by for system attributes search. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72880: ATLAS-3947 : Skip authorization for read of _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72880/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-3947
https://issues.apache.org/jira/browse/ATLAS-3947


Repository: atlas


Description
---

Skip authorization for read of _ALL_ENTITY_TYPES type of entity type and 
_ALL_CLASSIFICATION_TYPES type of classification type.
This are internally required by for system attributes search.

This patch Skip authorization for read of _ALL_ENTITY_TYPES entityType and and 
_ALL_CLASSIFICATION_TYPES classificationType.


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 458ec49ea 


Diff: https://reviews.apache.org/r/72880/diff/1/


Testing
---

Tested API's with no policies on types for a user. _ALL_ENTITY_TYPES and 
_ALL_CLASSIFICATION_TYPES are loaded correctly after it.


Thanks,

Nixon Rodrigues



[jira] [Created] (ATLAS-3947) Skip authorization for read _ALL_ENTITY_TYPES and _ALL_CLASSIFICATION_TYPES types

2020-09-17 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3947:
--

 Summary: Skip authorization for read _ALL_ENTITY_TYPES and 
_ALL_CLASSIFICATION_TYPES types
 Key: ATLAS-3947
 URL: https://issues.apache.org/jira/browse/ATLAS-3947
 Project: Atlas
  Issue Type: Improvement
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues


Skip authorization for read of _ALL_ENTITY_TYPES type of entity type  and 
_ALL_CLASSIFICATION_TYPES type of classification type.
 This are internally required by for system attributes search. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72879: ATLAS-3946 : Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72879/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Bugs: ATLAS-3946
https://issues.apache.org/jira/browse/ATLAS-3946


Repository: atlas


Description
---

Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.

This patch filterTypeDefs after authorization and updates the data for required 
types.


Diffs
-

  repository/src/main/java/org/apache/atlas/services/MetricsService.java 
7917f32e5 
  webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java 
e74a9e93a 


Diff: https://reviews.apache.org/r/72879/diff/1/


Testing
---

Tested Statistics UI from different users with different policies for 
entityType and classfication.

https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/25/console


Thanks,

Nixon Rodrigues



[jira] [Created] (ATLAS-3946) Filter TypeDefs in Metrics API and show data accordingly

2020-09-17 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3946:
--

 Summary: Filter TypeDefs in Metrics API and show data accordingly
 Key: ATLAS-3946
 URL: https://issues.apache.org/jira/browse/ATLAS-3946
 Project: Atlas
  Issue Type: Improvement
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues


Filter TypeDefs in Metrics API and show data accordingly, currently data is 
shown for all types even if user do not have access to those types.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72863: ATLAS-3939: added build profile berkeley-solr

2020-09-16 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72863/#review221868
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 12, 2020, 12:15 a.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72863/
> ---
> 
> (Updated Sept. 12, 2020, 12:15 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Nikhil Bonte, Sarath Subramanian, 
> and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3939
> https://issues.apache.org/jira/browse/ATLAS-3939
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> added build profile berkeley-solr
> 
> 
> Diffs
> -
> 
>   distro/.gitignore PRE-CREATION 
>   distro/pom.xml b92bd3548 
>   distro/src/bin/atlas_config.py 2d6143331 
>   distro/src/bin/atlas_start.py 963faf402 
>   distro/src/bin/atlas_stop.py 2e15c0f3f 
>   docs/src/documents/Setup/BuildInstruction.md 05f98fb9b 
>   docs/src/documents/Setup/InstallationInstruction.md fdff3a57e 
>   webapp/pom.xml 792b16445 
> 
> 
> Diff: https://reviews.apache.org/r/72863/diff/2/
> 
> 
> Testing
> ---
> 
> - built Atlas with profile berkeley-solr
> - deployed Atlas built above, started and successfully ran quick start
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>



Re: Review Request 72869: ATLAS-3942 : Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef while delete-type

2020-09-16 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72869/
---

(Updated Sept. 16, 2020, 6:32 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
and Sarath Subramanian.


Changes
---

Updated Patch with some more refactoring to it.


Bugs: ATLAS-3942
https://issues.apache.org/jira/browse/ATLAS-3942


Repository: atlas


Description (updated)
---

Problem : delete-type is triggering read-type authz access internally when 
called by method getByName. due to this delete-type access is depend on 
read-type access.
This patch propose refactoring of AtlasTypeDefGraphStore code to remove authz 
check reading typedef internally.


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 0b1317ad6 


Diff: https://reviews.apache.org/r/72869/diff/2/

Changes: https://reviews.apache.org/r/72869/diff/1-2/


Testing (updated)
---

Tested delete classfication when user do not have read access has deny access 
to update type.


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-3942) Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef while delete-type

2020-09-15 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3942:
---
Affects Version/s: 2.2.0

> Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef 
> while delete-type
> ---
>
> Key: ATLAS-3942
> URL: https://issues.apache.org/jira/browse/ATLAS-3942
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.2.0
>    Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3942.patch
>
>
> delete-type is triggering read-type authz access internally called by method 
> {{getByName}}.
> Considering refactoring {{AtlasTypeDefGraphStore}} code to remove authz check 
> reading typedef internally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3942) Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef while delete-type

2020-09-15 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3942:
---
Attachment: ATLAS-3942.patch

> Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef 
> while delete-type
> ---
>
> Key: ATLAS-3942
> URL: https://issues.apache.org/jira/browse/ATLAS-3942
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 2.2.0
>    Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3942.patch
>
>
> delete-type is triggering read-type authz access internally called by method 
> {{getByName}}.
> Considering refactoring {{AtlasTypeDefGraphStore}} code to remove authz check 
> reading typedef internally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Review Request 72869: ATLAS-3942 : Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef while delete-type

2020-09-15 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72869/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
and Sarath Subramanian.


Bugs: ATLAS-3942
https://issues.apache.org/jira/browse/ATLAS-3942


Repository: atlas


Description
---

Problem : delete-type is triggering read-type authz access internally when 
called by method getByName. due to this delete-type access is depend on 
read-type access.
This pactch propose refactoring of AtlasTypeDefGraphStore code to remove authz 
check reading typedef internally.
Also refactore the duplicate type check and type-read authorization code , to 
move type-read authorization code before duplicate type check


Diffs
-

  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 4a79b6fd5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 0b1317ad6 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasClassificationDefStoreV2.java
 9ffede4e3 


Diff: https://reviews.apache.org/r/72869/diff/1/


Testing
---

Tested delete classfication when user do not have read access has deny access 
to update type.
Tested creating duplicate classification type.


Thanks,

Nixon Rodrigues



[jira] [Updated] (ATLAS-3942) Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef while delete-type

2020-09-15 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3942:
---
Summary: Refactoring AtlasTypeDefGraphStore code to remove authz check 
reading typedef while delete-type  (was: Refactoring AtlasTypeDefGraphStore 
code to remove authz check reading typedef)

> Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef 
> while delete-type
> ---
>
> Key: ATLAS-3942
> URL: https://issues.apache.org/jira/browse/ATLAS-3942
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
>
> delete-type is triggering read-type authz access internally called by method 
> {{getByName}}.
> Considering refactoring {{AtlasTypeDefGraphStore}} code to remove authz check 
> reading typedef internally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3942) Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef

2020-09-15 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3942:
---
Description: 
delete-type is triggering read-type authz access internally called by method 
{{getByName}}.
Considering refactoring {{AtlasTypeDefGraphStore}} code to remove authz check 
reading typedef internally.

  was:
delete-type is triggering read-type authz access internally calls getByName.
Considering refactoring AtlasTypeDefGraphStore code to remove authz check 
reading typedef internally.


> Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef
> -
>
> Key: ATLAS-3942
> URL: https://issues.apache.org/jira/browse/ATLAS-3942
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
>
> delete-type is triggering read-type authz access internally called by method 
> {{getByName}}.
> Considering refactoring {{AtlasTypeDefGraphStore}} code to remove authz check 
> reading typedef internally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3942) Refactoring AtlasTypeDefGraphStore code to remove authz check reading typedef

2020-09-15 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3942:
--

 Summary: Refactoring AtlasTypeDefGraphStore code to remove authz 
check reading typedef
 Key: ATLAS-3942
 URL: https://issues.apache.org/jira/browse/ATLAS-3942
 Project: Atlas
  Issue Type: Bug
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues


delete-type is triggering read-type authz access internally calls getByName.
Considering refactoring AtlasTypeDefGraphStore code to remove authz check 
reading typedef internally.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3941) NotificationHookConsumer: Reduce Retry Pause Interval

2020-09-14 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17195553#comment-17195553
 ] 

Nixon Rodrigues commented on ATLAS-3941:


+1 for the patch, Thanks [~amestry]

> NotificationHookConsumer: Reduce Retry Pause Interval
> -
>
> Key: ATLAS-3941
> URL: https://issues.apache.org/jira/browse/ATLAS-3941
> Project: Atlas
>  Issue Type: Bug
>  Components:  atlas-core
>Affects Versions: trunk, 2.1.0
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3941-NotificationHookConsumer-Reduce-wait-time.patch
>
>
> *Background*
> The retry logic introduced earlier, had a long wait time in case a concurrent 
> entity create was detected. This adversely affect ingest speed in the case 
> where there are a lot of errors in the data being ingested.
> *Solution*
> Reduce the wait time.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3940) Upgrade snakeyaml to a version without CVE-2017-18640

2020-09-14 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3940:
---
Issue Type: Bug  (was: Improvement)

> Upgrade snakeyaml to a version without CVE-2017-18640 
> --
>
> Key: ATLAS-3940
> URL: https://issues.apache.org/jira/browse/ATLAS-3940
> Project: Atlas
>  Issue Type: Bug
>    Reporter: Nixon Rodrigues
>Priority: Major
>
> Maven package cassandra-all has transitive dependency on 
> org.yaml:snakeyaml:1.11 which has 
> CVE-2017-18640:https://nvd.nist.gov/vuln/detail/CVE-2017-18640



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3940) Upgrade snakeyaml to a version without CVE-2017-18640

2020-09-14 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3940:
--

 Summary: Upgrade snakeyaml to a version without CVE-2017-18640 
 Key: ATLAS-3940
 URL: https://issues.apache.org/jira/browse/ATLAS-3940
 Project: Atlas
  Issue Type: Improvement
Reporter: Nixon Rodrigues


Maven package cassandra-all has transitive dependency on 
org.yaml:snakeyaml:1.11 which has 
CVE-2017-18640:https://nvd.nist.gov/vuln/detail/CVE-2017-18640



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72821: ATLAS-3935 Use Audit framework to capture audit entries for Import/Export operations

2020-09-10 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72821/#review221843
---


Ship it!




Ship It!

- Nixon Rodrigues


On Sept. 9, 2020, 10:04 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72821/
> ---
> 
> (Updated Sept. 9, 2020, 10:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3935
> https://issues.apache.org/jira/browse/ATLAS-3935
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> By using Audit Framework, capture audit entries for Import/Export operations.
> 
> These audit entries can be seen under the "Audits" tab of Admin section.
> 
> Add Import and Export specific information in Audit entry
> 
> Total no. of entities imported/ exported
> Total no. of entities imported/ exported of specific TypeDef
> Export operation Fetch Type
> 
> 
> Diffs
> -
> 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 3a5ae5c 
> 
> 
> Diff: https://reviews.apache.org/r/72821/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>



Re: [DRAFT] Board report for Apache Atlas: September 2020

2020-09-07 Thread Nixon Rodrigues
Madhan,

Thanks for compiling this report and putting it together for review.

Draft looks good. +1

Regards

Nixon Rodrigues

On Mon, Sep 7, 2020, 12:40 PM Madhan Neethiraj  wrote:

> Atlas team,
>
> Please review the draft board report below and send your feedback/comments.
>
> Thanks,
> Madhan
>
> ## Description:
> Apache Atlas is a scalable and extensible set of core foundational
> governance
> services that enables enterprises to effectively and efficiently meet their
> compliance requirements within Hadoop and allows integration with the
> complete
> enterprise data ecosystem.
>
> ## Issues:
> There are no issues requiring board attention at this time.
>
> ## Membership Data:
> Apache Atlas was founded 2017-06-20 (3 years ago)
> There are currently 42 committers and 32 PMC members in this project.
> The Committer-to-PMC ratio is roughly 4:3.
>
> Community changes, past quarter:
>  - No new PMC members. Last addition was Ashutosh Mestry on 2019-04-16.
>  - Nikhil P Bonte was added as committer on 2020-09-03
>
> ## Project Activity:
>  - Atlas community released 2.1.0, more than a year in making, with a
> number
>of new features, enhancements and fixes, like:
>   - quick search, with type-ahead suggestions
>   - business Metadata to enable augmenting entity-types with additional
> attributes, search entities using these attributes
>   - ability to add labels on entities, and search entities using labels
>   - ability to add entity instance specific custom attributes i.e.
> attributes
> not defined in entity-def or business metadata
>   - REST APIs to purge deleted entities
>   - ability to find entities by more than one classification
>   - support to process notifications from multiple Kafka topics
>   - model updates to capture Spark, AWS S3, ADLS-Gen2 entities
>   - performance, UI improvements
>  - the community is working on enhancements and fixes for next release
>   - audit enhancements to track entity-type create/update/data
>   - authorization enhancements to support type-read permission
>   - support for date-range in search filters
>   - working on adding Java and Python APIs
>
> ## Community Health:
>  - dev@atlas.apache.org had a 28% decrease in traffic in the past quarter
>(1254 emails compared to 1734)
>  - u...@atlas.apache.org had a 50% increase in traffic in the past
> quarter (30
>emails compared to 20)
>  - 96 issues opened in JIRA, past quarter (-46% decrease)
>  - 60 issues closed in JIRA, past quarter (-81% decrease)
>  - 123 commits in the past quarter (-58% decrease)
>  - 18 code contributors in the past quarter (-21% decrease)
>  - 7 PRs opened on GitHub, past quarter (-22% decrease)
>  - 4 PRs closed on GitHub, past quarter (-55% decrease)
>
> ## Releases:
>   2.1.0was released on 07/16/2020
>   0.8.4was released on 06/21/2019
>   1.2.0was released on 06/12/2019
>   2.0.0was released on 05/14/2019
>   0.8.3was released on 10/31/2018
>   1.1.0was released on 09/17/2018
>   1.0.0was released on 06/02/2018
>   0.8.2was released on 02/05/2018
>   1.0.0-alpha  was released on 01/25/2018
>   0.8.1was released on 08/29/2017
>   0.8-incubating   was released on 03/16/2017
>   0.7.1-incubating was released on 01/26/2017
>   0.7-incubating   was released on 07/09/2016
>   0.6-incubating   was released on 12/31/2015
>   0.5-incubating   was released on 07/11/2015
>
>
>
>


[jira] [Commented] (ATLAS-3925) UI: Properties with value 0 or false are displayed as N/A for

2020-09-03 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17190128#comment-17190128
 ] 

Nixon Rodrigues commented on ATLAS-3925:


+1 for ATLAS-3925-1.patch, thanks [~kevalbhatt]

> UI: Properties with value 0 or false are displayed as N/A for 
> --
>
> Key: ATLAS-3925
> URL: https://issues.apache.org/jira/browse/ATLAS-3925
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3925-1.patch, ATLAS-3925.patch, 
> image-2020-08-25-12-53-09-294.png, image-2020-08-25-12-53-45-935.png
>
>
> Check the screenshot:
> *partitionCount* is displayed as N/A instead of *0*
>  
> +API response:+
>  
> *!image-2020-08-25-12-53-09-294.png|width=440,height=151!*
> +UI:+ 
>  
> *!image-2020-08-25-12-53-45-935.png|width=427,height=214!*
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (ATLAS-3925) UI: Properties with value 0 or false are displayed as N/A for

2020-09-03 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues reopened ATLAS-3925:


> UI: Properties with value 0 or false are displayed as N/A for 
> --
>
> Key: ATLAS-3925
> URL: https://issues.apache.org/jira/browse/ATLAS-3925
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3925-1.patch, ATLAS-3925.patch, 
> image-2020-08-25-12-53-09-294.png, image-2020-08-25-12-53-45-935.png
>
>
> Check the screenshot:
> *partitionCount* is displayed as N/A instead of *0*
>  
> +API response:+
>  
> *!image-2020-08-25-12-53-09-294.png|width=440,height=151!*
> +UI:+ 
>  
> *!image-2020-08-25-12-53-45-935.png|width=427,height=214!*
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3932) Upgrade Spring security , libpam4j and jna lib version

2020-08-28 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3932:
---
Attachment: 0001-ATLAS-3932-Upgrade-jna-spring.security-and-libpam4j-.patch

> Upgrade Spring security , libpam4j and jna lib version
> --
>
> Key: ATLAS-3932
> URL: https://issues.apache.org/jira/browse/ATLAS-3932
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3932-Upgrade-jna-spring.security-and-libpam4j-.patch
>
>
> Upgrade jna lib version from 4.1.0 to 5.2.0
> Upgrade libpam4j lib version from 1.8 to 1.11
> and Upgrade Spring security  version from 4.2.16.RELEASE to  4.2.17.RELEASE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3932) Upgrade Spring security , libpam4j and jna lib version

2020-08-28 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3932:
---
Description: 
Upgrade jna lib version from 4.1.0 to 5.2.0
Upgrade libpam4j lib version from 1.8 to 1.11
and Upgrade Spring security  version from 4.2.16.RELEASE to  4.2.17.RELEASE

  was:
Upgrade jna lib version from 4.1.0 to 5.2.0
and Upgrade Spring security  version to  4.2.17.RELEASE


> Upgrade Spring security , libpam4j and jna lib version
> --
>
> Key: ATLAS-3932
> URL: https://issues.apache.org/jira/browse/ATLAS-3932
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: 
> 0001-ATLAS-3932-Upgrade-jna-spring.security-and-libpam4j-.patch
>
>
> Upgrade jna lib version from 4.1.0 to 5.2.0
> Upgrade libpam4j lib version from 1.8 to 1.11
> and Upgrade Spring security  version from 4.2.16.RELEASE to  4.2.17.RELEASE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3932) Upgrade Spring security , libpam4j and jna lib version

2020-08-28 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3932:
---
Summary: Upgrade Spring security , libpam4j and jna lib version  (was: 
Upgrade Spring security and jna lib version)

> Upgrade Spring security , libpam4j and jna lib version
> --
>
> Key: ATLAS-3932
> URL: https://issues.apache.org/jira/browse/ATLAS-3932
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Upgrade jna lib version from 4.1.0 to 5.2.0
> and Upgrade Spring security  version to  4.2.17.RELEASE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3932) Upgrade Spring security and jna lib version

2020-08-28 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3932:
---
Summary: Upgrade Spring security and jna lib version  (was: Upgrade jna lib 
version to 5.2.0)

> Upgrade Spring security and jna lib version
> ---
>
> Key: ATLAS-3932
> URL: https://issues.apache.org/jira/browse/ATLAS-3932
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Upgrade jna lib version from 4.1.0 to 5.2.0 for PAM authentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3932) Upgrade Spring security and jna lib version

2020-08-28 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3932?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3932:
---
Description: 
Upgrade jna lib version from 4.1.0 to 5.2.0
and Upgrade Spring security  version to  4.2.17.RELEASE

  was:Upgrade jna lib version from 4.1.0 to 5.2.0 for PAM authentication


> Upgrade Spring security and jna lib version
> ---
>
> Key: ATLAS-3932
> URL: https://issues.apache.org/jira/browse/ATLAS-3932
> Project: Atlas
>  Issue Type: Improvement
>Affects Versions: 2.1.0
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
>
> Upgrade jna lib version from 4.1.0 to 5.2.0
> and Upgrade Spring security  version to  4.2.17.RELEASE



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (ATLAS-3932) Upgrade jna lib version to 5.2.0

2020-08-28 Thread Nixon Rodrigues (Jira)
Nixon Rodrigues created ATLAS-3932:
--

 Summary: Upgrade jna lib version to 5.2.0
 Key: ATLAS-3932
 URL: https://issues.apache.org/jira/browse/ATLAS-3932
 Project: Atlas
  Issue Type: Improvement
Affects Versions: 2.1.0
Reporter: Nixon Rodrigues
Assignee: Nixon Rodrigues
 Fix For: 3.0.0, 2.2.0


Upgrade jna lib version from 4.1.0 to 5.2.0 for PAM authentication



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3925) UI: Properties with value 0 or false are displayed as N/A for

2020-08-26 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17185077#comment-17185077
 ] 

Nixon Rodrigues commented on ATLAS-3925:


+1 for the patch , Thanks [~kevalbhatt]

> UI: Properties with value 0 or false are displayed as N/A for 
> --
>
> Key: ATLAS-3925
> URL: https://issues.apache.org/jira/browse/ATLAS-3925
> Project: Atlas
>  Issue Type: Bug
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3925.patch, image-2020-08-25-12-53-09-294.png, 
> image-2020-08-25-12-53-45-935.png
>
>
> Check the screenshot:
> *partitionCount* is displayed as N/A instead of *0*
>  
> +API response:+
>  
> *!image-2020-08-25-12-53-09-294.png|width=440,height=151!*
> +UI:+ 
>  
> *!image-2020-08-25-12-53-45-935.png|width=427,height=214!*
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Comment Edited] (ATLAS-3926) Atlas1.2 with Kerberos problem

2020-08-25 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184028#comment-17184028
 ] 

Nixon Rodrigues edited comment on ATLAS-3926 at 8/25/20, 1:31 PM:
--

For kerberos authentication properties with prefix 
"atlas.authentication.method.kerberos" are used for configuring the kerberos 
filter. I see them as some commented. please ensure following properties are 
set and kinit is done before running import-hive.sh

atlas.authentication.method.kerberos=true
atlas.authentication.method.kerberos.keytab=/keytab/atlas.keytab
atlas.authentication.method.kerberos.principal=atlas/_h...@example.com
atlas.authentication.method.kerberos.name.rules=
atlas.authentication.keytab=/keytab/atlas.keytab
atlas.authentication.principal=atlas/_h...@example.com




was (Author: nixonrodrigues):
For kerberos authentication properties with prefix 
"atlas.authentication.method.kerberos" are used for configuring the kerberos 
filter. I see them as some commented. please ensure following properties are 
set and kinit is done before running import-hive.sh

atlas.authentication.method.kerberos=true
atlas.authentication.method.kerberos.keytab=/keytab/atlas.keytab
atlas.authentication.method.kerberos.principal=atlas/_h...@example.com
atlas.authentication.method.kerberos.name.rules=
atlas.authentication.keytab=/keytab/atlas.keytab
atlas.authentication.principal=atlas/_h...@root.hwx.site



> Atlas1.2 with Kerberos problem
> --
>
> Key: ATLAS-3926
> URL: https://issues.apache.org/jira/browse/ATLAS-3926
> Project: Atlas
>  Issue Type: Bug
>  Components: falcon-integration, hive-integration
>Affects Versions: 1.2.0
>Reporter: yuyu
>Priority: Major
> Fix For: 1.2.0
>
> Attachments: image-2020-08-25-16-29-12-906.png, 
> image-2020-08-25-16-29-29-667.png, image-2020-08-25-16-30-34-221.png, 
> image-2020-08-25-16-31-23-439.png, image-2020-08-25-16-31-28-330.png, 
> image-2020-08-25-16-34-41-642.png, image-2020-08-25-16-35-09-836.png, 
> image-2020-08-25-16-38-45-645.png
>
>
> Hello, everyone. Recently, I encountered a problem with Kerberos when 
> deploying atlas.I tried to deploy atlas service on my CDH cluster with CDH 
> version 5.16 and Kerberos service deployed.My installation method is Atlas 
> 1.2 integrated CDH HBase and external 5.5.1 Solr
> When I start the atlas service, I can successfully access the atlas web page 
> through my computer:
> !image-2020-08-25-16-29-29-667.png!
> But when I tried to import hive metadata information, something went wrong,as 
> shown in the figure below:
> !image-2020-08-25-16-30-34-221.png!
> !image-2020-08-25-16-38-45-645.png!
> !image-2020-08-25-16-31-28-330.png!
> It seems to indicate that I don't have a valid Kerberos principal?
> Here is part of my atlas configuration file  atlas-application.properties:
> !image-2020-08-25-16-34-41-642.png!
> !image-2020-08-25-16-35-09-836.png!
> Can anyone tell me what the problem is,thanks.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3926) Atlas1.2 with Kerberos problem

2020-08-25 Thread Nixon Rodrigues (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17184028#comment-17184028
 ] 

Nixon Rodrigues commented on ATLAS-3926:


For kerberos authentication properties with prefix 
"atlas.authentication.method.kerberos" are used for configuring the kerberos 
filter. I see them as some commented. please ensure following properties are 
set and kinit is done before running import-hive.sh

atlas.authentication.method.kerberos=true
atlas.authentication.method.kerberos.keytab=/keytab/atlas.keytab
atlas.authentication.method.kerberos.principal=atlas/_h...@example.com
atlas.authentication.method.kerberos.name.rules=
atlas.authentication.keytab=/keytab/atlas.keytab
atlas.authentication.principal=atlas/_h...@root.hwx.site



> Atlas1.2 with Kerberos problem
> --
>
> Key: ATLAS-3926
> URL: https://issues.apache.org/jira/browse/ATLAS-3926
> Project: Atlas
>  Issue Type: Bug
>  Components: falcon-integration, hive-integration
>Affects Versions: 1.2.0
>Reporter: yuyu
>Priority: Major
> Fix For: 1.2.0
>
> Attachments: image-2020-08-25-16-29-12-906.png, 
> image-2020-08-25-16-29-29-667.png, image-2020-08-25-16-30-34-221.png, 
> image-2020-08-25-16-31-23-439.png, image-2020-08-25-16-31-28-330.png, 
> image-2020-08-25-16-34-41-642.png, image-2020-08-25-16-35-09-836.png, 
> image-2020-08-25-16-38-45-645.png
>
>
> Hello, everyone. Recently, I encountered a problem with Kerberos when 
> deploying atlas.I tried to deploy atlas service on my CDH cluster with CDH 
> version 5.16 and Kerberos service deployed.My installation method is Atlas 
> 1.2 integrated CDH HBase and external 5.5.1 Solr
> When I start the atlas service, I can successfully access the atlas web page 
> through my computer:
> !image-2020-08-25-16-29-29-667.png!
> But when I tried to import hive metadata information, something went wrong,as 
> shown in the figure below:
> !image-2020-08-25-16-30-34-221.png!
> !image-2020-08-25-16-38-45-645.png!
> !image-2020-08-25-16-31-28-330.png!
> It seems to indicate that I don't have a valid Kerberos principal?
> Here is part of my atlas configuration file  atlas-application.properties:
> !image-2020-08-25-16-34-41-642.png!
> !image-2020-08-25-16-35-09-836.png!
> Can anyone tell me what the problem is,thanks.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (ATLAS-3898) Authorize read of typedefs

2020-08-14 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues resolved ATLAS-3898.

Resolution: Fixed

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>  Components:  atlas-core
>Affects Versions: 2.1.0
>    Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
>  Labels: authorization, ranger
> Fix For: 3.0.0, 2.2.0
>
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

2020-08-14 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Description: 
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This patch authorize read for all typedefs. It implicitly add read permission 
if create,update or delete permission is assigned to user.

  was:
Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This jira propose to authorize read of classifications def to user with create 
permission.




> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

2020-08-14 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Attachment: ATLAS-3898.1.patch

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

2020-08-14 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Attachment: (was: ATLAS-3898.2.patch)

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.1.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This patch authorize read for all typedefs. It implicitly add read permission 
> if create,update or delete permission is assigned to user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (ATLAS-3898) Authorize read of typedefs

2020-08-14 Thread Nixon Rodrigues (Jira)


 [ 
https://issues.apache.org/jira/browse/ATLAS-3898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nixon Rodrigues updated ATLAS-3898:
---
Summary: Authorize read of typedefs  (was: Authorize read of 
Classifications def to user with create permission.)

> Authorize read of typedefs
> --
>
> Key: ATLAS-3898
> URL: https://issues.apache.org/jira/browse/ATLAS-3898
> Project: Atlas
>  Issue Type: New Feature
>    Reporter: Nixon Rodrigues
>    Assignee: Nixon Rodrigues
>Priority: Major
> Attachments: ATLAS-3898.2.patch
>
>
> Currently in the Atlas-Ranger plugin for types resource READ permission is 
> not available and read access is available by default to all types of any 
> category.
> This jira propose to authorize read of classifications def to user with 
> create permission.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: Review Request 72714: ATLAS-3898 :- Authorize read of typedefs.

2020-08-14 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72714/
---

(Updated Aug. 14, 2020, 1:35 p.m.)


Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nikhil Bonte, and 
Sarath Subramanian.


Summary (updated)
-

ATLAS-3898 :- Authorize read of typedefs.


Bugs: ATLAS-3898
https://issues.apache.org/jira/browse/ATLAS-3898


Repository: atlas


Description
---

Currently in the Atlas-Ranger plugin for types resource READ permission is not 
available and read access is available by default to all types of any category.

This patch authorize read for all typedefs. It implicitly add read permission 
if create,update or delete permission is assinged to user.

a)Instrumented authorization code to read classification typedef endpoints in 
Atlas code with create permission.
b)Added logAudit property in AtlasRequest to skip auditing for filtering calls.


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizationUtils.java
 460b454b9 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasAuthorizer.java 
95d69e685 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
7287b3dd7 
  
authorization/src/main/java/org/apache/atlas/authorize/AtlasTypesDefFilterRequest.java
 PRE-CREATION 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 734991691 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 79f52700b 


Diff: https://reviews.apache.org/r/72714/diff/2/


Testing
---

Done end to end testing with Atlas with SimpleAuthorizer for getAll typedefs 
API, and type def API with name & guid.

https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2110


Thanks,

Nixon Rodrigues



  1   2   3   4   5   6   7   8   9   10   >