Re: Review Request 72730: ATLAS-3875: Introduce AtlasClient in Python

2020-08-11 Thread Sidharth Mishra
f needed) client/client-v2/src/main/python/atlas_client/discovery_model.py Lines 145 (patched) <https://reviews.apache.org/r/72730/#comment310607> Please remove if not needed - Sidharth Mishra On Aug. 10, 2020, 5:26 p.m., Jyoti Singh wrote: > > ---

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-24 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72698/#review221369 --- Ship it! Ship It! - Sidharth Mishra On July 23, 2020, 6:10

Re: Review Request 72698: ATLAS-3875: Introduce sample project for AtlasClient

2020-07-22 Thread Sidharth Mishra
in/java/org/apache/atlas/AtlasClientBaseExample.java Lines 140 (patched) <https://reviews.apache.org/r/72698/#comment310199> Please use Console.readPassword instead - Sidharth Mishra On July 21, 2020, 4:24 p.m., Jyoti Singh wrote: > > --

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-14 Thread Sidharth Mishra
* use below: import static org.testng.Assert.assertNotNull; import static org.testng.Assert.fail; import static org.testng.Assert.assertNull; import static org.testng.Assert.assertEquals; - Sidharth Mishra On July 10, 2020, 12:05 a.m., Jyoti

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-14 Thread Sidharth Mishra
e any v2 API at AtlasBaseClient. Could you please move this to AtlasClientV2. client/common/src/main/java/org/apache/atlas/AtlasBaseClient.java Lines 489 (patched) <https://reviews.apache.org/r/72638/#comment310040> Please move this as well to v2 as this is the base client. - Sidhart

Re: Review Request 72638: ATLAS-3875: Enhancing AtlasClient by adding missing API endpoints

2020-07-14 Thread Sidharth Mishra
dMap queryParams = new MultivaluedMapImpl(); queryParams.add("name", name); client/client-v2/src/main/java/org/apache/atlas/AtlasClientV2.java Lines 650 (patched) <https://reviews.apache.org/r/72638/#comme

Re: [VOTE] Release Apache Atlas version 2.1.0 - rc3

2020-07-14 Thread sidharth mishra
+1 for Apache Atlas 2.1 rc3 Validated the following: - Verified the MD5/sha512 hash - Verified PGP signature - No binaries in extracted source - Verified the build with embedded-hbase and solr - Ran quick start and tested some sanity test cases - Basic/advanced search, Classification, Glossary,

Re: Review Request 72658: ATLAS-3877: Audit API returns the audit information for an unauthorised entity

2020-07-08 Thread Sidharth Mishra
ot;:[],\"removePropagationsOnEntityDelete\":false},{\"typeName\":\"PARENT\",\"entityGuid\":\"73cc5730-494b-4313-8747-9ccf8a1b0227\",\"entityStatus\":\"ACTIVE\",\"propagate\":true,\"validityPeriods\":[],\"removePropagationsOnEntityDelete\":false}],\"meanings\":[],\"proxy\":false}","eventKey":"def375bd-9bad-42f3-9fa7-9edc1c7d8d96:1594191071761:3:1594191103634","entity":null ,"type":null}] //Deny curl --location --request GET 'http://sid-ycloud-atlas1-2.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/def375bd-9bad-42f3-9fa7-9edc1c7d8d96/audit?count=1=ENTITY_PURGE' \ -u sid:sid Response: {"errorCode":"ATLAS-403-00-001","errorMessage":"sid is not authorized to perform read entity audit: guid=def375bd-9bad-42f3-9fa7-9edc1c7d8d96"} Thanks, Sidharth Mishra

Review Request 72658: ATLAS-3877: Audit API returns the audit information for an unauthorised entity

2020-07-08 Thread Sidharth Mishra
ot;,\"entityGuid\":\"73cc5730-494b-4313-8747-9ccf8a1b0227\",\"entityStatus\":\"ACTIVE\",\"propagate\":true,\"validityPeriods\":[],\"removePropagationsOnEntityDelete\":false}],\"meanings\":[],\"proxy\":false}","eventKey":"def375bd-9bad-42f3-9fa7-9edc1c7d8d96:1594191071761:3:1594191103634","entity":null ,"type":null}] //Deny curl --location --request GET 'http://sid-ycloud-atlas1-2.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/def375bd-9bad-42f3-9fa7-9edc1c7d8d96/audit?count=1=ENTITY_PURGE' \ -u sid:sid Response: {"errorCode":"ATLAS-403-00-001","errorMessage":"sid is not authorized to perform read entity audit: guid=def375bd-9bad-42f3-9fa7-9edc1c7d8d96"} Thanks, Sidharth Mishra

Re: [VOTE] Release Apache Atlas version 2.1.0 - rc1

2020-06-08 Thread sidharth mishra
+1 for Apache Atlas 2.1 RC1 Validated the following items. 1. Verified the md5/sha512 checksum of source bundle 2. Packaging with -Pdist,embedded-hbase-solr works fine 3. Starting Atlas server works fine 4. quick_start.py works fine and all the entities and tags get created

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-29 Thread Sidharth Mishra
;operationType": "CLASSIFICATION_ADD", "eventTime": 1590181673717 } } { "version": { "version": "1.0.0", "versionParts": [ 1 ] }, "msgCompressionKind": "NO

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sidharth Mishra
;operationType": "CLASSIFICATION_ADD", "eventTime": 1590181673717 } } { "version": { "version": "1.0.0", "versionParts": [ 1 ] }, "msgCompressionKind": "NO

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sidharth Mishra
"version": "1.0.0", "versionParts": [ 1 ] }, "msgCompressionKind": "NONE", "msgSplitIdx": 1, "msgSplitCount": 1, "msgSourceIP": "172.27.168.128", "msgCreatedBy": "", "msgCreationTime": 1590181680714, "message": { "type": "ENTITY_NOTIFICATION_V2", "entity": { "typeName": "hive_table", "attributes": { "owner": "anonymous", "createTime": 1590120919000, "qualifiedName": "sid_hive_db.sid_hive_table_ctas3@bulk", "name": "sid_hive_table_ctas3" }, "guid": "ab302745-a843-4164-8166-017f85c7e15e", "status": "ACTIVE", "displayText": "sid_hive_table_ctas3", "classificationNames": [ "ETL", "PII", "Fact" ], "classifications": [ { "typeName": "ETL", "entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811", "entityStatus": "ACTIVE", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false }, { "typeName": "PII", "entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811", "entityStatus": "ACTIVE", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false }, { "typeName": "Fact", "entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811", "entityStatus": "ACTIVE", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false } ] }, "operationType": "CLASSIFICATION_ADD", "eventTime": 1590181673717 } } Thanks, Sidharth Mishra

Re: Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-28 Thread Sidharth Mishra
ropagatedEntities when we call fullTextMapperV2.getAndCacheEntity(guid) we still get the old one without classification. So along with this change I added code to constructHeader so that it will set classification to entity from entityHeader. Now the updated solution works. - S

Review Request 72540: ATLAS-3806: Classifications information missing in notification events during entity create/update

2020-05-22 Thread Sidharth Mishra
"version": "1.0.0", "versionParts": [ 1 ] }, "msgCompressionKind": "NONE", "msgSplitIdx": 1, "msgSplitCount": 1, "msgSourceIP": "172.27.168.128", "msgCreatedBy": "", "msgCreationTime": 1590181680714, "message": { "type": "ENTITY_NOTIFICATION_V2", "entity": { "typeName": "hive_table", "attributes": { "owner": "anonymous", "createTime": 1590120919000, "qualifiedName": "sid_hive_db.sid_hive_table_ctas3@bulk", "name": "sid_hive_table_ctas3" }, "guid": "ab302745-a843-4164-8166-017f85c7e15e", "status": "ACTIVE", "displayText": "sid_hive_table_ctas3", "classificationNames": [ "ETL", "PII", "Fact" ], "classifications": [ { "typeName": "ETL", "entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811", "entityStatus": "ACTIVE", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false }, { "typeName": "PII", "entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811", "entityStatus": "ACTIVE", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false }, { "typeName": "Fact", "entityGuid": "410cb0f3-6df7-4523-ba23-8cd65752a811", "entityStatus": "ACTIVE", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false } ] }, "operationType": "CLASSIFICATION_ADD", "eventTime": 1590181673717 } } Thanks, Sidharth Mishra

Re: Review Request 72515: ATLAS-3785: Modify the AWS s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional

2020-05-15 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json 676a2237c Diff: https://reviews.apache.org/r/72515/diff/2/ Changes: https://reviews.apache.org/r/72515/diff/1-2/ Testing --- Manually added to my cluster Thanks, Sidharth Mishra

Re: Review Request 72512: Edge Creation: Refactoring

2020-05-14 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72512/#review220776 --- Ship it! Ship It! - Sidharth Mishra On May 14, 2020, 10:41

Review Request 72515: ATLAS-3785: Modify the AWS s3 v2 model to make relationship def end points as legacy attributes and objectPrefix as optional

2020-05-14 Thread Sidharth Mishra
-aws_s3_v2_typedefs.json 676a2237c Diff: https://reviews.apache.org/r/72515/diff/1/ Testing --- Manually added to my cluster Thanks, Sidharth Mishra

Re: Review Request 72512: Edge Creation: Refactoring

2020-05-14 Thread Sidharth Mishra
iews.apache.org/r/72512/#comment309463> Just to avoid two returns statement as we do other places in atlas, we can do something like: Initialize variable AtlasEdge ret = null; At 192 line: ret = GraphDbObjectFactory.createEdge(this, ret); At the end return ret; - Sidhart

Re: Review Request 72464: ATLAS-3778: Improve performance during classification delete

2020-05-04 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72464/#review220605 --- Ship it! Ship It! - Sidharth Mishra On May 3, 2020, 11:04

Re: Review Request 72452: Efficiently Searching for Edges Between Vertices

2020-05-04 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72452/#review220604 --- Ship it! Ship It! - Sidharth Mishra On April 30, 2020, 4:04

Re: Review Request 72452: Efficiently Searching for Edges Between Vertices

2020-04-29 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72452/#review220557 --- Ship it! Ship It! - Sidharth Mishra On April 29, 2020, 9:17

Re: Review Request 72452: Efficiently Searching for Edges Between Vertices

2020-04-29 Thread Sidharth Mishra
; ret = getActiveEdgeFromList(toVertex.getId(), edgesIterator); } } RequestContext.get().endMetricRecord(metric); return ret; - Sidharth Mishra On April 29, 2020, 5:51 p.

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sidharth Mishra
f times, I was not able to run EntityV2JerseyResourceIT. precommit run will ensure if this passes. Thanks, Sidharth Mishra

Re: Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as body with operation Put instead of Delete

2020-04-21 Thread Sidharth Mishra
'["bd7262f6-fed5-40f3-9f72-f57fba6b1193", "24c4df6e-b27a-4c60-b85a-67ed20210446", "24c4df6e-b27a-4c60-b85a-67ed20210446"]' Note: As local jetty was failing for couple of times, I was not able to run EntityV2JerseyResourceIT. precommit run will ensure if this passes. Thanks, Sidharth Mishra

Review Request 72411: ATLAS-3747: Atlas Admin Purge API should take list of guids as query param instead of body

2020-04-21 Thread Sidharth Mishra
will ensure if this passes. Thanks, Sidharth Mishra

Re: Review Request 72367: ATLAS-3709: fix to address skipped index initialization in earlier commit

2020-04-15 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72367/#review220328 --- Ship it! Ship It! - Sidharth Mishra On April 15, 2020, 5:22

Re: Review Request 72257: ATLAS-3583 Use Audit framework to generate audit entries for Classification CREATE, UPDATE and DELETE

2020-04-15 Thread Sidharth Mishra
hanges. toEntityAuditActionV2() should return proper state which can be used to get more details from entity audit - HBase) - Sidharth Mishra On April 7, 2020, 6:22 a.m., Mandar Ambawane wrote: > > --- > This is an automatically generated e

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra
-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=ENTITY_UPDATE' Thanks, Sidharth Mishra

Review Request 72358: ATLAS-3730: In case Hard delete and Purge of an Entity we should make the entity status as purged instead of deleted

2020-04-13 Thread Sidharth Mishra
777b6b", "entityStatus": "PURGED", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false }, { "typeName": "TEST_TAG_1", "entityGuid": "a2d1cad9-d2a1-4fe4-8570-2e58e16877ca", "entityStatus": "ACTIVE", "propagate": true, "validityPeriods": [], "removePropagationsOnEntityDelete": false } ] Thanks, Sidharth Mishra

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra
:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=ENTITY_UPDATE' Thanks, Sidharth Mishra

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra
be always to a const value. - Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72351/#review220287 --- On April

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0' --header 'Content-Type: application/json' Thanks, Sidharth Mishra

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-10 Thread Sidharth Mishra
'Content-Type: application/json' Thanks, Sidharth Mishra

Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-10 Thread Sidharth Mishra
: Basic YWRtaW46YWRtaW4xMjM=' Thanks, Sidharth Mishra

Re: Review Request 72338: ATLAS-3726: Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-09 Thread Sidharth Mishra
tartTime", "operator": "gte", "attributeValue": "1575958152162" }, { "attributeName": "endTime", "operator": "gte", "att

Review Request 72338: ATLAS-3726: Add result count to Atlas Admin Audit and enable filters on count for get audit

2020-04-08 Thread Sidharth Mishra
attributeValue": "1575958152162" }, { "attributeName": "endTime", "operator": "gte", "attributeValue": "1575958152184" }, { "attributeName": "resultCount", "operator": "eq", "attributeValue": "4" } ] }, "limit": 15, "offset": 0, "sortBy": "resultCount", "sortOrder": "DESCENDING" }' Thanks, Sidharth Mishra

Re: Review Request 72317: ATLAS-3709 Issues with quick search/suggestions in conjunction with Business Metadata attributes

2020-04-07 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72317/#review220236 --- Ship it! Ship It! - Sidharth Mishra On April 7, 2020, 6:20

Review Request 72328: ATLAS-3719: Tag and Type search is not doing index search

2020-04-06 Thread Sidharth Mishra
w '{"excludeDeletedEntities":true,"includeSubClassifications":true,"includeSubTypes":true,"includeClassificationAttributes":true,"limit":25,"offset":0,"typeName":null,"classification":"BEFORE_DEMO","termName":null}' Thanks, Sidharth Mishra

Re: Review Request 72284: ATLAS-3707: Atlas Purge entity is generating both purge and delete audit

2020-03-30 Thread Sidharth Mishra
e need to stop by adding the check. To keep the hard delete and purge code same we are still using the requestContext deletedEntities instead of having separate one for purge. - Sidharth --- This is an automatically generated e-mail. To

Re: Review Request 72265: ATLAS-3684: Atlas glossary get is taking more time when number of terms increase

2020-03-30 Thread Sidharth Mishra
/glossary/GlossaryService.java d630f669e repository/src/main/java/org/apache/atlas/repository/ogm/glossary/AbstractGlossaryDTO.java bee88c61f Diff: https://reviews.apache.org/r/72265/diff/1/ Testing --- Manually tested Thanks, Sidharth Mishra

Review Request 72284: ATLAS-3707: Atlas Purge entity is generating both purge and delete audit

2020-03-30 Thread Sidharth Mishra
' \ --header 'Authorization: Basic YWRtaW46YWRtaW4=' Thanks, Sidharth Mishra

Re: Review Request 72268: ATLAS-3688: updated dependencies to remove unnecessary references

2020-03-25 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72268/#review220081 --- Ship it! Ship It! - Sidharth Mishra On March 25, 2020, 7:35

Review Request 72265: ATLAS-3684: Atlas glossary get is taking more time when number of terms increase

2020-03-24 Thread Sidharth Mishra
/AbstractGlossaryDTO.java bee88c61f Diff: https://reviews.apache.org/r/72265/diff/1/ Testing --- Manually tested Thanks, Sidharth Mishra

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-20 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71482/#review220048 --- Ship it! Ship It! - Sidharth Mishra On March 20, 2020, 2:06

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-19 Thread Sidharth Mishra
> On March 18, 2020, 11:55 p.m., Sidharth Mishra wrote: > > repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java > > Lines 570 (patched) > > <https://reviews.apache.org/r/71482/diff/18/?file=2213646#file2213646line570> > > > >

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-18 Thread Sidharth Mishra
nst for 0 explaining what does the position contains repository/src/test/java/org/apache/atlas/glossary/GlossaryServiceTest.java Lines 960 (patched) <https://reviews.apache.org/r/71482/#comment308228> Please remove the extra space: assertEquals(e.getMessage(), "No Data found in the u

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-12 Thread Sidharth Mishra
blank lines like this even other places. repository/src/main/java/org/apache/atlas/glossary/GlossaryTermUtils.java Lines 558 (patched) <https://reviews.apache.org/r/71482/#comment308150> Remove the extra blank line - Sidharth Mishra On March 12, 2020, 10:37 a.m.,

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-05 Thread Sidharth Mishra
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71482/#review219788 --- - Sidharth Mishra On March 4, 2020, 10:07 a.m., mayank jain

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-05 Thread Sidharth Mishra
d) <https://reviews.apache.org/r/71482/#comment308010> Please take care of indentation at most of the places in your patchl. Like space before and after '+' etc. - Sidharth Mishra On March 4, 2020, 10:07 a.m., mayank jain wrote: > >

Re: Review Request 71482: ATLAS-3423:-Import Glossary Terms CSV into a Glossary

2020-03-05 Thread Sidharth Mishra
ews/glossary/ImportGlossaryLayoutView.js Lines 53 (patched) <https://reviews.apache.org/r/71482/#comment307987> This comment is not adding any useful information as the initialize block is self explanatory. - Sidharth Mishra On March 4, 2020, 10:07 a.m.,

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-03-02 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/18/ Changes: https://reviews.apache.org/r/71791/diff/17-18/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-03-02 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/17/ Changes: https://reviews.apache.org/r/71791/diff/16-17/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-02-26 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/16/ Changes: https://reviews.apache.org/r/71791/diff/15-16/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-02-25 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/15/ Changes: https://reviews.apache.org/r/71791/diff/14-15/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-01-27 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/14/ Changes: https://reviews.apache.org/r/71791/diff/13-14/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-01-27 Thread Sidharth Mishra
ps://reviews.apache.org/r/71791/#review219365 --- On Dec. 11, 2019, 1:17 a.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2020-01-27 Thread Sidharth Mishra
ImportAuditEntry is part of this which I might have moved to another inherited class. But we have plan to unify the imp/exp audit soon, will take care later - Sidharth --- This is an automatically generated e-mail. To repl

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-13 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/7/ Changes: https://reviews.apache.org/r/71922/diff/6-7/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-12 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/6/ Changes: https://reviews.apache.org/r/71922/diff/5-6/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-10 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_v2_typedefs.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/5/ Changes: https://reviews.apache.org/r/71922/diff/4-5/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-10 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/4/ Changes: https://reviews.apache.org/r/71922/diff/3-4/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-10 Thread Sidharth Mishra
the reason we have this at both the places. Only this and tag is common property among object and bucket. Do you think extracting these two to another basetype will make sense? > On Jan. 10, 2020, 6:26 p.m., Ashutosh Mestry wrote: > > addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json > > Lines 238 (patched) > > <https://reviews.apache.org/r/7

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-08 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/3/ Changes: https://reviews.apache.org/r/71922/diff/2-3/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-08 Thread Sidharth Mishra
- addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/1/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2020-01-08 Thread Sidharth Mishra
) - addons/models/3000-Cloud/3030-aws_s3_typedefs_v2.json PRE-CREATION Diff: https://reviews.apache.org/r/71922/diff/2/ Changes: https://reviews.apache.org/r/71922/diff/1-2/ Testing --- Thanks, Sidharth Mishra

Review Request 71922: ATLAS-3564: New version of AWS S3 model addition

2019-12-17 Thread Sidharth Mishra
://reviews.apache.org/r/71922/diff/1/ Testing --- Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-10 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-10 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-10 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-09 Thread Sidharth Mishra
IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
> > then audit them. I think its better to audit admin action purge even if we don't purge any entities. Please let me know if you still think we should not audit the unsuccessful purge action by admin. - Sidharth ------

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
AtlasEntityStore. So AtlasEntityStore can't depends on AtlasAuditService again. KIndly suggest is there any other option to avoid this circular injection issue. - Sidharth --- This is an automatically generated e-mail. To

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
on DataAccess and DataAccess depends on AtlasEntityStore. So AtlasEntityStore can't depends on AtlasAuditService again. - Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.or

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-04 Thread Sidharth Mishra
to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-03 Thread Sidharth Mishra
n automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218865 --- On Nov. 30, 2019, 7:44 p.m., Sidharth Mishra wrote: > > --- > This is

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-03 Thread Sidharth Mishra
9/. I am having separate patch for the lib version change and reverted the changes - Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218808 --------

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-12-03 Thread Sidharth Mishra
- Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71791/#review218808 --- On Nov. 30, 2019, 7:44 p.m., Sidharth Mishra wrote

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-30 Thread Sidharth Mishra
store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-30 Thread Sidharth Mishra
, visit: https://reviews.apache.org/r/71791/#review218785 ------- On Nov. 26, 2019, 9:11 a.m., Sidharth Mishra wrote: > > --- > This is an automatically gener

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-26 Thread Sidharth Mishra
: https://reviews.apache.org/r/71791/diff/4/ Changes: https://reviews.apache.org/r/71791/diff/3-4/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-21 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/3/ Changes: https://reviews.apache.org/r/71791/diff/2-3/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-19 Thread Sidharth Mishra
://reviews.apache.org/r/71791/diff/2/ Changes: https://reviews.apache.org/r/71791/diff/1-2/ Testing --- Two UT and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Review Request 71791: ATLAS-3518: Create Audit Framework for Atlas Purge Entity

2019-11-19 Thread Sidharth Mishra
and one IT has been added to test functionality like: 1. Atlas Audit entry save and retrive 2. Atlas Purge Audit store, retrive and search (UT and IT) Thanks, Sidharth Mishra

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
e485> > > > > should this be AtlasPrivilege.ADMIN_PURGE ? > > Sidharth Mishra wrote: > As we don't have the Ranger changes for time being its ADMIN_IMPORT. > Later ll change it to ADMIN_PURGE To track

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
1573161727305:0", "entity": null, "type": null }, { "entityId": "7b6806c1-8daf-4e0f-8d10-672a192968f1", "timestamp": 1573161723180, "user": "impala", "action": &qu

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
s is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218627 --- On Nov. 13, 2019, 9:04 p.m., Sidharth Mishra wrote: > > --- >

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-14 Thread Sidharth Mishra
-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218626 --- On Nov. 13, 2019, 9:04 p.m., Sidharth Mishra wrote: > >

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-13 Thread Sidharth Mishra
sit: https://reviews.apache.org/r/71737/#review218622 --- On Nov. 13, 2019, 6:04 a.m., Sidharth Mishra wrote: > > --- > This is an automatically generated e-mail. To re

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
1573161727305:0", "entity": null, "type": null }, { "entityId": "7b6806c1-8daf-4e0f-8d10-672a192968f1", "timestamp": 1573161723180, "user": "impala", "action": &qu

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
": "ENTITY_CREATE", "details": "Created: {\"typeName\":\"hive_column\",\"attributes\":{\"owner\":\"admin\",\"qualifiedName\":\"default.thursday_07_11_5.id@cm\",\"name\":\"id\",\"comment\":null,\"position\":0,\"type\":\"int\"},\"guid\":\"7b6806c1-8daf-4e0f-8d10-672a192968f1\",\"isIncomplete\":false,\"provenanceType\":0,\"version\":0,\"relationshipAttributes\":{\"table\":{\"guid\":\"c5ae4503-b498-493c-86b5-d8d909c6b16a\",\"typeName\":\"hive_table\",\"uniqueAttributes\":{\"qualifiedName\":\"default.thursday_07_11_5@cm\"},\"relationshipType\":\"hive_table_columns\"}},\"proxy\":false}", "eventKey": "7b6806c1-8daf-4e0f-8d10-672a192968f1:1573161723180:2", "entity": null, "type": null } ] Thanks, Sidharth Mishra

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
quot;impala", "action": "ENTITY_CREATE", "details": "Created: {\"typeName\":\"hive_column\",\"attributes\":{\"owner\":\"admin\",\"qualifiedName\":\"default.thursday_07_11_5.id@cm\",\"name\":\"id\",\"comment\":null,\"position\":0,\"type\":\"int\"},\"guid\":\"7b6806c1-8daf-4e0f-8d10-672a192968f1\",\"isIncomplete\":false,\"provenanceType\":0,\"version\":0,\"relationshipAttributes\":{\"table\":{\"guid\":\"c5ae4503-b498-493c-86b5-d8d909c6b16a\",\"typeName\":\"hive_table\",\"uniqueAttributes\":{\"qualifiedName\":\"default.thursday_07_11_5@cm\"},\"relationshipType\":\"hive_table_columns\"}},\"proxy\":false}", "eventKey": "7b6806c1-8daf-4e0f-8d10-672a192968f1:1573161723180:2", "entity": null, "type": null } ] Thanks, Sidharth Mishra

Re: Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-12 Thread Sidharth Mishra
omatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71737/#review218585 --- On Nov. 7, 2019, 11:54 p.m., Sidharth Mishra wrote: > > --- > This is

Review Request 71737: ATLAS-3477: Introduce purging of entity in Atlas

2019-11-07 Thread Sidharth Mishra
": "ENTITY_CREATE", "details": "Created: {\"typeName\":\"hive_column\",\"attributes\":{\"owner\":\"admin\",\"qualifiedName\":\"default.thursday_07_11_5.id@cm\",\"name\":\"id\",\"comment\":null,\"position\":0,\"type\":\"int\"},\"guid\":\"7b6806c1-8daf-4e0f-8d10-672a192968f1\",\"isIncomplete\":false,\"provenanceType\":0,\"version\":0,\"relationshipAttributes\":{\"table\":{\"guid\":\"c5ae4503-b498-493c-86b5-d8d909c6b16a\",\"typeName\":\"hive_table\",\"uniqueAttributes\":{\"qualifiedName\":\"default.thursday_07_11_5@cm\"},\"relationshipType\":\"hive_table_columns\"}},\"proxy\":false}", "eventKey": "7b6806c1-8daf-4e0f-8d10-672a192968f1:1573161723180:2", "entity": null, "type": null } ] Thanks, Sidharth Mishra

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
STORED AS TEXTFILE LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; Thanks, Sidharth Mishra

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
d match and even if it has multiple spaces it ll be taken care by [ ]* at beginning. Thanks, Sid - Sidharth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71620/#review218312 -

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
STORED AS TEXTFILE LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; Thanks, Sidharth Mishra

Re: Review Request 71620: ATLAS-3461: Impala process and lineage is not getting created appropriately if query contains variation like comment or extra spaces

2019-10-21 Thread Sidharth Mishra
AME string ) ROW FORMAT DELIMITED FIELDS TERMINATED BY ',' STORED AS TEXTFILE LOCATION '/warehouse/tablespace/external/hive/db1.db/thusday_ext1'; Thanks, Sidharth Mishra

  1   2   >