[jira] [Assigned] (ATLAS-2608) UI - Cache is not cleared if user click on cancel button while editing propagation flow

2018-04-25 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2608:


Assignee: pratik pandey

> UI - Cache is not cleared if user click on cancel button while editing 
> propagation flow
> ---
>
> Key: ATLAS-2608
> URL: https://issues.apache.org/jira/browse/ATLAS-2608
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: Tejas Rawool
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
>
> Steps to reproduce:-
>  
> 1.Do a Basic Search for Tables
> 2.Now go to Lineage Tab of  sales_fact
> 3.Click on arrow between sales_fact and loadSalesDaily
> 4.Now switch to Block Propagation
> 5.Checked any of the entity and click on cancel button
> 6.Now again click on that arrow and go to block propagation without 
> refreshing the page
> Error:-
> An Duplicate entity is created which is incorrect



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2594) UI, Tag propagation : Propagated classifications list on UI is not refreshed after propagateTags value is modified.

2018-04-23 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2594:
-
Attachment: ATLAS-2594.patch

> UI, Tag propagation : Propagated classifications list on UI is not refreshed 
> after propagateTags value is modified.
> ---
>
> Key: ATLAS-2594
> URL: https://issues.apache.org/jira/browse/ATLAS-2594
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2594.patch
>
>
> For the following lineage :
> table1 - edge1 > process1 - edge2 -> table2
> Added tag1 from table1 with propagate set to True . On detailPage of table2 , 
> Propagated classifications list shows tag1.
> Now , on detailPage of table2 , edited edge1 and set propagateTags to 
> ONE_TO_TWO (process1 to table1). Relationship update is done and tag1 is 
> removed from process1 and table2 in the backend.
> But , UI needs a refresh to remove tag1 from Propagated Classifications list 
> shown on detailsPage of table2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66760: ATLAS-2594 : UI, Tag propagation : Propagated classifications list on UI is not refreshed after propagateTags value is modified.

2018-04-23 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66760/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sarath Subramanian.


Bugs: ATLAS-2594
https://issues.apache.org/jira/browse/ATLAS-2594


Repository: atlas


Description
---

For the following lineage :

table1 - edge1 > process1 - edge2 -> table2

Added tag1 from table1 with propagate set to True . On detailPage of table2 , 
Propagated classifications list shows tag1.

Now , on detailPage of table2 , edited edge1 and set propagateTags to 
ONE_TO_TWO (process1 to table1). Relationship update is done and tag1 is 
removed from process1 and table2 in the backend.
But , UI needs a refresh to remove tag1 from Propagated Classifications list 
shown on detailsPage of table2


Diffs
-

  dashboardv2/public/css/scss/override.scss c3ee8b1 
  dashboardv2/public/css/scss/theme.scss 4848673 
  dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html 
1599858 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js eb17504 
  dashboardv2/public/js/views/graph/LineageLayoutView.js c1d8a9c 
  dashboardv2/public/js/views/graph/PropagationPropertyModal.js 76d62ef 


Diff: https://reviews.apache.org/r/66760/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2594) UI, Tag propagation : Propagated classifications list on UI is not refreshed after propagateTags value is modified.

2018-04-23 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2594:


 Summary: UI, Tag propagation : Propagated classifications list on 
UI is not refreshed after propagateTags value is modified.
 Key: ATLAS-2594
 URL: https://issues.apache.org/jira/browse/ATLAS-2594
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey


For the following lineage :

table1 - edge1 > process1 - edge2 -> table2

Added tag1 from table1 with propagate set to True . On detailPage of table2 , 
Propagated classifications list shows tag1.

Now , on detailPage of table2 , edited edge1 and set propagateTags to 
ONE_TO_TWO (process1 to table1). Relationship update is done and tag1 is 
removed from process1 and table2 in the backend.
But , UI needs a refresh to remove tag1 from Propagated Classifications list 
shown on detailsPage of table2.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66682: ATLAS-2584 : UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or NONE.

2018-04-18 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66682/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2584
https://issues.apache.org/jira/browse/ATLAS-2584


Repository: atlas


Description
---

When an edge is selected and propagation is changed to BOTH or NONE , PUT 
request is sent with default propagation (ONE_TO_TWO or TWO_TO_ONE).


Diffs
-

  dashboardv2/public/js/views/graph/PropagationPropertyModal.js c192dff 


Diff: https://reviews.apache.org/r/66682/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2584) UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or NONE

2018-04-18 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2584:
-
Attachment: ATLAS-2584.patch

> UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or 
> NONE
> ---
>
> Key: ATLAS-2584
> URL: https://issues.apache.org/jira/browse/ATLAS-2584
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2584.patch
>
>
> When an edge is selected and propagation is changed to BOTH or NONE , PUT 
> request is sent with default propagation (ONE_TO_TWO or TWO_TO_ONE).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2584) UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or NONE

2018-04-18 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2584:
-
Attachment: (was: ATLAS-2584.patch)

> UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or 
> NONE
> ---
>
> Key: ATLAS-2584
> URL: https://issues.apache.org/jira/browse/ATLAS-2584
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
>
> When an edge is selected and propagation is changed to BOTH or NONE , PUT 
> request is sent with default propagation (ONE_TO_TWO or TWO_TO_ONE).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2584) UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or NONE

2018-04-18 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2584:
-
Attachment: ATLAS-2584.patch

> UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or 
> NONE
> ---
>
> Key: ATLAS-2584
> URL: https://issues.apache.org/jira/browse/ATLAS-2584
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2584.patch
>
>
> When an edge is selected and propagation is changed to BOTH or NONE , PUT 
> request is sent with default propagation (ONE_TO_TWO or TWO_TO_ONE).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2584) UI , Tag propagation : Unable to modify Tag propagation at an edge to BOTH or NONE

2018-04-18 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2584:


 Summary: UI , Tag propagation : Unable to modify Tag propagation 
at an edge to BOTH or NONE
 Key: ATLAS-2584
 URL: https://issues.apache.org/jira/browse/ATLAS-2584
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey


When an edge is selected and propagation is changed to BOTH or NONE , PUT 
request is sent with default propagation (ONE_TO_TWO or TWO_TO_ONE).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Resolved] (ATLAS-2583) UI : DSL search doesn't list the associated classification list like basic search lists.

2018-04-18 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey resolved ATLAS-2583.
--
Resolution: Fixed

Closing this issue because fix it needed on the server side. (ATLAS-2567)

> UI : DSL search doesn't list the associated classification list like basic 
> search lists.
> 
>
> Key: ATLAS-2583
> URL: https://issues.apache.org/jira/browse/ATLAS-2583
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
>
> UI of DSL search results doesn't list the classifications associated to the 
> entities though the response of the DSL query returns the correct 
> classifications list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Issue Comment Deleted] (ATLAS-2583) UI : DSL search doesn't list the associated classification list like basic search lists.

2018-04-18 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2583:
-
Comment: was deleted

(was: Closing this issue because fix it needed on the server side. (ATLAS-2567))

> UI : DSL search doesn't list the associated classification list like basic 
> search lists.
> 
>
> Key: ATLAS-2583
> URL: https://issues.apache.org/jira/browse/ATLAS-2583
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
>
> UI of DSL search results doesn't list the classifications associated to the 
> entities though the response of the DSL query returns the correct 
> classifications list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2583) UI : DSL search doesn't list the associated classification list like basic search lists.

2018-04-18 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2583:
-

Closing this issue because fix it needed on the server side. (ATLAS-2567)

> UI : DSL search doesn't list the associated classification list like basic 
> search lists.
> 
>
> Key: ATLAS-2583
> URL: https://issues.apache.org/jira/browse/ATLAS-2583
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
>
> UI of DSL search results doesn't list the classifications associated to the 
> entities though the response of the DSL query returns the correct 
> classifications list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2583) UI : DSL search doesn't list the associated classification list like basic search lists.

2018-04-18 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2583:


Assignee: pratik pandey

> UI : DSL search doesn't list the associated classification list like basic 
> search lists.
> 
>
> Key: ATLAS-2583
> URL: https://issues.apache.org/jira/browse/ATLAS-2583
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
>
> UI of DSL search results doesn't list the classifications associated to the 
> entities though the response of the DSL query returns the correct 
> classifications list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2583) UI : DSL search doesn't list the associated classification list like basic search lists.

2018-04-18 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2583:


 Summary: UI : DSL search doesn't list the associated 
classification list like basic search lists.
 Key: ATLAS-2583
 URL: https://issues.apache.org/jira/browse/ATLAS-2583
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey


UI of DSL search results doesn't list the classifications associated to the 
entities though the response of the DSL query returns the correct 
classifications list.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2579) UI : Block Propagation at classification level in edit propagation flow.

2018-04-17 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2579:
-
Attachment: ATLAS-2579.patch

> UI : Block Propagation at classification level in edit propagation flow.
> 
>
> Key: ATLAS-2579
> URL: https://issues.apache.org/jira/browse/ATLAS-2579
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2579.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66662: ATLAS-2579 : UI : Block Propagation at classification level in edit propagation flow.

2018-04-17 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2579
https://issues.apache.org/jira/browse/ATLAS-2579


Repository: atlas


Description
---

This patch includes changes to block or unblock propagation at Classfication 
level in edit propagation modal UI.


Diffs
-

  dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html 
1599858 
  dashboardv2/public/js/views/graph/PropagationPropertyModal.js c192dff 


Diff: https://reviews.apache.org/r/2/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2579) UI : Block Propagation at classification level in edit propagation flow.

2018-04-17 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2579:


 Summary: UI : Block Propagation at classification level in edit 
propagation flow.
 Key: ATLAS-2579
 URL: https://issues.apache.org/jira/browse/ATLAS-2579
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2567) Classification list missing in DSL search result.

2018-04-17 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2567:


Assignee: (was: Madhan Neethiraj)

> Classification list missing in DSL search result.
> -
>
> Key: ATLAS-2567
> URL: https://issues.apache.org/jira/browse/ATLAS-2567
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>    Reporter: pratik pandey
>Priority: Major
>
> DSL search result doesn't have classifications list which is needed for UI to 
> differentiate between the propagated tag and self-associated tag.
> Please find API response for DSL & BASIC search.
> DSL:
>  
> {code:java}
> {
>  "queryType": "DSL",
>  "queryText": "`Table` ",
>  "entities": [
>  {
>  "typeName": "Table",
>  "attributes":
>  {
>  "owner": "John Doe",
>  "createTime": 1522060403813,
>  "qualifiedName": "product_dim",
>  "name": "product_dim",
>  "description": "product dimension table"
>  },
>  "guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
>  "status": "ACTIVE",
>  "displayText": "product_dim",
>  "classificationNames": ["Dimension"]
>  }]
> }
> {code}
> BASIC
> {code:java}
> {
> "queryType": "BASIC",
> "searchParameters":
> {
> "typeName": "Table",
> "excludeDeletedEntities": true,
> "includeClassificationAttributes": true,
> "includeSubTypes": true,
> "includeSubClassifications": true,
> "limit": 25,
> "offset": 0,
> "attributes": []
> },
> "entities": [
> {
> "typeName": "Table",
> "attributes":
> {
> "owner": "John Doe",
> "createTime": 1522060403813,
> "qualifiedName": "product_dim",
> "name": "product_dim",
> "description": "product dimension table"
> },
> "guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
> "status": "ACTIVE",
> "displayText": "product_dim",
> "classificationNames": ["Dimension"],
> "classifications": [
> {
> "typeName": "Dimension",
> "entityGuid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
> "propagate": true
> }]
> }]
> }
> {code}
>  
> As we can see basic search result have classifications list with *entityGuid* 
> whereas DSL search doesn't have it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2567) Classification list missing in DSL search result.

2018-04-17 Thread pratik pandey (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16440555#comment-16440555
 ] 

pratik pandey commented on ATLAS-2567:
--

[~grahamwallis]  I have updated the description and title. sorry for the 
ambiguity.

> Classification list missing in DSL search result.
> -
>
> Key: ATLAS-2567
> URL: https://issues.apache.org/jira/browse/ATLAS-2567
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>    Reporter: pratik pandey
>Assignee: Madhan Neethiraj
>Priority: Major
>
> DSL search result doesn't have classifications list which is needed for UI to 
> differentiate between the propagated tag and self-associated tag.
> Please find API response for DSL & BASIC search.
> DSL:
>  
> {code:java}
> {
>  "queryType": "DSL",
>  "queryText": "`Table` ",
>  "entities": [
>  {
>  "typeName": "Table",
>  "attributes":
>  {
>  "owner": "John Doe",
>  "createTime": 1522060403813,
>  "qualifiedName": "product_dim",
>  "name": "product_dim",
>  "description": "product dimension table"
>  },
>  "guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
>  "status": "ACTIVE",
>  "displayText": "product_dim",
>  "classificationNames": ["Dimension"]
>  }]
> }
> {code}
> BASIC
> {code:java}
> {
> "queryType": "BASIC",
> "searchParameters":
> {
> "typeName": "Table",
> "excludeDeletedEntities": true,
> "includeClassificationAttributes": true,
> "includeSubTypes": true,
> "includeSubClassifications": true,
> "limit": 25,
> "offset": 0,
> "attributes": []
> },
> "entities": [
> {
> "typeName": "Table",
> "attributes":
> {
> "owner": "John Doe",
> "createTime": 1522060403813,
> "qualifiedName": "product_dim",
> "name": "product_dim",
> "description": "product dimension table"
> },
> "guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
> "status": "ACTIVE",
> "displayText": "product_dim",
> "classificationNames": ["Dimension"],
> "classifications": [
> {
> "typeName": "Dimension",
> "entityGuid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
> "propagate": true
> }]
> }]
> }
> {code}
>  
> As we can see basic search result have classifications list with *entityGuid* 
> whereas DSL search doesn't have it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2567) Classification list missing in DSL search result.

2018-04-17 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2567?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2567:
-
Description: 
DSL search result doesn't have classifications list which is needed for UI to 
differentiate between the propagated tag and self-associated tag.

Please find API response for DSL & BASIC search.

DSL:

 
{code:java}
{
 "queryType": "DSL",
 "queryText": "`Table` ",
 "entities": [
 {
 "typeName": "Table",
 "attributes":
 {
 "owner": "John Doe",
 "createTime": 1522060403813,
 "qualifiedName": "product_dim",
 "name": "product_dim",
 "description": "product dimension table"
 },
 "guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
 "status": "ACTIVE",
 "displayText": "product_dim",
 "classificationNames": ["Dimension"]
 }]
}

{code}
BASIC
{code:java}
{
"queryType": "BASIC",
"searchParameters":
{
"typeName": "Table",
"excludeDeletedEntities": true,
"includeClassificationAttributes": true,
"includeSubTypes": true,
"includeSubClassifications": true,
"limit": 25,
"offset": 0,
"attributes": []
},
"entities": [
{
"typeName": "Table",
"attributes":
{
"owner": "John Doe",
"createTime": 1522060403813,
"qualifiedName": "product_dim",
"name": "product_dim",
"description": "product dimension table"
},
"guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
"status": "ACTIVE",
"displayText": "product_dim",
"classificationNames": ["Dimension"],
"classifications": [
{
"typeName": "Dimension",
"entityGuid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
    "propagate": true
}]
}]
}
{code}
 

As we can see basic search result have classifications list with *entityGuid* 
whereas DSL search doesn't have it.
Summary: Classification list missing in DSL search result.  (was: DSL 
search API doesn't have GUID for classifications.)

> Classification list missing in DSL search result.
> -
>
> Key: ATLAS-2567
> URL: https://issues.apache.org/jira/browse/ATLAS-2567
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0
>Reporter: pratik pandey
>Assignee: Madhan Neethiraj
>Priority: Major
>
> DSL search result doesn't have classifications list which is needed for UI to 
> differentiate between the propagated tag and self-associated tag.
> Please find API response for DSL & BASIC search.
> DSL:
>  
> {code:java}
> {
>  "queryType": "DSL",
>  "queryText": "`Table` ",
>  "entities": [
>  {
>  "typeName": "Table",
>  "attributes":
>  {
>  "owner": "John Doe",
>  "createTime": 1522060403813,
>  "qualifiedName": "product_dim",
>  "name": "product_dim",
>  "description": "product dimension table"
>  },
>  "guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
>  "status": "ACTIVE",
>  "displayText": "product_dim",
>  "classificationNames": ["Dimension"]
>  }]
> }
> {code}
> BASIC
> {code:java}
> {
> "queryType": "BASIC",
> "searchParameters":
> {
> "typeName": "Table",
> "excludeDeletedEntities": true,
> "includeClassificationAttributes": true,
> "includeSubTypes": true,
> "includeSubClassifications": true,
> "limit": 25,
> "offset": 0,
> "attributes": []
> },
> "entities": [
> {
> "typeName": "Table",
> "attributes":
> {
> "owner": "John Doe",
> "createTime": 1522060403813,
> "qualifiedName": "product_dim",
> "name": "product_dim",
> "description": "product dimension table"
> },
> "guid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
> "status": "ACTIVE",
> "displayText": "product_dim",
> "classificationNames": ["Dimension"],
> "classifications": [
> {
> "typeName": "Dimension",
> "entityGuid": "a31fe16a-3592-4b82-aeec-71db0f1fa85c",
> "propagate": true
> }]
> }]
> }
> {code}
>  
> As we can see basic search result have classifications list with *entityGuid* 
> whereas DSL search doesn't have it.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2567) DSL search API doesn't have GUID for classifications.

2018-04-16 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2567:


 Summary: DSL search API doesn't have GUID for classifications.
 Key: ATLAS-2567
 URL: https://issues.apache.org/jira/browse/ATLAS-2567
 Project: Atlas
  Issue Type: Bug
Affects Versions: 1.0.0
Reporter: pratik pandey
Assignee: Madhan Neethiraj






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2512) UI : Set propagateTags attribute to relationship on lineage page

2018-04-10 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2512:
-
Attachment: (was: ATLAS-2512.patch)

> UI : Set propagateTags attribute to relationship on lineage page
> 
>
> Key: ATLAS-2512
> URL: https://issues.apache.org/jira/browse/ATLAS-2512
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2512.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66244: ATLAS-2512 : UI : Set propagateTags attribute to relationship on lineage page.

2018-04-10 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66244/
---

(Updated April 10, 2018, 11:31 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Changes
---

show pop modal on edge click


Bugs: ATLAS-2512
https://issues.apache.org/jira/browse/ATLAS-2512


Repository: atlas


Description
---

This patch include changes to set propagation one of the following attribute 
for relationship on lineage page.

* ONE TO TWO
* TWO TO ONE
* BOTH 
* NONE


Diffs (updated)
-

  dashboardv2/public/css/scss/graph.scss 2d7e8a3 
  dashboardv2/public/css/scss/override.scss e224393 
  dashboardv2/public/js/collection/VRelationshipList.js PRE-CREATION 
  dashboardv2/public/js/models/VRelationship.js PRE-CREATION 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
8fc67e0 
  dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html a94284b 
  dashboardv2/public/js/templates/graph/PropagationPropertyModalView_tmpl.html 
PRE-CREATION 
  dashboardv2/public/js/utils/UrlLinks.js b69e3a8 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7c0cd55 
  dashboardv2/public/js/views/graph/LineageLayoutView.js 25e7120 
  dashboardv2/public/js/views/graph/PropagationPropertyModal.js PRE-CREATION 


Diff: https://reviews.apache.org/r/66244/diff/3/

Changes: https://reviews.apache.org/r/66244/diff/2-3/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



Review Request 66523: ATLAS-2543 : UI : In Edit classification window , Update button is not enabled when a validity period is removed.

2018-04-10 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66523/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2543
https://issues.apache.org/jira/browse/ATLAS-2543


Repository: atlas


Description
---

1. Create a tag and associate the tag to an entity and provide 2 validity 
periods.
2.Edit the same tag associated to the entity and remove any validity period.
3.Update button is not enabled.

For other updates like adding new validity period, editing propagate flag , 
editing tag attribute values , Update button is enabled.


Diffs
-

  dashboardv2/public/js/views/tag/AddTimezoneItemView.js ea2e9dc 


Diff: https://reviews.apache.org/r/66523/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2543) UI : In Edit classification window , Update button is not enabled when a validity period is removed.

2018-04-10 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2543:
-
Attachment: ATLAS-2543.patch

> UI : In Edit classification window , Update button is not enabled when a 
> validity period is removed.
> 
>
> Key: ATLAS-2543
> URL: https://issues.apache.org/jira/browse/ATLAS-2543
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2543.patch
>
>
> 1. Create a tag and associate the tag to an entity and provide 2 validity 
> periods.
> 2.Edit the same tag associated to the entity and remove any validity period.
> 3.Update button is not enabled.
> For other updates like adding new validity period, editing propagate flag , 
> editing tag attribute values , Update button is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66500: ATLAS-2538 : UI : Searching classification by navigating to "Classifications" tab has "Exclude sub-types" check box in the search layout.

2018-04-09 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66500/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2538
https://issues.apache.org/jira/browse/ATLAS-2538


Repository: atlas


Description
---

When classifications are searched from "Classifications" Tab , the result 
layout has "Exclude sub-types" check box which is not required . Only "Exclude 
sub-classifications" and "Show historical entities" check boxes should be good 
enough.


Diffs
-

  dashboardv2/public/js/modules/Helpers.js 3897d58 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
fb9481a 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js dc4f49a 


Diff: https://reviews.apache.org/r/66500/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2538) UI : Searching classification by navigating to "Classifications" tab has "Exclude sub-types" check box in the search layout.

2018-04-09 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2538:
-
Attachment: ATLAS-2538.patch

> UI : Searching classification by navigating to "Classifications" tab has 
> "Exclude sub-types" check box in the search layout.
> 
>
> Key: ATLAS-2538
> URL: https://issues.apache.org/jira/browse/ATLAS-2538
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2538.patch
>
>
> When classifications are searched from "Classifications" Tab , the result 
> layout has "Exclude sub-types" check box which is not required . Only 
> "Exclude sub-classifications" and "Show historical entities" check boxes 
> should be good enough.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2539) UI : Entity detail page shows loader when lineage tab is not present

2018-04-06 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2539:


Assignee: pratik pandey

> UI : Entity detail page shows loader when lineage tab is not present
> 
>
> Key: ATLAS-2539
> URL: https://issues.apache.org/jira/browse/ATLAS-2539
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0-alpha
>Reporter: Tejas Rawool
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
>
> Steps to Reproduce:-
> 1.Go to entity which has lineage (e.g sales_fact)
> 2.Go to its lineage tab and double click on entity which doesn't have lineage 
> tab (e.g loadSalesDaily type =  LoadProcess)
> 3.The continuous loader would be seen since lineage tab is not present for 
> type "LoadProcess"



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2538) UI : Searching classification by navigating to "Classifications" tab has "Exclude sub-types" check box in the search layout.

2018-04-06 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2538?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2538:


Assignee: pratik pandey

> UI : Searching classification by navigating to "Classifications" tab has 
> "Exclude sub-types" check box in the search layout.
> 
>
> Key: ATLAS-2538
> URL: https://issues.apache.org/jira/browse/ATLAS-2538
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
>
> When classifications are searched from "Classifications" Tab , the result 
> layout has "Exclude sub-types" check box which is not required . Only 
> "Exclude sub-classifications" and "Show historical entities" check boxes 
> should be good enough.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2538) UI : Searching classification by navigating to "Classifications" tab has "Exclude sub-types" check box in the search layout.

2018-04-06 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2538:


 Summary: UI : Searching classification by navigating to 
"Classifications" tab has "Exclude sub-types" check box in the search layout.
 Key: ATLAS-2538
 URL: https://issues.apache.org/jira/browse/ATLAS-2538
 Project: Atlas
  Issue Type: Bug
        Reporter: pratik pandey


When classifications are searched from "Classifications" Tab , the result 
layout has "Exclude sub-types" check box which is not required . Only "Exclude 
sub-classifications" and "Show historical entities" check boxes should be good 
enough.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2512) UI : Set propagateTags attribute to relationship on lineage page

2018-04-06 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2512:
-
Attachment: (was: ATLAS-2512.patch)

> UI : Set propagateTags attribute to relationship on lineage page
> 
>
> Key: ATLAS-2512
> URL: https://issues.apache.org/jira/browse/ATLAS-2512
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2512.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2512) UI : Set propagateTags attribute to relationship on lineage page

2018-04-06 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2512:
-
Attachment: ATLAS-2512.patch

> UI : Set propagateTags attribute to relationship on lineage page
> 
>
> Key: ATLAS-2512
> URL: https://issues.apache.org/jira/browse/ATLAS-2512
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2512.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66244: ATLAS-2512 : UI : Set propagateTags attribute to relationship on lineage page.

2018-04-06 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66244/
---

(Updated April 6, 2018, 10:05 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Changes
---

lineage chnages i.e. radio button label change according to entity name


Bugs: ATLAS-2512
https://issues.apache.org/jira/browse/ATLAS-2512


Repository: atlas


Description
---

This patch include changes to set propagation one of the following attribute 
for relationship on lineage page.

* ONE TO TWO
* TWO TO ONE
* BOTH 
* NONE


Diffs (updated)
-

  dashboardv2/public/css/scss/graph.scss 2d7e8a3 
  dashboardv2/public/css/scss/override.scss e224393 
  dashboardv2/public/js/collection/VRelationshipList.js PRE-CREATION 
  dashboardv2/public/js/models/VRelationship.js PRE-CREATION 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
8fc67e0 
  dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html a94284b 
  dashboardv2/public/js/utils/UrlLinks.js b69e3a8 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7c0cd55 
  dashboardv2/public/js/views/graph/LineageLayoutView.js f17de83 


Diff: https://reviews.apache.org/r/66244/diff/2/

Changes: https://reviews.apache.org/r/66244/diff/1-2/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



Review Request 66400: ATLAS-2528 : UI : Allow user to empty date for validity period.

2018-04-03 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66400/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2528
https://issues.apache.org/jira/browse/ATLAS-2528


Repository: atlas


Description
---

user can put empty value .


Diffs
-

  dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html 62b9009 
  dashboardv2/public/js/views/tag/AddTimezoneItemView.js 36616e6 


Diff: https://reviews.apache.org/r/66400/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2528) UI : Allow user to empty date for validity period.

2018-04-03 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2528?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2528:
-
Attachment: ATLAS-2528.patch

> UI : Allow user to empty date for validity period.
> --
>
> Key: ATLAS-2528
> URL: https://issues.apache.org/jira/browse/ATLAS-2528
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2528.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2529) UI Regression : Timezone list is not displayed when adding validity period.

2018-04-03 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2529:


Assignee: pratik pandey

> UI Regression : Timezone list is not displayed when adding validity period.
> ---
>
> Key: ATLAS-2529
> URL: https://issues.apache.org/jira/browse/ATLAS-2529
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: Atlas_UI_timezones_for_validity_period.png
>
>
> On HDP-3.0.0.0-1121 , On selecting validity period , list of timezones is not 
> displayed.
> Attached the screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2529) UI Regression : Timezone list is not displayed when adding validity period.

2018-04-03 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2529:


 Summary: UI Regression : Timezone list is not displayed when 
adding validity period.
 Key: ATLAS-2529
 URL: https://issues.apache.org/jira/browse/ATLAS-2529
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
 Attachments: Atlas_UI_timezones_for_validity_period.png

On HDP-3.0.0.0-1121 , On selecting validity period , list of timezones is not 
displayed.

Attached the screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2528) UI : Allow user to empty date for validity period.

2018-04-03 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2528:


 Summary: UI : Allow user to empty date for validity period.
 Key: ATLAS-2528
 URL: https://issues.apache.org/jira/browse/ATLAS-2528
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66244: ATLAS-2512 : UI : Set propagateTags attribute to relationship on lineage page.

2018-03-23 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66244/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2512
https://issues.apache.org/jira/browse/ATLAS-2512


Repository: atlas


Description
---

This patch include changes to set propagation one of the following attribute 
for relationship on lineage page.

* ONE TO TWO
* TWO TO ONE
* BOTH 
* NONE


Diffs
-

  dashboardv2/public/css/scss/graph.scss 2d7e8a3 
  dashboardv2/public/js/collection/VRelationshipList.js PRE-CREATION 
  dashboardv2/public/js/models/VRelationship.js PRE-CREATION 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
8fc67e0 
  dashboardv2/public/js/templates/graph/LineageLayoutView_tmpl.html a94284b 
  dashboardv2/public/js/utils/UrlLinks.js b69e3a8 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 7c0cd55 
  dashboardv2/public/js/views/graph/LineageLayoutView.js f17de83 


Diff: https://reviews.apache.org/r/66244/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2512) UI : Set propagateTags attribute to relationship on lineage page

2018-03-23 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2512:


 Summary: UI : Set propagateTags attribute to relationship on 
lineage page
 Key: ATLAS-2512
 URL: https://issues.apache.org/jira/browse/ATLAS-2512
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2509) updated frontend-maven-plugin to 1.4

2018-03-21 Thread pratik pandey (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408045#comment-16408045
 ] 

pratik pandey commented on ATLAS-2509:
--

+1 for the patch

> updated frontend-maven-plugin to 1.4
> 
>
> Key: ATLAS-2509
> URL: https://issues.apache.org/jira/browse/ATLAS-2509
> Project: Atlas
>  Issue Type: Improvement
>Reporter: Keval Bhatt
>Assignee: Keval Bhatt
>Priority: Major
> Attachments: ATLAS-2509.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2508) When adding validityPeriod , default value shown in UI is not taken by the POST request.

2018-03-21 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2508:
-
Attachment: ATLAS-2508.patch

> When adding validityPeriod , default value shown in UI is not taken by the 
> POST request.
> 
>
> Key: ATLAS-2508
> URL: https://issues.apache.org/jira/browse/ATLAS-2508
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2508.patch
>
>
> When Apply Validity Period check box is checked , default value for start 
> time and end time is applied 
> Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
> Start time : Today's Date Current time
> End time : Todays's Date 11:59 PM
> and no timezone is selected by default.
> But the POST request is sent as 
> "validityPeriods":[
> {"startTime":"","endTime":"","timeZone":""}
> ]}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2508) When adding validityPeriod , default value shown in UI is not taken by the POST request.

2018-03-21 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2508:
-
Attachment: (was: ATLAS-2508.patch)

> When adding validityPeriod , default value shown in UI is not taken by the 
> POST request.
> 
>
> Key: ATLAS-2508
> URL: https://issues.apache.org/jira/browse/ATLAS-2508
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
>
> When Apply Validity Period check box is checked , default value for start 
> time and end time is applied 
> Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
> Start time : Today's Date Current time
> End time : Todays's Date 11:59 PM
> and no timezone is selected by default.
> But the POST request is sent as 
> "validityPeriods":[
> {"startTime":"","endTime":"","timeZone":""}
> ]}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 66194: ATLAS-2508 : When adding validityPeriod , default value shown in UI is not taken by the POST request

2018-03-21 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66194/
---

(Updated March 21, 2018, 12:16 p.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Changes
---

single dateObject for create and edit.


Bugs: ATLAS-2508
https://issues.apache.org/jira/browse/ATLAS-2508


Repository: atlas


Description
---

When Apply Validity Period check box is checked , default value for start time 
and end time is applied 
Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
Start time : Today's Date Current time
End time : Todays's Date 11:59 PM

and no timezone is selected by default.

But the POST request is sent as 
"validityPeriods":[

{"startTime":"","endTime":"","timeZone":""}
]}


Diffs (updated)
-

  dashboardv2/public/js/views/tag/AddTimezoneItemView.js 420303f 


Diff: https://reviews.apache.org/r/66194/diff/2/

Changes: https://reviews.apache.org/r/66194/diff/1-2/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2508) When adding validityPeriod , default value shown in UI is not taken by the POST request.

2018-03-21 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2508:
-
Attachment: ATLAS-2508.patch

> When adding validityPeriod , default value shown in UI is not taken by the 
> POST request.
> 
>
> Key: ATLAS-2508
> URL: https://issues.apache.org/jira/browse/ATLAS-2508
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2508.patch
>
>
> When Apply Validity Period check box is checked , default value for start 
> time and end time is applied 
> Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
> Start time : Today's Date Current time
> End time : Todays's Date 11:59 PM
> and no timezone is selected by default.
> But the POST request is sent as 
> "validityPeriods":[
> {"startTime":"","endTime":"","timeZone":""}
> ]}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2508) When adding validityPeriod , default value shown in UI is not taken by the POST request.

2018-03-21 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2508:
-
Attachment: (was: ATLAS-2508.patch)

> When adding validityPeriod , default value shown in UI is not taken by the 
> POST request.
> 
>
> Key: ATLAS-2508
> URL: https://issues.apache.org/jira/browse/ATLAS-2508
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2508.patch
>
>
> When Apply Validity Period check box is checked , default value for start 
> time and end time is applied 
> Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
> Start time : Today's Date Current time
> End time : Todays's Date 11:59 PM
> and no timezone is selected by default.
> But the POST request is sent as 
> "validityPeriods":[
> {"startTime":"","endTime":"","timeZone":""}
> ]}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2508) When adding validityPeriod , default value shown in UI is not taken by the POST request.

2018-03-21 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2508:
-
Attachment: ATLAS-2508.patch

> When adding validityPeriod , default value shown in UI is not taken by the 
> POST request.
> 
>
> Key: ATLAS-2508
> URL: https://issues.apache.org/jira/browse/ATLAS-2508
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2508.patch
>
>
> When Apply Validity Period check box is checked , default value for start 
> time and end time is applied 
> Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
> Start time : Today's Date Current time
> End time : Todays's Date 11:59 PM
> and no timezone is selected by default.
> But the POST request is sent as 
> "validityPeriods":[
> {"startTime":"","endTime":"","timeZone":""}
> ]}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66194: ATLAS-2508 : When adding validityPeriod , default value shown in UI is not taken by the POST request

2018-03-21 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66194/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2508
https://issues.apache.org/jira/browse/ATLAS-2508


Repository: atlas


Description
---

When Apply Validity Period check box is checked , default value for start time 
and end time is applied 
Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
Start time : Today's Date Current time
End time : Todays's Date 11:59 PM

and no timezone is selected by default.

But the POST request is sent as 
"validityPeriods":[

{"startTime":"","endTime":"","timeZone":""}
]}


Diffs
-

  dashboardv2/public/js/views/tag/AddTimezoneItemView.js 420303f 


Diff: https://reviews.apache.org/r/66194/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2508) When adding validityPeriod , default value shown in UI is not taken by the POST request.

2018-03-21 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2508:


 Summary: When adding validityPeriod , default value shown in UI is 
not taken by the POST request.
 Key: ATLAS-2508
 URL: https://issues.apache.org/jira/browse/ATLAS-2508
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey


When Apply Validity Period check box is checked , default value for start time 
and end time is applied 
Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
Start time : Today's Date Current time
End time : Todays's Date 11:59 PM

and no timezone is selected by default.

But the POST request is sent as 
"validityPeriods":[

{"startTime":"","endTime":"","timeZone":""}

]}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2508) When adding validityPeriod , default value shown in UI is not taken by the POST request.

2018-03-21 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2508:


Assignee: pratik pandey

> When adding validityPeriod , default value shown in UI is not taken by the 
> POST request.
> 
>
> Key: ATLAS-2508
> URL: https://issues.apache.org/jira/browse/ATLAS-2508
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
>
> When Apply Validity Period check box is checked , default value for start 
> time and end time is applied 
> Example : 2018/03/20 2:18 PM - 2018/03/20 11:59 PM (i.e) 
> Start time : Today's Date Current time
> End time : Todays's Date 11:59 PM
> and no timezone is selected by default.
> But the POST request is sent as 
> "validityPeriods":[
> {"startTime":"","endTime":"","timeZone":""}
> ]}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66134: ATLAS-2506 : Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

2018-03-19 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66134/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2506
https://issues.apache.org/jira/browse/ATLAS-2506


Repository: atlas


Description
---

Attributes of the filters added in the inner filter group are not added in the 
"attributes" parameter of the POST body.

Hence "attributes" in the POST body has only createTime , retention and not 
temporary.


Diffs
-

  dashboardv2/public/js/views/search/SearchLayoutView.js a0cd41e 


Diff: https://reviews.apache.org/r/66134/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2506) Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

2018-03-19 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2506:
-
Attachment: ATLAS-2506.patch

> Attributes of filters in the inner filter group are not added to "attributes" 
> JSON array of the Basic POST request body
> ---
>
> Key: ATLAS-2506
> URL: https://issues.apache.org/jira/browse/ATLAS-2506
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2506.patch, Faceted_search.png
>
>
> Attributes of the filters added in the inner filter group are not added in 
> the "attributes" parameter of the POST body.
> Hence "attributes" in the POST body has only createTime , retention and not 
> temporary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2504) UI , Tag propagation : When an entity has the same tag propagated and directly associated , update window shows the values of propagated tags.

2018-03-19 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2504?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2504:
-
Attachment: ATLAS-2504.patch

> UI , Tag propagation : When an entity has the same tag propagated and 
> directly associated , update window shows the values of propagated tags.
> --
>
> Key: ATLAS-2504
> URL: https://issues.apache.org/jira/browse/ATLAS-2504
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2504.patch, tag_propagation_UI.mov
>
>
> 1. Created 2 tables employee and employee_ctas as CTAS of employee.
> 2. Created tag PII with attributes(a - float)
> 3. Associated PII to employee with attribute values (a =0.5). Now tag is 
> propagated to employee_ctas also.
> 4. Associated PII to employee_ctas with attribute values (a = 0.7).
> 5. On clicking the Edit classification of employee_ctas , values of PII 
> associated to employee table was shown instead of employee_ctas table. 
> Attached the video clip . [^tag_propagation_UI.mov] 
> 6.But on updating the values , correctly updated the employee_ctas table 
> only. (For example , in the video clip , updated a to 0.8 and it updated PII 
> of employee_ctas)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2506) Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

2018-03-19 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2506:


 Summary: Attributes of filters in the inner filter group are not 
added to "attributes" JSON array of the Basic POST request body
 Key: ATLAS-2506
 URL: https://issues.apache.org/jira/browse/ATLAS-2506
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey
 Attachments: Faceted_search.png

Attributes of the filters added in the inner filter group are not added in the 
"attributes" parameter of the POST body.

Hence "attributes" in the POST body has only createTime , retention and not 
temporary.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2504) UI , Tag propagation : When an entity has the same tag propagated and directly associated , update window shows the values of propagated tags.

2018-03-18 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2504:


 Summary: UI , Tag propagation : When an entity has the same tag 
propagated and directly associated , update window shows the values of 
propagated tags.
 Key: ATLAS-2504
 URL: https://issues.apache.org/jira/browse/ATLAS-2504
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey
 Attachments: tag_propagation_UI.mov

1. Created 2 tables employee and employee_ctas as CTAS of employee.
2. Created tag PII with attributes(a - float)
3. Associated PII to employee with attribute values (a =0.5). Now tag is 
propagated to employee_ctas also.
4. Associated PII to employee_ctas with attribute values (a = 0.7).
5. On clicking the Edit classification of employee_ctas , values of PII 
associated to employee table was shown instead of employee_ctas table. Attached 
the video clip . [^tag_propagation_UI.mov] 
6.But on updating the values , correctly updated the employee_ctas table only. 
(For example , in the video clip , updated a to 0.8 and it updated PII of 
employee_ctas)



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-2483) UI : Display of faceted query

2018-03-16 Thread pratik pandey (JIRA)

[ 
https://issues.apache.org/jira/browse/ATLAS-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16401521#comment-16401521
 ] 

pratik pandey commented on ATLAS-2483:
--

[~kevalbhatt] I have attached the patch for branch-0.8 please take a look.

> UI : Display of faceted query
> -
>
> Key: ATLAS-2483
> URL: https://issues.apache.org/jira/browse/ATLAS-2483
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Minor
> Attachments: ATLAS-2483-branch0.8.patch, ATLAS-2483.patch
>
>
> On searching using basic search :
> {code:java}
> type  = hive_column
> filter = position != 1 
> {code}
> the applied search is displayed as Type: hive_column AND (AND (position != 1))
> In earlier versions , when OR support wasn't there in UI , same query would 
> display Type: hive_table AND retention = 1
> "hive_column AND (AND (position != 1))" is confusing to user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2483) UI : Display of faceted query

2018-03-16 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2483:
-
Attachment: ATLAS-2483-branch0.8.patch

> UI : Display of faceted query
> -
>
> Key: ATLAS-2483
> URL: https://issues.apache.org/jira/browse/ATLAS-2483
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Minor
> Attachments: ATLAS-2483-branch0.8.patch, ATLAS-2483.patch
>
>
> On searching using basic search :
> {code:java}
> type  = hive_column
> filter = position != 1 
> {code}
> the applied search is displayed as Type: hive_column AND (AND (position != 1))
> In earlier versions , when OR support wasn't there in UI , same query would 
> display Type: hive_table AND retention = 1
> "hive_column AND (AND (position != 1))" is confusing to user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2501) UI , Tag propagation : On Search results page , entities with propagated tags have "Tag Remove button"

2018-03-15 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2501:
-
Attachment: ATLAS-2501.patch

> UI , Tag propagation : On Search results page , entities with propagated tags 
> have "Tag Remove button"
> --
>
> Key: ATLAS-2501
> URL: https://issues.apache.org/jira/browse/ATLAS-2501
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2501.patch, DeleteIconShownInSearchForCTAS.png
>
>
> 1. Created 2 Hive tables
> a.test_table
> b.test_table_ctas (CTAS of test_table)
> 2. Created a tag and associated the tag to test_table with propagate set to 
> True. 
> 3. Basic search for the tables listed test_table_ctas with PII tag and remove 
> button. On the detailsPage of test_table_ctas , remove button is not present.
> Attached the screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66087: ATLAS-2501 : UI , Tag propagation : On Search results page , entities with propagated tags have "Tag Remove button"

2018-03-15 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66087/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2501
https://issues.apache.org/jira/browse/ATLAS-2501


Repository: atlas


Description
---

1. Created 2 Hive tables
a.test_table
b.test_table_ctas (CTAS of test_table)
2. Created a tag and associated the tag to test_table with propagate set to 
True. 
3. Basic search for the tables listed test_table_ctas with PII tag and remove 
button. On the detailsPage of test_table_ctas , remove button is not present.


Diffs
-

  dashboardv2/public/css/scss/form.scss 0765dde 
  dashboardv2/public/js/utils/CommonViewFunction.js 47e50d6 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js ccc666b 


Diff: https://reviews.apache.org/r/66087/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Assigned] (ATLAS-2484) UI - Need validation for Start Date and End Date while applying validity period

2018-03-15 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2484:


Assignee: pratik pandey

> UI - Need validation for Start Date and End Date while applying validity 
> period
> ---
>
> Key: ATLAS-2484
> URL: https://issues.apache.org/jira/browse/ATLAS-2484
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0-alpha
>Reporter: Tejas Rawool
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2484.patch
>
>
> While assigning Tags to Entity, If Apply Validity Period is checked then 
> Start Date should not be greater then End Date and Time Zone should not 
> accept empty values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2484) UI - Need validation for Start Date and End Date while applying validity period

2018-03-15 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2484?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2484:
-
Attachment: ATLAS-2484.patch

> UI - Need validation for Start Date and End Date while applying validity 
> period
> ---
>
> Key: ATLAS-2484
> URL: https://issues.apache.org/jira/browse/ATLAS-2484
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 1.0.0-alpha
>Reporter: Tejas Rawool
>Priority: Major
> Fix For: 1.0.0
>
> Attachments: ATLAS-2484.patch
>
>
> While assigning Tags to Entity, If Apply Validity Period is checked then 
> Start Date should not be greater then End Date and Time Zone should not 
> accept empty values.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 66086: ATLAS-2484 : UI - Need validation for Start Date and End Date while applying validity period

2018-03-15 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66086/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2484
https://issues.apache.org/jira/browse/ATLAS-2484


Repository: atlas


Description
---

While assigning Tags to Entity, If Apply Validity Period is checked then Start 
Date should not be greater then End Date and Time Zone should not accept empty 
values.


Diffs
-

  dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html dbf7d66 
  dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html e7e1289 
  dashboardv2/public/js/views/tag/AddTagModalView.js 9d60e08 
  dashboardv2/public/js/views/tag/AddTimezoneItemView.js 015bb51 


Diff: https://reviews.apache.org/r/66086/diff/1/


Testing
---

Done one rouond of sanity testing.


Thanks,

pratik pandey



[jira] [Assigned] (ATLAS-2501) UI , Tag propagation : On Search results page , entities with propagated tags have "Tag Remove button"

2018-03-15 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2501:


Assignee: pratik pandey

> UI , Tag propagation : On Search results page , entities with propagated tags 
> have "Tag Remove button"
> --
>
> Key: ATLAS-2501
> URL: https://issues.apache.org/jira/browse/ATLAS-2501
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Attachments: DeleteIconShownInSearchForCTAS.png
>
>
> 1. Created 2 Hive tables
> a.test_table
> b.test_table_ctas (CTAS of test_table)
> 2. Created a tag and associated the tag to test_table with propagate set to 
> True. 
> 3. Basic search for the tables listed test_table_ctas with PII tag and remove 
> button. On the detailsPage of test_table_ctas , remove button is not present.
> Attached the screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2501) UI , Tag propagation : On Search results page , entities with propagated tags have "Tag Remove button"

2018-03-15 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2501:


 Summary: UI , Tag propagation : On Search results page , entities 
with propagated tags have "Tag Remove button"
 Key: ATLAS-2501
 URL: https://issues.apache.org/jira/browse/ATLAS-2501
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
 Attachments: DeleteIconShownInSearchForCTAS.png

1. Created 2 Hive tables
a.test_table
b.test_table_ctas (CTAS of test_table)
2. Created a tag and associated the tag to test_table with propagate set to 
True. 
3. Basic search for the tables listed test_table_ctas with PII tag and remove 
button. On the detailsPage of test_table_ctas , remove button is not present.

Attached the screenshot.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2485) UI : Unable to add tag to entity from Tags Search Page

2018-03-07 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2485:
-
Attachment: ATLAS-2485.patch

> UI : Unable to add tag to entity from Tags Search Page
> --
>
> Key: ATLAS-2485
> URL: https://issues.apache.org/jira/browse/ATLAS-2485
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2485.patch
>
>
> Tag Association window doesn't open when tag is attempted to be added by 
> clicking the + Button shown corresponding to the entities shown in the Tags 
> Search Page.
> On clicking the + Button , following stack trace is seen in Console tab of 
> browser.
> {code}
> TypeError: undefined is not an object (evaluating 
> 'this.tagCollection.fullCollection')
> tagsCollectionAddTagModalView.js:138
> onRenderAddTagModalView.js:116
> (anonymous function)backbone.marionette.min.js:1:7823
> triggerMethodbackbone.marionette.min.js:1:20699
> renderbackbone.marionette.min.js:1:28711
> (anonymous function)
> renderModal.js:35:97
> openModal.js:43
> initializeAddTagModalView.js:54
> Viewbackbone-min.js:1:13838
> constructorbackbone.marionette.min.js:1:17255
> constructorbackbone.marionette.min.js:1:22359
> constructorbackbone.marionette.min.js:1:27981
> (anonymous function)backbone-min.js:1:21782
> (anonymous function)SearchResultLayoutView.js:506
> execCbrequire.js:1:12902
> checkrequire.js:1:6639
> (anonymous function)require.js:1:9059
> (anonymous function)require.js:1:819
> (anonymous function)require.js:1:9516
> eachrequire.js:1:290
> emitrequire.js:1:9487
> checkrequire.js:1:7196
> (anonymous function)require.js:1:9059
> (anonymous function)require.js:1:819
> (anonymous function)require.js:1:9516
> eachrequire.js:1:290
> emitrequire.js:1:9487
> checkrequire.js:1:7196
> (anonymous function)require.js:1:9059
> (anonymous function)require.js:1:819
> (anonymous function)require.js:1:9516
> eachrequire.js:1:290
> emitrequire.js:1:9487
> checkrequire.js:1:7196
> enablerequire.js:1:9386
> initrequire.js:1:5744
> (anonymous function)require.js:1:8052
> (anonymous function)require.js:1:819
> execCbrequire.js:1:12902
> checkrequire.js:1:6639
> enablerequire.js:1:9386
> initrequire.js:1:5744
> (anonymous function)require.js:1:11266
> {code}
> CC : [~kbhatt] [~ppandey]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 65949: ATLAS-2485 : UI , Unable to add tag to entity from Tags Search Page

2018-03-07 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65949/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2485
https://issues.apache.org/jira/browse/ATLAS-2485


Repository: atlas


Description
---

Tag Association window doesn't open when tag is attempted to be added by 
clicking the + Button shown corresponding to the entities shown in the Tags 
Search Page.

On clicking the + Button , following stack trace is seen in Console tab of 
browser.

TypeError: undefined is not an object (evaluating 
'this.tagCollection.fullCollection')
tagsCollectionAddTagModalView.js:138
onRenderAddTagModalView.js:116
(anonymous function)backbone.marionette.min.js:1:7823
triggerMethodbackbone.marionette.min.js:1:20699
renderbackbone.marionette.min.js:1:28711
(anonymous function)
renderModal.js:35:97
openModal.js:43
initializeAddTagModalView.js:54
Viewbackbone-min.js:1:13838
constructorbackbone.marionette.min.js:1:17255
constructorbackbone.marionette.min.js:1:22359
constructorbackbone.marionette.min.js:1:27981
(anonymous function)backbone-min.js:1:21782
(anonymous function)SearchResultLayoutView.js:506
execCbrequire.js:1:12902
checkrequire.js:1:6639
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
enablerequire.js:1:9386
initrequire.js:1:5744
(anonymous function)require.js:1:8052
(anonymous function)require.js:1:819
execCbrequire.js:1:12902
checkrequire.js:1:6639
enablerequire.js:1:9386
initrequire.js:1:5744
(anonymous function)require.js:1:11266
CC : Kamlesh Bhatt [~ppandey]


Diffs
-

  dashboardv2/public/js/views/tag/TagDetailLayoutView.js 27f76bc 


Diff: https://reviews.apache.org/r/65949/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2485) UI : Unable to add tag to entity from Tags Search Page

2018-03-07 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2485:


 Summary: UI : Unable to add tag to entity from Tags Search Page
 Key: ATLAS-2485
 URL: https://issues.apache.org/jira/browse/ATLAS-2485
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey
Assignee: pratik pandey


Tag Association window doesn't open when tag is attempted to be added by 
clicking the + Button shown corresponding to the entities shown in the Tags 
Search Page.

On clicking the + Button , following stack trace is seen in Console tab of 
browser.
{code}
TypeError: undefined is not an object (evaluating 
'this.tagCollection.fullCollection')
tagsCollectionAddTagModalView.js:138
onRenderAddTagModalView.js:116
(anonymous function)backbone.marionette.min.js:1:7823
triggerMethodbackbone.marionette.min.js:1:20699
renderbackbone.marionette.min.js:1:28711
(anonymous function)
renderModal.js:35:97
openModal.js:43
initializeAddTagModalView.js:54
Viewbackbone-min.js:1:13838
constructorbackbone.marionette.min.js:1:17255
constructorbackbone.marionette.min.js:1:22359
constructorbackbone.marionette.min.js:1:27981
(anonymous function)backbone-min.js:1:21782
(anonymous function)SearchResultLayoutView.js:506
execCbrequire.js:1:12902
checkrequire.js:1:6639
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
(anonymous function)require.js:1:9059
(anonymous function)require.js:1:819
(anonymous function)require.js:1:9516
eachrequire.js:1:290
emitrequire.js:1:9487
checkrequire.js:1:7196
enablerequire.js:1:9386
initrequire.js:1:5744
(anonymous function)require.js:1:8052
(anonymous function)require.js:1:819
execCbrequire.js:1:12902
checkrequire.js:1:6639
enablerequire.js:1:9386
initrequire.js:1:5744
(anonymous function)require.js:1:11266
{code}

CC : [~kbhatt] [~ppandey]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2483) UI : Display of faceted query

2018-03-07 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2483:
-
Attachment: ATLAS-2483.patch

> UI : Display of faceted query
> -
>
> Key: ATLAS-2483
> URL: https://issues.apache.org/jira/browse/ATLAS-2483
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Minor
> Attachments: ATLAS-2483.patch
>
>
> On searching using basic search :
> {code:java}
> type  = hive_column
> filter = position != 1 
> {code}
> the applied search is displayed as Type: hive_column AND (AND (position != 1))
> In earlier versions , when OR support wasn't there in UI , same query would 
> display Type: hive_table AND retention = 1
> "hive_column AND (AND (position != 1))" is confusing to user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2483) UI : Display of faceted query

2018-03-07 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2483?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2483:


Assignee: pratik pandey

> UI : Display of faceted query
> -
>
> Key: ATLAS-2483
> URL: https://issues.apache.org/jira/browse/ATLAS-2483
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Minor
> Attachments: ATLAS-2483.patch
>
>
> On searching using basic search :
> {code:java}
> type  = hive_column
> filter = position != 1 
> {code}
> the applied search is displayed as Type: hive_column AND (AND (position != 1))
> In earlier versions , when OR support wasn't there in UI , same query would 
> display Type: hive_table AND retention = 1
> "hive_column AND (AND (position != 1))" is confusing to user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 65948: ATLAS-2483 : UI - Display of faceted query

2018-03-07 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65948/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2483
https://issues.apache.org/jira/browse/ATLAS-2483


Repository: atlas


Description
---

On searching using basic search :

type  = hive_column
filter = position != 1 
the applied search is displayed as Type: hive_column AND (AND (position != 1))
In earlier versions , when OR support wasn't there in UI , same query would 
display Type: hive_table AND retention = 1

"hive_column AND (AND (position != 1))" is confusing to user.


Diffs
-

  dashboardv2/public/js/utils/CommonViewFunction.js 2057e3e 


Diff: https://reviews.apache.org/r/65948/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2483) UI : Display of faceted query

2018-03-07 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2483:


 Summary: UI : Display of faceted query
 Key: ATLAS-2483
 URL: https://issues.apache.org/jira/browse/ATLAS-2483
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey


On searching using basic search :
{code:java}
type  = hive_column
filter = position != 1 
{code}
the applied search is displayed as Type: hive_column AND (AND (position != 1))
In earlier versions , when OR support wasn't there in UI , same query would 
display Type: hive_table AND retention = 1

"hive_column AND (AND (position != 1))" is confusing to user.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2482) UI , Tag Propagation : propagate value not set correctly when editing attributes if the value is False when association

2018-03-07 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2482:
-
Attachment: ATLAS-2482.patch

> UI , Tag Propagation : propagate value not set correctly when editing 
> attributes if the value is False when association
> ---
>
> Key: ATLAS-2482
> URL: https://issues.apache.org/jira/browse/ATLAS-2482
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2482.patch
>
>
> 1. Created a table and a view from the table.
> 2.Associated a tag to table with propagate set to False.
> 3.Edited the tag attribute associated to table. Since propagate is set to 
> False initially , propagate check box was unchecked. But request is sent with 
> default value True.
> 4. If check box value is toggled from 
> unchecked to checked and then checked to unchecked , propagate is set to 
> False correctly.
> 5. Thus , If no action is done on propagate check box , though it is 
> unchecked , the request is sent as "propagate" : True.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 65946: ATLAS-2482 : UI , Tag Propagation - propagate value not set correctly when editing attributes if the value is False when association

2018-03-07 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65946/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2482
https://issues.apache.org/jira/browse/ATLAS-2482


Repository: atlas


Description
---

1. Created a table and a view from the table.
2.Associated a tag to table with propagate set to False.
3.Edited the tag attribute associated to table. Since propagate is set to False 
initially , propagate check box was unchecked. But request is sent with default 
value True.
4. If check box value is toggled from 
unchecked to checked and then checked to unchecked , propagate is set to False 
correctly.
5. Thus , If no action is done on propagate check box , though it is unchecked 
, the request is sent as "propagate" : True.


Diffs
-

  dashboardv2/public/js/views/tag/AddTagModalView.js 43bb7dd 


Diff: https://reviews.apache.org/r/65946/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2482) UI , Tag Propagation : propagate value not set correctly when editing attributes if the value is False when association

2018-03-06 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2482:


 Summary: UI , Tag Propagation : propagate value not set correctly 
when editing attributes if the value is False when association
 Key: ATLAS-2482
 URL: https://issues.apache.org/jira/browse/ATLAS-2482
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey


1. Created a table and a view from the table.
2.Associated a tag to table with propagate set to False.
3.Edited the tag attribute associated to table. Since propagate is set to False 
initially , propagate check box was unchecked. But request is sent with default 
value True.
4. If check box value is toggled from 
unchecked to checked and then checked to unchecked , propagate is set to False 
correctly.
5. Thus , If no action is done on propagate check box , though it is unchecked 
, the request is sent as "propagate" : True.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2482) UI , Tag Propagation : propagate value not set correctly when editing attributes if the value is False when association

2018-03-06 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2482:


Assignee: pratik pandey

> UI , Tag Propagation : propagate value not set correctly when editing 
> attributes if the value is False when association
> ---
>
> Key: ATLAS-2482
> URL: https://issues.apache.org/jira/browse/ATLAS-2482
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
>
> 1. Created a table and a view from the table.
> 2.Associated a tag to table with propagate set to False.
> 3.Edited the tag attribute associated to table. Since propagate is set to 
> False initially , propagate check box was unchecked. But request is sent with 
> default value True.
> 4. If check box value is toggled from 
> unchecked to checked and then checked to unchecked , propagate is set to 
> False correctly.
> 5. Thus , If no action is done on propagate check box , though it is 
> unchecked , the request is sent as "propagate" : True.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2469) Tag propagation from object to child object or derivative asset

2018-03-05 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2469:
-
Attachment: ATLAS-2469.patch

> Tag propagation from object to child object or derivative asset
> ---
>
> Key: ATLAS-2469
> URL: https://issues.apache.org/jira/browse/ATLAS-2469
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 1.0.0
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Blocker
> Fix For: 1.0.0
>
> Attachments: ATLAS-2469.patch
>
>
> User Story:
> As a data steward i need a scalable way to quickly and efficiently propagate 
> tags for efficient searches and tag based security. Likewise tags for 
> derivative dataset should be inherited from the parent. For example, if an 
> entity is tagged "Secret" then resulting entity created from a CTAS operation 
> should also be tagged "secret" to maintain the classification of the parent. 
> In the case where 2 or more datasets are aggregated the derivative dataset 
> should be a union of all parent tags.
> Terms:
> * Child business terms should inherit the tags associated with the parent 
> term.
> * the option to propagate tags to child business terms in a hierarchy should 
> be provided
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a term should propagate to data assets that are already attached to 
> that business term as well
> Data assets
> * For supported components in HDP 2.6,if a derivative asset is created it 
> should inherit the tags and attributes from the original asset.
> * the option to propagate tags to child entities should be provided (e.g. if 
> you tag a hdfs folder optionally tag all the files within it)
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a parent object should be inherited even after child creation 
> dynamically (unless a flag is set not to do this)
> * Derived data assets should have the tags of the original data asset.
> conflict resolution - if the different values for attributes then a UX dialog 
> that prompts user for action needs to be provided. Once resolved, the 
> resolved value will be carry forth to derivative dataset.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65870: ATLAS-2469 : Tag propagation from object to child object or derivative asset.

2018-03-05 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65870/
---

(Updated March 5, 2018, 2:16 p.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

All notification text change from Tag to Classfication.


Bugs: ATLAS-2469
https://issues.apache.org/jira/browse/ATLAS-2469


Repository: atlas


Description
---

User Story:

As a data steward i need a scalable way to quickly and efficiently propagate 
tags for efficient searches and tag based security. Likewise tags for 
derivative dataset should be inherited from the parent. For example, if an 
entity is tagged "Secret" then resulting entity created from a CTAS operation 
should also be tagged "secret" to maintain the classification of the parent. In 
the case where 2 or more datasets are aggregated the derivative dataset should 
be a union of all parent tags.

Terms:

Child business terms should inherit the tags associated with the parent term.
the option to propagate tags to child business terms in a hierarchy should be 
provided
Ability to update the propagated tags manually via UI or through the API
Tagging a term should propagate to data assets that are already attached to 
that business term as well
Data assets

For supported components in HDP 2.6,if a derivative asset is created it should 
inherit the tags and attributes from the original asset.
the option to propagate tags to child entities should be provided (e.g. if you 
tag a hdfs folder optionally tag all the files within it)
Ability to update the propagated tags manually via UI or through the API
Tagging a parent object should be inherited even after child creation 
dynamically (unless a flag is set not to do this)
Derived data assets should have the tags of the original data asset.
conflict resolution - if the different values for attributes then a UX dialog 
that prompts user for action needs to be provided. Once resolved, the resolved 
value will be carry forth to derivative dataset.


Diffs (updated)
-

  dashboardv2/gruntfile.js 451a933 
  dashboardv2/package.json 9237c35 
  dashboardv2/public/css/scss/override.scss f1e2c6b 
  dashboardv2/public/js/main.js ce0f4fe 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
1578548 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 5d3c3af 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
403b064 
  dashboardv2/public/js/templates/site/SideNavLayoutView_tmpl.html b706609 
  dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html a477532 
  dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/tag/CreateTagLayoutView_tmpl.html 40827ef 
  dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 
d418782 
  dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html 
76f225a 
  dashboardv2/public/js/templates/tag/TagLayoutView_tmpl.html f786df4 
  dashboardv2/public/js/utils/CommonViewFunction.js 9b9ffcc 
  dashboardv2/public/js/utils/Enums.js a7b9a8b 
  dashboardv2/public/js/utils/Messages.js 44604cf 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 802f6a4 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 86520c9 
  dashboardv2/public/js/views/tag/AddTagModalView.js d1c8c67 
  dashboardv2/public/js/views/tag/AddTimezoneItemView.js PRE-CREATION 
  dashboardv2/public/js/views/tag/CreateTagLayoutView.js e43a431 
  dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 3d6b859 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c05b48d 
  dashboardv2/public/js/views/tag/TagLayoutView.js 0edb378 


Diff: https://reviews.apache.org/r/65870/diff/3/

Changes: https://reviews.apache.org/r/65870/diff/2-3/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2469) Tag propagation from object to child object or derivative asset

2018-03-05 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2469:
-
Attachment: ATLAS-2469.patch

> Tag propagation from object to child object or derivative asset
> ---
>
> Key: ATLAS-2469
> URL: https://issues.apache.org/jira/browse/ATLAS-2469
> Project: Atlas
>  Issue Type: New Feature
>Affects Versions: 1.0.0
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Blocker
> Fix For: 1.0.0
>
> Attachments: ATLAS-2469.patch
>
>
> User Story:
> As a data steward i need a scalable way to quickly and efficiently propagate 
> tags for efficient searches and tag based security. Likewise tags for 
> derivative dataset should be inherited from the parent. For example, if an 
> entity is tagged "Secret" then resulting entity created from a CTAS operation 
> should also be tagged "secret" to maintain the classification of the parent. 
> In the case where 2 or more datasets are aggregated the derivative dataset 
> should be a union of all parent tags.
> Terms:
> * Child business terms should inherit the tags associated with the parent 
> term.
> * the option to propagate tags to child business terms in a hierarchy should 
> be provided
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a term should propagate to data assets that are already attached to 
> that business term as well
> Data assets
> * For supported components in HDP 2.6,if a derivative asset is created it 
> should inherit the tags and attributes from the original asset.
> * the option to propagate tags to child entities should be provided (e.g. if 
> you tag a hdfs folder optionally tag all the files within it)
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a parent object should be inherited even after child creation 
> dynamically (unless a flag is set not to do this)
> * Derived data assets should have the tags of the original data asset.
> conflict resolution - if the different values for attributes then a UX dialog 
> that prompts user for action needs to be provided. Once resolved, the 
> resolved value will be carry forth to derivative dataset.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65870: ATLAS-2469 : Tag propagation from object to child object or derivative asset.

2018-03-05 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65870/
---

(Updated March 5, 2018, 12:20 p.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sarath Subramanian.


Changes
---

Review Commnet handled.


Bugs: ATLAS-2469
https://issues.apache.org/jira/browse/ATLAS-2469


Repository: atlas


Description
---

User Story:

As a data steward i need a scalable way to quickly and efficiently propagate 
tags for efficient searches and tag based security. Likewise tags for 
derivative dataset should be inherited from the parent. For example, if an 
entity is tagged "Secret" then resulting entity created from a CTAS operation 
should also be tagged "secret" to maintain the classification of the parent. In 
the case where 2 or more datasets are aggregated the derivative dataset should 
be a union of all parent tags.

Terms:

Child business terms should inherit the tags associated with the parent term.
the option to propagate tags to child business terms in a hierarchy should be 
provided
Ability to update the propagated tags manually via UI or through the API
Tagging a term should propagate to data assets that are already attached to 
that business term as well
Data assets

For supported components in HDP 2.6,if a derivative asset is created it should 
inherit the tags and attributes from the original asset.
the option to propagate tags to child entities should be provided (e.g. if you 
tag a hdfs folder optionally tag all the files within it)
Ability to update the propagated tags manually via UI or through the API
Tagging a parent object should be inherited even after child creation 
dynamically (unless a flag is set not to do this)
Derived data assets should have the tags of the original data asset.
conflict resolution - if the different values for attributes then a UX dialog 
that prompts user for action needs to be provided. Once resolved, the resolved 
value will be carry forth to derivative dataset.


Diffs (updated)
-

  dashboardv2/gruntfile.js 451a933 
  dashboardv2/package.json 9237c35 
  dashboardv2/public/css/scss/override.scss f1e2c6b 
  dashboardv2/public/js/main.js ce0f4fe 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
1578548 
  dashboardv2/public/js/templates/search/SearchLayoutView_tmpl.html 5d3c3af 
  dashboardv2/public/js/templates/search/SearchResultLayoutView_tmpl.html 
403b064 
  dashboardv2/public/js/templates/site/SideNavLayoutView_tmpl.html b706609 
  dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html a477532 
  dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/tag/CreateTagLayoutView_tmpl.html 40827ef 
  dashboardv2/public/js/templates/tag/TagAttributeDetailLayoutView_tmpl.html 
d418782 
  dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html 
76f225a 
  dashboardv2/public/js/templates/tag/TagLayoutView_tmpl.html f786df4 
  dashboardv2/public/js/utils/CommonViewFunction.js 9b9ffcc 
  dashboardv2/public/js/utils/Enums.js a7b9a8b 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 802f6a4 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 86520c9 
  dashboardv2/public/js/views/tag/AddTagModalView.js d1c8c67 
  dashboardv2/public/js/views/tag/AddTimezoneItemView.js PRE-CREATION 
  dashboardv2/public/js/views/tag/CreateTagLayoutView.js e43a431 
  dashboardv2/public/js/views/tag/TagAttributeDetailLayoutView.js 3d6b859 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c05b48d 
  dashboardv2/public/js/views/tag/TagLayoutView.js 0edb378 


Diff: https://reviews.apache.org/r/65870/diff/2/

Changes: https://reviews.apache.org/r/65870/diff/1-2/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2469) Tag propagation from object to child object or derivative asset

2018-03-01 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2469:
-
Attachment: TagPropagation.patch

> Tag propagation from object to child object or derivative asset
> ---
>
> Key: ATLAS-2469
> URL: https://issues.apache.org/jira/browse/ATLAS-2469
> Project: Atlas
>  Issue Type: New Feature
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Blocker
> Attachments: TagPropagation.patch
>
>
> User Story:
> As a data steward i need a scalable way to quickly and efficiently propagate 
> tags for efficient searches and tag based security. Likewise tags for 
> derivative dataset should be inherited from the parent. For example, if an 
> entity is tagged "Secret" then resulting entity created from a CTAS operation 
> should also be tagged "secret" to maintain the classification of the parent. 
> In the case where 2 or more datasets are aggregated the derivative dataset 
> should be a union of all parent tags.
> Terms:
> * Child business terms should inherit the tags associated with the parent 
> term.
> * the option to propagate tags to child business terms in a hierarchy should 
> be provided
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a term should propagate to data assets that are already attached to 
> that business term as well
> Data assets
> * For supported components in HDP 2.6,if a derivative asset is created it 
> should inherit the tags and attributes from the original asset.
> * the option to propagate tags to child entities should be provided (e.g. if 
> you tag a hdfs folder optionally tag all the files within it)
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a parent object should be inherited even after child creation 
> dynamically (unless a flag is set not to do this)
> * Derived data assets should have the tags of the original data asset.
> conflict resolution - if the different values for attributes then a UX dialog 
> that prompts user for action needs to be provided. Once resolved, the 
> resolved value will be carry forth to derivative dataset.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 65870: ATLAS-2469 : Tag propagation from object to child object or derivative asset.

2018-03-01 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65870/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sarath Subramanian.


Bugs: ATLAS-2469
https://issues.apache.org/jira/browse/ATLAS-2469


Repository: atlas


Description
---

User Story:

As a data steward i need a scalable way to quickly and efficiently propagate 
tags for efficient searches and tag based security. Likewise tags for 
derivative dataset should be inherited from the parent. For example, if an 
entity is tagged "Secret" then resulting entity created from a CTAS operation 
should also be tagged "secret" to maintain the classification of the parent. In 
the case where 2 or more datasets are aggregated the derivative dataset should 
be a union of all parent tags.

Terms:

Child business terms should inherit the tags associated with the parent term.
the option to propagate tags to child business terms in a hierarchy should be 
provided
Ability to update the propagated tags manually via UI or through the API
Tagging a term should propagate to data assets that are already attached to 
that business term as well
Data assets

For supported components in HDP 2.6,if a derivative asset is created it should 
inherit the tags and attributes from the original asset.
the option to propagate tags to child entities should be provided (e.g. if you 
tag a hdfs folder optionally tag all the files within it)
Ability to update the propagated tags manually via UI or through the API
Tagging a parent object should be inherited even after child creation 
dynamically (unless a flag is set not to do this)
Derived data assets should have the tags of the original data asset.
conflict resolution - if the different values for attributes then a UX dialog 
that prompts user for action needs to be provided. Once resolved, the resolved 
value will be carry forth to derivative dataset.


Diffs
-

  dashboardv2/gruntfile.js 451a933 
  dashboardv2/package.json 9237c35 
  dashboardv2/public/css/scss/override.scss f1e2c6b 
  dashboardv2/public/js/main.js ce0f4fe 
  dashboardv2/public/js/templates/detail_page/DetailPageLayoutView_tmpl.html 
1578548 
  dashboardv2/public/js/templates/site/SideNavLayoutView_tmpl.html b706609 
  dashboardv2/public/js/templates/tag/AddTagModalView_tmpl.html a477532 
  dashboardv2/public/js/templates/tag/AddTimezoneView_tmpl.html PRE-CREATION 
  dashboardv2/public/js/templates/tag/TagDetailTableLayoutView_tmpl.html 
76f225a 
  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js 802f6a4 
  dashboardv2/public/js/views/tag/AddTagModalView.js d1c8c67 
  dashboardv2/public/js/views/tag/AddTimezoneItemView.js PRE-CREATION 
  dashboardv2/public/js/views/tag/TagDetailTableLayoutView.js c05b48d 


Diff: https://reviews.apache.org/r/65870/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2469) Tag propagation from object to child object or derivative asset

2018-03-01 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2469:
-
Priority: Blocker  (was: Major)

> Tag propagation from object to child object or derivative asset
> ---
>
> Key: ATLAS-2469
> URL: https://issues.apache.org/jira/browse/ATLAS-2469
> Project: Atlas
>  Issue Type: New Feature
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Blocker
>
> User Story:
> As a data steward i need a scalable way to quickly and efficiently propagate 
> tags for efficient searches and tag based security. Likewise tags for 
> derivative dataset should be inherited from the parent. For example, if an 
> entity is tagged "Secret" then resulting entity created from a CTAS operation 
> should also be tagged "secret" to maintain the classification of the parent. 
> In the case where 2 or more datasets are aggregated the derivative dataset 
> should be a union of all parent tags.
> Terms:
> * Child business terms should inherit the tags associated with the parent 
> term.
> * the option to propagate tags to child business terms in a hierarchy should 
> be provided
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a term should propagate to data assets that are already attached to 
> that business term as well
> Data assets
> * For supported components in HDP 2.6,if a derivative asset is created it 
> should inherit the tags and attributes from the original asset.
> * the option to propagate tags to child entities should be provided (e.g. if 
> you tag a hdfs folder optionally tag all the files within it)
> * Ability to update the propagated tags manually via UI or through the API
> * Tagging a parent object should be inherited even after child creation 
> dynamically (unless a flag is set not to do this)
> * Derived data assets should have the tags of the original data asset.
> conflict resolution - if the different values for attributes then a UX dialog 
> that prompts user for action needs to be provided. Once resolved, the 
> resolved value will be carry forth to derivative dataset.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2469) Tag propagation from object to child object or derivative asset

2018-03-01 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2469:


 Summary: Tag propagation from object to child object or derivative 
asset
 Key: ATLAS-2469
 URL: https://issues.apache.org/jira/browse/ATLAS-2469
 Project: Atlas
  Issue Type: New Feature
Reporter: pratik pandey
Assignee: pratik pandey


User Story:

As a data steward i need a scalable way to quickly and efficiently propagate 
tags for efficient searches and tag based security. Likewise tags for 
derivative dataset should be inherited from the parent. For example, if an 
entity is tagged "Secret" then resulting entity created from a CTAS operation 
should also be tagged "secret" to maintain the classification of the parent. In 
the case where 2 or more datasets are aggregated the derivative dataset should 
be a union of all parent tags.


Terms:

* Child business terms should inherit the tags associated with the parent term.
* the option to propagate tags to child business terms in a hierarchy should be 
provided
* Ability to update the propagated tags manually via UI or through the API
* Tagging a term should propagate to data assets that are already attached to 
that business term as well

Data assets

* For supported components in HDP 2.6,if a derivative asset is created it 
should inherit the tags and attributes from the original asset.
* the option to propagate tags to child entities should be provided (e.g. if 
you tag a hdfs folder optionally tag all the files within it)
* Ability to update the propagated tags manually via UI or through the API
* Tagging a parent object should be inherited even after child creation 
dynamically (unless a flag is set not to do this)
* Derived data assets should have the tags of the original data asset.

conflict resolution - if the different values for attributes then a UX dialog 
that prompts user for action needs to be provided. Once resolved, the resolved 
value will be carry forth to derivative dataset.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2451) UI support to list tables in a namespace similar to listing tables in a db in the detailsPage of hive_db entity.

2018-02-19 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2451:
-
Fix Version/s: (was: 0.8.2)
   0.8.3

> UI support to list tables in a namespace similar to listing tables in a db in 
> the detailsPage of hive_db entity.
> 
>
> Key: ATLAS-2451
> URL: https://issues.apache.org/jira/browse/ATLAS-2451
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 1.0.0, 0.8.3
>
> Attachments: ATLAS-2451.branch-0.8.patch, ATLAS-2451.master.patch
>
>
> Following API fetches the HBase tables in a namespace.
> {code:java}
> /api/atlas/v2/search/relationship?limit=25=0==__hbase_table.namespace
> {code}
> UI support could be added to list the hbase_table entities in the 
> hbase_namespace entity's detailsPage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2451) UI support to list tables in a namespace similar to listing tables in a db in the detailsPage of hive_db entity.

2018-02-19 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2451:
-
Attachment: ATLAS-2451.master.patch
ATLAS-2451.branch-0.8.patch

> UI support to list tables in a namespace similar to listing tables in a db in 
> the detailsPage of hive_db entity.
> 
>
> Key: ATLAS-2451
> URL: https://issues.apache.org/jira/browse/ATLAS-2451
> Project: Atlas
>  Issue Type: Improvement
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2451.branch-0.8.patch, ATLAS-2451.master.patch
>
>
> Following API fetches the HBase tables in a namespace.
> {code:java}
> /api/atlas/v2/search/relationship?limit=25=0==__hbase_table.namespace
> {code}
> UI support could be added to list the hbase_table entities in the 
> hbase_namespace entity's detailsPage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 65708: ATLAS-2451 : UI support to list tables in a namespace similar to listing tables in a db in the detailsPage of hive_db entity.

2018-02-19 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65708/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, and Nixon Rodrigues.


Bugs: ATLAS-2451
https://issues.apache.org/jira/browse/ATLAS-2451


Repository: atlas


Description
---

Following API fetches the HBase tables in a namespace.

/api/atlas/v2/search/relationship?limit=25=0==__hbase_table.namespace

UI support could be added to list the hbase_table entities in the 
hbase_namespace entity's detailsPage.


Diffs
-

  dashboardv2/public/js/views/detail_page/DetailPageLayoutView.js ab74c3e 
  dashboardv2/public/js/views/profile/ProfileLayoutView.js 79cf3a5 
  dashboardv2/public/js/views/search/SearchResultLayoutView.js 18fb718 


Diff: https://reviews.apache.org/r/65708/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Created] (ATLAS-2451) UI support to list tables in a namespace similar to listing tables in a db in the detailsPage of hive_db entity.

2018-02-16 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2451:


 Summary: UI support to list tables in a namespace similar to 
listing tables in a db in the detailsPage of hive_db entity.
 Key: ATLAS-2451
 URL: https://issues.apache.org/jira/browse/ATLAS-2451
 Project: Atlas
  Issue Type: Improvement
Reporter: pratik pandey
Assignee: pratik pandey


Following API fetches the HBase tables in a namespace.
{code:java}
/api/atlas/v2/search/relationship?limit=25=0==__hbase_table.namespace
{code}
UI support could be added to list the hbase_table entities in the 
hbase_namespace entity's detailsPage.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2440) UI : select on "date" attribute results value in long format instead of formatted date.

2018-02-14 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2440:
-
Attachment: ATLAS-2440.1.patch

> UI : select on "date" attribute results value in long format instead of 
> formatted date.
> ---
>
> Key: ATLAS-2440
> URL: https://issues.apache.org/jira/browse/ATLAS-2440
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2440.1.patch, ATLAS-2440.patch
>
>
> hive_table select createTime 
> lists the createTime in long format.
> On detailsPage or results page of basic search , the value is formatted date 
> and not long value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2441) UI : DSL Search : type select __guid doesn't display result though the result has GUID response

2018-02-14 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2441:
-
Attachment: ATLAS-2441.1.patch

> UI : DSL Search : type select __guid doesn't display result though the result 
> has GUID response
> ---
>
> Key: ATLAS-2441
> URL: https://issues.apache.org/jira/browse/ATLAS-2441
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2441.1.patch, ATLAS-2441.patch
>
>
> DSL query 
> hive_table select __guid
> results all the guids. But the UI doesn't display them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65633: ATLAS-2440 : UI , select on "date" attribute results value in long format instead of formatted date

2018-02-14 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65633/
---

(Updated Feb. 14, 2018, 9:49 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Changes
---

review request comment handled.


Bugs: ATLAS-2440
https://issues.apache.org/jira/browse/ATLAS-2440


Repository: atlas


Description
---

query :

hive_table select createTime 
lists the createTime in long format.

On detailsPage or results page of basic search , the value is formatted date 
and not long value.


Diffs (updated)
-

  dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 


Diff: https://reviews.apache.org/r/65633/diff/2/

Changes: https://reviews.apache.org/r/65633/diff/1-2/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Assigned] (ATLAS-2440) UI : select on "date" attribute results value in long format instead of formatted date.

2018-02-13 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2440:


Assignee: pratik pandey

> UI : select on "date" attribute results value in long format instead of 
> formatted date.
> ---
>
> Key: ATLAS-2440
> URL: https://issues.apache.org/jira/browse/ATLAS-2440
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Assignee: pratik pandey
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2440.patch
>
>
> hive_table select createTime 
> lists the createTime in long format.
> On detailsPage or results page of basic search , the value is formatted date 
> and not long value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Updated] (ATLAS-2440) UI : select on "date" attribute results value in long format instead of formatted date.

2018-02-13 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2440?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2440:
-
Attachment: ATLAS-2440.patch

> UI : select on "date" attribute results value in long format instead of 
> formatted date.
> ---
>
> Key: ATLAS-2440
> URL: https://issues.apache.org/jira/browse/ATLAS-2440
> Project: Atlas
>  Issue Type: Bug
>Reporter: pratik pandey
>Priority: Major
> Fix For: 0.8.2, 1.0.0
>
> Attachments: ATLAS-2440.patch
>
>
> hive_table select createTime 
> lists the createTime in long format.
> On detailsPage or results page of basic search , the value is formatted date 
> and not long value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Review Request 65633: ATLAS-2440 : UI , select on "date" attribute results value in long format instead of formatted date

2018-02-13 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65633/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2440
https://issues.apache.org/jira/browse/ATLAS-2440


Repository: atlas


Description
---

query :

hive_table select createTime 
lists the createTime in long format.

On detailsPage or results page of basic search , the value is formatted date 
and not long value.


Diffs
-

  dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 


Diff: https://reviews.apache.org/r/65633/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



Review Request 65632: ATLAS-2441 : UI : DSL Search : type select __guid doesn't display result though the result has GUID response.

2018-02-13 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65632/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2441
https://issues.apache.org/jira/browse/ATLAS-2441


Repository: atlas


Description
---

DSL query 
hive_table select __guid

results all the guids. But the UI doesn't display them.


Diffs
-

  dashboardv2/public/js/views/search/SearchResultLayoutView.js b3f339b 


Diff: https://reviews.apache.org/r/65632/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2441) UI : DSL Search : type select __guid doesn't display result though the result has GUID response

2018-02-13 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2441:
-
Attachment: ATLAS-2441.patch

> UI : DSL Search : type select __guid doesn't display result though the result 
> has GUID response
> ---
>
> Key: ATLAS-2441
> URL: https://issues.apache.org/jira/browse/ATLAS-2441
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2441.patch
>
>
> DSL query 
> hive_table select __guid
> results all the guids. But the UI doesn't display them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Assigned] (ATLAS-2441) UI : DSL Search : type select __guid doesn't display result though the result has GUID response

2018-02-13 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey reassigned ATLAS-2441:


Assignee: pratik pandey

> UI : DSL Search : type select __guid doesn't display result though the result 
> has GUID response
> ---
>
> Key: ATLAS-2441
> URL: https://issues.apache.org/jira/browse/ATLAS-2441
> Project: Atlas
>  Issue Type: Bug
>    Reporter: pratik pandey
>    Assignee: pratik pandey
>Priority: Major
> Attachments: ATLAS-2441.patch
>
>
> DSL query 
> hive_table select __guid
> results all the guids. But the UI doesn't display them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2441) UI : DSL Search : type select __guid doesn't display result though the result has GUID response

2018-02-13 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2441:


 Summary: UI : DSL Search : type select __guid doesn't display 
result though the result has GUID response
 Key: ATLAS-2441
 URL: https://issues.apache.org/jira/browse/ATLAS-2441
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey


DSL query 
hive_table select __guid

results all the guids. But the UI doesn't display them.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (ATLAS-2440) UI : select on "date" attribute results value in long format instead of formatted date.

2018-02-13 Thread pratik pandey (JIRA)
pratik pandey created ATLAS-2440:


 Summary: UI : select on "date" attribute results value in long 
format instead of formatted date.
 Key: ATLAS-2440
 URL: https://issues.apache.org/jira/browse/ATLAS-2440
 Project: Atlas
  Issue Type: Bug
Reporter: pratik pandey


hive_table select createTime 

lists the createTime in long format.

On detailsPage or results page of basic search , the value is formatted date 
and not long value.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Review Request 65381: ATLAS-2152 : UI: Atlas UI not able to load the saved search

2018-01-29 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65381/
---

(Updated Jan. 29, 2018, 2:21 p.m.)


Review request for atlas, Ayub Pathan, keval bhatt, Madhan Neethiraj, Nixon 
Rodrigues, and Sharmadha Sainath.


Changes
---

change summary


Summary (updated)
-

ATLAS-2152 : UI: Atlas UI not able to load the saved search


Bugs: ATLAS-2152
https://issues.apache.org/jira/browse/ATLAS-2152


Repository: atlas


Description
---

After saving the search query, Atlas UI unable to load the saved search.

Below exception is observed on the browser console

CommonViewFunction.js:487 Uncaught TypeError: Cannot read property 'toJSON' of 
undefined
at CommonViewFunction.js:487
at Function.s.each.s.forEach (underscore-min.js:5)
at Object.g.generateUrlFromSaveSearchObject (CommonViewFunction.js:476)
at L.d.applyValue (SearchLayoutView.js:155)
at L.d.stateChange (SaveSearchItemView.js:60)
at HTMLLIElement.dispatch (jquery.min.js:3)
at HTMLLIElement.q.handle (jquery.min.js:3)


Diffs
-

  dashboardv2/public/css/scss/override.scss 605bcd5 
  dashboardv2/public/js/utils/CommonViewFunction.js 6cba9c0 
  dashboardv2/public/js/views/search/QueryBuilderView.js fdb3c22 
  dashboardv2/public/js/views/search/SearchLayoutView.js 255cf74 
  dashboardv2/public/js/views/search/SearchQueryView.js 2446d3d 


Diff: https://reviews.apache.org/r/65381/diff/1/


Testing
---

Done one round of sanity testing


Thanks,

pratik pandey



[jira] [Updated] (ATLAS-2152) Saved Search: UI: Atlas UI not able to load the saved search

2018-01-29 Thread pratik pandey (JIRA)

 [ 
https://issues.apache.org/jira/browse/ATLAS-2152?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

pratik pandey updated ATLAS-2152:
-
Attachment: ATLAS-2152.patch

> Saved Search: UI: Atlas UI not able to load the saved search
> 
>
> Key: ATLAS-2152
> URL: https://issues.apache.org/jira/browse/ATLAS-2152
> Project: Atlas
>  Issue Type: Bug
>  Components: atlas-webui
>Affects Versions: 1.0.0
>Reporter: Ayub Pathan
>    Assignee: pratik pandey
>Priority: Critical
> Attachments: ATLAS-2152.branch0.8.patch, ATLAS-2152.patch, 
> SavedSearchSample.json
>
>
> After saving the search query, Atlas UI unable to load the saved search. 
> Below exception is observed on the browser console
> {noformat}
> CommonViewFunction.js:487 Uncaught TypeError: Cannot read property 'toJSON' 
> of undefined
> at CommonViewFunction.js:487
> at Function.s.each.s.forEach (underscore-min.js:5)
> at Object.g.generateUrlFromSaveSearchObject (CommonViewFunction.js:476)
> at L.d.applyValue (SearchLayoutView.js:155)
> at L.d.stateChange (SaveSearchItemView.js:60)
> at HTMLLIElement.dispatch (jquery.min.js:3)
> at HTMLLIElement.q.handle (jquery.min.js:3)
> {noformat}
> Tested on master.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


  1   2   >