Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61040/#review181193 --- Ship it! Ship It! - Nixon Rodrigues On July 24, 2017, 3:50 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61040/ > --- > > (Updated July 24, 2017, 3:50 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1981 > https://issues.apache.org/jira/browse/ATLAS-1981 > > > Repository: atlas > > > Description > --- > > Updated search to use cached type-query string to improve performance > > > Diffs > - > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 049a537b > > repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java > dfb2ee27 > > > Diff: https://reviews.apache.org/r/61040/diff/2/ > > > Testing > --- > > verified that the search returns correct results after this enhancement > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61040/#review181192 --- Ship it! Ship It! - Nixon Rodrigues On July 24, 2017, 3:50 a.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61040/ > --- > > (Updated July 24, 2017, 3:50 a.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1981 > https://issues.apache.org/jira/browse/ATLAS-1981 > > > Repository: atlas > > > Description > --- > > Updated search to use cached type-query string to improve performance > > > Diffs > - > > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 049a537b > > repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java > dfb2ee27 > > > Diff: https://reviews.apache.org/r/61040/diff/2/ > > > Testing > --- > > verified that the search returns correct results after this enhancement > > > Thanks, > > Madhan Neethiraj > >
Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61040/ --- (Updated July 24, 2017, 3:50 a.m.) Review request for atlas. Changes --- fix for unit test failures caused by this update Bugs: ATLAS-1981 https://issues.apache.org/jira/browse/ATLAS-1981 Repository: atlas Description --- Updated search to use cached type-query string to improve performance Diffs (updated) - intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 049a537b repository/src/test/java/org/apache/atlas/services/EntityDiscoveryServiceTest.java dfb2ee27 Diff: https://reviews.apache.org/r/61040/diff/2/ Changes: https://reviews.apache.org/r/61040/diff/1-2/ Testing --- verified that the search returns correct results after this enhancement Thanks, Madhan Neethiraj
Re: Review Request 61040: ATLAS-1981: Cache escaped type-query string to avoid repeated computation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61040/#review181130 --- Ship it! Ship It! - Apoorv Naik On July 21, 2017, 4:34 p.m., Madhan Neethiraj wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61040/ > --- > > (Updated July 21, 2017, 4:34 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-1981 > https://issues.apache.org/jira/browse/ATLAS-1981 > > > Repository: atlas > > > Description > --- > > Updated search to use cached type-query string to improve performance > > > Diffs > - > > common/src/main/java/org/apache/atlas/repository/Constants.java e8621cf3 > intg/src/main/java/org/apache/atlas/type/AtlasClassificationType.java > c1c3add4 > intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java e3005ee1 > intg/src/main/java/org/apache/atlas/type/AtlasStructType.java b390a97c > intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 281422ba > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 745f9d7b > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > dbe11a69 > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > efcfb7fe > > repository/src/main/java/org/apache/atlas/discovery/FullTextSearchProcessor.java > 0d1c39b7 > repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java > 28621658 > > > Diff: https://reviews.apache.org/r/61040/diff/1/ > > > Testing > --- > > verified that the search returns correct results after this enhancement > > > Thanks, > > Madhan Neethiraj > >