Re: Review Request 61871: ATLAS-2083: Refactor AtlasDefStore classes to reduce code duplication

2017-08-25 Thread Richard Ding via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61871/
---

(Updated Aug. 25, 2017, 6:44 p.m.)


Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and 
Sarath Subramanian.


Changes
---

Uploaded a new patch rebased on the latest master branch.


Bugs: ATLAS-2083
https://issues.apache.org/jira/browse/ATLAS-2083


Repository: atlas


Description
---

1. Use generic interface to reduce code duplication
2. Move the common code in the implementation classes to the base class
3. Tighten the types required in the interface methods 
4. Move two test classes to the correct package


Diffs (updated)
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
 92a59f39 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
 08391ba5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
 d0f98e2f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStore.java
 df67958b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
 ebd2b706 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 f5e16182 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
 baf23092 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
 89445048 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
 d6cb2fd4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
 39c4dd93 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 bdde58bc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
 62729e79 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 ab738495 
  repository/src/test/java/org/apache/atlas/TestModules.java 4bc14872 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java
 5f011362 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStoreV1Test.java
 00d49779 


Diff: https://reviews.apache.org/r/61871/diff/2/

Changes: https://reviews.apache.org/r/61871/diff/1-2/


Testing
---

All unit tests passed.


Thanks,

Richard Ding



Re: Review Request 61871: ATLAS-2083: Refactor AtlasDefStore classes to reduce code duplication

2017-08-25 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61871/#review183833
---



Richard - can you please rebase the patch with the latest master and update the 
review? Thanks!

- Madhan Neethiraj


On Aug. 24, 2017, 12:08 a.m., Richard Ding wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61871/
> ---
> 
> (Updated Aug. 24, 2017, 12:08 a.m.)
> 
> 
> Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-2083
> https://issues.apache.org/jira/browse/ATLAS-2083
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> 1. Use generic interface to reduce code duplication
> 2. Move the common code in the implementation classes to the base class
> 3. Tighten the types required in the interface methods 
> 4. Move two test classes to the correct package
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
>  92a59f39 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasDefStore.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
>  08391ba5 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
>  d0f98e2f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStore.java
>  df67958b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
>  ebd2b706 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  22e14436 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
>  baf23092 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
>  89445048 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
>  d6cb2fd4 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
>  39c4dd93 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
>  bdde58bc 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
>  62729e79 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
>  50a42166 
>   repository/src/test/java/org/apache/atlas/TestModules.java 4bc14872 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java
>  5f011362 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStoreV1Test.java
>  00d49779 
> 
> 
> Diff: https://reviews.apache.org/r/61871/diff/1/
> 
> 
> Testing
> ---
> 
> All unit tests passed.
> 
> 
> Thanks,
> 
> Richard Ding
> 
>



Review Request 61871: ATLAS-2083: Refactor AtlasDefStore classes to reduce code duplication

2017-08-23 Thread Richard Ding via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61871/
---

Review request for atlas, Apoorv Naik, David Radley, Madhan Neethiraj, and 
Sarath Subramanian.


Bugs: ATLAS-2083
https://issues.apache.org/jira/browse/ATLAS-2083


Repository: atlas


Description
---

1. Use generic interface to reduce code duplication
2. Move the common code in the implementation classes to the base class
3. Tighten the types required in the interface methods 
4. Move two test classes to the correct package


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasClassificationDefStore.java
 92a59f39 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasDefStore.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStore.java
 08391ba5 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEnumDefStore.java
 d0f98e2f 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStore.java
 df67958b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasStructDefStore.java
 ebd2b706 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 22e14436 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasAbstractDefStoreV1.java
 baf23092 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasClassificationDefStoreV1.java
 89445048 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEntityDefStoreV1.java
 d6cb2fd4 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasEnumDefStoreV1.java
 39c4dd93 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasRelationshipDefStoreV1.java
 bdde58bc 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasStructDefStoreV1.java
 62729e79 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/AtlasTypeDefGraphStoreV1.java
 50a42166 
  repository/src/test/java/org/apache/atlas/TestModules.java 4bc14872 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasEntityDefStoreV1Test.java
 5f011362 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/AtlasRelationshipDefStoreV1Test.java
 00d49779 


Diff: https://reviews.apache.org/r/61871/diff/1/


Testing
---

All unit tests passed.


Thanks,

Richard Ding