Re: Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

2017-09-28 Thread Ramesh Mani 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62577/#review186582
---




repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Lines 121 (patched)


Please use ArrayUtils.isNotEmpty(modelsDirContents) if you can?


- Ramesh Mani


On Sept. 26, 2017, 3:06 p.m., Gergo Barna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62577/
> ---
> 
> (Updated Sept. 26, 2017, 3:06 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2176 defending against NPE during initialization  
> (AtlasTypeDefStoreInitializer.loadBootstrapTypeDefs)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  a65ec3a9ead1ce2fa91232bc56e601b31ccf750e 
> 
> 
> Diff: https://reviews.apache.org/r/62577/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gergo Barna
> 
>

Re: Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

2017-09-26 Thread Ashutosh Mestry 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62577/#review186288
---


Ship it!




Ship It!

- Ashutosh Mestry


On Sept. 26, 2017, 3:06 p.m., Gergo Barna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62577/
> ---
> 
> (Updated Sept. 26, 2017, 3:06 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2176 defending against NPE during initialization  
> (AtlasTypeDefStoreInitializer.loadBootstrapTypeDefs)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  a65ec3a9ead1ce2fa91232bc56e601b31ccf750e 
> 
> 
> Diff: https://reviews.apache.org/r/62577/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gergo Barna
> 
>

Re: Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

2017-09-26 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62577/#review186274
---


Ship it!




Ship It!

- Madhan Neethiraj


On Sept. 26, 2017, 3:06 p.m., Gergo Barna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62577/
> ---
> 
> (Updated Sept. 26, 2017, 3:06 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2176 defending against NPE during initialization  
> (AtlasTypeDefStoreInitializer.loadBootstrapTypeDefs)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  a65ec3a9ead1ce2fa91232bc56e601b31ccf750e 
> 
> 
> Diff: https://reviews.apache.org/r/62577/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gergo Barna
> 
>

Re: Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

2017-09-26 Thread Apoorv Naik 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62577/#review186272
---


Fix it, then Ship it!




Minor formatting change, otherwise looks good.


repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
Line 121 (original), 122 (patched)


Spaces instead of tabs


- Apoorv Naik


On Sept. 26, 2017, 3:06 p.m., Gergo Barna wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62577/
> ---
> 
> (Updated Sept. 26, 2017, 3:06 p.m.)
> 
> 
> Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-2176 defending against NPE during initialization  
> (AtlasTypeDefStoreInitializer.loadBootstrapTypeDefs)
> 
> 
> Diffs
> -
> 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  a65ec3a9ead1ce2fa91232bc56e601b31ccf750e 
> 
> 
> Diff: https://reviews.apache.org/r/62577/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Gergo Barna
> 
>

Review Request 62577: [ATLAS-2176] NegativeSSLAndKerberosTest failing due to error in initialization

2017-09-26 Thread Gergo Barna 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62577/
---

Review request for atlas, Madhan Neethiraj and Nixon Rodrigues.


Repository: atlas


Description
---

ATLAS-2176 defending against NPE during initialization  
(AtlasTypeDefStoreInitializer.loadBootstrapTypeDefs)


Diffs
-

  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 a65ec3a9ead1ce2fa91232bc56e601b31ccf750e 


Diff: https://reviews.apache.org/r/62577/diff/1/


Testing
---


Thanks,

Gergo Barna