[GitHub] [atlas] AmeerAssi edited a comment on pull request #98: AWS scheme is missing the aws account id that contains the S3 bucket.

2020-05-15 Thread GitBox 


AmeerAssi edited a comment on pull request #98:
URL: https://github.com/apache/atlas/pull/98#issuecomment-627370163


   @sarathkumarsubramanian kind reminder for this review.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [atlas] AmeerAssi edited a comment on pull request #98: AWS scheme is missing the aws account id that contains the S3 bucket.

2020-05-10 Thread GitBox 


AmeerAssi edited a comment on pull request #98:
URL: https://github.com/apache/atlas/pull/98#issuecomment-626381318


   > @AmeerAssi for existing deployments to add this attribute, can you please 
include a patch file to add this attribute? You can check a similar patch for 
reference - 
https://github.com/apache/atlas/blob/master/addons/models/3000-Cloud/patches/004-s3_add_attributes.json
   
   @sarathkumarsubramanian 
   AFAIK this model was never released with any Atlas version, can you please 
explain why this patch file is needed, as my understanding this patch file came 
for backward compatibility.
   
   in case this still needed, can you please explain what these properties mean 
in the mentioned json:
   "applyToVersion": "1.1",
"updateToVersion": "1.2"
   
   in my case what values should they have?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [atlas] AmeerAssi edited a comment on pull request #98: AWS scheme is missing the aws account id that contains the S3 bucket.

2020-05-04 Thread GitBox 


AmeerAssi edited a comment on pull request #98:
URL: https://github.com/apache/atlas/pull/98#issuecomment-620852203


   We are using Atlas models in our product.
   the product gives scan capabilities for customer's S3 in AWS.
   when scan result shown based on the model, it is missing for which account 
this bucket belongs. so it will be easy to access the account and review the 
scanned information by the customer.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org