[GitHub] [atlas] sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 'spark_application' type to avoid 'spark_process' from being updated for multiple operations

2020-03-05 Thread GitBox 
sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 
'spark_application' type to avoid 'spark_process' from being updated for 
multiple operations
URL: https://github.com/apache/atlas/pull/91#discussion_r388528238
 
 

 ##
 File path: addons/models/1000-Hadoop/1100-spark_model.json
 ##
 @@ -305,6 +305,34 @@
 }
   ]
 },
+{
+  "name": "spark_application",
+  "superTypes": [
+"Process"
+  ],
+  "serviceType": "spark",
+  "typeVersion": "1.0",
+  "attributeDefs": [
+{
+  "name": "currUser",
+  "typeName": "string",
+  "isOptional": true,
+  "cardinality": "SINGLE",
+  "isUnique": false,
+  "isIndexable": false,
+  "searchWeight": 10
+},
+{
+  "name": "remoteUser",
+  "typeName": "string",
+  "isOptional": true,
+  "cardinality": "SINGLE",
+  "isUnique": false,
+  "isIndexable": false,
 
 Review comment:
   isIndexable => true


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [atlas] sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 'spark_application' type to avoid 'spark_process' from being updated for multiple operations

2020-03-05 Thread GitBox 
sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 
'spark_application' type to avoid 'spark_process' from being updated for 
multiple operations
URL: https://github.com/apache/atlas/pull/91#discussion_r388528136
 
 

 ##
 File path: addons/models/1000-Hadoop/1100-spark_model.json
 ##
 @@ -305,6 +305,34 @@
 }
   ]
 },
+{
+  "name": "spark_application",
+  "superTypes": [
+"Process"
+  ],
+  "serviceType": "spark",
+  "typeVersion": "1.0",
+  "attributeDefs": [
+{
+  "name": "currUser",
+  "typeName": "string",
+  "isOptional": true,
+  "cardinality": "SINGLE",
+  "isUnique": false,
+  "isIndexable": false,
 
 Review comment:
   isIndexable => true


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [atlas] sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 'spark_application' type to avoid 'spark_process' from being updated for multiple operations

2020-03-05 Thread GitBox 
sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 
'spark_application' type to avoid 'spark_process' from being updated for 
multiple operations
URL: https://github.com/apache/atlas/pull/91#discussion_r388527692
 
 

 ##
 File path: addons/models/1000-Hadoop/1100-spark_model.json
 ##
 @@ -470,6 +498,24 @@
 "cardinality": "SINGLE"
   },
   "propagateTags": "NONE"
+},
+{
+  "name": "spark_application_process",
 
 Review comment:
   "spark_application_process" => "spark_application_processes"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [atlas] sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 'spark_application' type to avoid 'spark_process' from being updated for multiple operations

2020-03-05 Thread GitBox 
sarathsubramanian commented on a change in pull request #91: ATLAS-3655: Create 
'spark_application' type to avoid 'spark_process' from being updated for 
multiple operations
URL: https://github.com/apache/atlas/pull/91#discussion_r388527337
 
 

 ##
 File path: addons/models/1000-Hadoop/1100-spark_model.json
 ##
 @@ -305,6 +305,34 @@
 }
   ]
 },
+{
+  "name": "spark_application",
+  "superTypes": [
+"Process"
+  ],
+  "serviceType": "spark",
+  "typeVersion": "1.0",
+  "attributeDefs": [
+{
+  "name": "currUser",
 
 Review comment:
   consider renaming "currUser" to "currentUser"


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services