[jira] [Commented] (ATLAS-3116) Fix LDAP login, once a sign-on is made through knox SSO.

2019-04-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813168#comment-16813168
 ] 

ASF subversion and git services commented on ATLAS-3116:


Commit c477a6f6d1899211e7a7d9b67090b20757e28578 in atlas's branch 
refs/heads/master from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=c477a6f ]

ATLAS-3116:- Changed bean scope to prototype to fix LDAP login, once a sign-on 
is made through knox SSO.

Change-Id: Ia76852d1c4e13216c54d225e0cbcd1108fd2f402


> Fix LDAP login, once a sign-on is made through knox SSO.
> 
>
> Key: ATLAS-3116
> URL: https://issues.apache.org/jira/browse/ATLAS-3116
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.3, 1.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 0.8.4, 1.2.0, 2.0.0
>
> Attachments: ATLAS-3116.patch
>
>
> *Background of the issue.*
>  
> Dependency of AtlasAuthenticationProvider is Injected in two place from 
> constructor with @Inject 1) 
> [AtlasKnoxSSOFilter|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java#L102]
>  and 
> [AtlasSecurityConfig|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java#L72].
> After observing the hashCode of objects of the AtlasAuthenticationProvider 
> appeared to be same in respectively classes.
>  
> If no scope is specified single instance per container is created and thats 
> caused the bug described below.
>  
> The *ssoEnabled* is a property in AtlasAuthenticationProvider which set from 
> AtlasKnoxSSOFilter flow. Since the object reference were same, once the 
> ssoEnabled is set true,  it apply for LdapAuthentication flow also and the 
> [ldap authentication flow is goes in sso 
> block|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java#L92]
>  
> To fix the issue added scope prototype to AtlasAuthenticationProvider , so 
> that different objects are create in AtlasKnoxSSOFilter and 
> AtlasSecurityConfig respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-3116) Fix LDAP login, once a sign-on is made through knox SSO.

2019-04-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813167#comment-16813167
 ] 

ASF subversion and git services commented on ATLAS-3116:


Commit 8a8872c51f14c08d5280b8ba42b17f8d3c257dc5 in atlas's branch 
refs/heads/branch-2.0 from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=8a8872c ]

ATLAS-3116:- Changed bean scope to prototype to fix LDAP login, once a sign-on 
is made through knox SSO.

Change-Id: Ia76852d1c4e13216c54d225e0cbcd1108fd2f402


> Fix LDAP login, once a sign-on is made through knox SSO.
> 
>
> Key: ATLAS-3116
> URL: https://issues.apache.org/jira/browse/ATLAS-3116
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.3, 1.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 0.8.4, 1.2.0, 2.0.0
>
> Attachments: ATLAS-3116.patch
>
>
> *Background of the issue.*
>  
> Dependency of AtlasAuthenticationProvider is Injected in two place from 
> constructor with @Inject 1) 
> [AtlasKnoxSSOFilter|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java#L102]
>  and 
> [AtlasSecurityConfig|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java#L72].
> After observing the hashCode of objects of the AtlasAuthenticationProvider 
> appeared to be same in respectively classes.
>  
> If no scope is specified single instance per container is created and thats 
> caused the bug described below.
>  
> The *ssoEnabled* is a property in AtlasAuthenticationProvider which set from 
> AtlasKnoxSSOFilter flow. Since the object reference were same, once the 
> ssoEnabled is set true,  it apply for LdapAuthentication flow also and the 
> [ldap authentication flow is goes in sso 
> block|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java#L92]
>  
> To fix the issue added scope prototype to AtlasAuthenticationProvider , so 
> that different objects are create in AtlasKnoxSSOFilter and 
> AtlasSecurityConfig respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-3116) Fix LDAP login, once a sign-on is made through knox SSO.

2019-04-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813166#comment-16813166
 ] 

ASF subversion and git services commented on ATLAS-3116:


Commit 7e86cb30841b1ff9683fd121e3f8a17d2638e6e8 in atlas's branch 
refs/heads/branch-1.0 from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=7e86cb3 ]

ATLAS-3116:- Changed bean scope to prototype to fix LDAP login, once a sign-on 
is made through knox SSO.

Change-Id: Ia76852d1c4e13216c54d225e0cbcd1108fd2f402


> Fix LDAP login, once a sign-on is made through knox SSO.
> 
>
> Key: ATLAS-3116
> URL: https://issues.apache.org/jira/browse/ATLAS-3116
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.3, 1.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 0.8.4, 1.2.0, 2.0.0
>
> Attachments: ATLAS-3116.patch
>
>
> *Background of the issue.*
>  
> Dependency of AtlasAuthenticationProvider is Injected in two place from 
> constructor with @Inject 1) 
> [AtlasKnoxSSOFilter|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java#L102]
>  and 
> [AtlasSecurityConfig|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java#L72].
> After observing the hashCode of objects of the AtlasAuthenticationProvider 
> appeared to be same in respectively classes.
>  
> If no scope is specified single instance per container is created and thats 
> caused the bug described below.
>  
> The *ssoEnabled* is a property in AtlasAuthenticationProvider which set from 
> AtlasKnoxSSOFilter flow. Since the object reference were same, once the 
> ssoEnabled is set true,  it apply for LdapAuthentication flow also and the 
> [ldap authentication flow is goes in sso 
> block|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java#L92]
>  
> To fix the issue added scope prototype to AtlasAuthenticationProvider , so 
> that different objects are create in AtlasKnoxSSOFilter and 
> AtlasSecurityConfig respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-3116) Fix LDAP login, once a sign-on is made through knox SSO.

2019-04-09 Thread ASF subversion and git services (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813165#comment-16813165
 ] 

ASF subversion and git services commented on ATLAS-3116:


Commit 3781018cc9cfc71b680e4a57457315dc6083893d in atlas's branch 
refs/heads/branch-0.8 from Nixon Rodrigues
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=3781018 ]

ATLAS-3116:- Changed bean scope to prototype to fix LDAP login, once a sign-on 
is made through knox SSO.

Change-Id: Ia76852d1c4e13216c54d225e0cbcd1108fd2f402


> Fix LDAP login, once a sign-on is made through knox SSO.
> 
>
> Key: ATLAS-3116
> URL: https://issues.apache.org/jira/browse/ATLAS-3116
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.3, 1.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 0.8.4, 1.2.0, 2.0.0
>
> Attachments: ATLAS-3116.patch
>
>
> *Background of the issue.*
>  
> Dependency of AtlasAuthenticationProvider is Injected in two place from 
> constructor with @Inject 1) 
> [AtlasKnoxSSOFilter|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java#L102]
>  and 
> [AtlasSecurityConfig|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java#L72].
> After observing the hashCode of objects of the AtlasAuthenticationProvider 
> appeared to be same in respectively classes.
>  
> If no scope is specified single instance per container is created and thats 
> caused the bug described below.
>  
> The *ssoEnabled* is a property in AtlasAuthenticationProvider which set from 
> AtlasKnoxSSOFilter flow. Since the object reference were same, once the 
> ssoEnabled is set true,  it apply for LdapAuthentication flow also and the 
> [ldap authentication flow is goes in sso 
> block|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java#L92]
>  
> To fix the issue added scope prototype to AtlasAuthenticationProvider , so 
> that different objects are create in AtlasKnoxSSOFilter and 
> AtlasSecurityConfig respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (ATLAS-3116) Fix LDAP login, once a sign-on is made through knox SSO.

2019-04-09 Thread Sarath Subramanian (JIRA)


[ 
https://issues.apache.org/jira/browse/ATLAS-3116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16813024#comment-16813024
 ] 

Sarath Subramanian commented on ATLAS-3116:
---

+1 for patch - ATLAS-3116.patch

 

> Fix LDAP login, once a sign-on is made through knox SSO.
> 
>
> Key: ATLAS-3116
> URL: https://issues.apache.org/jira/browse/ATLAS-3116
> Project: Atlas
>  Issue Type: Bug
>Affects Versions: 0.8.3, 1.1.0
>Reporter: Nixon Rodrigues
>Assignee: Nixon Rodrigues
>Priority: Major
> Fix For: 0.8.4, 1.2.0, 2.0.0
>
> Attachments: ATLAS-3116.patch
>
>
> *Background of the issue.*
>  
> Dependency of AtlasAuthenticationProvider is Injected in two place from 
> constructor with @Inject 1) 
> [AtlasKnoxSSOFilter|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/filters/AtlasKnoxSSOAuthenticationFilter.java#L102]
>  and 
> [AtlasSecurityConfig|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasSecurityConfig.java#L72].
> After observing the hashCode of objects of the AtlasAuthenticationProvider 
> appeared to be same in respectively classes.
>  
> If no scope is specified single instance per container is created and thats 
> caused the bug described below.
>  
> The *ssoEnabled* is a property in AtlasAuthenticationProvider which set from 
> AtlasKnoxSSOFilter flow. Since the object reference were same, once the 
> ssoEnabled is set true,  it apply for LdapAuthentication flow also and the 
> [ldap authentication flow is goes in sso 
> block|https://github.com/apache/atlas/blob/master/webapp/src/main/java/org/apache/atlas/web/security/AtlasAuthenticationProvider.java#L92]
>  
> To fix the issue added scope prototype to AtlasAuthenticationProvider , so 
> that different objects are create in AtlasKnoxSSOFilter and 
> AtlasSecurityConfig respectively.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)