[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076919#comment-17076919
 ] 

ASF subversion and git services commented on ATLAS-3702:


Commit e20c3703a8873cb370f59103a88fb7ea2a99c92a in atlas's branch 
refs/heads/branch-2.0 from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=e20c370 ]

ATLAS-3702: Edge creation performance improvements. Part 2.


> Entity Creation: Improve Edge Creation
> --
>
> Key: ATLAS-3702
> URL: https://issues.apache.org/jira/browse/ATLAS-3702
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3702-Edge-creation-performance-improvements.-P.patch
>
>
> *Background*
> When creating entities with Atlas at scale, few inefficiencies were observed.
> They were:
>  * _GraphHelper.getAdjacentEdgesByLabel_: The existing approach results in 
> high memory usage. The method could use graph api that already exists.
>  * _AtlasRelationshipStoreV2.getRelationshipEdge_: This does full vertex 
> comparison. This is expensive.
>  * Edge label is not index. Indexing this will improve speed of edge by label 
> lookup.
> *Solution*
> Profile Atlas with (using metrics) to establish baseline.
> Use the fixes mentioned to the places above and profile.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076918#comment-17076918
 ] 

ASF subversion and git services commented on ATLAS-3702:


Commit 83c62c1d857c42c15d3f3ee2d2a831a1bba28caf in atlas's branch 
refs/heads/branch-2.0 from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=83c62c1 ]

ATLAS-3702: Edge creation performance improvements.


> Entity Creation: Improve Edge Creation
> --
>
> Key: ATLAS-3702
> URL: https://issues.apache.org/jira/browse/ATLAS-3702
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3702-Edge-creation-performance-improvements.-P.patch
>
>
> *Background*
> When creating entities with Atlas at scale, few inefficiencies were observed.
> They were:
>  * _GraphHelper.getAdjacentEdgesByLabel_: The existing approach results in 
> high memory usage. The method could use graph api that already exists.
>  * _AtlasRelationshipStoreV2.getRelationshipEdge_: This does full vertex 
> comparison. This is expensive.
>  * Edge label is not index. Indexing this will improve speed of edge by label 
> lookup.
> *Solution*
> Profile Atlas with (using metrics) to establish baseline.
> Use the fixes mentioned to the places above and profile.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-06 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076896#comment-17076896
 ] 

ASF subversion and git services commented on ATLAS-3702:


Commit 683e267bdf2e9461fbfdefe514e1856e32ce8e4b in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=683e267 ]

ATLAS-3702: Edge creation performance improvements. Part 2.


> Entity Creation: Improve Edge Creation
> --
>
> Key: ATLAS-3702
> URL: https://issues.apache.org/jira/browse/ATLAS-3702
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3702-Edge-creation-performance-improvements.-P.patch
>
>
> *Background*
> When creating entities with Atlas at scale, few inefficiencies were observed.
> They were:
>  * _GraphHelper.getAdjacentEdgesByLabel_: The existing approach results in 
> high memory usage. The method could use graph api that already exists.
>  * _AtlasRelationshipStoreV2.getRelationshipEdge_: This does full vertex 
> comparison. This is expensive.
>  * Edge label is not index. Indexing this will improve speed of edge by label 
> lookup.
> *Solution*
> Profile Atlas with (using metrics) to establish baseline.
> Use the fixes mentioned to the places above and profile.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-06 Thread Sarath Subramanian (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076495#comment-17076495
 ] 

Sarath Subramanian commented on ATLAS-3702:
---

+1 for the patch. Thanks [~amestry]

> Entity Creation: Improve Edge Creation
> --
>
> Key: ATLAS-3702
> URL: https://issues.apache.org/jira/browse/ATLAS-3702
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3702-Edge-creation-performance-improvements.-P.patch
>
>
> *Background*
> When creating entities with Atlas at scale, few inefficiencies were observed.
> They were:
>  * _GraphHelper.getAdjacentEdgesByLabel_: The existing approach results in 
> high memory usage. The method could use graph api that already exists.
>  * _AtlasRelationshipStoreV2.getRelationshipEdge_: This does full vertex 
> comparison. This is expensive.
>  * Edge label is not index. Indexing this will improve speed of edge by label 
> lookup.
> *Solution*
> Profile Atlas with (using metrics) to establish baseline.
> Use the fixes mentioned to the places above and profile.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-05 Thread Nikhil Bonte (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17076041#comment-17076041
 ] 

Nikhil Bonte commented on ATLAS-3702:
-

+1 for the part 2 patch.

Thanks Ashutosh for the patch.

> Entity Creation: Improve Edge Creation
> --
>
> Key: ATLAS-3702
> URL: https://issues.apache.org/jira/browse/ATLAS-3702
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3702-Edge-creation-performance-improvements.-P.patch
>
>
> *Background*
> When creating entities with Atlas at scale, few inefficiencies were observed.
> They were:
>  * _GraphHelper.getAdjacentEdgesByLabel_: The existing approach results in 
> high memory usage. The method could use graph api that already exists.
>  * _AtlasRelationshipStoreV2.getRelationshipEdge_: This does full vertex 
> comparison. This is expensive.
>  * Edge label is not index. Indexing this will improve speed of edge by label 
> lookup.
> *Solution*
> Profile Atlas with (using metrics) to establish baseline.
> Use the fixes mentioned to the places above and profile.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-05 Thread Ashutosh Mestry (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17075971#comment-17075971
 ] 

Ashutosh Mestry commented on ATLAS-3702:


Attached is a part 2 of the earlier patch. There was an equality check which 
was missed in earlier patch.

> Entity Creation: Improve Edge Creation
> --
>
> Key: ATLAS-3702
> URL: https://issues.apache.org/jira/browse/ATLAS-3702
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
> Attachments: 
> ATLAS-3702-Edge-creation-performance-improvements.-P.patch
>
>
> *Background*
> When creating entities with Atlas at scale, few inefficiencies were observed.
> They were:
>  * _GraphHelper.getAdjacentEdgesByLabel_: The existing approach results in 
> high memory usage. The method could use graph api that already exists.
>  * _AtlasRelationshipStoreV2.getRelationshipEdge_: This does full vertex 
> comparison. This is expensive.
>  * Edge label is not index. Indexing this will improve speed of edge by label 
> lookup.
> *Solution*
> Profile Atlas with (using metrics) to establish baseline.
> Use the fixes mentioned to the places above and profile.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (ATLAS-3702) Entity Creation: Improve Edge Creation

2020-04-02 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/ATLAS-3702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073969#comment-17073969
 ] 

ASF subversion and git services commented on ATLAS-3702:


Commit 159afa8044fac64436268e1f64bfe43beff65096 in atlas's branch 
refs/heads/master from Ashutosh Mestry
[ https://gitbox.apache.org/repos/asf?p=atlas.git;h=159afa8 ]

ATLAS-3702: Edge creation performance improvements.


> Entity Creation: Improve Edge Creation
> --
>
> Key: ATLAS-3702
> URL: https://issues.apache.org/jira/browse/ATLAS-3702
> Project: Atlas
>  Issue Type: Improvement
>  Components:  atlas-core
>Affects Versions: trunk
>Reporter: Ashutosh Mestry
>Assignee: Ashutosh Mestry
>Priority: Major
> Fix For: trunk
>
>
> *Background*
> When creating entities with Atlas at scale, few inefficiencies were observed.
> They were:
>  * _GraphHelper.getAdjacentEdgesByLabel_: The existing approach results in 
> high memory usage. The method could use graph api that already exists.
>  * _AtlasRelationshipStoreV2.getRelationshipEdge_: This does full vertex 
> comparison. This is expensive.
>  * Edge label is not index. Indexing this will improve speed of edge by label 
> lookup.
> *Solution*
> Profile Atlas with (using metrics) to establish baseline.
> Use the fixes mentioned to the places above and profile.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)