Friendly ping. Sent from my iPhone
Begin forwarded message: > From: Bolke de Bruin <bdbr...@gmail.com> > Date: 16 September 2019 at 21:11:17 CEST > To: Aadarsh Jajodia <aadarshjajo...@gmail.com>, Ashutosh Mestry > <ames...@cloudera.com>, Sridhar K <sridhar4apa...@gmail.com>, Le Ma > <constance.m...@gmail.com>, Nixon Rodrigues > <nixon.rodrig...@freestoneinfotech.com>, Madhan Neethiraj <mad...@apache.org> > Cc: Sarath Subramanian <sar...@apache.org>, atlas > <d...@atlas.incubator.apache.org>, Bolke de Bruin <bdbr...@gmail.com> > Subject: Re: Review Request 71431: Add indexed order by (sort) to basic search > Reply-To: Bolke de Bruin <bdbr...@gmail.com> > > > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71431/ > > On September 16th, 2019, 7:05 p.m. UTC, Madhan Neethiraj wrote: > > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java (Diff > revision 4) > 272 > FilterCriteria filterCriteria = new FilterCriteria(); > Instead of creating FilterCriteria, consider using lines #263 - #265 here: > if (StringUtils.isNotEmpty(attributeName) && > structType.getAttributeType(attributeName) == null) { > throw new AtlasBaseException(AtlasErrorCode.UNKNOWN_ATTRIBUTE, > attributeName, structType.getTypeName()); > > Better yet, update 'else' block at #260 to call this method: > } else { > validateAttribute(structType, filterCriteria.getAttributeName(); > } > Nice. I was struggling with that a bit. Fixed. > > - Bolke > > > On September 16th, 2019, 7:10 p.m. UTC, Bolke de Bruin wrote: > > Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, > Madhan Neethiraj, and Nixon Rodrigues. > By Bolke de Bruin. > Updated Sept. 16, 2019, 7:10 p.m. > > Bugs: https://issues.apache.org/jira/browse/ATLAS-3399 > Repository: atlas > Description > > Add indexed order by to basic search. > Testing > > production and tests added > Diffs > > graphdb/api/src/main/java/org/apache/atlas/repository/graphdb/AtlasIndexQuery.java > (f3722b827) > graphdb/janus/src/main/java/org/apache/atlas/repository/graphdb/janus/AtlasJanusIndexQuery.java > (7c258b7a3) > graphdb/janus/src/main/java/org/janusgraph/diskstorage/solr/Solr6Index.java > (e457866af) > intg/src/main/java/org/apache/atlas/model/discovery/SearchParameters.java > (aac6b5aa3) > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > (479ddfd89) > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > (f7d8f08c7) > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > (9bd0382eb) > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java (e6b338b84) > webapp/src/test/java/org/apache/atlas/web/integration/BasicSearchIT.java > (06931b38c) > webapp/src/test/resources/json/search-parameters/entity-filters.json > (f4b2efe63) > webapp/src/test/resources/json/search-parameters/tag-filters.json (5e74328d6) > View Diff
