-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61246/#review181838
-----------------------------------------------------------


Ship it!




Ship It!

- Apoorv Naik


On July 30, 2017, 6:53 p.m., Madhan Neethiraj wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61246/
> -----------------------------------------------------------
> 
> (Updated July 30, 2017, 6:53 p.m.)
> 
> 
> Review request for atlas.
> 
> 
> Bugs: ATLAS-2008
>     https://issues.apache.org/jira/browse/ATLAS-2008
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Gremlin query used in tag-attribute filtering fails when the filter includes 
> attributes of numeric type - due to Gremlin parsing integer values to 
> java.lang.Integer (which causes comparision with double/dloat/.. attribute 
> values to fail) and float/double values to java.math.BigDecimal (which causes 
> comparision with float/double type attributes to fail). Use of bind variables 
> in queries resolves this issue.
> 
> Also, renamed variable names that incorrectly referenced "gremlin" to "graph" 
> and "solr" to "index".
> 
> 
> Diffs
> -----
> 
>   
> repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java
>  f94d24b1 
>   
> repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java
>  59fed173 
>   repository/src/main/java/org/apache/atlas/discovery/SearchProcessor.java 
> 31d145cd 
> 
> 
> Diff: https://reviews.apache.org/r/61246/diff/1/
> 
> 
> Testing
> -------
> 
> Verified that tag-filtering executes correctly for numeric, date, string, 
> enum type attributes.
> 
> 
> Thanks,
> 
> Madhan Neethiraj
> 
>

Reply via email to