Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-02 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61274/#review182029 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 2, 2017, 8:48 a

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-02 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61274/#review182027 --- In _commit_ needs: _(offset + 1)_ See this: http://kafka.apache.

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-02 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61274/ --- (Updated Aug. 2, 2017, 8:48 a.m.) Review request for atlas, Apoorv Naik, Ashuto

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-02 Thread Nixon Rodrigues
> On Aug. 1, 2017, 8:12 p.m., Ashutosh Mestry wrote: > > Can you please let me know the testing performed to verify this. I am > > little hesitent because this removes _ShutdownableThread_. > > > > See attached my patch that merely calls _shutdown_ on consumer thread. I > > have done some test

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-02 Thread Nixon Rodrigues
> On Aug. 1, 2017, 4:25 p.m., Apoorv Naik wrote: > > webapp/src/main/java/org/apache/atlas/notification/NotificationHookConsumer.java > > Lines 221 (patched) > > > > > > LOG.info => LOG.debug Apoorv, this is logged

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-01 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61274/#review181916 --- Can you please let me know the testing performed to verify this. I

Re: Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-01 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61274/#review181900 --- webapp/src/main/java/org/apache/atlas/notification/NotificationHo

Review Request 61274: ATLAS-1944 - Fix for ConcurrentModificationException Exception in HookConsumer (KafkaConsumer) while stopping Atlas server

2017-08-01 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61274/ --- Review request for atlas, Apoorv Naik, Ashutosh Mestry, Madhan Neethiraj, and Sa