----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63451/#review189794 -----------------------------------------------------------
I don't think this actually fixes the problem. The reason the test (as it stands) survives is largely done to the buug in the final assertion of the test. If the test fails to return the edge then the bug in assertEdge will have returned true; and it only needs one of the edges to be present to pass the test. All of which I think camouflages the actual problem with duplicated schema vertices in the graph schema. - Graham Wallis On Oct. 31, 2017, 10:21 p.m., Sarath Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63451/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2017, 10:21 p.m.) > > > Review request for atlas. > > > Bugs: ATLAS-2240 > https://issues.apache.org/jira/browse/ATLAS-2240 > > > Repository: atlas > > > Description > ------- > > Fix and enable unit test testConcurrentCalls() and duplicate type name error > in QuickStartV2IT: > > runQuickStart(org.apache.atlas.examples.QuickStartV2IT) Time elapsed: 1.632 > sec <<< FAILURE! > org.apache.atlas.AtlasServiceException: Metadata service API > org.apache.atlas.AtlasClientV2$API_V2@6574c8a failed with status 409 > (Conflict) Response Body > ({"errorCode":"ATLAS-409-00-001","errorMessage":"Given type Dimension already > exists"}) > > > Diffs > ----- > > > repository/src/test/java/org/apache/atlas/repository/graph/GraphBackedMetadataRepositoryTest.java > 6e0245a5 > webapp/src/test/java/org/apache/atlas/web/integration/BaseResourceIT.java > aba0cf9b > > webapp/src/test/java/org/apache/atlas/web/integration/DataSetLineageJerseyResourceIT.java > 1a65daba > > > Diff: https://reviews.apache.org/r/63451/diff/1/ > > > Testing > ------- > > mvn clean package -DGRAPH-PROVIDER=janus > mvn clean package -DGRAPH-PROVIDER=titan0 > > > Thanks, > > Sarath Subramanian > >
