Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review196317 --- Ship it! Ship It! - David Radley On Jan. 19, 2018, 9:30 a.m.

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 18, 2018, 8:51 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java > > Lines 76 (patched) > > > > > > should this.name=name put into a else{}? after we check the

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Jan. 19, 2018, 9:30 a.m.) Review request for atlas and Madhan Neethira

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 18, 2018, 8:51 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java > > Lines 76 (patched) > > > > > > should this.name=name put into a else{}? after we check the

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 18, 2018, 8:51 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java > > Lines 76 (patched) > > > > > > should this.name=name put into a else{}? after we check the

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 18, 2018, 9:19 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalIdentifier.java > > Lines 83 (patched) > > > > > > here in the typical constructor, you checked the sco

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 18, 2018, 8:51 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java > > Lines 76 (patched) > > > > > > should this.name=name put into a else{}? after we check the

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 18, 2018, 8:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java > > Lines 46 (patched) > > > > > > for a Connected Asset's properties you list here, which on

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 18, 2018, 8:55 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java > > Lines 81 (patched) > > > > > > should this.type=type put after we check if type!=null? T

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java > > Lines 43 (patched) > > > > > > can you explain the relationship among "totalElement", "

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195700 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/External

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195698 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSum

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195697 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Informal

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/CommentType.java > > Lines 30 (patched) > > > > > > Some forums also have 'accepted answer' which is updat

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/StarRating.java > > Lines 28 (patched) > > > > > > Why 'UNRATED' ? This is an explicit rating so wouldn't

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/StarRating.java > > Lines 28 (patched) > > > > > > Why 'UNRATED' ? This is an explicit rating so wouldn't

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Ratings.java > > Lines 28 (patched) > > > > > > I see this class follows the common patterns for returning

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Location.java > > Lines 53 (patched) > > > > > > If we had something we wanted to store GPS coords for wou

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/InformalTag.java > > Lines 128 (patched) > > > > > > how can sse -> who can see :) thanks - fixed - Ma

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ExternalReference.java > > Lines 52 (patched) > > > > > > how are you using the url vs uri parameters here

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java > > Lines 30 (patched) > > > > > > So we are using userids everywhere... so if a user changes

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:13 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java > > Lines 65 (patched) > > > > > > should here also initialize the two strings as ""? for al

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:26 p.m., Nigel Jones wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java > > Lines 54 (patched) > > > > > > Typo - qualifiedNAme used, assume qualifiedName needed Tha

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195590 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.j

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195608 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementO

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:11 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaType.java > > Lines 28 (patched) > > > > > > should here also initialize the two strings as ""? for all t

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195605 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaTy

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 4:06 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java > > Lines 29 (patched) > > > > > > for all the properties/* class, you delete the ori

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195603 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Addition

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java > > Lines 43 (patched) > > > > > > can you explain the relationship among "totalElement", "

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java > > Lines 91 (patched) > > > > > > is it necessary to check whether template.getLinkedAttribute

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaLink.java > > Lines 65 (patched) > > > > > > is it necessary to check whether linkedAttributeGUIDS is nul

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:27 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaImplementationQuery.java > > Lines 52 (patched) > > > > > > is it necessary to check whether queryTargetE

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaAttribute.java > > Lines 64 (patched) > > > > > > is it necessar to check whether attributeType is null?

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Schema.java > > Lines 109 (patched) > > > > > > is it necessary to check whether schemaAttributes and schemaLi

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedMediaReference.java > > Lines 92 (patched) > > > > > > is it necessary to check whether mediaUsageList i

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/RelatedAsset.java > > Lines 75 (patched) > > > > > > is it necessary to check whether relatedAssetProperties is

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Referenceable.java > > Lines 65 (patched) > > > > > > is it necessary to check additionalProperties, meanings a

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 3:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PagingIterator.java > > Lines 88 (patched) > > > > > > in AssetPropertyIteratorBase, you have the constructor >

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195588 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/SchemaIm

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 9:36 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementOrigin.java > > Lines 31 (patched) > > > > > > change "Id" to "id" Fixed - Mandy --

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 16, 2018, 12:32 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java > > Lines 21 (patched) > > > > > > here should be AssetPropertyBase, there is no class

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 16, 2018, 12:09 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java > > Lines 81 (patched) > > > > > > should be this.guid= = templateAssetDescriptor.getGUID

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 16, 2018, 12:09 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDescriptor.java > > Lines 64 (patched) > > > > > > guid is not used in the constructor Good spot - it ne

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 12, 2018, 3:53 p.m., David Radley wrote: > > om-fwk-ocf/pom.xml > > Lines 1 (patched) > > > > > > When I build, versionName is not accepted on my system - it wants > > version here. Agreed - I corrupted th

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195564 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PagingIt

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 8:54 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUniverse.java > > Lines 117 (patched) > > > > > > is it necessary to check whether meanings, analysis etc

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 8:54 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Certification.java > > Lines 104 (patched) > > > > > > is it necessary to check whether link is null? No beca

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 8:54 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Comment.java > > Lines 68 (patched) > > > > > > is it necessary to check whether commentReplies is null? No be

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 9:36 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java > > Lines 105 (patched) > > > > > > I am confused about the use of cloneIterator. th

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 2:18 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/EmbeddedConnection.java > > Lines 48 (patched) > > > > > > is it necessary to check whether embeddedConnectionP

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 2:18 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Feedback.java > > Lines 48 (patched) > > > > > > is it necessary to check whether informalTags, likes, ratings

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 2:18 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/License.java > > Lines 100 (patched) > > > > > > is it necessary to check whether link is null? it is not nec

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 2:30 p.m., Nigel Jones wrote: > > om-fwk-ocf/pom.xml > > Lines 51 (patched) > > > > > > Same here > > [ERROR] Malformed POM > > /Users/jonesn/IdeaProjects/atlas/om-fwk-ocf/pom.xml: Unrecognis

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 2:27 p.m., Nigel Jones wrote: > > om-fwk-ocf/pom.xml > > Lines 1 (patched) > > > > > > Same issue here.. > > > > [ERROR] [ERROR] Some problems were encountered while processing the > > POM

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 2:18 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/MapSchemaElement.java > > Lines 80 (patched) > > > > > > is it necessary to check whether mapFrom/ToElement are

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 8:54 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java > > Lines 163 (patched) > > > > > > is it necessary to check whether connectorType, endpoint a

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 9:36 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedSchemaElement.java > > Lines 85 (patched) > > > > > > is it necessary to check whether the queries is nu

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 9:36 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ElementHeader.java > > Lines 60 (patched) > > > > > > is it necessary to check whether classfications is null?

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 17, 2018, 9:39 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AdditionalProperties.java > > Lines 56 (patched) > > > > > > here you checked whether additionalProperties is n

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195566 --- om-fwk-ocf/pom.xml Lines 51 (patched)

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195565 --- om-fwk-ocf/pom.xml Lines 1 (patched)

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195547 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Embedded

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195546 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Addition

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195540 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/DerivedS

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195536 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetUni

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 16, 2018, 10:44 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java > > Lines 132 (patched) > > > > > > do you need to check whether additionalProperties and >

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 16, 2018, 12:16 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java > > Lines 96 (patched) > > > > > > is that necessary to check whether assetProperties, classf

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 16, 2018, 12:32 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPropertyBase.java > > Lines 56 (patched) > > > > > > here in the parameters, does parentAsset equal to t

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Jan. 16, 2018, 12:32 p.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetSummary.java > > Lines 111 (patched) > > > > > > is it necessary to check whether classfications is null

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195450 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDet

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195449 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetPro

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195448 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDet

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195447 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDes

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195444 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotati

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review195325 --- om-fwk-ocf/pom.xml Lines 1 (patched)

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/ --- (Updated Jan. 12, 2018, 1:13 p.m.) Review request for atlas and Madhan Neethira

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:29 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java > > Lines 64 (patched) > > > > > > I suggest you add toString, hashCode and equals metho

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:29 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connections.java > > Lines 71 (patched) > > > > > > for (Connection templateConnection :templateConnecti

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java > > Lines 49 (patched) > > > > > > For consistency with other examples, the quoted system ac

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Annotation.java > > Lines 442 (patched) > > > > > > typo "may have looked an (at?) multiple annotations

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Analysis.java > > Lines 1 (patched) > > > > > > Just an observation; in this Analysis class you construct

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 14, 2017, 10:06 a.m., Yao Li wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java > > Lines 134 (patched) > > > > > > Do you mean in the ConnectorProvider class, it doesn't > > se

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:29 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java > > Lines 22 (patched) > > > > > > Looking at https://www.slf4j.org/licens

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java > > Lines 70 (patched) > > > > > > Consider adding a constructor to Exception class that tak

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/ConnectedAssetProperties.java > > Lines 128 (patched) > > > > > > If a sub class has not over-ridden re

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/AssetDetail.java > > Lines 153 (patched) > > > > > > You *could* use the 'elvis' operator (?:) for the

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java > > Lines 183 (patched) > > > > > > Consider dropping prefix "new" in the parameter names

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ffdc/OCFErrorCode.java > > Lines 227 (patched) > > > > > > Consider changing "String... params" to "Object... pa

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java > > Lines 185 (patched) > > > > > > Comment should say '...class cast exception...' Well spo

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java > > Lines 121 (patched) > > > > > > Did you mean 'whenever setConnectedAssetProperties() is cal

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 5, 2017, 10:46 a.m., Graham Wallis wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java > > Lines 93 (patched) > > > > > > Did you mean 'whenever setConnectedAssetProperties() is called' ?

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorProvider.java > > Lines 37 (patched) > > > > > > Similar to earlier comment on Connector & ConnectorBase

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBroker.java > > Lines 70 (patched) > > > > > > Consider adding a constructor to Exception class that tak

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63503/#review192838 --- om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java Line

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 1, 2017, 9:32 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/PrimitiveSchemaElement.java > > Lines 18 (patched) > > > > > > The patch I applied to my Intellij containe

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/ConnectorBase.java > > Lines 53 (patched) > > > > > > consider renaming "log" to "LOG" - to be consistent with re

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java > > Lines 97 (patched) > > > > > > If a connector object is specific to an asset, having a set() m

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Dec. 4, 2017, 8:19 p.m., Madhan Neethiraj wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/Connector.java > > Lines 60 (patched) > > > > > > Instead of defining an interface and a base implementation (Con

Re: Review Request 63503: ATLAS-1095 - Review of OCF - the Open Connector Framework

> On Nov. 30, 2017, 10:29 a.m., David Radley wrote: > > om-fwk-ocf/src/main/java/org/apache/atlas/ocf/properties/Connection.java > > Lines 64 (patched) > > > > > > I suggest you add toString, hashCode and equals metho

  1   2   >