Re: Review Request 65033: Advanced Search Documentation Update

2018-02-01 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/ --- (Updated Feb. 2, 2018, 1:42 a.m.) Review request for atlas, Apoorv Naik and

Re: Review Request 65033: Advanced Search Documentation Update

2018-02-01 Thread Ashutosh Mestry
> On Feb. 1, 2018, 7:29 p.m., Apoorv Naik wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 72 (patched) > > > > > > has 3 characters -> any 3 character > > > > followed by at least 1 character,

Re: Review Request 65033: Advanced Search Documentation Update

2018-02-01 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/#review196647 --- Fix it, then Ship it!

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-31 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/ --- (Updated Feb. 1, 2018, 1:28 a.m.) Review request for atlas, Apoorv Naik and

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-31 Thread Ashutosh Mestry
> On Jan. 31, 2018, 6:40 p.m., Apoorv Naik wrote: > > docs/src/site/twiki/Search-Advanced.twiki > > Lines 58 (patched) > > > > > > Do we support IN clause for this case ? We have this already. We use 'has' and

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-31 Thread Apoorv Naik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/#review196573 --- docs/src/site/twiki/Search-Advanced.twiki Lines 27 (patched)

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-30 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/ --- (Updated Jan. 31, 2018, 6:34 a.m.) Review request for atlas, Apoorv Naik and

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-09 Thread Ashutosh Mestry
> On Jan. 9, 2018, 12:16 p.m., Graham Wallis wrote: > > Thanks for the review. I have tried to address most of the review comments. Few items I have dropped not because they were not valuable but only because I thought that they were not in scope of this exercise. > On Jan. 9, 2018, 12:16

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-09 Thread Ashutosh Mestry
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/ --- (Updated Jan. 10, 2018, 12:45 a.m.) Review request for atlas, Apoorv Naik and

Re: Review Request 65033: Advanced Search Documentation Update

2018-01-09 Thread Graham Wallis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65033/#review195026 --- docs/src/site/twiki/Search-Advanced.twiki Lines 21 (patched)