Re: Review Request 65632: ATLAS-2441 : UI : DSL Search : type select __guid doesn't display result though the result has GUID response.

2018-02-14 Thread keval bhatt

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65632/#review197511
---


Ship it!




Ship It!

- keval bhatt


On Feb. 14, 2018, 11:05 a.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65632/
> ---
> 
> (Updated Feb. 14, 2018, 11:05 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
> Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2441
> https://issues.apache.org/jira/browse/ATLAS-2441
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> DSL query 
> hive_table select __guid
> 
> results all the guids. But the UI doesn't display them.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b3f339b 
> 
> 
> Diff: https://reviews.apache.org/r/65632/diff/2/
> 
> 
> Testing
> ---
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>



Re: Review Request 65632: ATLAS-2441 : UI : DSL Search : type select __guid doesn't display result though the result has GUID response.

2018-02-13 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65632/#review197454
---



With this patch, __guid field is rendered in search-results page. However, it 
will be good to add a hyperlink on the guid value - to the entity details page.

- Madhan Neethiraj


On Feb. 13, 2018, 10:33 a.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65632/
> ---
> 
> (Updated Feb. 13, 2018, 10:33 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
> Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2441
> https://issues.apache.org/jira/browse/ATLAS-2441
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> DSL query 
> hive_table select __guid
> 
> results all the guids. But the UI doesn't display them.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/views/search/SearchResultLayoutView.js b3f339b 
> 
> 
> Diff: https://reviews.apache.org/r/65632/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>



Review Request 65632: ATLAS-2441 : UI : DSL Search : type select __guid doesn't display result though the result has GUID response.

2018-02-13 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65632/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2441
https://issues.apache.org/jira/browse/ATLAS-2441


Repository: atlas


Description
---

DSL query 
hive_table select __guid

results all the guids. But the UI doesn't display them.


Diffs
-

  dashboardv2/public/js/views/search/SearchResultLayoutView.js b3f339b 


Diff: https://reviews.apache.org/r/65632/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey