Re: Review Request 65633: ATLAS-2440 : UI , select on "date" attribute results value in long format instead of formatted date

2018-02-14 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65633/
---

(Updated Feb. 14, 2018, 9:49 a.m.)


Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Changes
---

review request comment handled.


Bugs: ATLAS-2440
https://issues.apache.org/jira/browse/ATLAS-2440


Repository: atlas


Description
---

query :

hive_table select createTime 
lists the createTime in long format.

On detailsPage or results page of basic search , the value is formatted date 
and not long value.


Diffs (updated)
-

  dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 


Diff: https://reviews.apache.org/r/65633/diff/2/

Changes: https://reviews.apache.org/r/65633/diff/1-2/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey



Re: Review Request 65633: ATLAS-2440 : UI , select on "date" attribute results value in long format instead of formatted date

2018-02-13 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65633/#review197455
---



Even with this page, search-results for "hive_table select createTime" shows 
the attribute value as a long. Also, please update to render system attributes 
__timestamp and __modificationTimestamp as date value.

- Madhan Neethiraj


On Feb. 13, 2018, 10:37 a.m., pratik pandey wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65633/
> ---
> 
> (Updated Feb. 13, 2018, 10:37 a.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
> Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2440
> https://issues.apache.org/jira/browse/ATLAS-2440
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> query :
> 
> hive_table select createTime 
> lists the createTime in long format.
> 
> On detailsPage or results page of basic search , the value is formatted date 
> and not long value.
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 
> 
> 
> Diff: https://reviews.apache.org/r/65633/diff/1/
> 
> 
> Testing
> ---
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>



Review Request 65633: ATLAS-2440 : UI , select on "date" attribute results value in long format instead of formatted date

2018-02-13 Thread pratik pandey

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65633/
---

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and 
Sharmadha Sainath.


Bugs: ATLAS-2440
https://issues.apache.org/jira/browse/ATLAS-2440


Repository: atlas


Description
---

query :

hive_table select createTime 
lists the createTime in long format.

On detailsPage or results page of basic search , the value is formatted date 
and not long value.


Diffs
-

  dashboardv2/public/js/utils/CommonViewFunction.js 6a5fe25 


Diff: https://reviews.apache.org/r/65633/diff/1/


Testing
---

Done one round of sanity testing.


Thanks,

pratik pandey