Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

atlas <d...@atlas.incubator.apache.org>, Ashutosh Mestry <ames...@hortonworks.com> Date: 25/05/2018 14:40 Subject: Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds Graham, Please let me know if you need this commit to be included in 1.0 release

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

atlas.incubator.apache.org> Subject: Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/ Ship it! Ship It! - Madhan Neethiraj On May 25th, 2018, 12

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review203874 --- Ship it! Ship It! - Madhan Neethiraj On May 25, 2018, 12:47

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/ --- (Updated May 25, 2018, 12:47 p.m.) Review request for atlas, Ashutosh Mestry

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

> On May 16, 2018, 4:37 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > > Lines 77 (patched) > > > > > > Shouldn't homeId be added to AtlasObjectId as well?

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review203344 --- Ship it! Ship It! - Madhan Neethiraj On May 10, 2018, 2:52

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

> On May 16, 2018, 4:37 p.m., Madhan Neethiraj wrote: > > intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java > > Lines 77 (patched) > > > > > > Shouldn't homeId be added to AtlasObjectId as well?

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review203241 ---

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/ --- (Updated May 10, 2018, 2:52 p.m.) Review request for atlas, Ashutosh Mestry

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

> On May 7, 2018, 6:29 p.m., Ashutosh Mestry wrote: > > Ship It! Thanks Ashutosh - I have made changes in the latest patch to address the raised issues. I don't believe any of the changes make a functional difference to the code. - Graham

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

> On May 4, 2018, 12:04 p.m., David Radley wrote: > > intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java > > Line 384 (original), 389 (patched) > > > > > > I suggest adding a comment here, around why you

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/ --- (Updated May 10, 2018, 1:11 p.m.) Review request for atlas, Ashutosh Mestry

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

> On May 4, 2018, 12:04 p.m., David Radley wrote: > > common/src/main/java/org/apache/atlas/repository/Constants.java > > Lines 80 (patched) > > > > > > I suggest a comment here to describe how an Atlas developer

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review202564 --- Ship it! Ship It! - Ashutosh Mestry On May 4, 2018, 10:55

Re: Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/#review202433 --- common/src/main/java/org/apache/atlas/repository/Constants.java

Review Request 66949: ATLAS-2523: changes to accept external GUIDs and manage homeIds

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66949/ --- Review request for atlas, Ashutosh Mestry and Madhan Neethiraj. Repository: