Re: Review Request 68998: ATLAS-29018: Update JanusGraph version to 0.3.1
> On Oct. 12, 2018, 1:50 a.m., Graham Wallis wrote: > > Hi Sarath - Looks fine - just wondering why you moved the janus.version up > > to the root POM - I think I put in the janus module POM and kept it with > > the tinkerpop.version. Would it be worth moving both/neither? > > All the best > > Graham Hi Graham, I was thinking ti would be easier to maintain the component versions in the parent pom than in individual components. Since we don't maintain multiple janus versions. I will move tinkerpop versions also to the parent pom. - Sarath --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68998/#review209480 --- On Oct. 11, 2018, 12:56 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68998/ > --- > > (Updated Oct. 11, 2018, 12:56 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2918 > https://issues.apache.org/jira/browse/ATLAS-2918 > > > Repository: atlas > > > Description > --- > > Janusgraph community has released their latest version: > > https://github.com/JanusGraph/janusgraph/releases/tag/v0.3.1 > > This JIRA will update janus version to 0.3.1 in atlas source. > > > Diffs > - > > graphdb/janus/pom.xml cd5c82ee2 > intg/src/test/resources/atlas-application.properties 7e74d5107 > pom.xml 92b3218ed > > > Diff: https://reviews.apache.org/r/68998/diff/1/ > > > Testing > --- > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/754/console > > > Thanks, > > Sarath Subramanian > >
Re: Review Request 68998: ATLAS-29018: Update JanusGraph version to 0.3.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68998/#review209480 --- Hi Sarath - Looks fine - just wondering why you moved the janus.version up to the root POM - I think I put in the janus module POM and kept it with the tinkerpop.version. Would it be worth moving both/neither? All the best Graham - Graham Wallis On Oct. 11, 2018, 7:56 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68998/ > --- > > (Updated Oct. 11, 2018, 7:56 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2918 > https://issues.apache.org/jira/browse/ATLAS-2918 > > > Repository: atlas > > > Description > --- > > Janusgraph community has released their latest version: > > https://github.com/JanusGraph/janusgraph/releases/tag/v0.3.1 > > This JIRA will update janus version to 0.3.1 in atlas source. > > > Diffs > - > > graphdb/janus/pom.xml cd5c82ee2 > intg/src/test/resources/atlas-application.properties 7e74d5107 > pom.xml 92b3218ed > > > Diff: https://reviews.apache.org/r/68998/diff/1/ > > > Testing > --- > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/754/console > > > Thanks, > > Sarath Subramanian > >
Re: Review Request 68998: ATLAS-29018: Update JanusGraph version to 0.3.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68998/#review209467 --- Ship it! Ship It! - Madhan Neethiraj On Oct. 11, 2018, 7:56 p.m., Sarath Subramanian wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68998/ > --- > > (Updated Oct. 11, 2018, 7:56 p.m.) > > > Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. > > > Bugs: ATLAS-2918 > https://issues.apache.org/jira/browse/ATLAS-2918 > > > Repository: atlas > > > Description > --- > > Janusgraph community has released their latest version: > > https://github.com/JanusGraph/janusgraph/releases/tag/v0.3.1 > > This JIRA will update janus version to 0.3.1 in atlas source. > > > Diffs > - > > graphdb/janus/pom.xml cd5c82ee2 > intg/src/test/resources/atlas-application.properties 7e74d5107 > pom.xml 92b3218ed > > > Diff: https://reviews.apache.org/r/68998/diff/1/ > > > Testing > --- > > https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/754/console > > > Thanks, > > Sarath Subramanian > >
Review Request 68998: ATLAS-29018: Update JanusGraph version to 0.3.1
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68998/ --- Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj. Bugs: ATLAS-2918 https://issues.apache.org/jira/browse/ATLAS-2918 Repository: atlas Description --- Janusgraph community has released their latest version: https://github.com/JanusGraph/janusgraph/releases/tag/v0.3.1 This JIRA will update janus version to 0.3.1 in atlas source. Diffs - graphdb/janus/pom.xml cd5c82ee2 intg/src/test/resources/atlas-application.properties 7e74d5107 pom.xml 92b3218ed Diff: https://reviews.apache.org/r/68998/diff/1/ Testing --- https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/754/console Thanks, Sarath Subramanian
