Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-11 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/#review216541 --- Ship it! Ship It! - Madhan Neethiraj On July 12, 2019, 1:30

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-11 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/ --- (Updated July 11, 2019, 6:30 p.m.) Review request for atlas, Ashutosh Mestry, A

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sridhar K
> On July 10, 2019, 10:12 p.m., Madhan Neethiraj wrote: > > Ship It! I am not convinved that this is correct approach. - Sridhar --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/#review2

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/#review216503 --- Ship it! Ship It! - Madhan Neethiraj On July 10, 2019, 8:11

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sarath Subramanian
> On July 9, 2019, 5:11 p.m., Madhan Neethiraj wrote: > > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java > > Line 59 (original), 60 (patched) > > > > > > Configurations "atlas.clus

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/ --- (Updated July 10, 2019, 1:11 p.m.) Review request for atlas, Ashutosh Mestry, A

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sarath Subramanian
> On July 9, 2019, 9:45 p.m., Ashutosh Mestry wrote: > > addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java > > Lines 176 (patched) > > > > > > Duplicate code. All the bridge code - Hiv

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-10 Thread Sarath Subramanian
> On July 9, 2019, 10:55 p.m., Sridhar K wrote: > > Hello Sarath, > > Is this some thing new that we are doing? I understand the reasoning. I > > don't see a need for configuration "atlas.metadata.namespace". I suggest > > that we just use the . format. It is hard to > > manage with configurat

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Sridhar K
> On July 10, 2019, 5:55 a.m., Sridhar K wrote: > > Hello Sarath, > > Is this some thing new that we are doing? I understand the reasoning. I > > don't see a need for configuration "atlas.metadata.namespace". I suggest > > that we just use the . format. It is hard to > > manage with configurat

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Sridhar K
> On July 10, 2019, 5:55 a.m., Sridhar K wrote: > > Hello Sarath, > > Is this some thing new that we are doing? I understand the reasoning. I > > don't see a need for configuration "atlas.metadata.namespace". I suggest > > that we just use the . format. It is hard to > > manage with configurat

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Madhan Neethiraj
> On July 10, 2019, 5:55 a.m., Sridhar K wrote: > > Hello Sarath, > > Is this some thing new that we are doing? I understand the reasoning. I > > don't see a need for configuration "atlas.metadata.namespace". I suggest > > that we just use the . format. It is hard to > > manage with configurat

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Sridhar K
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/#review216470 --- Hello Sarath, Is this some thing new that we are doing? I understa

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/#review216469 --- Will make sense to write a unit test that exercises the logic for

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/#review216468 --- addons/hive-bridge/src/main/java/org/apache/atlas/hive/hook/HiveH

Re: Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/#review216460 --- addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/H

Review Request 71042: ATLAS-3321: Introduce atlas metadata namespace

2019-07-09 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71042/ --- Review request for atlas, Ashutosh Mestry, Aadarsh Jajodia, Sridhar K, Le Ma, Ma