Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-04-03 Thread Madhan Neethiraj

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/#review220215
---




distro/src/bin/atlas_config.py
Lines 262 (patched)


Wouldn't the 'for' loops in #262 and #266 cause the script to wait until 
Atlas server process started in #260 exits?

With ENABLE_LOGGING_TO_CONSOLE=true in atlas-env.sh, atlas_start.py script 
never exits. And tring to stop the server via atlas_stop.py doesn't work as 
well - since pid is written to atlas.pid only after these 'for' loops exit.

Please make sure that atlas_start.py exits cleanly, after starting the 
server process.


- Madhan Neethiraj


On March 26, 2020, 7:41 a.m., Mariusz Górski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72104/
> ---
> 
> (Updated March 26, 2020, 7:41 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 7159b16cf 
>   distro/src/bin/atlas_config.py f09026ff9 
>   distro/src/bin/atlas_start.py 963faf402 
>   distro/src/bin/cputil.py 98a9dc36d 
>   distro/src/conf/atlas-env.sh c4241e665 
>   distro/src/test/python/scripts/TestMetadata.py f1235f747 
> 
> 
> Diff: https://reviews.apache.org/r/72104/diff/4/
> 
> 
> Testing
> ---
> 
> The tests were concluded by:
> 
> 1. Building & running Atlas locally with default log4j configuration and 
> -Dlog.console mvn build option set to true.
> 2. Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and -Dlog.console mvn build option set to true.
> 3. Running distro tests on localhost
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> 
> 
> Thanks,
> 
> Mariusz Górski
> 
>



Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-03-30 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/#review220133
---


Ship it!




Ship It!

- Mehul Parikh


On March 26, 2020, 7:41 a.m., Mariusz Górski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72104/
> ---
> 
> (Updated March 26, 2020, 7:41 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 7159b16cf 
>   distro/src/bin/atlas_config.py f09026ff9 
>   distro/src/bin/atlas_start.py 963faf402 
>   distro/src/bin/cputil.py 98a9dc36d 
>   distro/src/conf/atlas-env.sh c4241e665 
>   distro/src/test/python/scripts/TestMetadata.py f1235f747 
> 
> 
> Diff: https://reviews.apache.org/r/72104/diff/4/
> 
> 
> Testing
> ---
> 
> The tests were concluded by:
> 
> 1. Building & running Atlas locally with default log4j configuration and 
> -Dlog.console mvn build option set to true.
> 2. Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and -Dlog.console mvn build option set to true.
> 3. Running distro tests on localhost
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> 
> 
> Thanks,
> 
> Mariusz Górski
> 
>



Fwd: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-03-26 Thread Bolke de Bruin
Can this be merged please?

Sent from my iPhone

Begin forwarded message:

> From: Bolke de Bruin 
> Date: 26 March 2020 at 14:38:51 CET
> To: Madhan Neethiraj , Sarath Subramanian 
> , Ashutosh Mestry , Nixon Rodrigues 
> , Bolke de Bruin 
> Cc: atlas , Mariusz Górski 
> 
> Subject: Re:  Review Request 72104: ATLAS-3610 Enable logging to STDOUT in 
> Atlas startup scripts
> Reply-To: Bolke de Bruin 
> 
> 
> This is an automatically generated e-mail. To reply, visit: 
> https://reviews.apache.org/r/72104/
> 
> Ship it!
> 
> Ship It!
> 
> - Bolke de Bruin
> 
> 
> On March 26th, 2020, 7:41 a.m. UTC, Mariusz Górski wrote:
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> By Mariusz Górski.
> Updated March 26, 2020, 7:41 a.m.
> 
> Repository: atlas
> Description
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> Testing
> 
> The tests were concluded by:
> 
> Building & running Atlas locally with default log4j configuration and 
> -Dlog.console mvn build option set to true.
> Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and -Dlog.console mvn build option set to true.
> Running distro tests on localhost
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> Diffs
> 
> distro/pom.xml (7159b16cf)
> distro/src/bin/atlas_config.py (f09026ff9)
> distro/src/bin/atlas_start.py (963faf402)
> distro/src/bin/cputil.py (98a9dc36d)
> distro/src/conf/atlas-env.sh (c4241e665)
> distro/src/test/python/scripts/TestMetadata.py (f1235f747)
> View Diff


Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-03-26 Thread Bolke de Bruin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/#review220088
---


Ship it!




Ship It!

- Bolke de Bruin


On March 26, 2020, 7:41 a.m., Mariusz Górski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72104/
> ---
> 
> (Updated March 26, 2020, 7:41 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 7159b16cf 
>   distro/src/bin/atlas_config.py f09026ff9 
>   distro/src/bin/atlas_start.py 963faf402 
>   distro/src/bin/cputil.py 98a9dc36d 
>   distro/src/conf/atlas-env.sh c4241e665 
>   distro/src/test/python/scripts/TestMetadata.py f1235f747 
> 
> 
> Diff: https://reviews.apache.org/r/72104/diff/4/
> 
> 
> Testing
> ---
> 
> The tests were concluded by:
> 
> 1. Building & running Atlas locally with default log4j configuration and 
> -Dlog.console mvn build option set to true.
> 2. Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and -Dlog.console mvn build option set to true.
> 3. Running distro tests on localhost
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> 
> 
> Thanks,
> 
> Mariusz Górski
> 
>



Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-03-26 Thread Mariusz Górski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/
---

(Updated March 26, 2020, 7:41 a.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

Updating Testing Done section


Repository: atlas


Description
---

This patch enables logging to STDOUT from processes spawned through 
atlas_start.py or atlas_config.py scripts. For now, even if configured in 
log4j, logging to STDOUT was supressed (by redirecting to log files only).


Diffs
-

  distro/pom.xml 7159b16cf 
  distro/src/bin/atlas_config.py f09026ff9 
  distro/src/bin/atlas_start.py 963faf402 
  distro/src/bin/cputil.py 98a9dc36d 
  distro/src/conf/atlas-env.sh c4241e665 
  distro/src/test/python/scripts/TestMetadata.py f1235f747 


Diff: https://reviews.apache.org/r/72104/diff/4/


Testing (updated)
---

The tests were concluded by:

1. Building & running Atlas locally with default log4j configuration and 
-Dlog.console mvn build option set to true.
2. Building & running Atlas on Openshift with log4j configuration pushing 
everything to STDOUT and -Dlog.console mvn build option set to true.
3. Running distro tests on localhost

In both scenarios logs were available both in the .out/.err files in the Atlas 
logdir (backwards compatibility), but at the same time I was able to see them 
in STDOUT of both running process (local installation) and pod (openshift 
deployment).


Thanks,

Mariusz Górski



Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-02-27 Thread Mariusz Górski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/
---

(Updated Feb. 27, 2020, 2:39 p.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

fix failing tests


Repository: atlas


Description
---

This patch enables logging to STDOUT from processes spawned through 
atlas_start.py or atlas_config.py scripts. For now, even if configured in 
log4j, logging to STDOUT was supressed (by redirecting to log files only).


Diffs (updated)
-

  distro/pom.xml 7159b16cf 
  distro/src/bin/atlas_config.py f09026ff9 
  distro/src/bin/atlas_start.py 963faf402 
  distro/src/bin/cputil.py 98a9dc36d 
  distro/src/conf/atlas-env.sh c4241e665 
  distro/src/test/python/scripts/TestMetadata.py f1235f747 


Diff: https://reviews.apache.org/r/72104/diff/4/

Changes: https://reviews.apache.org/r/72104/diff/3-4/


Testing
---

The tests were concluded by:

1. Building & running Atlas locally with default log4j configuration and 
-Dlog.console mvn build option set to true.
2. Building & running Atlas on Openshift with log4j configuration pushing 
everything to STDOUT and -Dlog.console mvn build option set to true.

In both scenarios logs were available both in the .out/.err files in the Atlas 
logdir (backwards compatibility), but at the same time I was able to see them 
in STDOUT of both running process (local installation) and pod (openshift 
deployment).


Thanks,

Mariusz Górski



Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-02-25 Thread Mehul Parikh

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/#review219662
---


Ship it!




Ship It!

- Mehul Parikh


On Feb. 22, 2020, 3:30 p.m., Mariusz Górski wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72104/
> ---
> 
> (Updated Feb. 22, 2020, 3:30 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
> Nixon Rodrigues, and Sarath Subramanian.
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> This patch enables logging to STDOUT from processes spawned through 
> atlas_start.py or atlas_config.py scripts. For now, even if configured in 
> log4j, logging to STDOUT was supressed (by redirecting to log files only).
> 
> 
> Diffs
> -
> 
>   distro/pom.xml 7159b16cf 
>   distro/src/bin/atlas_config.py f09026ff9 
>   distro/src/bin/atlas_start.py 963faf402 
>   distro/src/bin/cputil.py 98a9dc36d 
>   distro/src/conf/atlas-env.sh c4241e665 
> 
> 
> Diff: https://reviews.apache.org/r/72104/diff/3/
> 
> 
> Testing
> ---
> 
> The tests were concluded by:
> 
> 1. Building & running Atlas locally with default log4j configuration and 
> -Dlog.console mvn build option set to true.
> 2. Building & running Atlas on Openshift with log4j configuration pushing 
> everything to STDOUT and -Dlog.console mvn build option set to true.
> 
> In both scenarios logs were available both in the .out/.err files in the 
> Atlas logdir (backwards compatibility), but at the same time I was able to 
> see them in STDOUT of both running process (local installation) and pod 
> (openshift deployment).
> 
> 
> Thanks,
> 
> Mariusz Górski
> 
>



Re: Review Request 72104: ATLAS-3610 Enable logging to STDOUT in Atlas startup scripts

2020-02-22 Thread Mariusz Górski

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72104/
---

(Updated Feb. 22, 2020, 3:30 p.m.)


Review request for atlas, Ashutosh Mestry, Bolke de Bruin, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

updated testing description, added reviewers


Repository: atlas


Description
---

This patch enables logging to STDOUT from processes spawned through 
atlas_start.py or atlas_config.py scripts. For now, even if configured in 
log4j, logging to STDOUT was supressed (by redirecting to log files only).


Diffs
-

  distro/pom.xml 7159b16cf 
  distro/src/bin/atlas_config.py f09026ff9 
  distro/src/bin/atlas_start.py 963faf402 
  distro/src/bin/cputil.py 98a9dc36d 
  distro/src/conf/atlas-env.sh c4241e665 


Diff: https://reviews.apache.org/r/72104/diff/3/


Testing (updated)
---

The tests were concluded by:

1. Building & running Atlas locally with default log4j configuration and 
-Dlog.console mvn build option set to true.
2. Building & running Atlas on Openshift with log4j configuration pushing 
everything to STDOUT and -Dlog.console mvn build option set to true.

In both scenarios logs were available both in the .out/.err files in the Atlas 
logdir (backwards compatibility), but at the same time I was able to see them 
in STDOUT of both running process (local installation) and pod (openshift 
deployment).


Thanks,

Mariusz Górski