Re: Review Request 72197: ATLAS-3653: renamed Namespace to EntityExtn

2020-03-06 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72197/#review219818
---


Ship it!




Ship It!

- Sarath Subramanian


On March 5, 2020, 1:02 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72197/
> ---
> 
> (Updated March 5, 2020, 1:02 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Sameer Shaikh, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3653
> https://issues.apache.org/jira/browse/ATLAS-3653
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> renamed Namespace to EntityExtn
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
>  f2e483888 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
> 7d81e22f8 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
>  5f0c7b2b7 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
>  47b728003 
>   
> authorization/src/test/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizerTest.java
>  e585e93d2 
>   authorization/src/test/resources/atlas-simple-authz-policy.json 379d42b0c 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
>   intg/src/main/java/org/apache/atlas/model/TypeCategory.java cbcd0a3c8 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 2e2e4ee03 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> dcae71676 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java 
> 713a2c26a 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
> 81ea946e5 
>   intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java b08ace442 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 2824feb16 
>   intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java ede84436d 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 5c62a2497 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 5b7cbeef5 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 5b115b530 
>   intg/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
> d57a48443 
>   intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 32ed6ee4e 
>   
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java 
> 88677740b 
>   repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
> c443652f0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  a3a570b97 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  82a2d31d5 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  b5533525f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  2a602c871 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  39ea3f82e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  e1ef84924 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java
>  PRE-CREATION 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  30f5e5a7c 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java
>  eaaf6bbe3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  afdfba9b8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  2f3aad06b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  7533ebc78 
>   repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 
> df27b0ce4 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2Test.java
>  PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java
>  e2f5c16a7 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 72f5befee 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fcf71891f 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java e7cf62d07 
> 
> 
> Diff: https://reviews.apache.org/r/72197/diff/2/
> 
> 
> Testing
> ---
> 
> pre-commit tests run 
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1717/
> 
> 
> Thanks,
> 
>

Re: Review Request 72197: ATLAS-3653: renamed Namespace to EntityExtn

2020-03-05 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72197/
---

(Updated March 5, 2020, 9:02 p.m.)


Review request for atlas, Ashutosh Mestry, keval bhatt, Sameer Shaikh, and 
Sarath Subramanian.


Changes
---

renamed Namespace to BusinessMetadata


Bugs: ATLAS-3653
https://issues.apache.org/jira/browse/ATLAS-3653


Repository: atlas


Description
---

renamed Namespace to EntityExtn


Diffs (updated)
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
 f2e483888 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
7d81e22f8 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 5f0c7b2b7 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
 47b728003 
  
authorization/src/test/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizerTest.java
 e585e93d2 
  authorization/src/test/resources/atlas-simple-authz-policy.json 379d42b0c 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
  intg/src/main/java/org/apache/atlas/model/TypeCategory.java cbcd0a3c8 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 2e2e4ee03 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
dcae71676 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java 
713a2c26a 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
81ea946e5 
  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java b08ace442 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 2824feb16 
  intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java ede84436d 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 5c62a2497 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 5b7cbeef5 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 5b115b530 
  intg/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java d57a48443 
  intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 32ed6ee4e 
  intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java 
88677740b 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
c443652f0 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 a3a570b97 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
82a2d31d5 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
 b5533525f 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 2a602c871 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 39ea3f82e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 e1ef84924 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2.java
 PRE-CREATION 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 30f5e5a7c 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java
 eaaf6bbe3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
 afdfba9b8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2f3aad06b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 7533ebc78 
  repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 
df27b0ce4 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasBusinessMetadataDefStoreV2Test.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java
 e2f5c16a7 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 72f5befee 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fcf71891f 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java e7cf62d07 


Diff: https://reviews.apache.org/r/72197/diff/2/

Changes: https://reviews.apache.org/r/72197/diff/1-2/


Testing (updated)
---

pre-commit tests run 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1717/


Thanks,

Madhan Neethiraj

Re: Review Request 72197: ATLAS-3653: renamed Namespace to EntityExtn

2020-03-05 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72197/#review219783
---


Fix it, then Ship it!





webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java
Line 860 (original), 860 (patched)


can we use 'extension' instead of 'extns' in REST path for clarity?

e.g. "/guid/{guid}/extensions"


- Sarath Subramanian


On March 4, 2020, 9:10 p.m., Madhan Neethiraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72197/
> ---
> 
> (Updated March 4, 2020, 9:10 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, keval bhatt, Sameer Shaikh, and 
> Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3653
> https://issues.apache.org/jira/browse/ATLAS-3653
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> renamed Namespace to EntityExtn
> 
> 
> Diffs
> -
> 
>   
> authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
>  f2e483888 
>   authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
> 7d81e22f8 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
>  5f0c7b2b7 
>   
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
>  47b728003 
>   
> authorization/src/test/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizerTest.java
>  e585e93d2 
>   authorization/src/test/resources/atlas-simple-authz-policy.json 379d42b0c 
>   intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
>   intg/src/main/java/org/apache/atlas/model/TypeCategory.java cbcd0a3c8 
>   intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 
> 2e2e4ee03 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
> dcae71676 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java 
> 713a2c26a 
>   intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
> 81ea946e5 
>   intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java b08ace442 
>   intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 2824feb16 
>   intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java ede84436d 
>   intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 5c62a2497 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 5b7cbeef5 
>   intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 5b115b530 
>   intg/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java 
> d57a48443 
>   intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 32ed6ee4e 
>   
> intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java 
> 88677740b 
>   repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
> c443652f0 
>   
> repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
>  a3a570b97 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java
>  82a2d31d5 
>   
> repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
>  b5533525f 
>   
> repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
>  2a602c871 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
>  39ea3f82e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
>  e1ef84924 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
>  30f5e5a7c 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java
>  eaaf6bbe3 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
>  afdfba9b8 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  2f3aad06b 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
>  7533ebc78 
>   repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 
> df27b0ce4 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityExtnDefStoreV2Test.java
>  PRE-CREATION 
>   
> repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java
>  e2f5c16a7 
>   webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 72f5befee 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fcf71891f 
>   webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java e7cf62d07 
> 
> 
> Diff: https://reviews.apache.org/r/72197/diff/1/
> 
> 
> Testing
>

Review Request 72197: ATLAS-3653: renamed Namespace to EntityExtn

2020-03-04 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72197/
---

Review request for atlas, Ashutosh Mestry, keval bhatt, Sameer Shaikh, and 
Sarath Subramanian.


Bugs: ATLAS-3653
https://issues.apache.org/jira/browse/ATLAS-3653


Repository: atlas


Description
---

renamed Namespace to EntityExtn


Diffs
-

  
authorization/src/main/java/org/apache/atlas/authorize/AtlasEntityAccessRequest.java
 f2e483888 
  authorization/src/main/java/org/apache/atlas/authorize/AtlasPrivilege.java 
7d81e22f8 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizer.java
 5f0c7b2b7 
  
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthzPolicy.java
 47b728003 
  
authorization/src/test/java/org/apache/atlas/authorize/simple/AtlasSimpleAuthorizerTest.java
 e585e93d2 
  authorization/src/test/resources/atlas-simple-authz-policy.json 379d42b0c 
  intg/src/main/java/org/apache/atlas/AtlasErrorCode.java 04eb4a08e 
  intg/src/main/java/org/apache/atlas/model/TypeCategory.java cbcd0a3c8 
  intg/src/main/java/org/apache/atlas/model/instance/AtlasEntity.java 2e2e4ee03 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasEntityDef.java 
dcae71676 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasNamespaceDef.java 
713a2c26a 
  intg/src/main/java/org/apache/atlas/model/typedef/AtlasTypesDef.java 
81ea946e5 
  intg/src/main/java/org/apache/atlas/store/AtlasTypeDefStore.java b08ace442 
  intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java 2824feb16 
  intg/src/main/java/org/apache/atlas/type/AtlasNamespaceType.java ede84436d 
  intg/src/main/java/org/apache/atlas/type/AtlasStructType.java 5c62a2497 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeRegistry.java 5b7cbeef5 
  intg/src/main/java/org/apache/atlas/type/AtlasTypeUtil.java 5b115b530 
  intg/src/main/java/org/apache/atlas/typesystem/types/DataTypes.java d57a48443 
  intg/src/test/java/org/apache/atlas/TestRelationshipUtilsV2.java 32ed6ee4e 
  intg/src/test/java/org/apache/atlas/model/typedef/TestAtlasNamespaceDef.java 
88677740b 
  repository/src/main/java/org/apache/atlas/query/IdentifierHelper.java 
c443652f0 
  
repository/src/main/java/org/apache/atlas/repository/graph/GraphBackedSearchIndexer.java
 a3a570b97 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportService.java 
82a2d31d5 
  
repository/src/main/java/org/apache/atlas/repository/impexp/ExportTypeProcessor.java
 b5533525f 
  
repository/src/main/java/org/apache/atlas/repository/store/bootstrap/AtlasTypeDefStoreInitializer.java
 2a602c871 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasEntityStore.java
 39ea3f82e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/AtlasTypeDefGraphStore.java
 e1ef84924 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityStoreV2.java
 30f5e5a7c 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2.java
 eaaf6bbe3 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasTypeDefGraphStoreV2.java
 afdfba9b8 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 2f3aad06b 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphRetriever.java
 7533ebc78 
  repository/src/main/java/org/apache/atlas/repository/util/FilterUtil.java 
df27b0ce4 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityExtnDefStoreV2Test.java
 PRE-CREATION 
  
repository/src/test/java/org/apache/atlas/repository/store/graph/v2/AtlasNamespaceDefStoreV2Test.java
 e2f5c16a7 
  webapp/src/main/java/org/apache/atlas/examples/QuickStartV2.java 72f5befee 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java fcf71891f 
  webapp/src/main/java/org/apache/atlas/web/rest/TypesREST.java e7cf62d07 


Diff: https://reviews.apache.org/r/72197/diff/1/


Testing
---

pre-commit tests run 
https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/1711/


Thanks,

Madhan Neethiraj