Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-12 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220294
---


Ship it!




Ship It!

- Sarath Subramanian


On April 12, 2020, 1:04 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> ---
> 
> (Updated April 12, 2020, 1:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add audits entries when Namespace Attributes are added/updated/deleted to an 
> entity
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/Enums.js e2d8cd2 
>   dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js a820616 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> 2394a12 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> 9301e21 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  00c0114 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  8819688 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
>  c4dc5a1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
>  2943ea9 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  6d64fec 
> 
> 
> Diff: https://reviews.apache.org/r/72270/diff/6/
> 
> 
> Testing
> ---
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1805/console
> 
> Basic testing is done.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-12 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220291
---


Ship it!




Ship It!

- Madhan Neethiraj


On April 12, 2020, 8:04 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> ---
> 
> (Updated April 12, 2020, 8:04 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add audits entries when Namespace Attributes are added/updated/deleted to an 
> entity
> 
> 
> Diffs
> -
> 
>   dashboardv2/public/js/utils/Enums.js e2d8cd2 
>   dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js a820616 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> 2394a12 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> 9301e21 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  00c0114 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  8819688 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
>  c4dc5a1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
>  2943ea9 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  6d64fec 
> 
> 
> Diff: https://reviews.apache.org/r/72270/diff/6/
> 
> 
> Testing
> ---
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1805/console
> 
> Basic testing is done.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-12 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
---

(Updated April 12, 2020, 8:04 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689


Repository: atlas


Description
---

Add audits entries when Namespace Attributes are added/updated/deleted to an 
entity


Diffs (updated)
-

  dashboardv2/public/js/utils/Enums.js e2d8cd2 
  dashboardv2/public/js/views/audit/CreateAuditTableLayoutView.js a820616 
  intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
2394a12 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
9301e21 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 00c0114 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 8819688 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
 c4dc5a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
 2943ea9 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 6d64fec 


Diff: https://reviews.apache.org/r/72270/diff/6/

Changes: https://reviews.apache.org/r/72270/diff/5-6/


Testing (updated)
---

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1805/console

Basic testing is done.


Thanks,

Mandar Ambawane

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-11 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220289
---




intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java
Lines 184 (patched)


- onBusinessMetadataAttributeUpdated() => onBusinessAttributesUpdated
- bmAttrValueMap => updatedBusinessAttributes



intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java
Lines 54 (patched)


BUSINESS_METADATA_ATTRIBUTE_ADD and BUSINESS_METADATA_ATTRIBUTE_DELETE are 
not used. Please review and remove.



repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
Lines 603 (patched)


bmAttrValueMap => updatedBusinessAttributes



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
Lines 768 (patched)


bmAttrValueMap => updatedBusinessAttributes



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 421 (patched)


- please move 'private' methods towards end of the file i.e. after all 
public and protected methods
- is 'action' argument needed anymore, given 
BUSINESS_METADATA_ATTRIBUTE_UPDATE is the only action supported for 
business-attributes?
- since 'action' is not needed, please update 'bmAttributeActionMap':
  from: Map>> bmAttributeActionMap 
  to:   Map updatedBusinessAttributes



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 529 (patched)


Consider sending entityGuid, instead of retrieving entity here - similar to 
notificaitons for label updates.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
Lines 56 (patched)


- onBusinessMetadataAttributeUpdatedToEntity() ==> 
onBusinessAttributesUpdated()
- bmAttrValueMap => updatedBusinessAttributes


- Madhan Neethiraj


On April 11, 2020, 11:57 a.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> ---
> 
> (Updated April 11, 2020, 11:57 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add audits entries when Namespace Attributes are added/updated/deleted to an 
> entity
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> 2394a12 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> 9301e21 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  00c0114 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  8819688 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
>  c4dc5a1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
>  2943ea9 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  6d64fec 
> 
> 
> Diff: https://reviews.apache.org/r/72270/diff/5/
> 
> 
> Testing
> ---
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1804/console
> 
> Basic testing is done.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-11 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
---

(Updated April 11, 2020, 11:57 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689


Repository: atlas


Description
---

Add audits entries when Namespace Attributes are added/updated/deleted to an 
entity


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
2394a12 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
9301e21 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 00c0114 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 8819688 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
 c4dc5a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
 2943ea9 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 6d64fec 


Diff: https://reviews.apache.org/r/72270/diff/5/

Changes: https://reviews.apache.org/r/72270/diff/4-5/


Testing
---

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console

Basic testing is done.


Thanks,

Mandar Ambawane

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-09 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220274
---




intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java
Lines 185 (patched)


- why is it necessary to send 
AtlasBusinessMetadataType.AtlasBusinessAttribute (attribute-type) list to 
notifications? If it is send names of attributes added/updated/deleted, 
consider using a Set type argument.
- updates to  business attributes is covered by a single permission - 
AtlasPrivilege.ENTITY_UPDATE_BUSINESS_METADATA. I suggest to use only one audit 
action - BUSINESS_ATTRIBUTES_UPDATE. The audit data should include name & value 
of all business attributes that were added/updated/deleted; for deleted 
attributes, the value should be null.



repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
Lines 608 (patched)


This creates one audit entry for each attribute; this is not 
necessary/useful. I suggest to create a single audit that includes all 
added/updated/removed business-attributes - similar to add/update/remove of 
classifications.


- Madhan Neethiraj


On April 9, 2020, 8:22 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> ---
> 
> (Updated April 9, 2020, 8:22 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add audits entries when Namespace Attributes are added/updated/deleted to an 
> entity
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> 2394a12 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> 9301e21 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  00c0114 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  0d5b631 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
>  c4dc5a1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
>  2943ea9 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  6d64fec 
> 
> 
> Diff: https://reviews.apache.org/r/72270/diff/4/
> 
> 
> Testing
> ---
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console
> 
> Basic testing is done.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-09 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
---

(Updated April 9, 2020, 8:22 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Resolved test case failures and some code refactoring


Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689


Repository: atlas


Description
---

Add audits entries when Namespace Attributes are added/updated/deleted to an 
entity


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
2394a12 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
9301e21 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 00c0114 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 0d5b631 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
 c4dc5a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
 2943ea9 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 6d64fec 


Diff: https://reviews.apache.org/r/72270/diff/4/

Changes: https://reviews.apache.org/r/72270/diff/3-4/


Testing (updated)
---

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1800/console

Basic testing is done.


Thanks,

Mandar Ambawane

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-08 Thread Nikhil Bonte 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220263
---




intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java
Lines 185 (patched)


I suggest to have input as list of businessMetadataAttributes.
That way events can be put for all businessMetadataAttributes at one go 
instead putting for 1 attribute at a time.

Same may be done for case update, delete.


- Nikhil Bonte


On April 8, 2020, 2:30 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> ---
> 
> (Updated April 8, 2020, 2:30 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add audits entries when Namespace Attributes are added/updated/deleted to an 
> entity
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> 2394a12 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> 9301e21 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  590f7a0 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  00c0114 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  0d5b631 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
>  c4dc5a1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
>  2943ea9 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  6d64fec 
> 
> 
> Diff: https://reviews.apache.org/r/72270/diff/3/
> 
> 
> Testing
> ---
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
> 
> Basic testing is done.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-08 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
---

(Updated April 8, 2020, 2:30 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Addressed review comments


Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689


Repository: atlas


Description
---

Add audits entries when Namespace Attributes are added/updated/deleted to an 
entity


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
2394a12 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
9301e21 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 590f7a0 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 00c0114 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 0d5b631 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
 c4dc5a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
 2943ea9 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 6d64fec 


Diff: https://reviews.apache.org/r/72270/diff/3/

Changes: https://reviews.apache.org/r/72270/diff/2-3/


Testing
---

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console

Basic testing is done.


Thanks,

Mandar Ambawane

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-04-08 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220249
---




intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java
Lines 178 (patched)


consider adding comments to be in alignment with other methods in this 
interface.



intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java
Lines 54 (patched)


BUSINESS_ATTRIBUTE_ADD=> BUSINESS_METADATA_ATTRIBUTE_ADD
BUSINESS_ATTRIBUTE_UPDATE => BUSINESS_METADATA_ATTRIBUTE_UPDATE
BUSINESS_ATTRIBUTE_DELETE => BUSINESS_METADATA_ATTRIBUTE_DELETE

consider updating in line 95, 97 and 99 as well



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
Lines 411 (patched)


why this check is added? we are not creating any audit vertex for business 
metadata add/update/delete. Please review and remove.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 452 (patched)


instead of creating audit entries for every iteration of for loop. Consider 
sending audits at the end to avoid multiple calls to write to audit repository.

maintain a list of business metadata attributes - added/updated/deleted for 
entity and send audit notification outside for loop.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 520 (patched)


same comment. consider sending audit entries at the end - outside for loop.



repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
Lines 567 (patched)


consider adding the audit entry after you exit out of for loop, so 
notification is sent at the end. A recent change was added to add bulk audit 
notification for add classifications. Please review.



webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
Lines 323 (patched)


nit: add comments inside these methods - "// do nothing -> notification not 
sent out for business metadata attribute addition/updation/removal from 
entities"


- Sarath Subramanian


On April 6, 2020, 11:21 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> ---
> 
> (Updated April 6, 2020, 11:21 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add audits entries when Namespace Attributes are added/updated/deleted to an 
> entity
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> 2394a12 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> 9301e21 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  590f7a0 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  00c0114 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  75b016c 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
>  c4dc5a1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
>  2943ea9 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  6d64fec 
> 
> 
> Diff: https://reviews.apache.org/r/72270/diff/2/
> 
> 
> Testing
> ---
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
> 
> Basic testing is done.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-03-31 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
---

(Updated March 31, 2020, 7:28 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, and Sarath Subramanian.


Changes
---

Addressed review comments


Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689


Repository: atlas


Description
---

Add audits entries when Namespace Attributes are added/updated/deleted to an 
entity


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
2394a12 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
9301e21 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 590f7a0 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 00c0114 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 75b016c 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
 c4dc5a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
 2943ea9 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 6d64fec 


Diff: https://reviews.apache.org/r/72270/diff/2/

Changes: https://reviews.apache.org/r/72270/diff/1-2/


Testing
---

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console

Basic testing is done.


Thanks,

Mandar Ambawane

Re: Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-03-30 Thread Nixon Rodrigues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/#review220098
---




repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
Line 53 (original), 54 (patched)


Avoid import *


- Nixon Rodrigues


On March 25, 2020, 7:40 p.m., Mandar Ambawane wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72270/
> ---
> 
> (Updated March 25, 2020, 7:40 p.m.)
> 
> 
> Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
> and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-3689
> https://issues.apache.org/jira/browse/ATLAS-3689
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> Add audits entries when Namespace Attributes are added/updated/deleted to an 
> entity
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
> 2394a12 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> 9301e21 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  590f7a0 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
>  00c0114 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
>  75b016c 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
>  c4dc5a1 
>   
> repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
>  2943ea9 
>   
> webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
>  6d64fec 
> 
> 
> Diff: https://reviews.apache.org/r/72270/diff/1/
> 
> 
> Testing
> ---
> 
> Pre-commit: 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console
> 
> Basic testing is done.
> 
> 
> Thanks,
> 
> Mandar Ambawane
> 
>

Review Request 72270: ATLAS-3689 Add audits entries when Business Metadata Attributes are added/updated/deleted to an entity

2020-03-25 Thread Mandar Ambawane 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72270/
---

Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, 
and Sarath Subramanian.


Bugs: ATLAS-3689
https://issues.apache.org/jira/browse/ATLAS-3689


Repository: atlas


Description
---

Add audits entries when Namespace Attributes are added/updated/deleted to an 
entity


Diffs
-

  intg/src/main/java/org/apache/atlas/listener/EntityChangeListenerV2.java 
2394a12 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
9301e21 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 590f7a0 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/AtlasEntityChangeNotifier.java
 00c0114 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/EntityGraphMapper.java
 75b016c 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/IAtlasEntityChangeNotifier.java
 c4dc5a1 
  
repository/src/main/java/org/apache/atlas/repository/store/graph/v2/bulkimport/EntityChangeNotifierNop.java
 2943ea9 
  
webapp/src/main/java/org/apache/atlas/notification/EntityNotificationListenerV2.java
 6d64fec 


Diff: https://reviews.apache.org/r/72270/diff/1/


Testing
---

Pre-commit: 
https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1759/console

Basic testing is done.


Thanks,

Mandar Ambawane