Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-17 Thread Sarath Subramanian 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/#review220360
---


Ship it!




Ship It!

- Sarath Subramanian


On April 13, 2020, 5:46 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72351/
> ---
> 
> (Updated April 13, 2020, 5:46 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3727
> https://issues.apache.org/jira/browse/ATLAS-3727
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3727: Add get result details REST for admin audit record
> ATLAS-3729: Add audit operation as a parameter to v2/entity/{guid}/audit
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 98e56f2bb 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> bcfdd9466 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  0deb7295e 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  35bf1d07e 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  b8131bd39 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  4c1e1a959 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
>  2a47e39ed 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  021ca43ab 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
>  ad6ec94c0 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
>  4bb68d502 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
>  aa175a229 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 2ab8bdb03 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 402a323dd 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
> 43b85efc0 
> 
> 
> Diff: https://reviews.apache.org/r/72351/diff/3/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> 
> curl -u admin:admin123 --location --request GET 
> 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
>  --header 'Content-Type: application/json'
> 
> curl -u admin:admin123 --location --request GET 
> 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=0b10d06b-6740-4550-a571-5be8ba1ea3ae:1586797534411:0:1586797535131=ENTITY_UPDATE'
> 
> curl -u admin:admin123 --location --request GET 
> 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=ENTITY_UPDATE'
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/
---

(Updated April 14, 2020, 12:46 a.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3727
https://issues.apache.org/jira/browse/ATLAS-3727


Repository: atlas


Description
---

ATLAS-3727: Add get result details REST for admin audit record
ATLAS-3729: Add audit operation as a parameter to v2/entity/{guid}/audit


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
98e56f2bb 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
bcfdd9466 
  
repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
 0deb7295e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 35bf1d07e 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 b8131bd39 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 4c1e1a959 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
 2a47e39ed 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 021ca43ab 
  
repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
 ad6ec94c0 
  
repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
 4bb68d502 
  
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
 aa175a229 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
2ab8bdb03 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 402a323dd 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
43b85efc0 


Diff: https://reviews.apache.org/r/72351/diff/3/

Changes: https://reviews.apache.org/r/72351/diff/2-3/


Testing
---

Manual Testing:

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
 --header 'Content-Type: application/json'

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=0b10d06b-6740-4550-a571-5be8ba1ea3ae:1586797534411:0:1586797535131=ENTITY_UPDATE'

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=ENTITY_UPDATE'


Thanks,

Sidharth Mishra

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/
---

(Updated April 13, 2020, 6:17 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3727
https://issues.apache.org/jira/browse/ATLAS-3727


Repository: atlas


Description (updated)
---

ATLAS-3727: Add get result details REST for admin audit record
ATLAS-3729: Add audit operation as a parameter to v2/entity/{guid}/audit


Diffs
-

  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
98e56f2bb 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
bcfdd9466 
  
repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
 0deb7295e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 35bf1d07e 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 b8131bd39 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 4c1e1a959 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
 2a47e39ed 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 021ca43ab 
  
repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
 ad6ec94c0 
  
repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
 4bb68d502 
  
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
 aa175a229 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
2ab8bdb03 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 402a323dd 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
43b85efc0 


Diff: https://reviews.apache.org/r/72351/diff/2/


Testing (updated)
---

Manual Testing:

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
 --header 'Content-Type: application/json'

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=0b10d06b-6740-4550-a571-5be8ba1ea3ae:1586797534411:0:1586797535131=ENTITY_UPDATE'

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/v2/entity/0b10d06b-6740-4550-a571-5be8ba1ea3ae/audit?count=1=ENTITY_UPDATE'


Thanks,

Sidharth Mishra

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra 


> On April 11, 2020, 1:35 a.m., Madhan Neethiraj wrote:
> > repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
> > Lines 231 (patched)
> > 
> >
> > caching => limit

I think this parameter is causing confusion and its been used for 
scan.setCaching(MAXPAYLOAD) which will increase the payload size to MAXPAYLOAD 
rows per remote call. I am removing this from function parameter as this will 
be always to a const value.


- Sidharth


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/#review220287
---


On April 13, 2020, 6:15 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72351/
> ---
> 
> (Updated April 13, 2020, 6:15 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3727
> https://issues.apache.org/jira/browse/ATLAS-3727
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3727: Add get result details REST for admin audit record
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 98e56f2bb 
>   intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
> bcfdd9466 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
>  0deb7295e 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  35bf1d07e 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
>  b8131bd39 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  4c1e1a959 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
>  2a47e39ed 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  021ca43ab 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
>  ad6ec94c0 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
>  4bb68d502 
>   
> repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
>  aa175a229 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 2ab8bdb03 
>   webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 402a323dd 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
> 43b85efc0 
> 
> 
> Diff: https://reviews.apache.org/r/72351/diff/2/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> 
> curl -u admin:admin123 --location --request GET 
> 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
>  --header 'Content-Type: application/json'
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-13 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/
---

(Updated April 13, 2020, 6:15 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3727
https://issues.apache.org/jira/browse/ATLAS-3727


Repository: atlas


Description
---

ATLAS-3727: Add get result details REST for admin audit record


Diffs (updated)
-

  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
98e56f2bb 
  intg/src/main/java/org/apache/atlas/model/audit/EntityAuditEventV2.java 
bcfdd9466 
  
repository/src/main/java/org/apache/atlas/repository/audit/AbstractStorageBasedAuditRepository.java
 0deb7295e 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 35bf1d07e 
  
repository/src/main/java/org/apache/atlas/repository/audit/CassandraBasedAuditRepository.java
 b8131bd39 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 4c1e1a959 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
 2a47e39ed 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 021ca43ab 
  
repository/src/main/java/org/apache/atlas/repository/audit/InMemoryEntityAuditRepository.java
 ad6ec94c0 
  
repository/src/main/java/org/apache/atlas/repository/audit/NoopEntityAuditRepository.java
 4bb68d502 
  
repository/src/test/java/org/apache/atlas/repository/audit/AuditRepositoryTestBase.java
 aa175a229 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
2ab8bdb03 
  webapp/src/main/java/org/apache/atlas/web/rest/EntityREST.java 402a323dd 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
43b85efc0 


Diff: https://reviews.apache.org/r/72351/diff/2/

Changes: https://reviews.apache.org/r/72351/diff/1-2/


Testing
---

Manual Testing:

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
 --header 'Content-Type: application/json'


Thanks,

Sidharth Mishra

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-10 Thread Madhan Neethiraj 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/#review220287
---




repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
Lines 231 (patched)


caching => limit



repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
Lines 418 (patched)


- I suggest to replace use of DEFAULT_CACHING with explicit 'maxResults' 
parameter to this method - similar to #403 above
- given this method returns EntityAuditEventV2 objects, consider changing 
the return type from List to List



webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 611 (patched)


guid => auditGuid, to avoid confusing with 'guid' of entity (for which the 
audit record was generated).



webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 623 (patched)


Consider avoiding prefix 'atlas' for variables.

atlasAuditEntry => auditEntry



webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java
Lines 624 (patched)


Consider handling atlasAuditEntry.getResult() == null


- Madhan Neethiraj


On April 10, 2020, 10:44 p.m., Sidharth Mishra wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72351/
> ---
> 
> (Updated April 10, 2020, 10:44 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
> Subramanian.
> 
> 
> Bugs: ATLAS-3727
> https://issues.apache.org/jira/browse/ATLAS-3727
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> ATLAS-3727: Add get result details REST for admin audit record
> 
> 
> Diffs
> -
> 
>   intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
> 98e56f2bb 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
>  35bf1d07e 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
>  cab4e1e55 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
>  2a47e39ed 
>   
> repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
>  021ca43ab 
>   webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
> 2ab8bdb03 
>   webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
> 43b85efc0 
> 
> 
> Diff: https://reviews.apache.org/r/72351/diff/1/
> 
> 
> Testing
> ---
> 
> Manual Testing:
> 
> curl -u admin:admin123 --location --request GET 
> 'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
>  --header 'Content-Type: application/json'
> 
> 
> Thanks,
> 
> Sidharth Mishra
> 
>

Re: Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-10 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/
---

(Updated April 10, 2020, 10:44 p.m.)


Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3727
https://issues.apache.org/jira/browse/ATLAS-3727


Repository: atlas


Description
---

ATLAS-3727: Add get result details REST for admin audit record


Diffs
-

  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
98e56f2bb 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 35bf1d07e 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e55 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
 2a47e39ed 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 021ca43ab 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
2ab8bdb03 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
43b85efc0 


Diff: https://reviews.apache.org/r/72351/diff/1/


Testing (updated)
---

Manual Testing:

curl -u admin:admin123 --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
 --header 'Content-Type: application/json'


Thanks,

Sidharth Mishra

Review Request 72351: ATLAS-3727: Add get result details REST for admin audit record

2020-04-10 Thread Sidharth Mishra 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72351/
---

Review request for atlas, Ashutosh Mestry, Madhan Neethiraj, and Sarath 
Subramanian.


Bugs: ATLAS-3727
https://issues.apache.org/jira/browse/ATLAS-3727


Repository: atlas


Description
---

ATLAS-3727: Add get result details REST for admin audit record


Diffs
-

  intg/src/main/java/org/apache/atlas/model/audit/AtlasAuditEntry.java 
98e56f2bb 
  
repository/src/main/java/org/apache/atlas/repository/audit/AtlasAuditService.java
 35bf1d07e 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditListenerV2.java
 cab4e1e55 
  
repository/src/main/java/org/apache/atlas/repository/audit/EntityAuditRepository.java
 2a47e39ed 
  
repository/src/main/java/org/apache/atlas/repository/audit/HBaseBasedAuditRepository.java
 021ca43ab 
  webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 
2ab8bdb03 
  webapp/src/test/java/org/apache/atlas/web/resources/AdminResourceTest.java 
43b85efc0 


Diff: https://reviews.apache.org/r/72351/diff/1/


Testing
---

Manual Testing:

curl --location --request GET 
'http://sid-ycloud-atlas1-1.sid-ycloud-atlas1.root.hwx.site:31000/api/atlas/admin/audit/706e6e32-b619-43f2-8587-f2877ee27582/details?limit=100=0'
 \
--header 'Content-Type: application/json' \
--header 'Authorization: Basic YWRtaW46YWRtaW4xMjM='


Thanks,

Sidharth Mishra