Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/#review220679 ---

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-07 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/#review220678 --- Ship it! Ship It! - Madhan Neethiraj On May 7, 2020, 8:03

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-07 Thread Damian Warszawski
> On May 6, 2020, 10:59 p.m., Madhan Neethiraj wrote: > > graphdb/common/src/main/java/org/apache/atlas/repository/graphdb/tinkerpop/query/TinkerpopGraphQuery.java > > Line 215 (original), 215 (patched) > > > > > >

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-07 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/ --- (Updated May 7, 2020, 8:03 a.m.) Review request for atlas, Bolke de Bruin,

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-06 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/#review220665 ---

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-06 Thread Damian Warszawski
> On May 6, 2020, 6:49 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > > Lines 369 (patched) > > > > > > typo maybe? => 'return -1' As the return

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-06 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/#review220660 ---

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/ --- (Updated May 5, 2020, 10:11 p.m.) Review request for atlas, Bolke de Bruin,

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
> On May 2, 2020, 2:44 p.m., Bolke de Bruin wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntitySearchProcessor.java > > Line 203 (original), 203 (patched) > > > > > > can you add a test please?

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/ --- (Updated May 5, 2020, 3:26 p.m.) Review request for atlas, Bolke de Bruin,

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/ --- (Updated May 5, 2020, 11:45 a.m.) Review request for atlas, Bolke de Bruin,

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-05 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/ --- (Updated May 5, 2020, 11:45 a.m.) Review request for atlas, Bolke de Bruin,

Re: Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-02 Thread Bolke de Bruin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/#review220587 ---

Review Request 72459: EntitySearchProcessor is failing on graph query with sortBy attribute.

2020-05-01 Thread Damian Warszawski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72459/ --- Review request for atlas, Bolke de Bruin, Madhan Neethiraj, and Nixon Rodrigues.