Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72489/#review220787 --- Ship it! Ship It! - Madhan Neethiraj On May 14, 2020, 8:45 a.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72489/ > --- > > (Updated May 14, 2020, 8:45 a.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3788 > https://issues.apache.org/jira/browse/ATLAS-3788 > > > Repository: atlas > > > Description > --- > > When selecting ALL_CLASSIFICATION_TYPES, with system attribute Created Time < > currentTimeStamp , it results to less or zero number of entities than actual. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 74c088c0e > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 958781e41 > > repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72489/diff/3/ > > > Testing > --- > > Manually Tested. > Added test cases. > Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1894 > > > Thanks, > > Pinal Shah > >
Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72489/ --- (Updated May 14, 2020, 8:45 a.m.) Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3788 https://issues.apache.org/jira/browse/ATLAS-3788 Repository: atlas Description --- When selecting ALL_CLASSIFICATION_TYPES, with system attribute Created Time < currentTimeStamp , it results to less or zero number of entities than actual. Diffs - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 74c088c0e repository/src/test/java/org/apache/atlas/BasicTestSetup.java 958781e41 repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/72489/diff/3/ Testing (updated) --- Manually Tested. Added test cases. Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/1894 Thanks, Pinal Shah
Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72489/ --- (Updated May 14, 2020, 5:46 a.m.) Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- added license to new file Bugs: ATLAS-3788 https://issues.apache.org/jira/browse/ATLAS-3788 Repository: atlas Description --- When selecting ALL_CLASSIFICATION_TYPES, with system attribute Created Time < currentTimeStamp , it results to less or zero number of entities than actual. Diffs (updated) - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 74c088c0e repository/src/test/java/org/apache/atlas/BasicTestSetup.java 958781e41 repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/72489/diff/3/ Changes: https://reviews.apache.org/r/72489/diff/2-3/ Testing --- Manually Tested. Will add Precommit Link. Thanks, Pinal Shah
Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72489/#review220742 --- Ship it! Ship It! - Madhan Neethiraj On May 13, 2020, 5:04 p.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72489/ > --- > > (Updated May 13, 2020, 5:04 p.m.) > > > Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath > Subramanian. > > > Bugs: ATLAS-3788 > https://issues.apache.org/jira/browse/ATLAS-3788 > > > Repository: atlas > > > Description > --- > > When selecting ALL_CLASSIFICATION_TYPES, with system attribute Created Time < > currentTimeStamp , it results to less or zero number of entities than actual. > > > Diffs > - > > > repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java > 74c088c0e > repository/src/test/java/org/apache/atlas/BasicTestSetup.java 958781e41 > > repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/72489/diff/2/ > > > Testing > --- > > Manually Tested. > Will add Precommit Link. > > > Thanks, > > Pinal Shah > >
Re: Review Request 72489: ATLAS-3788 : BasicSearch: Classification with System attribute(indexed) filters has pagination issue
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72489/ --- (Updated May 13, 2020, 5:04 p.m.) Review request for atlas, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Changes --- Added unit test cases for basic search of classification Bugs: ATLAS-3788 https://issues.apache.org/jira/browse/ATLAS-3788 Repository: atlas Description --- When selecting ALL_CLASSIFICATION_TYPES, with system attribute Created Time < currentTimeStamp , it results to less or zero number of entities than actual. Diffs (updated) - repository/src/main/java/org/apache/atlas/discovery/ClassificationSearchProcessor.java 74c088c0e repository/src/test/java/org/apache/atlas/BasicTestSetup.java 958781e41 repository/src/test/java/org/apache/atlas/discovery/BasicSearchClassificationTest.java PRE-CREATION Diff: https://reviews.apache.org/r/72489/diff/2/ Changes: https://reviews.apache.org/r/72489/diff/1-2/ Testing (updated) --- Manually Tested. Will add Precommit Link. Thanks, Pinal Shah
