Re: Review Request 72631: ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-07-01 Thread Nixon Rodrigues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72631/#review221107
---


Ship it!




Ship It!

- Nixon Rodrigues


On July 1, 2020, 4:29 a.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72631/
> ---
> 
> (Updated July 1, 2020, 4:29 a.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3871
> https://issues.apache.org/jira/browse/ATLAS-3871
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
> ozone & hdfs path entites.
>  
> This will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & adls 
> path entities.
> 
> Would add more tests for ozone as well.
> 
> 
> Diffs
> -
> 
>   common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
> 664bfb72b 
> 
> 
> Diff: https://reviews.apache.org/r/72631/diff/2/
> 
> 
> Testing
> ---
> 
> PC build 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2001/console 
> (Finished: SUCCESS)
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>



Re: Review Request 72631: ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-06-30 Thread Sarath Subramanian

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72631/#review221105
---


Ship it!




Ship It!

- Sarath Subramanian


On June 30, 2020, 9:29 p.m., Nikhil Bonte wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72631/
> ---
> 
> (Updated June 30, 2020, 9:29 p.m.)
> 
> 
> Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
> Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.
> 
> 
> Bugs: ATLAS-3871
> https://issues.apache.org/jira/browse/ATLAS-3871
> 
> 
> Repository: atlas
> 
> 
> Description
> ---
> 
> AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
> ozone & hdfs path entites.
>  
> This will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & adls 
> path entities.
> 
> Would add more tests for ozone as well.
> 
> 
> Diffs
> -
> 
>   common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
> 664bfb72b 
> 
> 
> Diff: https://reviews.apache.org/r/72631/diff/2/
> 
> 
> Testing
> ---
> 
> PC build 
> https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2001/console 
> (Finished: SUCCESS)
> 
> 
> Thanks,
> 
> Nikhil Bonte
> 
>



Re: Review Request 72631: ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-06-30 Thread Nikhil Bonte

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72631/
---

(Updated July 1, 2020, 4:29 a.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Updated pre-commit build status


Bugs: ATLAS-3871
https://issues.apache.org/jira/browse/ATLAS-3871


Repository: atlas


Description
---

AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
ozone & hdfs path entites.
 
This will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & adls path 
entities.

Would add more tests for ozone as well.


Diffs
-

  common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
664bfb72b 


Diff: https://reviews.apache.org/r/72631/diff/2/


Testing (updated)
---

PC build https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2001/console 
(Finished: SUCCESS)


Thanks,

Nikhil Bonte



Re: Review Request 72631: ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-06-30 Thread Nikhil Bonte

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72631/
---

(Updated June 30, 2020, 1:34 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Added Pre commit build details


Bugs: ATLAS-3871
https://issues.apache.org/jira/browse/ATLAS-3871


Repository: atlas


Description
---

AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
ozone & hdfs path entites.
 
This will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & adls path 
entities.

Would add more tests for ozone as well.


Diffs
-

  common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
664bfb72b 


Diff: https://reviews.apache.org/r/72631/diff/2/


Testing (updated)
---

PC build https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2001/console 
(In Progress)


Thanks,

Nikhil Bonte



Re: Review Request 72631: ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-06-30 Thread Nikhil Bonte

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72631/
---

(Updated June 30, 2020, 1:30 p.m.)


Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Changes
---

Refactorings


Bugs: ATLAS-3871
https://issues.apache.org/jira/browse/ATLAS-3871


Repository: atlas


Description
---

AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
ozone & hdfs path entites.
 
This will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & adls path 
entities.

Would add more tests for ozone as well.


Diffs (updated)
-

  common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
664bfb72b 


Diff: https://reviews.apache.org/r/72631/diff/2/

Changes: https://reviews.apache.org/r/72631/diff/1-2/


Testing
---


Thanks,

Nikhil Bonte



Review Request 72631: ATLAS-3871 Add unit tests to path extractor utility for s3, s3 v2, adls path entities

2020-06-30 Thread Nikhil Bonte

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72631/
---

Review request for atlas, Ashutosh Mestry, Jayendra Parab, Madhan Neethiraj, 
Nixon Rodrigues, Sarath Subramanian, and Sidharth Mishra.


Bugs: ATLAS-3871
https://issues.apache.org/jira/browse/ATLAS-3871


Repository: atlas


Description
---

AtlasPathExtractorUtilTest added in ATLAS-3836 which covers unit tests for 
ozone & hdfs path entites.
 
This will improve AtlasPathExtractorUtilTest.java to cover s3, s3v2 & adls path 
entities.

Would add more tests for ozone as well.


Diffs
-

  common/src/test/java/org/apache/atlas/utils/AtlasPathExtractorUtilTest.java 
664bfb72b 


Diff: https://reviews.apache.org/r/72631/diff/1/


Testing
---


Thanks,

Nikhil Bonte