Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Nixon Rodrigues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221472 --- Ship it! Ship It! - Nixon Rodrigues On Aug. 5, 2020, 4:27

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221471 --- Ship it! Ship It! - Madhan Neethiraj On Aug. 5, 2020, 4:27

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ --- (Updated Aug. 5, 2020, 4:27 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221470 --- Fix it, then Ship it!

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-04 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ --- (Updated Aug. 4, 2020, 11:01 a.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-08-01 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221445 --- Fix it, then Ship it!

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-31 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ --- (Updated July 31, 2020, 12:43 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-29 Thread Madhan Neethiraj
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221416 --- intg/src/main/java/org/apache/atlas/type/AtlasEntityType.java

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-29 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ --- (Updated July 29, 2020, 1:41 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-29 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ --- (Updated July 29, 2020, 1:38 p.m.) Review request for atlas, Jayendra Parab,

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-23 Thread Pinal Shah
> On July 23, 2020, 10:50 p.m., Sarath Subramanian wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Line 607 (original), 616 (patched) > > > > > > what if out/in edges

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-23 Thread Sarath Subramanian
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221343 ---

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-22 Thread Ashutosh Mestry via Review Board
> On July 20, 2020, 10:54 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Line 649 (original), 662 (patched) > > > > > > Consider replacing this

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-21 Thread Pinal Shah
> On July 20, 2020, 10:54 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Line 649 (original), 662 (patched) > > > > > > Consider replacing this

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-21 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221282 ---

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-21 Thread Pinal Shah
> On July 20, 2020, 10:54 p.m., Ashutosh Mestry wrote: > > repository/src/main/java/org/apache/atlas/discovery/EntityDiscoveryService.java > > Lines 705 (patched) > > > > > > What is the volume of data you have

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-20 Thread Ashutosh Mestry via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/#review221273 ---

Re: Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-06 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ --- (Updated July 6, 2020, 9:14 a.m.) Review request for atlas, Jayendra Parab,

Review Request 72646: ATLAS-3876 : Relationship Search API not showing correct approximateCount

2020-07-06 Thread Pinal Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72646/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues,