Re: Review Request 72651: ATLAS-3880 : BasicSearch: Multiple type/tag: Log invalid and allow searching valid type/tag names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72651/#review221164 --- Ship it! Ship It! - Nixon Rodrigues On July 8, 2020, 4:26 p.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72651/ > --- > > (Updated July 8, 2020, 4:26 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3880 > https://issues.apache.org/jira/browse/ATLAS-3880 > > > Repository: atlas > > > Description > --- > > **Issue:** > If in basic search, request has combination of valid and invalid > typename/tags, it throws "errorCode": "ATLAS-400-00-00A" unknown/invalid > typeName for the invalid typeName. > > **WorkAround:** > Log invalid typeNames/tagNames and allow searching for valid > > **Example:** > typeName:"valid,invalid" > Allow searching entities for 'valid' type. > > > Diffs > - > > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 04e82186b > > repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java > b7ce97845 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 140ed9a6e > > > Diff: https://reviews.apache.org/r/72651/diff/2/ > > > Testing > --- > > Manually tested > Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2033 > (Failed in hive bridge) > > > Thanks, > > Pinal Shah > >
Re: Review Request 72651: ATLAS-3880 : BasicSearch: Multiple type/tag: Log invalid and allow searching valid type/tag names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72651/#review221163 --- Ship it! Ship It! - Madhan Neethiraj On July 8, 2020, 4:26 p.m., Pinal Shah wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72651/ > --- > > (Updated July 8, 2020, 4:26 p.m.) > > > Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, > and Sarath Subramanian. > > > Bugs: ATLAS-3880 > https://issues.apache.org/jira/browse/ATLAS-3880 > > > Repository: atlas > > > Description > --- > > **Issue:** > If in basic search, request has combination of valid and invalid > typename/tags, it throws "errorCode": "ATLAS-400-00-00A" unknown/invalid > typeName for the invalid typeName. > > **WorkAround:** > Log invalid typeNames/tagNames and allow searching for valid > > **Example:** > typeName:"valid,invalid" > Allow searching entities for 'valid' type. > > > Diffs > - > > repository/src/main/java/org/apache/atlas/discovery/SearchContext.java > 04e82186b > > repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java > b7ce97845 > webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 140ed9a6e > > > Diff: https://reviews.apache.org/r/72651/diff/2/ > > > Testing > --- > > Manually tested > Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2033 (In > progress) > > > Thanks, > > Pinal Shah > >
Re: Review Request 72651: ATLAS-3880 : BasicSearch: Multiple type/tag: Log invalid and allow searching valid type/tag names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72651/ --- (Updated July 8, 2020, 4:26 p.m.) Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3880 https://issues.apache.org/jira/browse/ATLAS-3880 Repository: atlas Description --- **Issue:** If in basic search, request has combination of valid and invalid typename/tags, it throws "errorCode": "ATLAS-400-00-00A" unknown/invalid typeName for the invalid typeName. **WorkAround:** Log invalid typeNames/tagNames and allow searching for valid **Example:** typeName:"valid,invalid" Allow searching entities for 'valid' type. Diffs - repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 04e82186b repository/src/test/java/org/apache/atlas/discovery/EntitySearchProcessorTest.java b7ce97845 webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 140ed9a6e Diff: https://reviews.apache.org/r/72651/diff/2/ Testing (updated) --- Manually tested Precommit : https://builds.apache.org/job/PreCommit-ATLAS-Build-Test/2033 (In progress) Thanks, Pinal Shah
Review Request 72651: ATLAS-3880 : BasicSearch: Multiple type/tag: Log invalid and allow searching valid type/tag names
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72651/ --- Review request for atlas, Jayendra Parab, Madhan Neethiraj, Nixon Rodrigues, and Sarath Subramanian. Bugs: ATLAS-3880 https://issues.apache.org/jira/browse/ATLAS-3880 Repository: atlas Description --- **Issue:** If in basic search, request has combination of valid and invalid typename/tags, it throws "errorCode": "ATLAS-400-00-00A" unknown/invalid typeName for the invalid typeName. **WorkAround:** Log invalid typeNames/tagNames and allow searching for valid **Example:** typeName:"valid,invalid" Allow searching entities for 'valid' type. Diffs - repository/src/main/java/org/apache/atlas/discovery/SearchContext.java 04e82186b webapp/src/main/java/org/apache/atlas/web/rest/DiscoveryREST.java 140ed9a6e Diff: https://reviews.apache.org/r/72651/diff/1/ Testing --- Manually tested Precommit : Thanks, Pinal Shah
